GitLab

Updates chromeos::DemoSession to use
chromeos::DIR_PREINSTALLED_COMPONENTS to determine the preinstalled demo
mode resources path.

TEST=existing unittests
BUG=869455

Change-Id: Idd63ae0893b4fa3966d69bb295fbdb0290456bca
Reviewed-on: https://chromium-review.googlesource.com/1180729
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585373}

DeepCopy returns a bare pointer, use CreateDeepCopy instead which
returns an owned pointer.

In the same spirit, change Manifest::DeepCopy to CreateDeepCopy
and let it return owned pointer value as well.

Bug: None
Test: None, internal cleanup.
Change-Id: I72da757694d511ab0de45da2f42859057cb9f418
Reviewed-on: https://chromium-review.googlesource.com/1142524Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585372}

**SHERIFFS** this test only CL may cause regression but it's expected.

Bug: chromium:862077
Bug: chromium:873081
Change-Id: Ia8c338b6e87fec576f3b5573ecfd1c2d824f2836
Reviewed-on: https://chromium-review.googlesource.com/1184733Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585371}

Sticky descendants need to re-compute paint offset upon scrolled. Beside
fixing the under-invalidation, this CL also reduced the strength of the
invalidation so instead of full paint invalidation it only needs a paint
offset check.

BUG=874675

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0e4ab3b667a6f06bfe3c584285dc2e31fa4ea7c2
Reviewed-on: https://chromium-review.googlesource.com/1182668Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585370}

Prevent closing the custom background dialog when clicking outside to
stay consistent with the custom link edit dialog. Also fix bug 874820.
When dragging mouse cursor within the overlay, now the dialog will not
close.

Bug: 874820
Change-Id: I4f78da252df73a664a7c31099e7e311a6c7856ed
Reviewed-on: https://chromium-review.googlesource.com/1185799Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585369}

This will use Perfetto instead of TraceLog for all
trace-based Telemetry tests running on Mac/Windows/Android.

R=nednguyen@google.com

Bug: 839084
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01
Reviewed-on: https://chromium-review.googlesource.com/1176119
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585368}

This adds a method to blink::FileError that more or less does the same
as blink::FileError::CreateDOMException(content::FileErrorToWebFileError(code)),
just without the extra conversion through WebFileError and
blink::FileError::ErrorCode in between.

Bug: 872460, 872465
Change-Id: I6b7f94d9a3da2fa730cf78f5a74d5315d34c95c0
Reviewed-on: https://chromium-review.googlesource.com/1185791Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585367}

Previously, BlockPainter's PaintObject method:
 1) was rather uncommented, particularly as it related to its correspondence
    to the W3C "Appendix E" spec for stacking context painting (at
    https://www.w3.org/TR/CSS21/zindex.html).
 2) was a bit convoluted, in the parts that dealt with painting LayoutBlockFlow
    objects. BlockPainter handled painting most parts of painting both
    LayoutBlocks and LayoutBlockFlows, except for in two places. In those
    places, a BlockFlowPainter was constructed and called, and then
    at one point in BlockFlowPainter::PaintContents, a BlockPainter
    was constructed and PaintContents called on that. Functional but confusing.

With this CL, comments are added to link BlockPainter to Appendix E, and
BlockFlowPainter is eliminated. That code is folded back into BlockPainter,
inline where it was called.

Bug: 873387
Change-Id: Idc041eacbcfadd1df1a610f81a2a98de024b7d49
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1175226
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585366}

- Change the context being sent to HaTS to only include info on
horizontal tab switcher.
- Get a max value through HTS experiment and if both max values exist
take the minimum of the two between HTS and Modern experiments.

BUG=865089

Change-Id: I6523bec32aa2d878aac4bb301f674ccb624ff96e
Reviewed-on: https://chromium-review.googlesource.com/1168389
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585365}

Using wpt-import in Chromium 0d2fc4e4.
With Chromium commits locally applied on WPT:
2160c22c "Modify source path for wpt test of Accept-CH"
f4c510e1 "Move XR LayoutTests over to be WPTs"
3152c6f7 "[UserTiming] Correct measure where start is undefined"
7e57f956 "Revert "Move XR LayoutTests over to be WPTs""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23132

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I8fb88d499bcf46eb536b851ff546afa4913c7ce0
Reviewed-on: https://chromium-review.googlesource.com/1186023
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585364}

The color of active icons should be Grey 200, which is darker than the
labels by 1 level.
This will affect multiple places including:
- tray collapse button
- feature pod icons
- top shortcut buttons
- slider button
- menu back arrow icon
- ink drop of sign out button
- tray popup

Bug: 853695
Change-Id: Ifbbfe221db040f2f02d9577a636b7c7dd4f796f0
Reviewed-on: https://chromium-review.googlesource.com/1180787Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585363}

This CL makes slotting-manual mode support slot change event
which is already supported in auto mode.

BUG:869308

Change-Id: I106d1037036e5e34d552cf7ce17eacd8f453fc9c
Reviewed-on: https://chromium-review.googlesource.com/1179555Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kyoko Muto <kymuto@google.com>
Cr-Commit-Position: refs/heads/master@{#585362}

Previously, ParentLocalSurfaceIdAllocator would default to an invalid
LocalSurfaceId. A new LSI had to be explicitly allocated before the
normal behavior could use it.

With ParentLocalSurfaceIdAllocator now default initializing a valid LSI,
the various call sites no longer need to explicitly check for the
uninitialized state.

Render Widget is one of those call sites.

BUG=837030

Change-Id: I330d2c47492f1ac577a928f20a8e8e4e14f91b29
Reviewed-on: https://chromium-review.googlesource.com/1038127
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585361}

This CL adds a "metrics_only" parameter to IdnNavigationSuggestions feature. When set to "true",
the parameter will suppress the display of the "Did you mean to go to ..." UI and only
record metrics.

Bug: 843361,847662
Change-Id: Idb72225ff0fc2f011bd2c1ae5bb0ee7167d687ba
Reviewed-on: https://chromium-review.googlesource.com/1182123
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585360}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29361ca11fa3..b7214602e3f1


git log 29361ca11fa3..b7214602e3f1 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 tandrii@chromium.org git cl: remove unused issue kwarg.


Created with:
  gclient setdep -r src/third_party/depot_tools@b7214602e3f1

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ice188b5ef26cee1efa29e1adf1b1f291f3295151
Reviewed-on: https://chromium-review.googlesource.com/1185689Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585359}

This CL adds support for Android client to resize host to fit client
resolution.

Bug: 874626
Change-Id: I9c3c8139eab20834e79deb2ce662a8ab1234b09c
Reviewed-on: https://chromium-review.googlesource.com/1182187Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585358}

This CL adds a gn arg enable_downstream_media_tests, which downstream consumers
of chromium can set to make these builds appear. This prevents building and
isolate generation [which fails] in upstream chromium builds that try to
build/isolate all targets.

Bug: 876915
Change-Id: Ic0f892680e889a5cd5d92b8853800a3c08926a9b
Reviewed-on: https://chromium-review.googlesource.com/1186102Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585357}

This CL creates the skeleton of common password controller and moves FormActivityObserver related logic into it`.
The goal is to move common password autofill logics into components folder so that they can be shared by both Chrome iOS and //ios/web_view.

> Moved webState and jsPasswordManager into helper class.
> Moved FormActivityObserver logic into helper class.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2dbfdb1cb4f0bdf22bf1d5c37451f46682addcac
Reviewed-on: https://chromium-review.googlesource.com/1156528Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585356}

Bug: 869557, 870840
Change-Id: I3da61f9ee1e632e8aec68ad0d07ebc4ffab4487a
Reviewed-on: https://chromium-review.googlesource.com/1185985Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585355}

There are crashes during destruction where |side_data_size_| == 0
but |side_data_| contains an invalid pointer. Adding a CHECK for this
in the destructor to hopefully get better data to help isolate the
real problem.

BUG=794740
TEST=media_unittests still pass

Change-Id: Id1633395c544b66ef632445d475a40e57a8aa1b4
Reviewed-on: https://chromium-review.googlesource.com/1185961
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585354}

This CL fades out the old button completely and then fades in the new
button.

Bug: 874097
Change-Id: I131c2383d645ead9909ca4f4270c855595a25b60
Reviewed-on: https://chromium-review.googlesource.com/1175207Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585353}

After trial, UX decided to change the color of stacked notification
counter.

TEST=manual
BUG=876469

Change-Id: I8492716588048d74b8bdbea611e580fb35701556
Reviewed-on: https://chromium-review.googlesource.com/1184735Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585352}

This is a reland of 2be1f912

In addition to the original change, also temporarily mark video pixel
tests on the Intel HD630 bot as failing, and increment the test version
numbers for rebaselining. A follow-up CL will re-enable the tests.

Original change's description:
> Enable Windows NV12 overlays on waterfall
>
> We plan on shipping this via a finch experiment to Canary/Dev soon, and then
> enable it by default if we don't encounter major issues. This should only affect
> the DirectComposition pixel tests since we force-enable overlays for those
> tests. Other tests don't exercise DirectComposition code because those code
> paths are disabled unless the hardware supports it.
>
> Bug: 869677
> Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a
> Reviewed-on: https://chromium-review.googlesource.com/1170385
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582305}

TBR=holte@chromium.org

Bug: 869677
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8fda27e0377f4cd8ad38c96bf8441832c3644436
Reviewed-on: https://chromium-review.googlesource.com/1182222
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585351}

Make it the defacto OWNERS directory.

Add mdjones@ and huayinz@ to it.

BUG=876369

Change-Id: I857f0da620c967870c17ddd1b6cacb6a4ae492e4
Reviewed-on: https://chromium-review.googlesource.com/1185918Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585350}

Doing this requires moving --enable-unsafe-webgpu
from content_switches to gpu_switches.

Bug: 868192
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I757bd228248b8cf733c381217fbb00e69e2482c0
Reviewed-on: https://chromium-review.googlesource.com/1184264Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585349}

This CL allows a user to use 'name' property on DedicatedWorker
and access from worker thread by 'self.name'.

i.e
// index.html
const worker = new Worker("dedicated_worker.js", { name: "worker_name" });

// dedicated_worker.js
console.log(self.name); // worker_name

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/aZ804HggENE/WwWgDrz4DgAJ

Spec: https://html.spec.whatwg.org/multipage/workers.html#workeroptions
Spec: https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-dedicatedworkerglobalscope-interface

Bug: 721219
Change-Id: I36127df5ee249ecf6c13ae30aaac42621b3720b5
Reviewed-on: https://chromium-review.googlesource.com/1176887Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Asami Doi <asamidoi@google.com>
Cr-Commit-Position: refs/heads/master@{#585348}

I'll request a merge into M69 when this is in so we can restart experiments quickly.

Bug: 872922
Change-Id: Icb269a5f6499a5a58a2a51f3348b23e15f20c035
Reviewed-on: https://chromium-review.googlesource.com/1183912
Commit-Queue: Quentin Fiard <qfiard@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585347}

At ObjectPaintInvalidatorWithContext::InvalidateSelection we update PartialInvalidationVisualRect
even if the union rect of old and new selection rect is empty.

This patch skips the update if the union rect is empty.


Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I11dd813381b4fd5be69d4357e816d9c64cdb17ba
Reviewed-on: https://chromium-review.googlesource.com/1183011Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585346}

This change adds an enterprise policy that disables NetBios share discovery
by default for enterprises and allows enterprises to manually turn it on.
NetBios discovery will be on for non-enterprise users.

This change does include any code to enforce the policy.

Bug: chromium:757625
Change-Id: I30288a13ef89378f021364b6f1fe4cead4e44afe
Reviewed-on: https://chromium-review.googlesource.com/1184240
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585345}

https://android.googlesource.com/platform/external/perfetto.git/+log/a4238afbd1d0..46ef92275f43


git log a4238afbd1d0..46ef92275f43 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 fmayer@google.com Do not specify API level twice.


Created with:
  gclient setdep -r src/third_party/perfetto@46ef92275f43

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ibf7351dec8fd0b898e9c450022d5ad03be705e4f
Reviewed-on: https://chromium-review.googlesource.com/1185688Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585344}

ServiceWorkerNavigationPreloadTest.NetworkFallback is flaky when
NetworkService is on, after r585201. Temporarily disabling
to soothe the CQ while I investigate.

Bug: 876911,  873575
Change-Id: I8b5cdd9ae8ac173a2a6debba05219bad7fa0d606
TBR: kinuko
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1186003Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585343}

This is a reland of f4c510e1

Original change's description:
> Move XR LayoutTests over to be WPTs
> 
> Moving as many of the WebXR LayoutTests as possible over to be
> WebPlatformTests. All the tests that have been moved test some
> aspect of the spec (https://immersive-web.github.io/webxr/) in
> a platform agnostic way.
> 
> Bug: 863557, 844772
> Change-Id: I203b4c59be0daa0ca624fb0281fc33035f1be8a1
> Reviewed-on: https://chromium-review.googlesource.com/1171857
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585064}

Bug: 863557, 844772
Change-Id: I2a85e45018fc0a17fe91c3d7bddd89587a2617e0
Reviewed-on: https://chromium-review.googlesource.com/1185384Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585342}

All codes in ProcessInitializationHandler.initializePostNative() requires
full browser to run. And some of the class uses profile during initialization,
which will crash when only service manager is running. As a result, there is
no need to run this method if full browser is not launched.
For services, they should add their own required tasks in
ChromeBrowserInitializer.handlePostNativeStartup.

BUG=695115

Change-Id: I66f314cfcb56df00553f017d3e5b6989e3a9ef60
Reviewed-on: https://chromium-review.googlesource.com/1182008Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585341}

* Add a simple mechanism to keep track of the active shelf item
  in the model
* Use the existing shelf window watcher to update the active shelf
  item
* When rendering shelf items in ShelfView, query the active shelf
  item to show the proper indicator
* Remove the STATUS_ACTIVE value since this is now all managed within
  ash

Bug: 874181
Bug: 805612
Change-Id: I089587646208ee03776f95a4f479c5b6d35d82f8
Reviewed-on: https://chromium-review.googlesource.com/1180274Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585340}

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I911ec971475379b5627e5bfc91bdf612127f21f9
Reviewed-on: https://chromium-review.googlesource.com/1182678
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585339}

ThinLTO emits warnings when linking modules with different target
triples. Android uses armv7-a as its default triple, so the mixing with
armv8-a here is problematic.

Bug: 807147
Test: md5sum <(objdump -d crc32_simd.o) is the same for Android.
Change-Id: If2bffc4090d3d94f158eea80d19ee9eb827fc837
Reviewed-on: https://chromium-review.googlesource.com/1147867
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585338}

Temporarily add some values to minidumps, to help diagnose BlobReader
crash reports.

Bug: 864351
Change-Id: I70a8b36e83fdb1c43f698d83aaf6b712da6a9264
Reviewed-on: https://chromium-review.googlesource.com/1185906Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585337}

Adds an enum for distinguishing which call sites trigger video
capture errors. The goal of this work is to improve the UMA logging
by differentiating various possible sources of error events. Doing
so will help us better understand what error events contribute most
to the high error counts and will help us better pinpoint causes
for future changes in error counts.

Design Doc: https://docs.google.com/document/d/1chso0ntOMecY7SfcrQzkHLuBAxO_oUwSpOhy1MrXAhc/edit?usp=sharing

Bug: 849636, 876002
Change-Id: I02fcc8930ff7e66a15c91c4393bf9a280383902b
Reviewed-on: https://chromium-review.googlesource.com/1180412
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585336}

https://skia.googlesource.com/skia.git/+log/92b161fab40f..33d5394d08f6


git log 92b161fab40f..33d5394d08f6 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 scroggo@google.com Revert "Switch SkCodec to use skcms" and follow on change
2018-08-22 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms b2fffd2ecf2e..e8e06f9724b0 (1 commits)
2018-08-22 robertphillips@google.com Address perf regression due adding GrRenderTargetContext::drawShape method
2018-08-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 44ae899ae9ce..9259fd0d4f4c (6 commits)
2018-08-22 brianosman@google.com Fix CMYK handling in JPEG codec
2018-08-22 brianosman@google.com Stop conflating F16 with linear gamma
2018-08-22 csmartdalton@google.com Reland "Disable GPU clip masks"
2018-08-22 brianosman@google.com Add support for unpremul image sources in the GPU backend
2018-08-22 michaelludwig@google.com Add reset and findLastOf to SkSLString.
2018-08-22 benjaminwagner@google.com [infra] Remove Braswell Perf Debug jobs.
2018-08-22 herb@google.com Pull SkSpan into its own header file
2018-08-22 benjaminwagner@google.com Remove extra Mac CPU jobs.


Created with:
  gclient setdep -r src/third_party/skia@33d5394d08f6

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Iad8298e24e90590bfa96a2b11b14a60dd7aa3a25
Reviewed-on: https://chromium-review.googlesource.com/1185687Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585335}

The media pipeline does not expect to be called about track changes
prior to HaveCurrentData. There's also no reason for the element
to create disabled video+audio tracks and then tell the renderer
to enable those very same non-existant tracks. Just create them
as enabled instead.

It's possible we can remove even the creation of placeholder
tracks, but that's a bigger web facing change, so I don't want
to hold up this bug fix on that analysis.

BUG=873837
TEST=new unittest, twitter videos no longer hang.

Change-Id: I9863ae4feca29a58140e6dad1532bc8b7a380c3b
Reviewed-on: https://chromium-review.googlesource.com/1180347
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585334}