- 31 Oct, 2018 40 commits
-
-
Charlie Harrison authored
Bug: 900062,839190 Change-Id: I0b5ed1f711a221790cfe0f2ee40842a46556e50c Reviewed-on: https://chromium-review.googlesource.com/c/1308034Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#604398}
-
Scott Violet authored
This changes how ExtensionAppWindowLauncherController watches for activation. ExtensionAppWindowLauncherController inherits activation watching from wm::ActivationChangeObserver. The ActivationChangeObserver is added to Shell's root window. This doesn't work for mash. This switches ExtensionAppWindowLauncherController to use a Widget observer. This works in both the mash and non-mash code. I did not promote this logic to AppWindowLauncherController as AppWindowLauncherController is also used for arc/crostini windows, which are created in ash and should continue to use AppWindowLauncherController (at least for the single-process-mash case). For multi-process-mash the arc/crostini launcher code likely does not work at all (because the windows are entirely created by ash) and will need more extensive changes. BUG=826386 TEST=covered by test Change-Id: If5f89d88f782ce452f10889da17210f41189dc77 Reviewed-on: https://chromium-review.googlesource.com/c/1306355Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#604397}
-
Ryan Sturm authored
In a refactor from the InfoBar delegate into the PreviewsUITabHelper, we stopped reporting non-opt outs to Previews code. This will break Previews for all users in M71 once they dismiss enough previews (even if we serve them a lot of Previews they do not dismiss). Bug: 900711 Change-Id: I1f0e2da1c7421f3ec8668b79b09ad0367e4dce47 Reviewed-on: https://chromium-review.googlesource.com/c/1311118Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59f591bd4e30..454cfea9e32c Created with: gclient setdep -r src-internal@454cfea9e32c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: I43d9f88d60591c8efc9328a1e13f8127357d1ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1310600Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604395}
-
Carlos Knippschild authored
This change adds a new metrics that works as a mirror of OfflinePages.OfflineUsage, aptly named OfflinePages.OfflineUsage.NotOfflineResilient, that should report exactly the same values but does not accumulate counters in PrefsService, reporting them directly to UMA instead. We want to compare these two metrics to try and assess the loss bias of metrics often reported in offline situations. Bug: 899800, 857134 Change-Id: I90b83ce1da638ca389ef38785a9f5ef1bb4538f3 Reviewed-on: https://chromium-review.googlesource.com/c/1305397 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604394}
-
Tibor Goldschwendt authored
Fakes module install by copying a feature module on the device's download folder into the directory where SplitCompat expects downloaded modules. Then invokes SplitCompat to emulate the module. The fake install mode is activated via a command line flag. The fake install mode is useful for testing purposes where it is difficult to host the module on Play. + Refactors install logic out of ModuleInstaller into the ModuleInstallerBackend. + Adds two backends - one for the existing install logic and one for the fake install logic described above. Bug: 862702 Change-Id: I8f2deff34a9aa4f8c0d434429fe7895038be7464 Reviewed-on: https://chromium-review.googlesource.com/c/1308608 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#604393}
-
Vlad Tsyrklevich authored
While reading through this header file, I ran across this outdated warning that said that use of function-level static initializers was not thread-safe and hence not advisable for use with ThreadLocalStorage. This comment was written before C++11 and function-level static initializers were ensured to be constructed thread safely. Change-Id: I8407edc5c32dc30e307a7192c42b411f22e75f7e Reviewed-on: https://chromium-review.googlesource.com/c/1309300Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604392}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71822866c65d..062a691cae73 git log 71822866c65d..062a691cae73 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9996ac89..6271fcdc (604166:604273) 2018-10-31 Peter) Slatala When SDES is used, pass pre-shared key to media transport. Created with: gclient setdep -r src/third_party/webrtc@062a691cae73 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I708331050d6efab0f78c5533f689f14be2eb8f3d Reviewed-on: https://chromium-review.googlesource.com/c/1310597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604391}
-
Francois Doray authored
The goal is to improve readability of upcoming additions to the tests. Bug: 885293 Change-Id: I154a924e0493440d6ecf2b574c90183fbbc1ce73 Reviewed-on: https://chromium-review.googlesource.com/c/1305205 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#604390}
-
Morten Stenshorne authored
Avoid duplicate BuildResponseHeaders(): https://chromium-review.googlesource.com/c/1292008 introduced compilation errors, because there was already a BuildResponseHeaders() in content/browser/devtools/protocol/network_handler.cc , and that file and content/browser/devtools/protocol/fetch_handler.cc got bundled together in the same translation unit by Jumbo. Similarly, we suddenly got two ToInterceptorStage() functions. The new one in fetch_handler.cc, in addition to the one we already had in network_handler.cc. TBR=caseq@chromium.org Change-Id: I07e130ef68a57d3fdb012c3beaa64be7b16edb7c Reviewed-on: https://chromium-review.googlesource.com/c/1310815Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604389}
-
Paul Meyer authored
This patch implements crash reporting, as detailed in the reporting spec: https://w3c.github.io/reporting/#crash-report This is a fixed version of the previously reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1174965 Bug: 898860 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I95c3995bac79801e7321f8d0909563bf7bf89db8 Reviewed-on: https://chromium-review.googlesource.com/c/1220031Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Douglas Creager <dcreager@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604388}
-
Stephen Martinis authored
Bug: 756686, 873373 Change-Id: I22adc1b01841e97a81e230f4fa8b94e96fdf623a Reviewed-on: https://chromium-review.googlesource.com/c/1309229 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604387}
-
Min Qin authored
DownloadManagerImpl::PostInitialization() is called twice, one by history db, one by download db. If History db is initialized first, it will call OnHistoryQueryComplete() and set load_history_downloads_cb_. If download db is ready later, it calls PostInitialization() and executes load_history_downloads_cb_ immediately. Since load_history_downloads_cb_ calls PostInitialization() again, we got an reentrance issue. BUG=900417 Change-Id: Ie89146f9bd7d30ca955601c7288e0f33c2e9e11b Reviewed-on: https://chromium-review.googlesource.com/c/1309218Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604386}
-
Sammie Quon authored
Test: manual Bug: 900281 Change-Id: I96380621d6b10fbf364dbb7e33df9dfa36aa86c7 Reviewed-on: https://chromium-review.googlesource.com/c/1308262Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604385}
-
Sergey Berezin authored
The builder is experiencing a massive failure due to a swarming error. Making it non-blocking for CQ while the fix is being worked on. TBR=tandrii@chromium.org Bug: 900742 Change-Id: Ie6f95ec39062107b77fca6942992dbcb35557ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1311128Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604384}
-
Giovanni Ortuño Urquidi authored
StopScan just sends the command directly to the active adapter. Future iterations will cause the state to change to kTransitioning, and support concurrent calls. Bug: 870192 Change-Id: I84e57147e7b1c82f3137841d615d7250bfac4cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1295612 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#604383}
-
dpapad authored
Also remove PaperInputBehavior. Last usages of these were in paper-input which was removed recently. Bug: 899982 Change-Id: I3fc9c741d726851a4c694d73d91aa11159ad8e2d Reviewed-on: https://chromium-review.googlesource.com/c/1309226Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604382}
-
Yuke Liao authored
This CL implements the Clang code coverage compiler wrapper, which can be used to instrument a subset of source files, and the main use case is to enable generating code coverage reports at per-cl level during try jobs. This CL only focuses on the wrapper itself, how to hook this wrapper into the build system will be addressed in a separate CL. Bug: 898695 Change-Id: Idb21640b5566ce78089059b3d0116390b488a383 Reviewed-on: https://chromium-review.googlesource.com/c/1301969 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#604381}
-
Jérôme Lebel authored
Removing calls to IsUIRefreshPhase1Enabled() for Google services settings. Bug: 884724 Change-Id: I112df44eb0da39a42954cfb0d471d12c54edfacc Reviewed-on: https://chromium-review.googlesource.com/c/1309784 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604380}
-
Xianda Sun authored
We now count async verifying time in Event.AsyncTargeting.ResponseTime and this is not expected. This patch excludes verifying data from the metric. Bug: 900638 Change-Id: Ida75dc486746f033d6f2563846e37ebf6ee00ee9 Reviewed-on: https://chromium-review.googlesource.com/c/1310453Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#604379}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I435f874d46bce46746237bbe5c60416444ca7e85 Reviewed-on: https://chromium-review.googlesource.com/c/1311261Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604378}
-
Antonio Gomes authored
This CL converts the PeopleHandler unittests away from SignManager and ProfileOAuth2TokenService, in favor of the new IdentityManager. Production code has been converted in [1]. This is a follow up steps. [1] https://crrev.com/c/1261637 BUG=890810 Change-Id: I405e46d2126180a2da61393bf32263ae43877b6b Reviewed-on: https://chromium-review.googlesource.com/c/1311093Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#604377}
-
Tarun Bansal authored
rootscroller/gesture-scroll-document-not-root-scroller.html Bug: 900730 Change-Id: I4cff47211412225bf84a74cd8574afe97fdd470b TBR: zmin@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1311091Reviewed-by:
-
David McAllister authored
This properly prevents double destruction as intended by the surrounding if block. R=mdjones@chromium.org Bug: None Change-Id: I97c9d13098bfb01df99a65a55e274ebf1e8d1a07 Reviewed-on: https://chromium-review.googlesource.com/c/1309098Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604375}
-
Weidong Guo authored
Instead of setting snapped bounds to app list window's parent (which is a container), we need set bounds to app list window itself to avoid bounds issue in secondary display. Bug: 899060 Change-Id: I276ce2a5312be3f4e43396cb6be398a67360d083 Reviewed-on: https://chromium-review.googlesource.com/c/1309220 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#604374}
-
Owen Min authored
Bug: 900701 Change-Id: I75a497a1c2db7eddb925b1269cdbd3c1b4e113e6 Tbr: lukebjerring@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1311253Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604373}
-
Sammie Quon authored
Could not repro the issue but based on the stack trace, looks like post animation code is running after window is destroyed, so stop observing animations when object is destroyed. Test: none Bug: 899459 Change-Id: Ia1ec07057281c91aaa390ab90df28910fa74aaac Reviewed-on: https://chromium-review.googlesource.com/c/1308610Reviewed-by:
-
Nasko Oskov authored
Error page isolation requires process swaps and locking processes to origin. It isn't clear Android WebView supports these quite yet, so disable this feature for now. Bug: 800544, 838161 Change-Id: Idb5c4a22aee3c6d40560a7676a7659d9101ee2e8 Reviewed-on: https://chromium-review.googlesource.com/c/1310566Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#604371}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6b65b358. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26812 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I7232e61c3fc886786184f92f57849cd43d897fe3 Reviewed-on: https://chromium-review.googlesource.com/c/1310474 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#604370}
-
Aiden Benner authored
Updates JNI wrapper to use the version that optimizes the best with R8, and includes a testing flag/setter. Bug: 898261 Change-Id: I343dd1a4f470fb8067dfd4cdb31d7c545b5f3717 Reviewed-on: https://chromium-review.googlesource.com/c/1308098 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604369}
-
Vladislav Kaznacheev authored
Bug: 876117 Test: manual Change-Id: Icad9c7939161c5b488b0852a59f1ad58c4af5658 Reviewed-on: https://chromium-review.googlesource.com/c/1306414Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#604368}
-
Scott Chen authored
Originally the landing page would be visible briefly until modules finished initializing. This CL makes it so the whole view-manager is hidden until steps are ready to be shown. The animation had also been changed to exit immediately, so 1) the users don't see remnant of fade-out of the landing view when they land on //welcome/new-user and //welcome/returning-user directly, 2) prepare the transition to match mock, which doesn't want a fade-out animation for the exiting view. Bug: 874151 Change-Id: Ie0d3853639686b51205bd37cd1dc4035bc96b94d Reviewed-on: https://chromium-review.googlesource.com/c/1306840 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#604367}
-
Darwin Huang authored
- Renamed DocumentAttached() to DidAttachDocument() so that function names better express what the function is trying to accomplish - Remove extraneous GetDocument() calls - Spellfixing "I think that DocumentAttached(..) is misleading, since it seems to imply that it's going to find out whether a document is attached and return a boolean representing that. Instead, it's in essence attaching to a document (or rather the document’s context, but with some clearing and such going on as well). Therefore, I'm thinking of perhaps renaming DocumentAttached(..) to AttachDocument(..) or AttachToDocument(..) in another CL." -Darwin in another CL Bug: 896479 Change-Id: I4b9e2cd9a998f2b18acdbca9e2339c7ca5a124e8 Reviewed-on: https://chromium-review.googlesource.com/c/1300680 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604366}
-
Daniel Bratell authored
More of third_party/* has been made gn check clean and this CL enables it for another 14 directories. Most (but not all) of the rest look non-trivial. Bug: 898837 Change-Id: I95c7348d8c1fa0bf85e0345aaaa9228f971a300e Reviewed-on: https://chromium-review.googlesource.com/c/1309743Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#604365}
-
Javier Ernesto Flores Robles authored
Enables the injection handler used in Manual Fallback to work on frames. Adds testing utilities to support tapping an element in a window frame. Adds the frame messaging flag to the manual fallback test bot. Bug: 845472 Change-Id: Id054361af1f4be5450f13cd0afabe46e24ea11ff Reviewed-on: https://chromium-review.googlesource.com/c/1292409 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604364}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: If9bfa6f520533a87f923d592ffb658b19d9118c1 Reviewed-on: https://chromium-review.googlesource.com/c/1310557Reviewed-by:
-
Brian White authored
Bug: 836238 Change-Id: Iafd29fb293af9b284ae9ab98b2f6c12bb27fa9a0 Reviewed-on: https://chromium-review.googlesource.com/c/1308634 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604362}
-
Michael Giuffrida authored
Helper class to set up state for demo sessions and control how the Demo Mode resources component loads. Supports both core Demo Mode unit tests and other unit tests that need to verify interactions in Demo Mode. Bug: None Change-Id: Id465d3f5b9bceaa3d4184feb01506504f49e6a51 Reviewed-on: https://chromium-review.googlesource.com/c/1300494Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604361}
-
Yi Su authored
Enable SearchEngineTabHelper to add new TemplateURL to TemplateURLService by following steps: 1. Receive messages of OSDD(Open Search Description Document) <link> in page from Js; 2. Download, parse OSDD XML file, and create TemplateURL; 3. Add TemplateURL to TemplateURLService. The OSDD functionaliy on Js side has not been changed yet, but SearchEngineTabHelper and SearchEngineTabHelperTest is decoupled from it. search_engine.js will change from positive calling into message mechanism for OSDD in another CL. Bug: 433824 Change-Id: I113e362ed1fa38cff43cea1e8fe2f591fac469c0 Reviewed-on: https://chromium-review.googlesource.com/c/1309746 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/673cf8fc2ca9..59f591bd4e30 Created with: gclient setdep -r src-internal@59f591bd4e30 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib6ab3925b8507eee0d3c6541bf363d2e7a92086d Reviewed-on: https://chromium-review.googlesource.com/c/1310595Reviewed-by:
-
