- 07 Aug, 2020 40 commits
-
-
Maggie Cai authored
Currently the intent picker launched the web app when user select the web app. This CL updates to reparent the web app instead of launch. BUG=1113969, 853604 Change-Id: Ie7a790999f68696a9c1d58bb1ef6e1e1cd8112b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341228Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#795799}
-
Kent Tamura authored
This CL ports LayoutButton::BaselinePosition() to ng_flex_layout_algorithm.cc. FlexNG's children don't have the last-line baseline values. So we set BaselineAlgorithmType in NGFlexLayoutAlgorithm::Layout() so that children provide the last-line baseline as well as the first-line baseline. PropagateBaselineFromChild() needs to call |NGBoxFragment:: FirstBaseline()| explicitly because button children's Baseline() is the last-line baselines. * text-overflow-ellipsis-button-expected.html Ellipsis processing in LayoutNG keeps the first letter. Bug: 1040826 Change-Id: I36402b4fc291d2989c45fb1764202f4fcea91fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300902 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#795798}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca50c1ef5f52..5a1495ff04c6 2020-08-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-07 nidhijaju@google.com Revert "Adding a link to SW internals page to view other origin SWs in DevTools" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112894 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87c3e12cad8f46f062ce9e9f2e8370bf772e38fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795797}
-
Zufeng Wang authored
When the help app launches (or navigates), the main frame updates the src of the iframe with the main frame's pathname (but not search or hash params). The existing routing logic inside the iframe shows the subpage. Also changed the iframe to be created by js in browser_proxy.js, and add <head> and <body> tags so Chrome doesn't need to infer where to add them. Bug: b/147786001 Change-Id: Iddc2028a9f086d4caf5f18b93c148914578f31d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340503 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795796}
-
Minggang Wang authored
As SplitCacheContentBrowserTestEnabled.SplitCacheDedicatedWorkersScripts becomes flaky recently, this patch disables it on Win10 and Linux ASAN. Bug: 1104847 Change-Id: I3ba6e017232f79cf78b127b8621e1aa17d03caa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342465Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#795795}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29812a90. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Iccf4e22ef0e929da50967775c4a332c6e4fa83e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339939Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795794}
-
Ahmed Mehfooz authored
Bug: 1111484 Change-Id: I62e6916d4e535065dc968cf708c914f4bfa7321f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338003 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795793}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //android_webview. Bug: 1113033 Change-Id: I5dcc8599dc972c2631a7bd9d0e26d11e1fe68d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335659Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Auto-Submit: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#795792}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ee50b032e42a..c4d3ff474abe 2020-08-07 wvw@google.com Fix systrace cgroup data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1113545 Tbr: oysteine@google.com Test: Test: catapult/systrace/bin/systrace sched Change-Id: I29b79a556f226c8f2ce89cd916d0417c18fac3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342070Reviewed-by:
-
Makoto Shimazu authored
These tests are disabled: - RequestDesktopMobileSiteTestCase/testAppVersionJSAPIWithMobileUserAgent - RequestDesktopMobileSiteTestCase/testRequestDesktopSiteKeptSessionRestoration - RequestDesktopMobileSiteTestCase/testRequestDesktopSiteDoesNotPropagateToNewTab - RequestDesktopMobileSiteTestCase/testRequestMobileSitePropagatesToNextNavigations - RequestDesktopMobileSiteTestCase/testRequestDesktopSitePropagatesToNextNavigations - RequestDesktopMobileSiteTestCase/testRequestDesktopSiteGoBackToMobilePurged Tbr: gambard@chromium.org No-Try: true Bug: 1111194 Change-Id: I3ac977790b4eef149cd8ccbecf955d416043319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331252Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795790}
-
sangwoo authored
Sometimes the first or the last dot of dotted line for text is too heavy and long. We should improve this. Bug: 807368 Change-Id: I2851c964892b145154514c6f38e8025a8c29a7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319501 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#795789}
-
Josh Simmons authored
Add a Chromium feature flag to enable / disable Files.app running as a System Web Application (SWA). Bug: 1113981 Change-Id: Ib829df993294bef692b14aed8dab3749c5d227e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342227Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#795788}
-
Rakina Zata Amni authored
Turn off proactive BrowsingInstance swap for WebAppDataRetrieverTest.GetWebApplicationInfo_FrameNavigated The test does not expect a change of RenderFrames. Bug: 977562 Change-Id: Ib11cf533d413616fc9189103f44c0dc8dc327e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335850 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#795787}
-
Joe DeBlasio authored
This CL adds a list of 10k common english words to Chrome. Rather than include this list directly into the binary as a full list, its encoded as a DAFSA, which provides a space efficient set inclusion check. This CL is a necessary building block for implementing the policy in the referenced bug. This list isn't presently used anywhere, but the CL is large enough by itself that I didn't want to burden it further. It'll be used shortly after submit. Bug: 1106962 Change-Id: Ia03daca847e2eea42671b3d18348d5c706cc4904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340879 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795786}
-
Gavin Williams authored
This new destination will be used in the Print Preview dropdown to replace the existing Save to Drive destination. go/save-to-drive-cros-design-doc Bug: 1112416 Change-Id: If754c141adb66e070a3224343f034865e9ee0b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336019Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#795785}
-
Kang Minchul authored
Remove use of base/macro.h and use explicit deletion instead Bug: 1010217 Change-Id: I506af7085e0098351642a28b127965d16d103c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341022 Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795784}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a6e1d2d16082..ca50c1ef5f52 2020-08-07 cjamcl@chromium.org [Lighthouse] Roll Lighthouse 6.2.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79f792ae159ba591d35385b1c14bfb9e80908ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341705Reviewed-by:
-
Alan Cutter authored
This CL ensures we re-install default installed Extension apps that were migrated to web apps if the migration flag is disabled. Previously we would not reinstall the old Extension because the uninstall for migration was recorded as a user uninstall. This CL updates AppService.Uninstall() to take an |uninstall_source| enum so the call site can indicate whether it is a user or migration uninstall. Bug: 1104696 Change-Id: I832e2d8f3c3769a45f147aafb1c4e15646c8fdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339294 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#795782}
-
Mark Pearson authored
I keep seeing people miss it. Change-Id: I5d008064d76de1c36d1f71a08df014d2c3967e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335815Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#795781}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/595e752cb141..bcb0ad4d8c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: patricialor@google.com Change-Id: Ic7f53ff882dd1b320158804ecf217b7b098db674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342088Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795780}
-
calamity authored
This reverts commit f68e4323. Reason for revert: Causing crashes as expected and needs to be reverted for next Beta release. Original change's description: > Add null check to ContentAction::Apply. > > This CL is a speculative fix for a Feedback App crash. > > Bug: 1010336 > Change-Id: Ifc97455fbf942af41dc54417cc7449b888577d32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210602 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Auto-Submit: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774999} TBR=benwells@chromium.org,calamity@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010336, 1113103 Change-Id: Ic16d88a87b8f68bf365406a469dcbad6af7d7fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342425 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#795779}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ZF_pgjG6rhfxsI1g17CmHTot4WuP2GZTEgUV2qEN0E8C Release notes: http://go/media_app-x20/relnotes/Stable/media_app_20200806_RC00.html Bug: b/162102218, b/161761740, b/162996761, b/162541639, b/162542166 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ieaa73d30bee08fc32f1ff945457f3b10ea6fcd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342225 Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#795778}
-
Ben Pastene authored
Given the limited capacity & P coverage due to crbug.com/1111436, experimental suites on this bot are likely doing more harm than good. These are the lowest hanging fruits we can chop off in the hopes of restoring P coverage. So let's remove them for now. Bug: 1113877, 1111436 Change-Id: Ifa590079673841fadc3ab3d84084dd9d96b140b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342121 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#795777}
-
John Delaney authored
What: Add impression attributes to anchor element IDL, gated behind the ConversionMeasurement. Why: We want to allow programmatic assignment of conversion measurement without having to use SetAttribute for simplicity. API explainer: https://github.com/WICG/conversion-measurement-api Bug: 1097144 Change-Id: I58a40998642aee5e7ae3f632c95a531604c93ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258254 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#795776}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5cf00e267438..ee50b032e42a 2020-08-07 dberris@chromium.org chromeperf: Introduce retries in API discovery 2020-08-07 bsheedy@chromium.org Revert "[Telemetry] Disable testGetMinidumpPathOnCrash" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1108432,chromium:1111450 Tbr: oysteine@google.com Change-Id: I3487a98a24ea49d52566dda5542680285151abe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342266Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea952ff32bf6..e3988722bf9f 2020-08-07 syoussefi@chromium.org Fix an OOB access bug with RewriteRowMajorMatrices 2020-08-06 jmadill@chromium.org Vulkan: Add Image serial. 2020-08-06 jmadill@chromium.org Vulkan: Accumulate Buffer barriers. 2020-08-06 jmadill@chromium.org Vulkan: Add command buffer performance counter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I7e1b3e0d3cbb401c978467622a7984f5c222ff5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342244Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie181d2ce35a867c5449d20781a5c4f8a3d2b0d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342544Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795773}
-
Yuchen Liu authored
Bug: internal b/160753974 Test: CQ Change-Id: I5bf7eb989bb4dd34edb1194532375423c9963d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342129 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#795772}
-
Ana Salazar authored
When entering or exiting cardfified state, we now use transforms for app icons so that animations run smoothier and in a more controlled way. Bug: 1108643 Change-Id: Ib3d0728e62bc360b98c04910ea9793eb39dc1b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335556 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795771}
-
Vladimir Levin authored
This patch lands a test and marks it as failing. Since the solution to this bug doesn't seem obvious yet (see the referenced bug), we should land the test so any of the potential fixes can be verified on the bots. R=chrishtr@chromium.org, wangxianzhu@chromium.org Bug: 1113838 Change-Id: I410766ce8294309840ca21945c3b231c018825aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341356 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#795770}
-
Wei Lee authored
We will use NativeFileSystem API for external storage access in SWA. Bug: 980846 Test: CCA (SWA) can save captured photo Change-Id: I4d324c71ef62729b8a9dbf53cacff37bf4c0e5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131672Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
-
Regan Hsu authored
Before EOL, Eol warning notifications "Learn More" button and About Details Page "Learn More" link will link to Auto update page. After EOL, Eol final warning notification "Learn More" button and About Details Page "Learn More" link will link to EOL page. Also adds unit tests. Fixed: 1098797 Change-Id: I411702fa107363beb3fb361337a1f257195ef0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340105 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#795768}
-
Yusuke Sato authored
The proxy does that by itself today. BUG=b:142140355 TEST=pkill crosvm, confirm ARCVM restarts and mojo works. Change-Id: I72fae8dba5d5c134510e093288db1d1c90f12148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341996Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#795767}
-
Joshua Peraza authored
9cd1a4dadb51 doc: Upgrade the crashpad-home App Engine app to the Go 1.11 runtime 94b7e45210a7 fix OS guards for attachments 2f66eefb7921 Update language to eliminate 'whitelist' 0cccdc0b7ec3 Replace is_linux with is_linux || is_chromeos Change-Id: Ia91ba57d7051b49d398f3cfa18c335cf6303e993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341940 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#795766}
-
Dirk Pranke authored
This file needs to be updated when we add or remove builders, so it makes sense to have infra troopers be able to make and approve changes for it, along with the normal owners of the code. Change-Id: Id3351654d75b23019b59062c124e7f2d2fa29e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342264 Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
-
Dale Curtis authored
These should expect BT.709 when the proper color spaces are not supported by the OS version. R=sandersd Fixed: 1113153 Change-Id: I3e6ae4bcedcf9adecb93efb70db0d38f99bced23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342345 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#795764}
-
Dale Curtis authored
We need to expand values to fill the R16 range despite the texture type being labeled as "unorm". This copies the same method we use for R16 video uploads. Tests show the compiler does a reasonable job of optimizing this loop with SIMD; it's still faster than the F16 path, but a few hundred microseconds slower than the previous CopyPlay_16 path. R=pkasting, wtc Fixed: 1112436 Change-Id: Ie049297937be9c9f8f934e35581e2e4575f4b1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341666 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#795763}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3231b152604..b35c3b8bcdf7 2020-08-07 johnstiles@google.com Replace `unimpl` comments with `= delete`. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I3f293b920b0107f2193cedb8a2f4a0482fa459ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342087Reviewed-by:
-
Patti authored
This reverts commit c8df13e9. Reason for revert: Failing on a few builders now in the gclient runhooks step, see crbug.com/1113988 Original change's description: > Reland #2 of "Parallelize fetching telemetry benchmark deps" > > This reverts commit e6ad8b42. > > Difference from previous reland: using close and join instead of terminate > > Original change's description: > > Revert "Reland "Parallelize fetching telemetry benchmark deps"" > > > > This reverts commit 95e22d39. > > > > Reason for revert: Potentially breaking many builders, https://crbug.com/1108314 > > > > Original change's description: > > > Reland "Parallelize fetching telemetry benchmark deps" > > > > > > This is a reland of 8ab0b856 > > > > > > Original change's description: > > > > Parallelize fetching telemetry benchmark deps > > > > > > > > The fetching script currently fetches about 2 GB (on my linux workstation) > > > > from cloud storage serially. This can (and is) trivially parallelizable, and > > > > should speed up the fetching script significantly. > > > > > > > > This script has been taking 20 minutes on mac machines for a long time. This > > > > will hopefully significantly speed the mac builders up. > > > > > > > > Bug: 1102597 > > > > Change-Id: I93d2fa2b1f4b4ef6e27e9c894a9dd4c0d0e12d7b > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285503 > > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > > > Reviewed-by: John Chen <johnchen@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#786521} > > > > > > Bug: 1102597 > > > Change-Id: I37d0055fadb26bf4eae2b0b5fe0ecc4732edde3d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288740 > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Reviewed-by: John Chen <johnchen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#789736} > > > > TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > # Tree is currently closed, trying to fix an outage > > > > No-Try: true > > No-Tree-Checks: true > > Bug: 1102597 > > Change-Id: If6b95395208a3136a798118e4eb229e4322c7878 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317774 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#791304} > > TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1102597 > Change-Id: I2f9a7162e73ee264ed9f0f844f45106160bce793 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339589 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/master@{#795751} TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com Change-Id: Ia31da9d6b6fd00f6e0105314955d8f0bfe830b05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342228Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#795761}
-
Hazim Mohamed authored
Restructure Native File System drag and drop by changing DataTransferItem.getAsFileSystemHandle() to return a ScriptPromise<NativeFileSystemEntry> instead of synchronously returning a NativeFileSystemHandle. To support this change, this CL introduces the content::NativeFileSystemDragDropToken interface to transfer drag & drop data between the browser and renderer processes, instead of using the existing content::NativeFileSystemTransferToken class. Consequently, the NativeFileSystemTransferToken class has been refactored to reduce unnecessary complexity introduced to support NativeFS drag and drop. Bug: 1080811 Change-Id: I5d31cbb50290e6422d44e051bcd6c80e5b7a089c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282101Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Cr-Commit-Position: refs/heads/master@{#795760}
-
