- 17 Jan, 2020 40 commits
-
-
Guillaume Jenkins authored
When I attempted to submit the field trial test for the Windows native spell checker integration, the try bots picked up several crashes in existing tests when the native spell checker flags are enabled in Chrome: https://cr-buildbucket.appspot.com/build/8891251817173916304 The crashes were caused by the use of raw pointers instead of weak pointers, because the SpellcheckHunspellDictionary object was deleted by the time the callback from PlatformSupportsLanguage() was invoked. Change-Id: I8ac2afa9b66a11a2846a086f23d024ce380f77eb Bug: 463364, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003087Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Auto-Submit: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#732910}
-
Michael Crouse authored
This change uses the persisted session FCP mean for the previous page load's FCP when there is no previous page load available. For the first page load of the session, this will always be the case. Bug: 1041664 Change-Id: Ie2666cbcf841ebaa4ad20a2747c92377cf6c451b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999302Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#732909}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b7cd486d..c766f984 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I919f537bb6a276addd551f62e964b8144cbd6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007769Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732908}
-
Eric Seckler authored
Also includes manual modification to switch to perfetto's EventContext. https://android.googlesource.com/platform/external/perfetto.git/+log/11c11a1a891c..d092437b81ea 2020-01-17 fmayer@google.com Merge "Cleanup of profile related trackers." 2020-01-17 eseckler@google.com Merge "client lib: Add an EventContext constructor for Chrome" 2020-01-17 lalitm@google.com Merge "bazel: Disable warning about unused system_header pragma" 2020-01-17 lalitm@google.com Merge "trace_processor: fix overflow in bitvector" 2020-01-17 taylori@google.com Merge "Make selection default behaviour" 2020-01-17 treehugger-gerrit@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." 2020-01-17 eseckler@google.com Merge "processor: Only fall back to legacy tracks for legacy events" 2020-01-17 treehugger-gerrit@google.com Merge "TrackEvent: Add initial legacy macro support" 2020-01-17 fmayer@google.com Merge "Function for on-demand flamegraph for heap graph." 2020-01-17 treehugger-gerrit@google.com Merge "Turn ingestion DFATALs into DLOG." 2020-01-17 khokhlov@google.com Merge "Exclude targets depending on sqlite from embedder builds" 2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated" 2020-01-16 eseckler@google.com Merge "processor: Export pid/tid as signed integers into JSON" 2020-01-16 lalitm@google.com Merge "trace_processor: fix compile and build on fuzzer" 2020-01-16 joelaf@google.com Merge "Fix precision errors by explicit casting" 2020-01-16 lalitm@google.com Merge "Revert "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead."" 2020-01-16 chiur@google.com Merge "Add VulkanApiEvent.VkQueueSubmit message" 2020-01-16 khokhlov@google.com Merge "trace_processor: Run metrics on Windows" 2020-01-16 primiano@google.com Merge "gn: Fix issue with finding llvm when using python3" 2020-01-16 hjd@google.com Merge changes Ic6800bd0,I29636316 2020-01-16 treehugger-gerrit@google.com Merge "processor: Fix handling of 0 timestamp in TrackEventTokenizer." 2020-01-16 rsavitski@google.com Merge "heapprofd producer: use sigqueue(si_value: 0) instead of kill" 2020-01-16 taylori@google.com Merge "perfetto-ui: Toggle sidebar on ctrl/cmd + b" 2020-01-16 eseckler@google.com Merge "client lib: Support building in Chrome using a fake platform" 2020-01-16 eseckler@google.com Merge "processor: Translate duplicate pids/tids during json export" 2020-01-16 buss@google.com Merge changes I1bb0e215,I498ed990 2020-01-16 treehugger-gerrit@google.com Merge "processor: Support pid reuse in ProcessTracker without Start/EndThread" 2020-01-16 primiano@google.com Merge "GTEST_EXECUTE_STATEMENT_ is not available on iOS execute the statement directly instead." Created with: gclient setdep -r src/third_party/perfetto@d092437b81ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: 1043059 Change-Id: I37e4964f76d212bcfef69c8715ac7521521e82a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007750Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#732907}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/486a2cf15526..243095cddff8 Created with: gclient setdep -r src-internal@243095cddff8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1007337 Tbr: jbudorick@google.com Change-Id: I938935162017b29cbb817777383a47c2834e80eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007913Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732906}
-
Jan Wilken Dörrie authored
This reverts commit 61f91381. Reason for revert: Likely causing flakiness in source-frame-breakpoint-decorations.js: https://crbug.com/1043146 Original change's description: > Remove event races in two breakpoint decoration tests > > This CL changes two layout tests to follow the pattern of: > 1. Install an instrumentation promise > 2. Run and await an async action > 3. Await that the instrumentation is called > 4. Dump breakpoint information > > This CL is also in preparation for asyncification of source mapping, > hence making the "action" async. > > Drive-by: Re-baseline one of the layout tests that seems to be fixed > now. > > Bug: chromium:1032016 > Change-Id: Ibad4160fe9ab32aa3f818cdd4937112c3f4e6f08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000023 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731171} TBR=sigurds@chromium.org,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1032016 Change-Id: I05e46d646d6cbf1516c8d9a2c1eab46cd8d05377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007810Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732905}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I3a781c86f9cd280b2aaf5f5227fff18a7770f289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001718Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732904}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c5f3dc47. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." 8a985066 "[Trusted Types] Implement require-trusted-types-for" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id5a73efae805b713278c2766d9606859c4109b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007611Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732903}
-
Jimmy Gong authored
- Adds a new printer entry type: PRINTSERVER - Print server printers are treated as nearby printers - Adds browser test to reflect this change. Bug: 1015628 Test: browser test, End to end manual Change-Id: I3a21f3af8be274fe47c7e57d2e4a349ea35b974c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993754 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#732902}
-
Jan Wilken Dörrie authored
[Sheriff] Disable flaky virtual/stable/external/wpt/html/cross-origin-embedder-policy/blob.https.html TBR=foolip Bug: 1042681 Change-Id: I5db2d0cbfd1fc84400d25b22d93b4f9bc62b34ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007574Reviewed-by:
-
Alex Chau authored
Change-Id: I133d3fd7ceef23ce4fa4dd3dc5230761f067f440 Bug: 1043130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007694Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732900}
-
Mugdha Lakhani authored
Tying to BrowserFragment lifecycle leaves a loophole. If setRetainInstance() is called on BrowserFragment, it will be detached and reattached without necessarily being destroyed and re-created. In the duration the BrowserFragment is alive but not attached, it'll not receive any network change notifications. Tying registration to the Browser lifecycle fixes that. Bug: 1018848 Change-Id: I63be218a0fa2f8422f5cd9cc0d6e2dee2fa2be0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998398 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#732899}
-
Bruce Dawson authored
When you choose 'retry' in the bisect script then the next two candidates are prefetched again. On most platforms this is just inefficient but on Windows it leads to a script failure. The prefetched files can't be deleted because they are still open. I didn't investigate exactly how the open handle happened, but orphaned threads and redundant downloads seemed worth cleaning up. Change-Id: I64ce6af18d82030c91bbb4fd31ab01b5adfd1d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996396Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732898}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9b1ec5f072a5..93e3c76a6543 git log 9b1ec5f072a5..93e3c76a6543 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 robertphillips@google.com Vulkan texture upload clean up 2020-01-17 kjlubick@google.com [canvaskit] Make font names programmatically accessible 2020-01-17 sergeyu@google.com Fix protected image allocation in createVkImageForBackendSurface() 2020-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 98818e57..870bcafd (445 commits) 2020-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5fc197dc7669..2cb1db08e5f1 (2 commits) Created with: gclient setdep -r src/third_party/skia@93e3c76a6543 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I0c71d5ba827658ba71309b14971c5ae10be056f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732897}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/524417f3f7d0..db6ca7f2d7fd git log 524417f3f7d0..db6ca7f2d7fd --date=short --first-parent --format='%ad %ae %s' 2020-01-17 ilnik@webrtc.org Add safety checks in RtpPacket::ZeroMutableExtensions and fuzz it 2020-01-17 srte@webrtc.org Do not allow sending tasks to a thread that is quitting. 2020-01-17 phoglund@webrtc.org Repurpose upload script to read natively generated histogram json. 2020-01-17 srte@webrtc.org Using EmulatedEndpoint in Scenario tests. Created with: gclient setdep -r src/third_party/webrtc@db6ca7f2d7fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042535 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4eb4791a8a50d8fedbb5ee2c497787a882fc73e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007911Reviewed-by:
-
arthursonzogni authored
This test is navigating 14*7 = 70 iframes in parallel. This is a lot! We need to increase the WPT test timeout to make it work without exceeding it. Bug: 818324 Change-Id: I80aa2f74e41957e35b5490a9d57dcfccd2ac011f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007416 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732895}
-
Takumi Fujimoto authored
When a Cast session is initiated from a web page and the page doesn't get rid of its media session, we generally get duplicate media notification items: one for the sender page and the other from the receiver. This CL hides the former in such cases. Bug: 1038447 Change-Id: Icfa3487a9c101aa185b5ec7e41f5981da23a64df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955086 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732894}
-
Jared Saul authored
Also removes 5 tests that only have relevance as long as the checkbox exists (which it no longer does) Please note that this is exactly the same CL as https://chromium-review.googlesource.com/c/chromium/src/+/1682429, which was originally rolled back so we could temporarily unlaunch. We are now continuing with the full rollout and can set these to ENABLED_BY_DEFAULT again. Bug: 941664 Change-Id: I1006e28a1f0fab42216ea051fd9b2cd1701bab0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003622 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732893}
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: Ic3d63d3bef4a0cda472e9794470d28afba0deb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985336 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#732892}
-
Jan Wilken Dörrie authored
TBR=ericrobinson Bug: 1041810 Change-Id: I3a37ae565ac3b578e75220977e87ad41d9d616fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007453Reviewed-by:
-
arthursonzogni authored
Reenable the tests. They have probably been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1995261 Remove attribute "async defer" to the <script>. It delays the script execution for no reasons and might also cause it to fail. Improve coding style along the way. Bug: 1039643, 1039642 Change-Id: I8e4667a455d96f03f3f2d99e229f529ec5d70153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007732 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Kyle Milka authored
Show 7 3P sharing options in the bottom row. For now these are just the first 7 things returned by the package manager, no filtering or sorting is applied. Bug: 1009124 Change-Id: I6bae7e52e14a044192a8f8c9b9bd550525c300ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995467 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732889}
-
Dominique Fauteux-Chapleau authored
Bug: 1020267 Change-Id: I98f1a6b785f66225622bacd60721bd84e3d508d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005688Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732888}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2cb1db08e5f1..d95467ec4e30 git log 2cb1db08e5f1..d95467ec4e30 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 capn@google.com Rename createBlend4 to createShuffle4 Created with: gclient setdep -r src/third_party/swiftshader@d95467ec4e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia894a1cccbb94df12521df04701aaee56d0f3247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007928Reviewed-by:
-
Hui Wang authored
Bug: None Signed-off-by:
Hui Wang <wanghui210@huawei.com> Change-Id: Ie8395d6e72a7193f000afe03c15218d7c7bb36b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006446Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732886}
-
Vadym Doroshenko authored
Addressing one TODO and removed several already addressed TODOs. Change-Id: I8b4e1f96fb67e47d97c5eced35992c237e6043fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007690Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#732885}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by me. Bug: 1041419 Change-Id: If28253fb33fc1e42c6ae6f0d83f0c1c529bf7f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007650Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732884}
-
Charlie Hu authored
This CL adds initialization of document policy on browser side. A DocumentPolicy instance is now available in RenderFrameHostImpl. Bug: 993790 Change-Id: I990a39d219179dd9254060a7488eab4f991e44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988156 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#732883}
-
Fritz Koenig authored
When using low latency MSAA resolve was gated by swap chains. ChromeOS does not use swap chains. Move the resolve to before checking for swap chains. Test: https://codepen.io/miguelao/pen/WKZaqd Bug: 1025747 Change-Id: I344c8576c16277348950836a3fc28a58f787a256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003073 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#732882}
-
Nohemi Fernandez authored
Bug: 1005509 Change-Id: I7eab2ad6ad082daadff0ab38aafe9ea57d655ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007450 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732881}
-
Stepan Khapugin authored
This just makes _browserViewWrangler a property and updates calls. This will allow for cleaner CLs moving code to SceneController. Bug: none Change-Id: Ic3118c54ac0799a0089a0e5a159d68d672b899c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003854Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732880}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d8628858c150..9293af72309e git log d8628858c150..9293af72309e --date=short --first-parent --format='%ad %ae %s' 2020-01-17 tvanderlippe@chromium.org Migrate sdk/ to ESM internally Created with: gclient setdep -r src/third_party/devtools-frontend/src@9293af72309e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc5dacd874ff6cf492874b38f293e2cfe6fb8d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007908Reviewed-by:
-
Scott Violet authored
As a last file doesn't make sense for WebLayer this is structuring the code in such a way that the last file related code is not in the base class. This does the following: renames BaseSessionService* to CommandStorageManager* Next step is to move the functions related to a 'last file' out of CommandStorageManagerinto CommandStorageManagerWithBackup. Specifically the functions: MoveCurrentSessionToLastSession, DeleteLastSession, ScheduleGetLastSessionCommands. CommandStorageManagerWithBackup will subclass CommandStorageManager. SessionBackend will be similarly split such that functions related to last session are moved into SessionBackendWithBackup, which will extend SessionBackend. I'm not dead set on the 'WithBackup' suffix. It's not really a backup, so much as the last session. I considered the prefix 'MultiFile' but that's a bit too generic and obscure. I'm certainly open to other suggestions. BUG=112512 TEST=none Change-Id: I33d2c9be43bbaea4336fa32bdb3fe750d39f543a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005809Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#732878}
-
Leonard Grey authored
These fail deterministically See: https://test-results.appspot.com/data/layout_results/Mac10_10_Tests/50711/webkit_layout_tests/layout-test-results/results.html TBR=iopopesc@microsoft.com Bug: 1035582 Change-Id: Ie5d7937feb8edea4452894960ab5a7d76af3f4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007868 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#732877}
-
Mike West authored
Leaning on Google Security's work defining Strict CSP (https://csp.withgoogle.com/docs/strict-csp.html), this patch considers a policy to be "reasonably secure" if it: 1. Asserts `object-src 'none'`. 2. Asserts `base-uri 'none'` or `base-uri 'self'`. 3. Avoids URL-based matching, in favor of hashes and nonces. It adds metrics for each of these independently for both enforced and report-only policies, as well as for the "reasonably secure" metric composing all three. Bug: 1040876 Change-Id: I4054e5abccd0966a30dcec01a3f8c04f6e3575a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002587 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#732876}
-
Nazerke authored
This CL updates StoreKitCoordinator to use the preferred init for coordinators, which provides a Browser instance, also updates the unit tests. Bug: 1029346 Change-Id: Ifa9d080eb4a0c1768e549d01c6282cfe7207a0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007188 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
-
Christopher Cameron authored
The concept of "the color space of the display" falls apart on several platforms, because display (or OS) can be configured to handle multiple color spaces. Rather than sending a single color space, send a set of color spaces to use in various situations (sRGB-only content, SDR WCG content, and HDR content). Use this gfx::DisplayColorSpaces structure in display::Display, instead of using gfx::ColorSpace and sdr_white_point. Also communicate this via mojo, which had not been done in the past. For now, only use the "HDR transparent" color space. The next patch use this structure in ui::Compositor, viz::Display, and viz::SurfaceAggregator. This structure is added to gfx because it is imported from these several locations. Bug: 1037954, 1038770, 1038494, 958166 Change-Id: I677e3f5c4d01deeb95f76b6463541eec2163b48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006068Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#732874}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1918d6d30029..486a2cf15526 Created with: gclient setdep -r src-internal@486a2cf15526 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1200d259eaa6c4e94ac9d3e20cd5aa7acbf0d309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007305Reviewed-by:
-
Olga Gerchikov authored
This change reduces number of TIME_UPDATED events passed to main thread. When syncing time from compositor to main thread, only the last time value produced on the compositor thread is relevant. Passing all other values is unnecessary overhead. Bug: 1013654 Change-Id: Id950d48f2b36c6afb2d74cf26605c490767121b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001260 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732872}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c9f42ad909c0..524417f3f7d0 git log c9f42ad909c0..524417f3f7d0 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 titovartem@webrtc.org Move method to right place in the PC API Created with: gclient setdep -r src/third_party/webrtc@524417f3f7d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ied0683d49569f7ba35559b38e6d9bc7120251b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007848Reviewed-by:
-
