- 18 Jun, 2020 40 commits
-
-
Giovanni Ortuño Urquidi authored
Passing both types of files, .ts and .m.ts, to the compiler at the same time caused them to pollute each others' namespaces. This meant that all interfaces and constants specified in .ts files would be available in .m.ts files without us having to actually import them. This fixes the issue by compiling .ts files separately from .m.ts. files. Bug: 1011609 Change-Id: Iee93d85ec4eec44d82823ab5ab4ba2828b72ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245982Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#779717}
-
Marc Treib authored
Before this CL: With the feature EnablePasswordsAccountStorage enabled, calls to PasswordAutofillAgent::MaybeCheckSafeBrowsingReputation were always bypassed (as an unintended side effect of showing the autofill dropdown even if there are no password suggestions). This caused the following two tests to fail with the feature enabled: PasswordAutofillAgentTest.CheckSafeBrowsingReputationWhenUserStartsFillingUsernamePassword NavigationMetricsRecorderBrowserTest.PasswordEntry_EngagementLevel This CL rearranges the logic so that MaybeCheckSafeBrowsingReputation gets called again when appropriate. Bug: 1095984, 1093310 Change-Id: If51032f09463ec25bb239ffa410af822d13b4678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247795Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779716}
-
Koji Ishii authored
This patch fixes hit-testing floating objects in a legacy root. With |NGPaintFragment|, floats are in children, and that regular traversal can cover this case. With |FragmentItem|, floats are either in |NGFragmentItems| if it has an inline formatting context, or in children otherwise. This difference requires additional branch to the legacy fallback when hit-testing floating objects. Bug: 1096259 Change-Id: I8565eb663781318233c21482270804cf254e0aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249249Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779715}
-
Javier Ernesto Flores Robles authored
Bug: 1081664 Change-Id: Ia96ee3dea8d05c177736c19371aeff723bee404d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250058Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#779714}
-
Koji Ishii authored
Following bot results are included. 2495 2496 2502 2508 2518 2519 2523 2526 2533 2534 22 lines were removed and 0 lines were deflaked by consecutive results since 2487. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I8829926775b32d00ba60754a5590e4324e600f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246122Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779713}
-
Rakina Zata Amni authored
This CL adds the capability of doing proactive BrowsingInstance swap on same-site main-frame navigations when the "SameSite" level is set on the "ProactivelySwapBrowsingInstance" flag. With that, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL does not include: - Updates for tests that fails because they didn't expect a change of RenderFrameHosts, etc. on same-site main frame navigations. These are handled in other CLs. - Fix to ensure order of unload handlers on same-site cross-RFH navigations (will be fixed on a future CL) - Fix to ensure WebPreferences are carried over for cross-RFH same-site navigations (will be fixed on a future CL) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I455e598d1c422984cb707bb3a8b54fa926bb5911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121522 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#779712}
-
Francois Beaufort authored
This CL makes sure PictureInPictureWindow is accessible from the leavepictureinpicture event so that users don't have to keep a reference to the PictureInPictureWindow object they got from the enterpictureinpicture event. Spec change: https://github.com/w3c/picture-in-picture/pull/189 Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/gwaEnJjtfKw Change-Id: Ibb6972596cd6b766bc2ed35cc6e360b7907c594d Bug: 1096350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241537Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#779711}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I439d719e7ae034b755e38d6034fa00fda9272262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249839 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#779710}
-
Maksim Ivanov authored
This makes the chrome.test.checkDeepEq() and the chrome.test.assertEq() functions more robust when handling the ArrayBuffer values, in particular handling the following scenario: chrome.test.checkDeepEq([], (new Uint8Array([1,2,3])).buffer); chrome.test.checkDeepEq([], (new Uint8Array([])).buffer); Before this CL, the code above evaluated to |true|, despite that the values are logically different. The bug was caused by the fact that iterating using a "for" loop over an ArrayBuffer doesn't actually visit any of its values, which led to it being considered as an empty container. The proposed fix is to additionally compare the results of the "instanceof" check. Also fix the "ExtensionWebRequestApiTest.PostData2" test to explicitly clear the array buffer in the field where it shouldn't be used in the comparison, rather than rely on the previous implicit "any array buffer is considered equal to an empty array" behavior. Bug: 1078761 Change-Id: Ie48293d7894a6212a7ec07444ad328603cfe0c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245487Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779709}
-
Anders Hartvoll Ruud authored
Instead of collecting all dependencies in a (potentially big) HashMap, and then rejecting them cache-time, it's better to reject excessive entries in the dependency map in the first place. This way declarations like "all:inherit" won't (pointlessly) create a huge HashMap internally. Bug: 1057072 Change-Id: Ib88c964cdadad2469b9635d510647be8499c76df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247765Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#779708}
-
Jiajia Qin authored
Previously, '--use-angle=gles' was not recoginzed by chromeos. If call 'command_line->GetSwitchValueASCII(switches::kUseANGLE)', it will return ''. This patch makes it get correct value. Bug: 1093720 Change-Id: I51dd57be40206c3c2b077c22241283da98d45f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241292Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#779707}
-
Yves Arrouye authored
Introduce a new VPD key, enterprise_management_embargo_end_date, to control the date until which one shall not try and ping Google enteprise management servers. If this VPD key exists, use it. If not, use the RLZ embargo end date instead as before. This VPD key gives OEMs control about when a device can start to ping Google servers that is fully independent of the marketing embargo for RLZ promotions. Bug: chromium:1093139 Test: unit_tests Change-Id: Iab264912b9c65af23b90563ec8109b673eafc26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239286Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#779706}
-
Bo Majewski authored
During a cleanup https://codereview.chromium.org/1148563004 the image Request class was renamed to ImageRequest. However, the file name was kept as request.js. Make the class and its file name the same. Bug: 903742 Change-Id: I6f2d7bbfb6f3f94001d0cd1e629fc27f83061c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245429Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#779705}
-
Leonid Baraz authored
Its purpose is to accept, store, upload and remove individual encrypted reporting records from any OS and/or Chrome components (FileSet treats them as opaque blobs of various size, limited by Options settings). The queue supports adding new records asynchronously, maintains strict records order (including the case when Storage module has restarted after crash or reboot), uploading records in batches periodically or immediately after write (in the future uploading on request is planned to be supported too). Uploading is performed by creating an uploader sink, which accepts series of individual records and then completion call - all are non-blocking asynchronous calls, with actual implementation of the uploader sink provided by the caller. The queue also accepts a confirmation request for specific sequencing numberi and priority, after which all records with lower numbers (inclusively) are assumed to have been processed and no longer included in future uploads from that queue. Bug: b:153364303 Change-Id: If9098df63bd74a8548775ab7621b362fec89dc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231033 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#779704}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d452e06b175c..8ee14407329b 2020-06-18 thestig@chromium.org Fix some typos. 2020-06-18 tsepez@chromium.org Introduce GCedTreeNode class template. 2020-06-17 nigi@chromium.org Create struct CFX_TextRenderOptions to represent text rendering options. 2020-06-17 tsepez@chromium.org Introduce CONSTRUCT_VIA_MAKE_RETAIN macro. 2020-06-17 thestig@chromium.org Add a test case for another FPDFAttachment_GetFile() failure mode. 2020-06-17 nigi@chromium.org Fix two embeddertests for Skia/SkiaPaths. 2020-06-16 tsepez@chromium.org Split off HeapEmbedderTest into GCedEmbedderTest. 2020-06-16 nigi@chromium.org Enable FPDFAnnotEmbedderTest.AddAndModifyImage for SkiaPaths. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:177188 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2b1f4f6eda41af5aa2615fffdf62c95d82902e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779703}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592438165-4613e214984c35e27b9764a9abcf09412695e573.profdata to chrome-mac-master-1592459911-64171aa0ec184a29370607ccffd98ff29f1f78e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9ea2bca6ab85f19ceb3e9ffe3aa9b719b7dec232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251458Reviewed-by:
-
Todd Sahl authored
This change adds two new group policies. The first policy accepts a list of protocols that may be launched by the browser without prompting the user. The second policy, if used, accepts a list of origin patterns that restrict the behavior of the first policy to just those origin patterns. The rules for origin pattern matching are described publicly here: http://www.chromium.org/administrators/url-blacklist-filter-format "/path" and "@query" patterns cannot be used as part of origin patterns, and this is noted in the policy description. Bug: 911605 Change-Id: Icb3aa769d5f0010225cb21097e3bb635085ad7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225522 Commit-Queue: Todd Sahl <toddsahl@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779701}
-
My Nguyen authored
Mock screenshot: https://screenshot.googleplex.com/n6jPyLOGHoZ Actual view: https://screenshot.googleplex.com/xho3q7phQr8 Note the actual view is because emoji suggestion can be managed by enterprise policy Bug: 1093650 Change-Id: Ie9bf4b4bdc1a51b44b60cf76feebe479334243a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237835 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#779700}
-
Wei Lee authored
Bug: 980846 Test: None Change-Id: I2621e011ba544c42ee1fc5029df8cb69b5dd8ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249213 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#779699}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Iea589d4d9bba82b1a88041791d7e5901b9270a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250477 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#779698}
-
Daniel Rubery authored
This CL adds a metric recording the results of the malware scan when an Advanced Protection user uploads a file for deep scanning. This will be useful to quantify the benefits of deep scanning at launch time. Bug: 1020418 Change-Id: I4d184ad0859c5fe2bf870f8f3aba2e23a322880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240410 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779697}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592444957-71678dbb85583180f0a866ae4da634fc0e847777.profdata to chrome-win64-master-1592452187-d8b5060216a94a83da3c0624280c3c37a480cfb4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0fcd0bdda642354ceaacb93b9e2c3fe08f24e961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251350Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592441973-8f9a4741d5f9fee5ba7748f102e2fb2e80661b9c.profdata to chrome-win32-master-1592452187-94708d6f0067ad9e590c4843569525b02efba040.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iaec2923a17584a2c14b9e934e98a042e5640cfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251349Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/622ed3fe6f3f..13d717d087e2 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8ee3be9c507533b8e1ecc4170bf0fea6f8f60fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251356Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b623d84fd3d3..2878b9ea5ed3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1012448 Tbr: kinuko@google.com Change-Id: I885754ea07a42277a1e6395b3df129b32c7fd402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779693}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67237c14a6db..53f973c22a26 2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 763957e6b4fc to 7a1d99d0be42 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ifc41b6d0c86ac19a2160cac6508b09148a5f14d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251355Reviewed-by:
-
Regan Hsu authored
The navigator.language must be explicitly passed into the time formatter for ES-419 formatted time to be displayed. This also corrects the additional zero shown in single digit hours. Bug: 1076309 Change-Id: Idd09e744e72a5d0cbaaa1ec92e4d1b88a8683105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250473Reviewed-by:
-
Noel Gordon authored
The files app drag drop chip is rendered in a #drag-container element, that must be visible to the browser, but hidden with z-index:-1 behind the files app #dialog-container (invisible to users). The files-ng drag drop chip differs from non-files-ng in its CSS style and also its HTML structure. Prefix existing #drag-container CSS with body:not(.files-ng). Move the #drop-label CSS into that group, add the same prefix and TODO comments about removing the #drop-label element. Add a CSS body.files-ng #drag-container group, used to style drag drop container structure for the files-ng case. Add renderThumbnailFilesNg_ to create that structure. Add notes to remove renderThumbnail_ used by non-files-ng case. Update to code to render the files-ng or non-files-ng drag thumbnails. For the files-ng RTL case, move the drag image grab point to the right by its clientWidth, scaled by the device pixel ratio, to satisfy dragStartEvent.dataTransfer.setDragImage(element, x, y) whose x,y co-ords work in screen units, rather than device independent co-ords like CSS pixel (px) units. For touch initiated drags, there is no need to reposition in the y-direction since the files-ng design has enough room to avoid a finger obscuring the drag drop chip content. Add code comments about "dropping directories on themselves", and code a plain for-loop over the selection Array rather than Array.find(). It is easier to reason about, and it is faster. Saves a function call per loop iteration and it helps if the code is fast since it's called from a drag event handler. Bug: 1002394 Change-Id: I1befcb6f69eca1c7f64591fbf0aca6bb0a69448e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247987Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779690}
-
Arnaud Mandy authored
Test to verify screen id. adding 3 displays to display vector. getScreens() should return 3 screens with ids 0,1,2. removing middle display from display vector. getScreens() should return 2 screens with ids 0,1. removing last display from display vector. getScreens() should return 1 screen with id 0. Bug: 1075656 Change-Id: Ib671b760353766d21330b95833b983c9b5e4737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238112Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#779689}
-
Hesen Zhang authored
Bug: 1087476 Change-Id: If941947a498da55e0e5d0809cdef276d16f5ae50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248863Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779688}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If4336e492c4d9dee0163b6d1b8473681dc5d9212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251359Reviewed-by:
-
Joel Hockey authored
The related bug shows that infobar is using the wrong color for non-tabbed PWAs. Infobar takes its color from the active tab color, and non-tabbed PWAs are currently setting active tab color to the theme color (rather than alt color) in order to get the desired NTP page during page load. The fix here is to roll back some of crrev.com/c/2094484 and set active tab color back to the alt color, and then to separate NTP and active tab colors so that NTP can be kept with the desired theme color. All other clients of BrowserThemePack are unchanged since ntp_color is taking active tab color in GetAutogeneratedThemeColors. Only AppBrowserController is changing for non-tabbed PWAs to set alt color for active_tab (fixes bug relating to info bar), but can now keep the theme color for NTP so as not to regress crbug.com/1059696. For reference the previous changes for AppBrowserController: crrev.com/c/2045278 crrev.com/c/2064164 crrev.com/c/2094484 Screenshots: crbug.com/1096027#c1 Bug: 1096027 Change-Id: I7db5a2836fef381116b4082b1fde219ba8bdec95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248391Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#779686}
-
Kazuki Takise authored
We are still actively monitoring these metrics. Bug: 1052913 Bug: 1052914 Test: builds Change-Id: I19fbeb7c77c6a43b0fba00f0624a26fe6e4f55af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247425Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#779685}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4147.33-1591609027-benchmark-85.0.4170.0-r1 to 85-4161.0-1592216902-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibaaea16b4630d5bacac330d4168ac525d65a8ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251353Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a3a9da74308f..67237c14a6db 2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5af39e89 to 2adbb514 (484 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ic3ccd36e489a9e8a9b69ffeb71460cb04b854ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251342Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d56d2c282f22..622ed3fe6f3f 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Icae1f13873710c5ec8cec04d78edc741884aac75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251343Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4147.33-1591609549-benchmark-85.0.4170.0-r1 to 85-4163.0-1592215894-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3ccfc6bc70c4a8b83af4154299ce7d79884923d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251352Reviewed-by:
-
Alexis Savery authored
Add UMA histograms "Platform.StatefulTrim.TimeBetweenTrim" and "Platform.StatefulTrim.TrimmedAmount" to track the amount of time between trims and the amount of data that is trimmed by chromeos-trim. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2236859 Bug: chromium:1063105 Test: ran validate_format.py Change-Id: I9fd71492804000c1ec73cd5944a5894a4ef63c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237047 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:
-
Peter Kasting authored
This eliminates the need for implementations to override the getters. Bug: none Change-Id: I3df33cd593c3c600739b5b0546270d89342394aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250822 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779679}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4161.0-1591613309-benchmark-85.0.4170.0-r1 to 85-4163.0-1592214946-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic74c65068c943da594a0fe5077cd715a5bf4f273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251351Reviewed-by:
-
