GitLab

Follow-up CLs will add this to the graph display, and then
individually wire up the types of opener relationships.

BUG=1085129

Change-Id: If25406e0bc15fd6c6cbeeb62cc0db0c438fe9ea3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215281
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772265}

TBR=bokan

Bug: 777258
Change-Id: Iabe5d80b83db19610a4b1c775c802e41a9c8c66e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218112Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772264}

ExternalPrefLoaderTest.PrefReadInitiatesCorrectly is only relevant
pre-SplitSettingsSync, so disable the feature for that test.

ExternalProviderImplChromeOSTest.PriorityCompleted needs to be updated
to mark OOBE completed and simulate the correct type of priority pref
sync.

This is in preparation to enable SplitSettingsSync by default. See
failing tests in tryjobs from:
https://chromium-review.googlesource.com/c/chromium/src/+/2210623

Bug: 1060289
Change-Id: I3a3807c304334fa5a22df7e102f85ee1c629c312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215249Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772263}

Task APIs v3 will all have an explicit destination. In the past
"default traits" meant ThreadPool. These CLs are thus a no-op
except for the few callers that clearly wanted to post a QuitClosure()
on the current thread (posting a QuitClosure() to a parallel task will
merely bounce it back to the current thread anyways). Those few callers
were migrated to ThreadTaskRunnerHandle::Get().

These changes are thus required to phase out task APIs v2 (post_task.h)
Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit

This specific change is a subset of
https://chromium-review.googlesource.com/c/chromium/src/+/2216733

This CL was uploaded by git cl split.

R=dcastagna@chromium.org

Bug: 1026641
Change-Id: Ib464bb9af983f16e6561e54e9a40b3352ab33a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217209
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772262}

Move RenderWidgetInputHandler into blink and call it from the
WidgetBase. Some intermediate methods have been added to
WebWidgetClient while the WidgetInputHandlerManager and
MainThreadEventQueue are still on the content side. These APIs will
eventually disappear when those classes are moved beside the
WidgetBaseInputHandler.

BUG=1073560

Change-Id: I06a202fb832c1d8655428ae1dff19178a2ba69be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212805Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772261}

All future policies will be ignored by default unless it's whitelisted by
EnabledExperimentalPolicies.

Bug: 1076560
Change-Id: I17cd79bd3d7e501f70eb326348d9b64d37c58bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211091
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772260}

This is a reland of 9d2c67b2
Landed changes to relax LifetimeAssert when DestroyActivitiesRule
fails. See bug for details.

Original change's description:
> android: Add LifetimeAssert to WindowAndroid
>
> Bug: 1081250
> Change-Id: Id0924545fbdb1eb28ae3c8fe015559fd3e9c53d1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191785
> Commit-Queue: Bo <boliu@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771220}

Bug: 1081250
Change-Id: Iea2dd27c5b114d748c6f0de8edf17c68b3ec98de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216798Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772259}

Moved the Accelerator initalizers for TabbedPane into the
constructor. This enables TabbedPane to be reparented without
redundantly adding accelerators.

Bug: 1083822
Change-Id: Iaa6483c6c6484a21c9ad17fa5b3948ca5118d94a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208590
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772258}

https://skia.googlesource.com/skia.git/+log/1303a1a15c88..55822f17bd5c

2020-05-27 egdaniel@google.com Add submittedProc to GrFlushInfo.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: westont@google.com
Change-Id: Ic05cc310246fe12a1898d12e8c4ec3cf9c575b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218328Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772257}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d0a8b04f..9990e869

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0b3bacad1f51306689668a298b9e80cb29668bcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218367Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772256}

This CL disables the function to enable AX mode through ATK calls
since it seems to enable it even when it's not required. After
figuring out what API causes false positives, it will be enabled.

APIs on Linux and enabling AX mode is allowed with the command
line option, '--force-renderer-accessibility'.

Bug: 1086506
AX-Relnotes: It disables automatic enabling AX mode on using ATK
Change-Id: I6c0b865349d4f965700bf0ff0639f0508e712de5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216135
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772255}

This reverts commit bee2010f.

Reason for revert: OmniboxQueryTileSuggestionTest was added by this
CL and is failing on:
https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-arm64-rel/21620
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel
https://ci.chromium.org/p/chromium/builders/ci/android-pie-arm64-rel
https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel

Original change's description:
> Reland "Query Tiles : Integration test"
> 
> This is a reland of d95d2248
> 
> Original change's description:
> > Query Tiles : Integration test
> > 
> > This CL adds end-to-end Integration tests for query tiles. The network
> > layer is substituted by a embedded test server that serves a fake
> > server response. Added omnibox javatests that use this mechanism to
> > test the full flow.
> > 
> > Bug: 1083807
> > Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153
> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> > Reviewed-by: David Trainor <dtrainor@chromium.org>
> > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
> > Reviewed-by: Hesen Zhang <hesen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#770512}
> 
> Bug: 1083807
> Change-Id: I7f65bfb79006201bdaa545c0aba8dd7cf2b4a243
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210654
> Reviewed-by: Xing Liu <xingliu@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Hesen Zhang <hesen@chromium.org>
> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#772139}

TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org

Change-Id: I345b9c70b3de4e964f3e309117928992b69deb0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1083807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218490Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772254}

This is a reland of 142274a8 with a fix
for DiceBrowserTest.EnableSyncAfterToken. Original change's info:
> Bug: 1015293
> Change-Id: Ic76e7911403a925fa46a5b5fc58eca95fa292269
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209392
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771116}

Bug: 1015293, 1085540
Change-Id: Ifad9f0583ef0f5ec82b20068bd186b923d4e4eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216325Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772253}

We want to move away from OnInstallStatus signal and instead move to a
per-DLC signal DlcStateChanged. This new signal is designed to make it
much easier for clients to monitor the state of a DLC.

BUG=chromium:1071260
TEST=./testing/xvfb.py ./out/Default/unit_tests --gtest_filter=Dlc*

Change-Id: Ibc042670afb5ec1fa9183bb20833d12c911ec94f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213892
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Amin Hassani <ahassani@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772252}

After PerNavigationMojoInterface has been launched, most commits
used NavigationClient::CommitNavigation instead. This IPC was
only used by non-committed interstitials.

After r766516, even interstitials do not use this IPC, and all
commits now go through NavigationClient.

Bug: 1020175, 1077074
Change-Id: Iea23c7bd2e22a8adf8023f2fae8fcc3d8e60c404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214626
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772251}

The VoiceSearchController created by VoiceSearchProvider may depend on
state that is no longer valid after shut down.  Reset BVC's pointer to
it early so that shutdown can occur properly when the BVC is later
destroyed.

Bug: 1083208
Change-Id: I05dffce9eb79d353443eae759bc990fb61d74308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216804
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772250}

DefaultWidgetDelegate descends from WidgetDelegate which already sets the private widget_ field and overrides GetWidget(). Adding yet another member field of the same thing seems redundant.

Bug: N/A
Change-Id: I6e5036fdf667540893c3c0104d0bc08da0003e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216606Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772249}

Bug: 1086109
Change-Id: I270ffc2e1498b3671c6a771066217d978c5ad703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216650Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#772248}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b7228caa9292..d81fad6de554

2020-05-27 wolfi@chromium.org Reland "Port IssuesModel to TypeScript"
2020-05-27 tvanderlippe@chromium.org Fix es_modules_import to handle `.mjs` files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1058320,chromium:1079233
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic2d37587ec471a350de26b3da531b5cfc7c9da60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218327Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772247}

This patch removes style containment checks from stacking context
computation since whether containment has an effect depends on the
type of layout object created:
- Rename ComputedStyle::IsStackingContext to
  IsStackingContextWithoutContainment.
- Remove containment checks from
  UpdateIsStackingContextWithoutContainment.
- Add LayoutObject::IsStackingContext/IsStacked that checks.
  style values without containment and also containment values that
  apply.
- Updates code to use the new functions where appropriate.

R=futhark@chromium.org, pdr@chromium.org

Fixed: 1068596
Change-Id: I6bc09d8e1087394227a1bf2cee8d7c9c69b0ac7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204316
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772246}

I guess the French TV I've been watching recently has had an effect on
my spelling.

TBR=csharrison

Change-Id: I6fea013a281ec9675ab7071f480653ce1809c7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217728Reviewed-by: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772245}

https://webrtc.googlesource.com/src.git/+log/014197b581a3..df95f5d43f28

2020-05-27 danilchap@webrtc.org Add parametrized unit tests for av1 to check scalability structures

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I7f13bc411be686e94f247af1409b26d82a7a94d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214060Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772244}

When the Frame used by a web-based component self-terminates, the web
component will now report the status code passed to the channel's error-
handler as the component's OnTerminated() exit-code.

The Frame implementation is updated to close the channel with ZX_OK if
the web content itself triggers teardown (e.g. via window.close()).

In addition to reporting the exit-code via OnTerminated(), instances of
CastComponent will report the exit-code to their ApplicationContext.

Bug: fuchsia:51028, b/148594115
Change-Id: Ib3543782d81e276372f9163e4c2e51454f9fc280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207389
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772243}

This may be the first time that a function from Netapi32.dll has been
called and so the dynamic loader lock may be held while this library is
initialized. Since this call occurs on a low priority background thread
this can cause other threads which need to load libraries or look up
function addressed to hang while they wait for the lock.

Noticed in crash/b4a7bd8445afe9f3.

Bug: 973868
Change-Id: I6604971ac9d95f626690ed043141631d5a907995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216716
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772242}

https://android.googlesource.com/platform/external/perfetto.git/+log/fffa2ecdc7fc..609c36d7e6ea

2020-05-27 fmayer@google.com Use SOCK_CLOEXEC when possible.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I2753b4e1c20f22d264472fc1d1391183d8c7efae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214059Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772241}

Disallow duplicate payment method identifiers as specced in
https://github.com/w3c/payment-request/pull/908

Bug: 1085712
Change-Id: I9cb2d8d0960f248d1cbad83140ba6d6be92fbbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214868
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772240}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0edc2a3f0892..3c1f483205d2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jdoerrie@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jdoerrie@google.com
Change-Id: I2ae4b83082c575a928005241bac92de4091eaf90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214056Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772239}

On Android, add a `Learn more` link to the abusive flavor of the quiet
notification permission infobar.

Bug: 1086518
Change-Id: I8843a0514acb4286821e9e7819744bc40b78dfb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216078Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772238}

This CL adds following UMAs for navigation requests.

PageLoad.Experimental.NavigationTiming.*
- NavigationStartToFirstLoaderCallback
- NavigationStartToNavigationCommitSent
- FirstResponseStartToFirstLoaderCallback

FirstLoaderCallback is the timing that the loader callback was invoked
for the first time. NavigationCommitSent is the timing that navigation
commit message was sent to a renderer process.

We decided not to add FirstLoaderCallbackToNavigationCommitSent that
does not seem very useful. Instead, we are going to add
LastLoaderCallbackToNavigationCommitSent in a separate CL.

See the design doc for more details about these UMAs:
https://docs.google.com/document/d/16oqu9lyPbfgZIjQsRaCfaKE8r1Cdlb3d4GVSdth4AN8/edit?usp=sharing

Bug: 1068843
Change-Id: I23b83da68c2ce0a2ec9c856675737225d347a32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198528
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772237}

This CL adds the CriOS tag + the major version to the User Agent used
to request the desktop version of websites for Chrome.
It also don't change anything for the other embedder of ios/web.

Bug: 1083999
Change-Id: Ief1bd073d4a664e3f02a3b3459ea34bd35152558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207314Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772236}

TBR=petermarshall

Bug: 1046784
Change-Id: I53b500ac0a602fc509bac5a1f49a061ded4ee876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218268Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772235}

BUG=1086653

Change-Id: Id91956ebcf96d1058e987b025c3dddc6620916de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216590Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772234}

No change to logic. This adds 'android_channel' to the AOSP integration
doc, since the default no-channel build is typically meant for local
developers.

Fixed: 1085710
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: If45f36523a9b01315815257467bfd52c54bcf7eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213926
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772233}

I accidentally included a VLOG statement from local debugging in a prior
change; this CL removes it.

R=jbroman

Bug: None
Change-Id: If942046836e306696547e163c18c6a0d84f5805b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218229
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772232}

Task APIs v3 will all have an explicit destination. In the past
"default traits" meant ThreadPool. These CLs are thus a no-op
except for the few callers that clearly wanted to post a QuitClosure()
on the current thread (posting a QuitClosure() to a parallel task will
merely bounce it back to the current thread anyways). Those few callers
were migrated to ThreadTaskRunnerHandle::Get().

These changes are thus required to phase out task APIs v2 (post_task.h)
Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit

This specific change is a subset of
https://chromium-review.googlesource.com/c/chromium/src/+/2216733

This CL was uploaded by git cl split.

R=torne@chromium.org

Bug: 1026641
Change-Id: I6b36b810dac8ee0af5b4c80f46b24d5505bacd18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217202
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772231}

An upcoming lint check will flag calls to toLowerCase() that do not
specify a locale. Since these strings are being compared to those
entered by the user the default locale is used.

Bug: 1085466
Change-Id: I4cbc60d99b02d34f741947c2ec8bd719b8843253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216684
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772230}

This CL fixes the ConfirmSyncDataStateMachine crash related to the
DialogFragment update to androidx.

Bug: 1083833
Change-Id: I7f78f491f1b8e66668b1f5552c1483ac68c48624
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216070
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772229}

Roll Chrome Win64 PGO profile from chrome-win64-master-1590522742-b76e1162c3da480ee6f6075020dc3e74b538d7b3.profdata to chrome-win64-master-1590580498-39ab72543da7a96a4f695b1a54bce8558b65f184.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: If31a9601813b30ec290885dcad03d6b68c9a26e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214057Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#772228}

The tests in pointer_lock_browsertest.cc were flaky for 3 reasons:
- requestPointerLock being asynchronous
- mouse events being asynchronous
- native mouse events interfering with tests during execution
All the above were addressed in prior CLs.

Bug: 766450
Change-Id: Icc977b9c8bbfaba8c322a82ff6388886aee83941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212997Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772227}

Some languages (Chinese, Japanese, ...) have no Windows or Hunspell
dictionary support, but a user will often have English spellchecking
enabled. In this case, when Windows spellchecking is enabled, all
editable content composed in the unsupported spellcheck
language will be red squiggled as misspelled, since the words aren't
recognized by the Windows spellchecker. This is a pretty ugly
experience and differs from what was seen when there was only Hunspell.

The fix is to check if a word that is flagged as misspelled by the
Windows spellchecker is written in a script associated with any of
the enabled spellchecker dictionaries (either Windows or Hunspell).
If not, ignore the word as a misspelling.

Bug: 1076677
Change-Id: I072a783d84a981e8f5f0316e8957d7ab93979ca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210796
Commit-Queue: Bruce Long <brlong@microsoft.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#772226}