- 11 Sep, 2018 40 commits
-
-
Fredrik Söderquist authored
TBR=schenney@chromium.org Bug: 880983, 882649 Change-Id: I5d75f448106ad20adf8e9e02ab33883b7eaa54a8 Reviewed-on: https://chromium-review.googlesource.com/1219247Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#590256}
-
Adam Rice authored
Some crashes in CloseAndLockAndDisturb may be caused by early collection of the stream referenced by BodyStreamBuffer. Keep an extra reference to the stream on the stack as a speculative workaround. BUG=882599 Change-Id: I798a175cbac6414a7a70cfcb1e924624232a0a19 Reviewed-on: https://chromium-review.googlesource.com/1218123Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#590255}
-
Findit authored
This reverts commit 88924f03. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 590251 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4OTI0ZjAzOWQwYjk2NjI2YzMzYzIxODNiZDE3Nzk1MmIwMGEyYTYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/16046 Sample Failed Step: compile Original change's description: > blink/bindings: ASAN checks to ensure proper ParkableString accesses. > > A ParkableString underlying string memory should not be cached. > Following a suggestion by pasko@, add ASAN instrumentation to make sure > this is actually the case. > > Bug: 877044 > Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7 > Reviewed-on: https://chromium-review.googlesource.com/1216422 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590251} Change-Id: I3ce53830604e42a6bef13da80a420c44b9d5df11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877044 Reviewed-on: https://chromium-review.googlesource.com/1218548 Cr-Commit-Position: refs/heads/master@{#590254}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1bfa8980a363..a2ceb19a3a9a git log 1bfa8980a363..a2ceb19a3a9a --date=short --no-merges --format='%ad %ae %s' 2018-09-11 saklein@chromium.org Port cros_choose_profile to a chromite python script. Created with: gclient setdep -r src/third_party/chromite@a2ceb19a3a9a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifdcffd368a45120135306a15b3a364df55f97929 Reviewed-on: https://chromium-review.googlesource.com/1218545Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590253}
-
Egor Pasko authored
The benchmark cannot report metrics correctly for WebView. Also WebView cares about different startup scenarios and has its own stories for that. Bug: 880091 Change-Id: I76bec3c24843a5429bfeec45a53439b19b3d7ef6 Reviewed-on: https://chromium-review.googlesource.com/1217103Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#590252}
-
Benoit Lize authored
A ParkableString underlying string memory should not be cached. Following a suggestion by pasko@, add ASAN instrumentation to make sure this is actually the case. Bug: 877044 Change-Id: I463ad229b118f2e629b460f1a2beed41fc54b6a7 Reviewed-on: https://chromium-review.googlesource.com/1216422Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590251}
-
Gauthier Ambard authored
The bottom toolbar tip doesn't use the isUserEngaged variable. This allows us to display the tip multiple time during the isUserEngaged period, for example during test. Bug: 881829 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia4559353aaf831abeb34fd01bf4f4911d1a3267e Reviewed-on: https://chromium-review.googlesource.com/1215208Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#590250}
-
Friedrich Horschig [CEST] authored
This reverts commit 87036e9b. Reason for revert: Compile failure: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/146603 Original change's description: > [Android] Use a delegate for all keyboard visibility functions > > This CL extends the use of the visibility delegate from affecting > only the isKeyboardShown() function to all keyboard-related methods. > > Using a delegate is also the first step to move towards binding > the keyboard detection to WindowAndroid. This enables other > components like the keyboard accessory to affect the visibility on > an activity-specific level (instead of global and static). > > These changes require more work and will follow in further CLs. > > TBR=joedow@chromium.org > TBR Reason: Renamed an interface which doesn't change any behavior. > > Bug: 857460 > Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf > Reviewed-on: https://chromium-review.googlesource.com/1190523 > Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590243} TBR=tedchoc@chromium.org,joedow@chromium.org,mdjones@chromium.org,fhorschig@chromium.org Change-Id: I328fee1ed53a9e32a5ce3fb3092c5b3a6dd36887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 857460 Reviewed-on: https://chromium-review.googlesource.com/1219126Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590249}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f45d4eb1. With Chromium commits locally applied on WPT: d7762551 "Consistently use single quotes in Background Fetch WPTs." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24527 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I66911887a8cd388ca3e2b6fc49f518308d2e817c Reviewed-on: https://chromium-review.googlesource.com/1218448 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590248}
-
Marc Treib authored
This adds some first integration tests for secondary account support in Sync: Signing in to a secondary account starts Sync in transport-only mode, and making the account primary triggers full Sync. Bug: 871221 Change-Id: I8ce74f3a8a7f819c1fea28347dd6ee4c6c917074 Reviewed-on: https://chromium-review.googlesource.com/1213507 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#590247}
-
Olivier Robin authored
At the moment, none of the callbacks use it. This support will be added in future CL feature by feature. sender_frame will be non null if - kWebFrameMessaging feature is enabled - the page is secure (URL is https without error or whitelisted by the user, iframe URL is https without error or whitelisted by the user) - the frame is available (between FrameDidBecomeAvailable and FrameWillBecomeUnavailable messages). On any other case, the sender_frame will be nullptr. Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: Ic91d685fed2f28aa65b7846999f538aa0991d4c3 Reviewed-on: https://chromium-review.googlesource.com/1146721 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590246}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I397f7201fd7c7f40574d443cbe58c82178a66e9b Reviewed-on: https://chromium-review.googlesource.com/1218547 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590245}
-
Javier Ernesto Flores Robles authored
This adds a search header for all passwords in manual fallback. Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8b9516c42d491aed7a8a008a154b999102f11d1a Reviewed-on: https://chromium-review.googlesource.com/1210504 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590244}
-
Friedrich Horschig authored
This CL extends the use of the visibility delegate from affecting only the isKeyboardShown() function to all keyboard-related methods. Using a delegate is also the first step to move towards binding the keyboard detection to WindowAndroid. This enables other components like the keyboard accessory to affect the visibility on an activity-specific level (instead of global and static). These changes require more work and will follow in further CLs. TBR=joedow@chromium.org TBR Reason: Renamed an interface which doesn't change any behavior. Bug: 857460 Change-Id: Ia878e84221d68c4a7c90a0dd2bbce9c8858d98bf Reviewed-on: https://chromium-review.googlesource.com/1190523 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#590243}
-
Hirokazu Honda authored
VideoFrameLayout should have information about offset per plane, not only stride. The number of stride should be the same as the number of offsets. To guarantee this, they are stored in the vector of struct, Plane. BUG=chromium:876986, chromium:856562 TEST=VDA unittest and media_unittest Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie9d9afa5db7dabaee2f48fbcd355c13d29be8035 Reviewed-on: https://chromium-review.googlesource.com/1188730 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590242}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f2582da04e4d..49b2c3c4c433 git log f2582da04e4d..49b2c3c4c433 --date=short --no-merges --format='%ad %ae %s' 2018-09-11 perkj@webrtc.org Revert "Decrease complexity of RtpPacketHistory::GetBestFittingPacket." 2018-09-10 steveanton@webrtc.org Use C++11 for range loop in pc/mediasession.cc (and test) Created with: gclient setdep -r src/third_party/webrtc@49b2c3c4c433 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9fa98d53cd1c43d054b668efa98f72af4ec72307 Reviewed-on: https://chromium-review.googlesource.com/1218544Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590241}
-
Dominic Battre authored
This CL adds some debug output to investigate why we are observing failing navigations on the Windows 10 bots. TBR=sky@chromium.org Bug: 882545 Change-Id: I4ec3fd453eb7641f79f717c1a48993985ef99681 Reviewed-on: https://chromium-review.googlesource.com/1218902 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL adds test code for more worker/worklet-related cases to mixed-content/ WPT tests: - module-worker-top-level (outsideSettings of https: module script) - module-data-worker-import (outsideSettings of data: worker) - classic-data-worker-fetch (insideSettings of data: worker) - worklet-*-top-level (outsideSettings of https: worklets) - worklet-*-data-import (outsideSettings of data: worklets) Actual generated tests is added in a separate CL https://chromium-review.googlesource.com/1212746 for easier code review. These tests are for https://chromium-review.googlesource.com/1208390. Bug: 880986, 880023, 880015 Change-Id: I07eb96cffec889103bf437813180127644466af8 Reviewed-on: https://chromium-review.googlesource.com/1212744 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590239}
-
Greg Thompson authored
use install_static in InitChannelInfo, SetEULAConsent, and {Get,Set}ExperimentLables. Also: - changed EULA -> Eula in symbol names in chrome/installer. - added support for testing both per-user and per-machine installs in GCAPIOmahaExperimentTest. BUG=879568 Change-Id: I7676c7b75a9cb4cd3a85d1ba609d66a71581f05e Reviewed-on: https://chromium-review.googlesource.com/1215024 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#590238}
-
Malay Keshav authored
This patch ensures that the currently set zoom level is sent to the wayland client. Bug: 881492 Change-Id: I516ff73e73753cb0fc5fdec1f7f5216c0608a401 Component: wayland Reviewed-on: https://chromium-review.googlesource.com/1211725Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#590237}
-
Yutaka Hirano authored
This reverts commit f8d8a935. Reason for revert: NetInfoNetworkQualityEstimatorHoldbackBrowserTest.EffectiveConnectionTypeChangeNotified/1 is flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NetInfoNetworkQualityEstimatorHoldbackBrowserTest.EffectiveConnectionTypeChangeNotified Original change's description: > Add logic for holdback experiment for network quality estimator Web APIs. > > When the holdback experiment is enabled, the NetInfo > network quality related Web APIs (https://wicg.github.io/netinfo/) > would report network quality corresponding to the experiment > params. > > This CL only affects the NetInfo JavaScript APIs. A subsequent CL > will use the framework in this CL to also override the values > of network quality reported in network quality related client hints > headers. > > Change-Id: Iab9d4ecfe7c14eb5d3cee26dbf209fd943156333 > Bug: 880545 > Reviewed-on: https://chromium-review.googlesource.com/1201343 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590212} TBR=kinuko@chromium.org,jkarlin@chromium.org,tbansal@chromium.org,ryansturm@chromium.org Change-Id: I4e098f91606613d446f373775ef0649876532f40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880545 Reviewed-on: https://chromium-review.googlesource.com/1218387Reviewed-by:
-
Jdragon authored
This patch means rearrange module file name in alphabetical order. Change-Id: Ia2697a2d2dfeb3576677b0732d64f7b7bc21cce3 Reviewed-on: https://chromium-review.googlesource.com/1215153Reviewed-by:
-
Vadym Doroshenko authored
When flag #new-password-form-parsing is on, PasswordFormManager is used for saving and NewPasswordFormManager for filling. Now they have separate metric recorders. Metric PasswordManager.ActionsTakenV3 (and others) is inconsistent because filling and saving parts of this metric written with different recorders. This CL implements usage of the same metric recorder for PasswordFormManager and NewPasswordFormManager that corresponds for the same form. Bug: 882432, 831123 Change-Id: I84b480c86ec8172fb9d055cd8189529c5e4f42fb Reviewed-on: https://chromium-review.googlesource.com/1215965 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#590234}
-
Max Morin authored
This reverts commit 5fddb84e. Reason for revert: Speculative revert for failing WebRTC browser tests. Original change's description: > Enable sandboxing for audio service field trial testing on Windows and Mac. > > Bug: 832666 > Change-Id: Ic64a983498156bba73c458f2abc872db337d1999 > Reviewed-on: https://chromium-review.googlesource.com/1216142 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589911} TBR=rkaplow@chromium.org,marinaciocea@chromium.org Change-Id: Ib0a488a759dea9176b6096bdfafd710f6c3aa8bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832666, 882780 Reviewed-on: https://chromium-review.googlesource.com/1218942Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#590233}
-
Alex Lau authored
Add missing assertions after callRemoteTestUtil invocations. LOG(FATAL) instead of assertion when trying to add entries to a non-existant Android Files test volume. Also remove unnecessary AndroidFilesTestVolume.Initialize() call. Bug: 877371 Change-Id: I925ad37a056e411eb3a5bd833cad59a5ce11fae3 Reviewed-on: https://chromium-review.googlesource.com/1218664Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#590232}
-
momohatt authored
This method resumes a cache writer which is paused by enabling pause_when_not_identical option. With this option enabled, a cache writer pauses right after it finds any differences with the cached body and the body from network, and calling Resume() to such paused cache writers makes them resume its internal state machine and complete the remaining read and write to the storage. This method takes a callback, but it is triggered only when the remaining read and write finishes asynchronously. Bug: 648295 Change-Id: I1c01804151bff20fc69ba7d0993447f676e98548 Reviewed-on: https://chromium-review.googlesource.com/1214975 Commit-Queue: Momoko Hattori <momohatt@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#590231}
-
Manu Cornet authored
Enable shelf background blur only when the launcher's background blur is enabled. This allows for a more consistent user experience, and may also help with performance on some devices. Bug: 879962,881134 Change-Id: I40015199f3312b62ef7b175167b65d5a9a6e352a Reviewed-on: https://chromium-review.googlesource.com/1217584 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#590230}
-
Rune Lillesveen authored
We used to push SelectorFilter for AttachLayoutTree when we did style resolution there. The test in question used to fail DCHECKs. No longer necessary for this test. Change-Id: Icf7d7020d03c15dc446d18469971302915abbe89 Reviewed-on: https://chromium-review.googlesource.com/1218724Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#590229}
-
Dominic Battre authored
Disabled testToolbarSwipeNextThenPrevTab and testToolbarSwipeNextThenPrevTabIncognito for flakiness. See bug for details. TBR=mdjones@chromium.org Bug: 882003 Change-Id: Ic78f41566c1abce0feb4010196fcf1270fba11a6 Reviewed-on: https://chromium-review.googlesource.com/1218722Reviewed-by:
-
Ulan Degenbaev authored
Bug: 880432 Change-Id: Ice70a3804321e89f21579436e2de05a76cdeb8fd Reviewed-on: https://chromium-review.googlesource.com/1216283 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 90e9d5ae. Reason for revert: The test is still flaky. Original change's description: > Tentatively re-enable SitePerProcessHitTestBrowserTest.TouchActionAckTimeout > > A number of changes have landed recently that may eliminate the > flakieness seen in this test. This CL re-enables the test, but feel > free to revert this if the flakes continue. > > Bug: 871062 > Change-Id: Iad353f9aecbf2eb59c4831ef70658f08c13a47a9 > Reviewed-on: https://chromium-review.googlesource.com/1217087 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590047} TBR=kenrb@chromium.org,wjmaclean@chromium.org Change-Id: I7467a05dc55da2a98e0e5476bb4088e64ffb7d01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871062 Reviewed-on: https://chromium-review.googlesource.com/1218306Reviewed-by:
-
Hiroshige Hayashizaki authored
To make mixed content check more spec-conformant, this CL makes mixed content check in Workers/Worklets take into account whether the parent contexts are HTTPS or not, in addition to their SecurityOrigin, by - Implementing HTTPS state spec concept in ExecutionContext, i.e. Document https://html.spec.whatwg.org/#concept-document-https-state WorkerGlobalScope https://html.spec.whatwg.org/#concept-workerglobalscope-https-state WorkletGlobalScope https://drafts.css-houdini.org/worklets/#set-up-a-worklet-environment-settings-object - Plumbing outside Settings's HTTP state to Worker/WorkletGlobalScope via GlobalScopeCreationParams, and - Plumbing HTTP state from Worker/WorkletGlobalScope to WorkerFetchContext via FetchClientSettingsObjectImpl, and https://html.spec.whatwg.org/#https-state - Using it for mixed content check instead of SecurityOrigin. https://w3c.github.io/webappsec-mixed-content/#categorize-settings-object While this is still not completely spec-conformant, mixed content check becomes stricter: for top-level worklet scripts and subresource requests from data: URL workers created from HTTPS Documents, HTTP requests will be blocked after this CL. Bug: 880986, 880023, 880015 Change-Id: I4a43e2ee424177e93b0d7da40c2c1b8891cdced3 Reviewed-on: https://chromium-review.googlesource.com/1208390Reviewed-by: -
Rune Lillesveen authored
And that we do not re-enter RebuildLayoutTree. Bug: 868810 Change-Id: Icb70557747c26ccd107775919034ec91b054d070 Reviewed-on: https://chromium-review.googlesource.com/1217743Reviewed-by:
-
Rune Lillesveen authored
We will need it outside of node.cc for layout tree rebuild root. Bug: 868810 Change-Id: If428d5c1f954686c70c35631718c5fa270c8971b Reviewed-on: https://chromium-review.googlesource.com/1217422Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/727453b25672..56e273293a3c git log 727453b25672..56e273293a3c --date=short --no-merges --format='%ad %ae %s' 2018-09-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@56e273293a3c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I10281a13235851fac2d0ed17962022eb17baae85 Reviewed-on: https://chromium-review.googlesource.com/1217817Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590222}
-
Yutaka Hirano authored
- Mark cancel-invoked.html as Timeout. - Mark basic.html as Timeout on ASAN. - Remove SLOW expectations for both of them. Bug: 882756, 867982 Change-Id: Ie5d332d02ca8543cb6a4342101b2897ea7af27f3 Tbr: rmcilroy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1218642Reviewed-by:
-
Camillo Bruni authored
Bug: 878390 Change-Id: Idbf6ea53989688e675718c76babe259caf51c9db Reviewed-on: https://chromium-review.googlesource.com/1215946 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Mike West authored
This is a re-land of [1] after MSAN failures caused a rollback in [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/966442 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/1213152 Bug: 787905 Change-Id: Ie4632a3a482c77202e7e4d3b5c360f021e628389 Reviewed-on: https://chromium-review.googlesource.com/1216684Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit d2bade56. Reason for revert: Speculative revert for test failure. https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yODg5My9icm93c2VyX3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMS9UbUYyYVdkaGRHbHVaMFY0ZEdWdWMybHZibEJ2Y0hWd1FuSnZkM05sY2xSbGMzUXVVR0ZuWlVsdVUyRnRaVVY0ZEdWdWMybHZiZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Original change's description: > Scheduler: WebURLLoader should notify Blink with the initial priority. > > The loading stack only notifies Blink with any increase in the > request priority. Add support to notify the scheduler with the > initial priority as well. > > Bug: 870349 > Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b > Reviewed-on: https://chromium-review.googlesource.com/1185593 > Commit-Queue: Farah Charab <farahcharab@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586752} TBR=kinuko@chromium.org,altimin@chromium.org,farahcharab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870349, 882200 Change-Id: Id010e1ce5f2c4374f3f89208567fe4e344399051 Reviewed-on: https://chromium-review.googlesource.com/1218263 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Ramin Halavati authored
ChromeOS specific preferences are removed from the persistent storage list for incognito mode. As these preferences are not written from inside an incognito window, the CL is not expected to make any behavioral change and is just cleanup. Bug: 861722 Change-Id: I9b5c18427cf9875b20d44dd99b65cab2900a5998 Reviewed-on: https://chromium-review.googlesource.com/1185598Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#590217}
-
![Friedrich Horschig [CEST]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich Horschig [CEST]")
