- 21 Oct, 2019 40 commits
-
-
Miriam Zimmerman authored
Fix the following classes of lint errors For i18n-content use javaScriptCase. Found lines longer than 80 characters This CL was generated manually, using code-search to double-check that all references were updated. BUG=None TEST=Deploy to eve, check feedback dialog Change-Id: Iaaf3d565fafcca251096fe97b48a3a4f363d8f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869995Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#708043}
-
Chris Davis authored
This is a reland of e0dffd84. 706934 fixed the compile issue with headless code and the issues with the delayloads_unittests have been resolved. Original change's description: > Set is_multi_dll_chrome to false by default > > This change sets is_multi_dll_chrome to false by default thus merging > chrome.dll and chrome_child.dll to a single dll. This saves disk space > and improves startup performance. It is also consistent with all other > platforms (windows was the only platform the split was enabled by > default). > > Bug: 726150 > Change-Id: Iade2c7f1bbe696d45ebac7483072f7e2e7e84ab4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850272 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705667} Bug: 726150 Change-Id: I8261e781102e23b2c2319a181295655dfda3b811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868389Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#708042}
-
John Rummell authored
Adds |mOrigin| to keep track of the origin ID used. Also removes some unnecessary logging, especially of errors when a security level is not supported. Bug: 917527 Test: Installed Chrome and looked at the adb log Change-Id: Icb930af9b96da42d4ce1c675639ada4cb5cfc8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802697Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#708041}
-
Brian Sheedy authored
Re-enables the Telemetry minidump symbolization tests on ChromeOS, but with additional logging if several asserts fail. The flakiness that caused the tests to be disabled on ChromeOS has not reproed locally or on swarming, so hopefully this will give us enough information to fix the issue if it occurs again on the bots. Bug: 1014754 Change-Id: I9c064c0600dc713d2325b6eb5bdd77cdbe6a3eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869340 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#708040}
-
Ahmed Fakhry authored
Since the WindowCycleView is owned by the Views hierarchy, its Layout() may get called even after WindowCycleList is destroyed. This CL fixes the crash by making sure Layout() returns early in such situation. BUG=1013174 TEST=Run test with --gtest_repeat=20, no flakes at all. Change-Id: I6b2e66ac9695f27de2969b7c4fb6729b43db79f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873087Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#708039}
-
Antonio Rivera authored
This is necessary for the case where a dynamic group leader has its resources revoked. In that situation, it needs to release its resources without stopping the cast app; thus, the CastRenderer needs to remain but the resources need to be released. Test: With chromecast internal changes on 1.40ac branch. Bug: b/141143745 Change-Id: Ia69aa32e7f97bd4126bead4f650f210d00e98d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872240 Commit-Queue: Antonio Rivera <antoniori@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708038}
-
Evan Stade authored
Bug: 268984 Change-Id: Id59283a4bde7a87a88345672b10d9db9bf9b9c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869829Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708037}
-
Peng Huang authored
Bug: 1016321 Change-Id: I50d285da5cfb1b3e8f8738c5fa16f5e85ebb2671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872456Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708036}
-
Evan Stade authored
Bug: 268984 Change-Id: I1e4e34c663cfa2c2cc2d5d903ee506b7171c4881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869022Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708035}
-
Eric Willigers authored
test_computed_value now checks that the value is supported. Change-Id: Ic8c38df6030b3689f4fdec30a55f230d6cc113d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866498Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#708034}
-
Jamie Madill authored
Revert "Reland "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode."" This reverts commit d97ee8ce. Reason for revert: Still has the same failure mode. Bug: 1014659 Original change's description: > Reland "Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode." > > This is a reland of 9d6a01ba > We now handle negative values returned from ::GetThreadPriority(). > https://chromium-review.googlesource.com/c/chromium/src/+/1829570 > > Original change's description: > > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > > > This experiment enables: > > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > > background threads. This affects memory and IO priority in addition > > to CPU priority. > > - Increase thread priority to "normal" in scopes where background > > threads load modules. > > > > The expectation is that this will improve responsiveness of Chrome > > (input delay, first contentful paint), without regressing jank. > > > > We are adding the testing config in preparation for enabling this > > via Finch in M79. > > > > Bug: 973868 > > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Auto-Submit: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#705960} > > TBR=rkaplow@chromium.org > > Bug: 973868 > Change-Id: I392cfb2f92e2ac0fa888fa1e323557ab35055b48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872312 > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707822} TBR=fdoray@chromium.org,rkaplow@chromium.org Change-Id: I814a086aea8caacacd09d4fb507c433b5fe7ebdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872017Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#708033}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4036a6d8ac64..94e1a5268692 git log 4036a6d8ac64..94e1a5268692 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 fmalita@chromium.org [skottie] fix clangtidy warning 2019-10-21 kjlubick@google.com [fuzzing] Add two fuzzers for SkDescriptor Created with: gclient setdep -r src/third_party/skia@94e1a5268692 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I8457f3d1dcaf3fdad7c76d0ea32297b57a7ad331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708032}
-
Mason Freed authored
```yaml IN CASE OF PROBLEMS: If this CL causes your site/app to break, you are using deprecated features that have now been removed. Please see [2] to enroll in the Deprecation Extension program to give yourself more time. ``` With this CL, two of the three Web Components v0 APIs are disabled by default. The third, HTML Imports, will be disabled (soon) by a separate CL. These features were deprecated in August, 2018, in [1]. The original removal timeline called for a deadline of M73. Due to high use counters for the features, this deadline was extended to M80, which is now here. For those sites that need additional time, there is a "deprecation extension" (sometimes called a "reverse origin trial") that can be used to extend this removal for specific sites through M87. For more information on that, see [2]. For overall context on this removal, including motivation and ways to test/upgrade, see [3]. With this CL, these features will still be enabled for testing across all test suites. Once this CL has had a chance to land and stabilize, subsequent CLs will disable the features for all tests by default, and enable a virtual test suite to continue testing specific code with WCv0 features enabled, to ensure the features continue to function through the end of the deprecation extension period. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841 [3] https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade Bug: 911943 Change-Id: I939e1ead03a3196e63f0f9c192f916c87ab16562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850795Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#708031}
-
Ella Ge authored
Input predictor's GeneratePrediction used to return a boolean for whether the prediction exist and also a InputData class contains the prediction results. This is unnecessary. This CL makes: 1. GeneratePrediction returns a unique_ptr of InputData class. If prediction exist, it's the predict result; otherwise, it's nullptr. 2. No need to check HasPrediction before GeneratePrediction. It should be decided by predictor itself and returns result or nullptr accordingly. Change-Id: Id5e092dc98f4c0fa4e66ac709e05fbf7cae8c734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849173 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708030}
-
Jinsuk Kim authored
The method is not used outside the chrome.browser.tab package. Did a little refactoring in tests to make it private-package. Bug: 995903 Change-Id: I65dcd3d5c0f5e773f5b0f49135f3c6a7ea19c533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870155 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#708029}
-
Ken Rockot authored
This CL changes SharedRemote so that its sync calls now block only the calling sequence rather than additionally blocking the underlying Remote's bound sequence. Fixed: 1016022 Change-Id: I2483c130d882de24686c0bb1396a894171a733fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871249 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56dc7021..dd844944 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4caac49de42d2f7290a7bd167d5c3fd8c72f5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871896Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708027}
-
chrome://flagsJonathan Freed authored
Bug: 1013795 Change-Id: I1a0db4a62fee2ba9c014daa6780c4e118da1d3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857638Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#708026}
-
Fredrik Söderquist authored
This makes it better match its semantic counterparts. CurrentValuesFromKeyPoints(...) is adjusted in a similar since it is called by the function in $subject. Also fix coding-style in SVGAnimationElement::UpdateAnimation(). Bug: 998526 Change-Id: Ib232c0dd7dacd29fe74a9b696a4715d1f9ef2f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869002 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708025}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, when switching tab models, the GTS is populated even if it is not visible. This led to loading the thumbnails unnecessarily. Bug: 1014792 Change-Id: Iecff9173e6e4a3ebae80961e067762c000c3caf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869124 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708024}
-
Martin Kreichgauer authored
This adds code to parse the maxCredentialCountInList and maxCredentialIdLength fields from authenticatorGetInfo responses. GetAssertionTask is changed to filter and batch allow lists when silently probing credentials according to these values, if the authenticator supports it. In particular, probing is skipped if the allow list fits into a single batch (and the request doesn't have an App ID that the GetAssertionTask might have to fall back to). MakeCredentialTask similarly filters and batches before silently probing for credentials in the exclude list parameter. Probing is skipped entirely, if the exclude list fits into a single batch and the request does not carry an appIdExclude extension. Fixed: 954613 Change-Id: I644e602054e4e2ebb4101b98b867f5dbc61e0901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867448 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#708023}
-
Oystein Eftevaag authored
All usage has now been replaced by the Perfetto-based Consumer API Reduces MonochromePublic.apk size by 20.5k. BUG=839086,1006760 TBR=dcheng@chromium.org Change-Id: I9e778ec1fa51f674c4769466db36b8ef51aa97fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820017Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#708022}
-
rbpotter authored
Feature launched in M77. Bug: 949585 Change-Id: I83dd05bb5941de84ea44958121ef13eb59566503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868654Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#708021}
-
Sammie Quon authored
It seems the opaque background has no children anymore, and repaints afterwards, so I don't think a render cache is needed. Test: none Bug: 10158843 Change-Id: I5f99340f177d8a655f231d3565c972fee337f062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868916Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708020}
-
Alex Newcomer authored
Added test coverage, noticed we need to have a gesture of atleast 6px for us to register a ui::ET_GESTURE_SCROLL_UPDATE, which is required for us to move the hotseat. Change-Id: I73020cda89ab252fc5d7497ac9eccd1fb5e7f232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870051 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
John Lee authored
This CL adds temporary checkboxes to the bottom right of the tab strip to allow for easy testing of 4 modes: 1) Most Recently Used ordering with auto-closing tab strip 2) Most Recently Used ordering when tab strip is closed manually 3) Default ordering with auto-closing tab strip 4) Default ordering with no auto-closing tab strip This CL also brings back drag-and-drop for unpinned tabs for cases where MRU is disabled. Bug: 989131, 1005554, 1005565 Change-Id: Iae066c2d85da712ecae29c040468cf67b31fd0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867477 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/62b68fec1b2c..75c59424e3f1 git log 62b68fec1b2c..75c59424e3f1 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 apolito@google.com [fetch] use py3 for fetch Created with: gclient setdep -r src/third_party/depot_tools@75c59424e3f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:939847 Change-Id: Icc2676f2b266b1e725f097c98019744ed97a8143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872893Reviewed-by:
-
Findit authored
This reverts commit 7777033e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 707985 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc3NzcwMzNlZGFkMzA1ZTI5YThlMmM0OTk4ODIzNThkNzAxN2NhY2IM Sample Failed Build: https://ci.chromium.org/b/8898950660954702496 Sample Failed Step: compile Original change's description: > Introduce an empty WebRTC component. > > While testing the WebRTC component build in [1], there was a problem > with some testonly code Chromium depends on (which cannot be part of the > WebRTC component). > > In order to support this use case, [2] will make the testonly code > needed by Chromium depend on the WebRTC component and this CL is needed > in order to land everything in an incremental fashion. > > [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961 > [2] - https://webrtc-review.googlesource.com/c/src/+/157427 > > Bug: webrtc:9419 > Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707985} Change-Id: I259491613f592da9a5b4584de9fecca895d9398e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872944 Cr-Commit-Position: refs/heads/master@{#708016}
-
Mitsuru Oshima authored
I could cleanly apply this change to 78. Bug: 987819 Test: manually tested on 4k display device Change-Id: I9ed0c3a0f1007b46a213030fa19edf25dcb3810b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868840Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#708015}
-
Etienne Bergeron authored
The code for ItemizeTextToRuns is really slow on some corner cases. This CL is fixing the performance issue (see http://crbug.com/924915). The main issue is that each iteration of the ItemizeText loop will move forward by the smallest amount of characters (size of the run) and then the whole logic to find the breaking position is applied again. As an example, the following text: "\n!\n!\n!\n!\n!\n!\n!\n!\n!\n!\n!\n!" * Computing the breaking point of "bidi direction" is O(n) * Computing the breaking point of "script" is O(n) Unfortunately, most runs will be split at the \n since it's a special character. This means the complexity of this code will be O(n^2). The proposed code in this CL is: 1) Splitting in block of same bidi direction 2) Splitting in sequence of characters with compatible script 3) Splitting for special characters / style This way, the 1) and 2) are only executed once (e.g. O(n) ) by character. NOTE: This bad pattern was happening often with emoji since they are often isolated in a run as a special characters. Bug: 924915, 1014119 Change-Id: I8d950e166ff01285ad0ce9796e38321ec502f368 Fixed: 2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865673Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708014}
-
Michael Ludwig authored
This refactors DoDrawQuad's material branching into an internal function that can be reused by DrawRenderPassQuad. This makes DrawRenderPassQuad independent of the bypass quad's material type. Bug: 1013735 Change-Id: I0c8b316ac11fc34aed9d2f1e6ae88f06931bbf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860594 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708013}
-
Ken Rockot authored
Almost of all of the code in this class is shared acoss all instances of the tempate. This introduces a ThreadSafeForwarderBase class and moves the logic into it. No functional changes. Bug: 1016022 Change-Id: I515c472f8a6fdc97fdd25d90db596d23a89ce543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871195Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#708012}
-
Andres Calderon Jaramillo authored
This CL stops and restarts the camera capture stream in V4L2CaptureDelegate the first time a timeout is detected while polling for captured frames. This is a workaround for a Huddly GO camera issue where the camera gets into a deadlock state at times at the beginning of the capture session. The underlying issue seems to be a kernel driver synchronization problem, but upgrading the kernel might not be practical in the short term for affected devices. 1) Flash M78 Chrome OS image. 2) Deploy Chrome in debug mode (a bunch of irrelevant DCHECKs must be deleted). 3) In non-kiosk mode, visit https://webrtc.github.io/samples/src/content/devices/input-output/ 4) Switch between the two Huddly GO streams constantly while monitoring /var/log/chrome/chrome. Eventually, the deadlock path is hit (see the DLOG(WARNING) in v4l2_capture_delegate.cc) but we recover successfully and the camera continues capturing normally. Change-Id: Idc90aa8b9dbb069c419c3ca1b90be9b47d4a6c51 Bug: 1010557,b:141978989 Test: on a guado with a Huddly GO: Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859901 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708011}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3c79cf2ab9f2..2c8b5c637028 git log 3c79cf2ab9f2..2c8b5c637028 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 cwallez@chromium.org Introduce the webgpu[_cpp].h headers. 2019-10-21 rharrison@chromium.org Rolling 3 dependencies 2019-10-21 rafael.cintron@microsoft.com Plug D3D 11on12 memory leak Created with: gclient setdep -r src/third_party/dawn@2c8b5c637028 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ib1e0c945cd3524dbf7ce3af477d123eee30cf6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872922Reviewed-by:
-
Kevin Marshall authored
This is a reland of 3692f7b0 Adds a missing GN dep which caused a build breakage on component/debug builds. Original change's description: > [web_engine] Add "web_engine_shell" standalone executable. > > Implements a simple standalone executable which will launch a fullscreen > browsing session and navigate it to a given URL. Similar to > content_shell, but using Web Engine instead. > > The flow is kept deliberately simple and linear so it can serve as a > functioning code sample for aspiring embedders of Web Engine. > > The shell can be used to test arbitrary static data, which is sourced > from //fuchsia/engine/test/shell_data and hosted under the content URL > fuchsia-dir://shell-data/ . > > The shell can also optionally request that the DevTools server be > started at a port specified on the command line. > > Bug: 1016485 > Change-Id: I09ad56f20553acc83fbf38924fa3e8d8a98a1200 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869887 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707911} TBR=ddorwin@chromium.org Bug: 1016485 Change-Id: I49728ffa5ab21e8a329bd8e1fefdb1071460ef4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872827Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708009}
-
Xiaoqian Dai authored
Previously it was in HomeLauncherGestureHandler. That means all eligible windows were hidden before the drag actually started. Move it to its own class DragWindowFromShelfController so that we only hide window when drag actually starts. It will also be benificial for the class DragWindowFromShelfController to be called from other caller. Bug: 997885 Change-Id: I0cb8285c9505b48db76d4f5e5103ca24ebe1d90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872804Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f192c2cad99..c21b70d6b576 Created with: gclient setdep -r src-internal@c21b70d6b576 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I012e250854cb7d4456085ff60990ead802af0384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872920Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708007}
-
Victor Costan authored
Bug: 1016038 Change-Id: I3faa9e5071e09a5923e9321fc1449431f22ca666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869384 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#708006}
-
Alex Cooper authored
This is the first step in removing WebVR. This change removes WebVR from about://flags and also removes the separate command-line switch that was used. In order to keep the tests running for the time being, this change modifies the blink webvr feature to be set to "test." The browser tests for WebVr have been updated to set the new flags that will turn on WebVr. This also removes the Origin Trial flag for WebVr, and as such deletes the origin trial layout tests as well. Bug: 960132 Change-Id: Ia625e3ae9986183ef2746dcb69e595cab49fd981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862855 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708005}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c61f5295030..0ce6d876771d git log 8c61f5295030..0ce6d876771d --date=short --no-merges --format='%ad %ae %s' 2019-10-21 lamontjones@chromium.org config: add R79 to luci-scheduler. Created with: gclient setdep -r src/third_party/chromite@0ce6d876771d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I348c232627a58e6e1653d8c23850c07148173af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872923Reviewed-by:
-
