- 07 Aug, 2020 40 commits
-
-
K. Moon authored
Adds empty implementations of the PDFEngine::Client interface to PdfViewWebPlugin, in preparation for using PdfViewWebPlugin with PDFiumEngine. Bug: 1085334 Change-Id: Iebe1681829a6b02e220bb353c767a9c28cd2a3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342138Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#796078}
-
Aleks Totic authored
Tables with collapsed borders compute their borders by running an algorithm. To run this algorithm, ComputeBorders needs an NGBlockNode argument. Change-Id: I1d1028bed42a4b16b662bd51c4d46d18e68c57f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341411Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796077}
-
Abigail Klein authored
Based on UXW feedback, modify the live caption settings subtitle string and add a new download complete string. Also, only show the download error message when there is an error event from the component updater. Previously, we also showed an error message if the download progress was unknown, but it is better to do nothing in that case and wait for more information about the download progress. Bug: 1055150 Change-Id: Ib8343b45b20b8a3b66a4dbbc15361189d015cae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343231Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#796076}
-
Adam Raine authored
Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/2283289 Adding the compositor failure reasons to the trace allows Lighthouse to report if an animation fails due to unsupported CSS properties, but Lighthouse cannot see which CSS properties are unsupported. These changes collect the unsupported CSS properties and add them to the animation trace event for compositor failure reasons. Bug: 230229 Change-Id: I5d40b1ffd7fd82f8231940b7027ace30ea25df48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320552Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#796075}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce00f903c268..55eebf450c36 2020-08-07 jalyn@microsoft.com Enable new Shortcuts settings page by default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48ca2762a9bc9336dce26393736892e81a32e558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343525Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796074}
-
Matthias Körber authored
Change-Id: I185216a1a5cdb7063b9e6d90d99195cc608f97ab Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339350 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#796073}
-
Angela Yoeurng authored
Bug: 1046523 Change-Id: Ie25435820d7ebbb67b884638fd4add05a7011c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341840Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#796072}
-
Ben Pastene authored
Bug: 1092973 Change-Id: I4df191266f28297cf8581f1687de87e336713363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339580Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#796071}
-
John Delaney authored
Moves ConversionStorage and it's task runner into a wrapper which can be shared across threads. The new ConversionStorageContext is created by the ConversionManager on the UI thread. To integrate with QuotaManager, ConversionStorage needs to be accessible/owned by the IO thread where QuotaClients are accessed. ConversionStorageContext wraps a ConversionStorage instance which lives on its own task runner. As is, this requires redeclaring all ConversionStorage methods with appropriate callbacks on the ConversionStorageContext. Future improvements to base::SequenceBound may remove this need, but for now this simply moves the existing task runner + storage interface into the storage context This construction allows for data races on tasks that are posted to the storage task runner, which is okay because operations on ConversionStorage does not require any sequencing on operations. Change-Id: Iff0c2c22bb1d02d98f8d8fd80734f235b116918c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239676 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#796070}
-
Bella Bah authored
Was causing Windows trybot traffic_annotation tests to fail because of module naming collision. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8872768115210425728/+/steps/test_traffic_annotation_auditor/0/stdout Change-Id: I5205f8232c633cb9028de667472f4e80f869d973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339941Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Mohamadou Bella Bah <bellabah@chromium.org> Cr-Commit-Position: refs/heads/master@{#796069}
-
Carlos IL authored
Prior to this fix, stale rectangles where showing at the start of a new animation. Bug: 1112848 Change-Id: Ie41eae474a2c2477b436a6b450cda099225f90f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341839 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
-
Brian Manthos authored
No functional changes other than the namespace the function is in and making the function available elsewhere via the header declaration. Change-Id: Ie48dd21e1c8358c53e692fd45f219a16e9cfd9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342311 Commit-Queue: Brian Manthos <brianman@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#796067}
-
Alexander Surkov authored
Bug: 1100991 Change-Id: Ie00ccd7659e131a20702b5b8a028cbd1289f1647 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341400 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Justin Cohen authored
An unresolvable URL is now a syntax error in WebKit. Change-Id: I6707b683887db3d7b715eb87b8d223023ee733bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342321 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796065}
-
Chris Sharp authored
As an escape hatch we shouldn't mark this policy as deprecated until removing it. Bug: 1114250 Change-Id: I7261b51fd4d10c584564a13dc7624b2ed4a8f55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339943Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#796064}
-
Matthias Körber authored
This CL integrates the merging into the AutofillProfile. It also disables honorifics and fixes most but not all test issues that occur if the structured-name feature is globally enabled. Change-Id: Ibf940a01a28697a6e0be2ea5e61625a6a23bf8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333204 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Alex Gough authored
Removes pre-spawn hook and export from network service and moves code into utility delegate. No functional changes. This code only runs for Windows. Various DEPS and OWNERS are also updated to reflect the move. (The linux sandbox hook is not moved as runs in the utility at start up.) Bug: 1111421,1049894 Change-Id: Ib7c6145509731883a21d790ce1c7ce4da220c8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339325Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#796062}
-
nuwanda authored
This change should not affect bots unless --experimental-tbmv3-metrics flag is supplied. The metric is defined here: https://source.chromium.org/chromium/chromium/src/+/master:tools/perf/core/tbmv3/metrics/accessibility_metric.proto. Change-Id: I600ce186b8f343f8c12d3d80a7d2f98bd83e3d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339966 Commit-Queue: Julia Semavina <nuwanda@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796061}
-
James Vecore authored
The visibility page is just stubbed in place without the center content. A shared component will be added to implement the visibility selection in a future CL. The link used for "Managed Contacts" is also temporary. Specs, strings, accessibility handled in a follow-up CL. The "Confirm" button will however actually enable Nearby Sharing. Screenshot: https://screenshot.googleplex.com/xOasYwc8hSq Change-Id: I68ab57e10611045270d261deae1dd66f3e3969f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340681 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#796060}
-
Dominique Fauteux-Chapleau authored
This reverts commit c2e39ede. Reason for revert: Breaks Mac builder (https://ci.chromium.org/p/chromium/builders/ci/Mac%20Builder/119092) Original change's description: > Do clean up in PlatformFontMac > > Do not try to derive one weight of font from another. > Use the API to directly generate them. > > PlatformFontMacTest.FontWeightAPIConsistency tested that > our understanding of shifting weights up and down was > correct. The code no longer shifts weights up and down > as that is unreliable and version-specific, so there is > no need to test weight shifting and it is removed. > > This also fixes Big Sur issues. > > Bug: 1101426 > Change-Id: I2165c3550ad295b3ee7742f3289874ed2bb89c68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340262 > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796044} TBR=ellyjones@chromium.org,avi@chromium.org Change-Id: I7a7d792d80eadfab524fc7235c3b9a349a34c970 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343490Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#796059}
-
Thoren Paulson authored
Looks like this was missed in crrev.com/c/2297920 Bug: internal b/162634401 Test: CQ Change-Id: Iafbfb2dbcf24abe1e6e31e6d4b461908382309eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343504 Commit-Queue: Thoren Paulson <thoren@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Auto-Submit: Thoren Paulson <thoren@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#796058}
-
Ali Juma authored
This makes SafeBrowsingService use a persistent cookie store, and clears this cookie store whenever cookies are cleared for "all time". This makes the behavior on iOS consistent with the behavior of Safe Browsing on other platforms. Change-Id: I37fec41b6929386ecf2ce1e29fdbb8e95ac89383 Bug: 1103219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291694 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#796057}
-
Kalvin Lee authored
This change * fixes some bugs in the way the PpdMetadataManager deals with cache expiration and * adds unit tests to enforce the advertised conventions. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: I6254fae91a158c93734930ba941d7b0404b8d115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332037Reviewed-by:
Luum Habtemariam <luum@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#796056}
-
Nate Chapin authored
Split most of the window initialization logic out into a helper. Also, it's not clear that GlobalObjectReusePolicy needs to be an enum. Return a boolean for whether we should reuse the dom window, and use the bool |should_reset_browser_interface_broker| for all of the layers of load commit callbacks, rather than switching from enum to bool part way. Change-Id: I8ff3c514115ff6b94f7992af8a73c5cc06e77623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341346 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#796055}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3b08f35fd150..3e8fae719358 2020-08-07 brianosman@google.com Revert "Add inline threshold to SkSL::Program::Settings" 2020-08-07 johnstiles@google.com Enable ClangTidy check readability-const-return-type. 2020-08-07 johnstiles@google.com Enable ClangTidy check readability-static-accessed-through-instance. 2020-08-07 johnstiles@google.com Fix bug in SkMipmapCache::AddAndRef factory selection. 2020-08-07 brianosman@google.com Add support for children to runtime color filters 2020-08-07 fmalita@chromium.org [skottie] Add animation in/out point getters 2020-08-07 brianosman@google.com Add inline threshold to SkSL::Program::Settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I9b4d24b880ad32ce43e0a72575db074f6fd76e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343374Reviewed-by:
-
phillis authored
Move OS updates from being embedded in WebAppInstallTask and observer pattern to OsIntegrationManager and remove AppShortcutManager from WebAppInstallTask and InstallManager. This also removes ShortcutManager and FileHandlerManager from inheriting AppRegistrarObserver and get rid of unneeded TestAppShortcutManager. Bug: 1098027 Change-Id: I7ecbaa2a68669435d4a8a05b7d02c8b6ef67fc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331072 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796053}
-
Brian Sheedy authored
Prepares RenderTestRule for the upcoming test name change to not include OS or device model in the test name reported to Skia Gold. This is done by creating a copy of the compareForResult method that does not add the extra information and calling it at the end of compareForResult. These extra comparisons have the ignore=1 field in their JSON, which means that they won't cause Gold to comment on CLs if they fail. This is so that any existing flakiness in the tests can work through the system with the new names without affecting anyone. Once everything is ready, this new implementation can just replace the existing compareForResult (with the ignore field removed and some renaming performed). Bug: 1077274 Change-Id: I714999a382b2f2f9a7e4e5abe34d46a817c8882a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337101Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796052}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fe4688edfa48..4c2f9c90f425 2020-08-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f197110..61491ae4 (795842:795944) 2020-08-07 sprang@webrtc.org Revert "Makes aborting delayed probes default enabled." 2020-08-07 eshr@google.com Add ilnik to OWNERS of video/adaptation 2020-08-07 nisse@webrtc.org Delete unused argument |require_key_frame| If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I68aed292d930e7857d5e20e829e39d493a47b922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343375Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idddd721b170edfddc3b7a43f39825583d4e4b707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343372Reviewed-by:
-
shivanigithub authored
Change-Id: I2e64bf17aafd6aeeaaafbb54d30f246998fcf4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324506Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#796049}
-
Tommy Li authored
Add a new value to OmniboxFocusType called DELETED_PERMANENT_TEXT, which corresponds to the Ctrl+L, and then Backspace case. This CL also breaks OmniboxFocusType out of template_url.h, into its own header file. This is because we plan to use OmniboxFocusType within AutocompleteInput in the next CL, to replace the from_omnibox_focus() boolean with this multi-valued enum. Bug: 1106096 Change-Id: I2ef25083845d272fd934adafa66624de85d84cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341399Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796048}
-
Xinghui Lu authored
Per UX guidance, the highlighted area should match the tap target area. Mocks: go/esb-clank-dd-highlight screenshot: http://screen/OkDyUpuFG3Q RTL screenshot: http://screen/2U98n12nfaw Bug: 1105998 Change-Id: I3bac076c70596f090f76800ca8b82f80a0a37dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292710 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Sammie Quon authored
The overview bounds calculations today consists of determining the bounds in OverviewGrid, then adding a margin (for the highlight border) and to eat events near the edge), then removing the margin for calculations down the line. This patch simplifies some of that logic, allowing us to remove a workaround in WmHighlightItemBorder. Some calculations are still left behind, but its a lot fewer and better commented. This does affect behavior in one case - for extreme window cases (in this example super wide windows), the ratio between the width and height is now 2:1. Previously, the ratio between the width + margin and height + margin was 2:1. I think this is the expected behavior we want. Test: existing tests Bug: 1111961 Change-Id: I564a63cdf5f9420ef364cd6473acaccba3c6050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335794 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#796046}
-
Sammie Quon authored
Existing screenshot accelerators now enter capture mode. Test: manual, no screenshots taken with capture mode enabled Change-Id: Iaa80f4f16b906907c8f574627c4ce4217469a039 Fixed: 1113848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341831Reviewed-by:
-
Avi Drissman authored
Do not try to derive one weight of font from another. Use the API to directly generate them. PlatformFontMacTest.FontWeightAPIConsistency tested that our understanding of shifting weights up and down was correct. The code no longer shifts weights up and down as that is unreliable and version-specific, so there is no need to test weight shifting and it is removed. This also fixes Big Sur issues. Bug: 1101426 Change-Id: I2165c3550ad295b3ee7742f3289874ed2bb89c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340262 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796044}
-
Robert Sesek authored
Bug: 1114242, 1113952 Change-Id: Ie4ac3587177024f3c14bdca10515d5291063e1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342255Reviewed-by:
-
Xida Chen authored
This CL fixes a problem when pinch zoom is laggy. The root cause of this is due to a legacy IPC channel that is not removed yet in the InputRouterImpl. More specifically, in InputRouterImpl, we now have: 1. OnSetCompositorTouchAction, which sets the allowed touch action computed from CC. This is the most restricted touch action which can be used to process gesture event right away. 2. SetTouchActionFromMain: this is the touch action computed by the Blink main thread, and that's the correct one (more correct than the compositor computed one), and we should use this touch action to process touch events. 3. OnSetTouchAction: this is the legacy one, it was there before SetTouchActionFromMain was introduced. This should be removed. The problem is that we got SetTouchActionFromMain to be Auto, which means any gesture event is allowed. But then OnSetTouchAction somehow set the touch action to be none, which means no gesture event can be allowed, and that prevents pinch zoom. Bug: 1059125, 1030234 Change-Id: I4bb66ad52f6a1353f8383d6685cb293b41d4e08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304161 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796042}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb03de538548..3a3d419df752 2020-08-07 courtneygo@google.com Reference count context to fix ASAN issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I6814164726522aaa5c833b9beb08eda14931c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343371Reviewed-by:
-
Michael Thiessen authored
Chrome does not allow sites to navigate to content URIs, but the Google Search app parses and re-sends URIs, including content URIs, sent to it. This allows intents sent to GSA to bypass this content URI restriction. In order to prevent this bypass, we can simply remove the BROWSABLE category from our intent filters that handle content URIs, as we don't need to handle content URIs coming from other browsers. This change also adds tests for our Intent Filters, which, as far as I can tell, were untested before this change. I also fixed a few edge cases with the intent filters I modified as revealed by the tests. Note that for some intent filters I removed the content scheme altogether. In these cases the filter wasn't useful because a file extension was specified, making it impossible for the content scheme to be matched. I also suppressed some AppLinkUrlErrors: "Error: Activity supporting ACTION_VIEW is not set as BROWSABLE". This isn't an error. I don't know why lint flags it other than to make sure you know what you're doing and don't accidentally prevent browsers from launching your View intent Activity. Bug: 1092453 Change-Id: I167d2e41c0d9c75c0b80a5a1778817b42016e21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321522 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#796040}
-
Egor Pasko authored
When run_web_tests.py --driver-name=... is used, print the driver name on error instead of the default driver name. Bug: None Change-Id: I5577fe5e774f6fd9959737d3e2792c20e5fc9359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341649Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796039}
-
