GitLab

Change-Id: If1acff58705ce3bb7bd07e23a2eb4de24d0dd968
Reviewed-on: https://chromium-review.googlesource.com/c/1432492Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625410}

Purpose is to have manifest changes reviewed so that unexpected changes
can't sneak into the merged manifest (ex. adding an aar dep that needs
extra permissions).

Any deviations from the golden files are printed for release builds
and will fail the build if the GN arg
check_android_configuration = true.

Bug: 882528
Change-Id: I3fee0546004df18ada0fc33077c978edaa64f127
Reviewed-on: https://chromium-review.googlesource.com/c/1409406
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625409}

Previously, if the alert severity was anything other than NONE, the
tooltip on the app menu prompted the user that an upgrade was available.
But alerts are used for other things too (like an extension that has
been disabled) so now we display a generic alert tooltip for non-upgrade
situations.

Bug: 889779
Change-Id: I952bc7803d09fbd7076b4c0636eb619085aee689
Reviewed-on: https://chromium-review.googlesource.com/c/1431475Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625408}

This reverts commit 0cee3055.

Reason for revert: This change makes app icons bleed outside of the overflow when there are too many of them.

Original change's description:
> CrOS Shelf: Remove overflow shelf clip
> 
> Remove overflow shelf clip so that inkdrop ripples can propagate
> outside the overflow bubble.
> 
> The mask isn't really useful in the first place anyway.
> 
> See before/after screenshots here:
> 
>     https://bugs.chromium.org/p/chromium/issues/detail?id=631240#c14
> 
> Bug: 631240
> Change-Id: Iaa1d2f4e2e74bff34a708fa9e2cd7be5ed9a52fa
> Reviewed-on: https://chromium-review.googlesource.com/c/1429639
> Auto-Submit: Manu Cornet <manucornet@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625234}

TBR=xiyuan@chromium.org,manucornet@chromium.org

Change-Id: I51a004caf0a1b516fd21251621e9f716a241ca14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 631240
Reviewed-on: https://chromium-review.googlesource.com/c/1432732Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625407}

This patch modifies PaintImage to have an interface to indicate
that the underlying image is YUV pixel format and adds a
corresponding DecodeYuv() method.

In GpuImageDecodeCache, this change adds "is YUV" variables/getters to
DecodedImageData, UploadedImageData (has_yuv_planes()), and ImageData,
as well as base:Optional arrays for the SkImages and GL texture IDs for
each Y, U, and V plane in the relevant places.

The YUV decoding path will initially be implemented for in-process
GPU rasterization and later for OOPR (Out of Process Rasterization).
Changes that affect WebP decoding in Blink will be hidden behind a flag called
kDecodeLossyWebPImagesToYUV.

Finally, because this decides whether to YUV decode based on
the result of PaintImageGenerator::QueryYUVA8, we separately modified
JPEGImageDecoder::CanDecodeToYUV (crrev.com/c/1400764) and
VideoImageGenerator::QueryYUVA8 (crrev.com/c/1418322)
to return false in order to avoid prematurely going down the YUV decode path.

See bit.ly/webp-decoding-into-yuv for the design document and
crrev.com/c/1338461 for a working prototype CL.

Bug: 900672
Change-Id: I14f60d83cc2da2382e3da296fab598597b7e8ec8
Reviewed-on: https://chromium-review.googlesource.com/c/1368687Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625406}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b1be6763f6f3..86d0d9be254a


git log b1be6763f6f3..86d0d9be254a --date=short --no-merges --format='%ad %ae %s'
2019-01-23 afdx@google.com Refactored reducer so that the 'finding' functionality of a reduction pass are separated from the generic functionality for tracking progress of a pass.  With this change, we now have a ReductionOpportunityFinder abstract class, with many subclasses for each type of reduction, and just one ReductionPass class, which has an associated finder. (#2321)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@86d0d9be254a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I58a795f2caba2d6f251c2e15b85b6bc4f692c929
Reviewed-on: https://chromium-review.googlesource.com/c/1431839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625405}

The current amd64-generic builder has thin-lto and cfi disabled by default
for build cycle time reasons. Chromeos-chrome ebuilds use them both however,
so changes might slip in that break the ebuild but pass on the cq.

This will add a CI bot (and an optional trybot) that has them both enabled.

Bug: 924192
Change-Id: I371e4c6606c0e2e28112750add47208e9dcfd899
Reviewed-on: https://chromium-review.googlesource.com/c/1431515Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625404}

Fix VolumeManager unittest by forcing the flag to be enabled and
changing the volume id to the new id.

Bug: 873539
Change-Id: Ibb230220486cd6b91eadbe7b7e0b35972a45a695
Reviewed-on: https://chromium-review.googlesource.com/c/1428001
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625403}

In https://crrev.com/dbd4eed1920a2aafbc87236db7efb98f108ba063 I moved
around some fragment scrolling code to simplify and clean it up. As part
of that, I made focusing and scrolling happen at the same time.

Unfortunately, as noted in [1], this violates the lifecycle assumptions
since focus() can synchronously execute an event handler - script is
forbidden in the entire lifecycle, not just within layout.

This CL undoes the loosening of the ScriptForbiddenScopes from the CL
above. To do that, FragmentAnchor splits up the application of focus
from scrolling and tries to apply focus at the time of FragmentAnchor
creation (i.e. during parsing/navigation). If we can't apply it then
(because rendering is blocked) it'll be applied at BeginFrame time,
before rAF callbacks are executed.

[1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5BJSTl-FMGY

Change-Id: If2c4c638f3f0faa7dab23e7e129c196357076fad
Bug: 795381
Reviewed-on: https://chromium-review.googlesource.com/c/1408217Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625402}

The SynchronizeVisualProperties() method is called from the IPC handler
to apply some of the IPC message. The code for page scale factor is
moved out to the IPC handler to act on it directly.

It is also called by a number of methods for tests, which apply various
properties to the RenderWidget. Page scale is not ever changed by these
test methods, so they do not depend on it being inside
SynchronizeVisualProperties().

It is also also called from the screen metrics emulator, but since the
emulator does not change the page scale factor, it also does not depend
on this code being in SynchronizeVisualProperties().

The notification of the page scale factor change to each
RenderFrameProxy is dramatically reordered with respect to the other
properties of RenderWidget changing. This is okay because the
notification is only to pass the value over IPC up to the browser and
down to the child RenderWidget, so it does not depend on the ordering.

This reduces the test-only method dependency footprint on the
VisualProperties structure. Left a TODO about changing the routing
of this page scale property to go

blink->RenderView->RenderViewHost->{All RenderWidgets}

instead of the current

blink->RenderView->RenderWidget->
  {All RenderFrameProxy->RenderWidgetHost->RenderWidgets}

Other page-level properties could benefit from this path as well
but are much trickier since they
a) do not go through RenderFrameProxy today and instead seem to
propagate through the browser code, which is good, except
b) are treated identically in child RenderWidgets as in the main
frame,

whereas the page scale factor has clear behaviour differences for
child RenderWidgets. So this could be useful for exploring and
establishing this pattern.

R=ajwong@chromium.org
TBR=avi

Change-Id: I4af9b114e729c26e8356e69ecb9569337d653cb3
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1427466
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625401}

Session restoration completion code was moved from
didCommitNavigation to didStartProvisionalNavigation.
This change will allow the user to start interacting with
web contents without waiting until the first post-restore
navigation is complete.

There will be no committed URL until the first post-restore
navigation is complete, but user should be able to load new
pages and perform back forward navigations.

Bug: 877671
Change-Id: Iceeeff857aee36bf4151f247815c0705ac377e73
Reviewed-on: https://chromium-review.googlesource.com/c/1407909
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625400}

AppCacheFrontend is only used in AppCache's browser-side
implementation. Having it in content/common/appcache_interfaces.h is
misleading, as it suggests that the class is shared with the renderer.

Bug: 611938
Change-Id: I68865d63ee38841d59b61866664716c0ec8c2c39
Reviewed-on: https://chromium-review.googlesource.com/c/1429247
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625399}

This redraw used to be

  if (params.needs_resize_ack)
    delegate_->Redraw();

Which was there to cause a paint (pre compositing) or a composite (post
compositing) in order to send an ack after a resize. We no longer need
to make this redraw happen to get the appropriate ACK as
664698a6 converted us to ACKing to SynchronizeVisualProperties
(which replaced Resize) directly, and now ACKing is tied to surface
synchronization and local surface IDs.

R=avi@chromium.org

Change-Id: Id1c0e3e5534b41767ce36fb2298af56a639fa677
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1431213Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625398}

Message added under Browsing Reporting section on Desktop
with "Chrome Reporting Extension (cloud or OnPrem)" installed
for each of the following policies:
  * report_machine_id_data (true for cloud reporting)
  * report_user_id_data (true for cloud reporting)
  * report_version_data (true for cloud reporting)
  * report_policy_data (true for cloud reporting)
  * report_extensions_data (true for cloud reporting)
  * report_safe_browsing_data (true for cloud reporting)
  * report_system_telemetry_data
  * report_user_browsing_data

Bug: 921698
Change-Id: Icccf744acb775be9723e38b61829ffb42fc2053c
Reviewed-on: https://chromium-review.googlesource.com/c/1423116
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625397}

This CL adds a number of deps to the target
//chrome/browser/safe_browsing:safe_browsing
It also adds the safe_browsing target to allow_circular_includes_from
for //chrome/browser:browser, since these are tightly coupled. The
remaining gn check errors are only due to circular dependencies with:
  //chrome/browser/ui:ui
  //chrome/browser/extensions:extensions
Both of which will be fixed in future CLs

Bug: 919683
Change-Id: Iec1c1737aceef070aca082260b587dc96250bc16
Reviewed-on: https://chromium-review.googlesource.com/c/1428480Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625396}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6aa6bc44417e..5f9f137868bd


Created with:
  gclient setdep -r src-internal@5f9f137868bd

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icce4c91cf17d385e89919647ab3b5ca4332b44eb
Reviewed-on: https://chromium-review.googlesource.com/c/1431832Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625395}

Two changes:
- Remove the IS_OFFICIAL_BUILD check (don't require official builds to
  be signed for app shims to run at all).
- Construct a custom designated requirement to verify the app shim,
  which checks its identifier and that its certificate matches the
  browser's.

For now, keep failures log-only.

This reverts commit add2f7a1.

Bug: 913362, 923612
Change-Id: I1c536e2172519dbf8e5b36a2dd9b5f1b26fb8302
Reviewed-on: https://chromium-review.googlesource.com/c/1427385Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625394}

BUG=762641
TBR=michaelpg@google.com

Change-Id: Ia4ebed15d53163eace05eaa2997a8111e9f0a6ff
Reviewed-on: https://chromium-review.googlesource.com/c/1429199Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625393}

https://android.googlesource.com/platform/external/perfetto.git/+log/a824c339c217..3eabfafdae1e


git log a824c339c217..3eabfafdae1e --date=short --no-merges --format='%ad %ae %s'
2019-01-23 lalitm@google.com Merge "trace_processor: add support for polled oom_score_adj"
2019-01-23 treehugger-gerrit@google.com Merge "profiling: Log on pipeline stall."


Created with:
  gclient setdep -r src/third_party/perfetto@3eabfafdae1e

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I1bda3ef94d7f99044c6e5f7116410da7a27d5539
Reviewed-on: https://chromium-review.googlesource.com/c/1431455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625392}

Bug: None
Test: locally build and run
Change-Id: Ifdb6e31b926da18c6da47e7a2a5540f58e9fa9a9
Reviewed-on: https://chromium-review.googlesource.com/c/1423620Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625391}

FireWebUIListener(name, ...) is essentially an alias for:

  CallJavascriptFunction("cr.webUIListenerCallback", base::Value(name), ...);

Using it reduces the amount of times we paste "cr.webUIListenerCallback" and
generally reduces the amount of parallel paths for notifying running web
UI pages.

R=aee@chromium.org
BUG=none

Change-Id: Id3ee2622949c0fd1bba9705655de4cb0faf386f4
Reviewed-on: https://chromium-review.googlesource.com/c/1431293Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625390}

This CL resets the pending pointerdown information in
InteractiveDetector when a pointerCancel or pointerCausedUaAction are
detected because those indicate that scrolls have happened. This CL also
changes the UMA and UKM metrics affected by this change by adding a 2 at
the end of the histogram names.

Bug: 924278
Change-Id: I4b42e9478c74d9ba42b77170800b6267151c91e8
Reviewed-on: https://chromium-review.googlesource.com/c/1427924
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625389}

The PrinterQuery being passed in is never nullptr, since the caller is
written as: printer_query->SetSettings(..., printer_query).

Change-Id: I97bdd100743e35b967de8b34df6bbfed2bb80216
Reviewed-on: https://chromium-review.googlesource.com/c/1428406Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625388}

This test is flaky on platforms that where Sleep(delta) isn't
guaranteed to be in TimeTicks (e.g. on Mac, it's in base::Time).
Use base::test::ScopedTaskEnvironment::MainThreadType::MOCK_TIME
instead.

Also, cleans up some APIs and adds a comment to the Sleep() API.

Bug: 915672
Change-Id: Ib539c0d06a217dfdb9ee6f7411e885d6975438a9
Reviewed-on: https://chromium-review.googlesource.com/c/1427927
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625387}

Pretty much everything should use --cr-link-color, which magically
changes based on light/dark mode.

There was also just a ton of duplicated a[href] rules, which I
instead added to shared_style.html (and verified each place I
deleted from used include="shared-style").

Screenshots: https://imgur.com/a/kaT6MJc

R=dpapad@chromium.org
BUG=883049

Change-Id: I00440e1bcfaae21b31763f51d65385729ba7fab9
Reviewed-on: https://chromium-review.googlesource.com/c/1429379
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625386}

Bug: 924322
Test: None
Change-Id: Ief0e8239031f82984c48f08dbf332584f67c5b48
Reviewed-on: https://chromium-review.googlesource.com/c/1428839Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625385}

This reverts commit 5a0921ab.

Reason for revert: Seems to cause ThirdPartyConflictsManagerTest.InitializeUpdaters to fail in official builds.

Original change's description:
> Get the CertificateInfo of the current exe from ModuleDatabase
> 
> The ThirdPartyConflictsManager needs the CertificateInfo of the current
> executable to identify third-party DLLs. It used to create it itself,
> but that information is already available from the ModuleDatabase.
> 
> Bug: 921746
> Change-Id: I3d57d289f17bac563fed498e59f48c3bbc9f4f64
> Reviewed-on: https://chromium-review.googlesource.com/c/1426061
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624901}

TBR=pmonette@chromium.org,sebmarchand@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 921746, 852295
Change-Id: I74a40d6c9af0c41c487e6201581230d537c56daa
Reviewed-on: https://chromium-review.googlesource.com/c/1432233Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625384}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f7971436824d..695e7cf35258


git log f7971436824d..695e7cf35258 --date=short --no-merges --format='%ad %ae %s'
2019-01-23 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@695e7cf35258

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I02676c5883f16255d66f67f76a39ceb0711992c8
Reviewed-on: https://chromium-review.googlesource.com/c/1431454Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625383}

Bug: 901952
Change-Id: If2338a9904c0d0ff5f831769d1549001adcb0b3b
Reviewed-on: https://chromium-review.googlesource.com/c/1431112
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625382}

As per UX review

Screenshots with change
- https://screenshot.googleplex.com/is30KnFrqJv
- https://screenshot.googleplex.com/X9RqOSW4PVz

Bug: 913646
Change-Id: I052ede08da6aaf7d994e48e69f502e182f71a878
Reviewed-on: https://chromium-review.googlesource.com/c/1427979Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Commit-Position: refs/heads/master@{#625381}

This change:
1) Marks uses of launch_data_t as deprecated with no replacement (so ignored);
2) Marks uses of the NSObject accessibility API as deprecated to be replaced
   (per bug 921109)
3) Replaces one use of CWInterface with a corresponding use of CWWiFiClient, and
   marks another as ignored for now;
4) Replaces some LaunchServices invocations with their new equivalents;
5) Marks GTM to ignore deprecation warnings, since the GTM dependency will go
   away soon anyway;
6) Fixes how blink refers to NSCalendarIdentifierGregorian;
7) Replaces some uses of NSRunAlertPanel with explicit constructions of NSAlert;
8) Bumps the deployment target to 10.10

An earlier version of this change attempted to incrementally upgrade, but many
of the replacement APIs are themselves only @available on 10.10, so it proved
to be significantly uglier.

Bug: 841631
Change-Id: Ic6e96efbb84ba0a077eda3528b452137d64f5f02
Reviewed-on: https://chromium-review.googlesource.com/c/1407177
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625380}

Clang built from trunk now implements _xgetbv, causing errors as it is
now redefined.

Modeled after https://crrev.com/c/1414858 which is a similar fix to v8.

TEST=built locally with clang from trunk

Change-Id: Ie1c242ae6b9ae34b695a512991e90a74dfafdedc
Reviewed-on: https://chromium-review.googlesource.com/c/1431352Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Jordan Rupprecht <rupprecht@google.com>
Cr-Commit-Position: refs/heads/master@{#625379}

Change-Id: Idc5b8baf277b02a4adf0ff4835f45ea0a7b0f513
Reviewed-on: https://chromium-review.googlesource.com/c/1431233Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625378}

This CL extends expiry of several metrics related to download and media.

Useful for implementing new feature:
Android.DownloadManager.ViewRetentionTime.Video
Android.DownloadManager.ViewRetentionTime.Audio
Download.DeleteRetentionTime.Video
Download.DeleteRetentionTime.Audio

Important system health metrics:
Download.ParallelDownloadAddStreamSuccess
Download.ParallelDownloadRequestCount

Bug: 918380,918378
Change-Id: Id597b9a8ae3ed72f1c0b0cd95ef36df4b5467d8d
Reviewed-on: https://chromium-review.googlesource.com/c/1428741Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625377}

This adds proper logic to run_cts.py to auto-determine the device
architecture, and to throw an error if the device architecture is not
supported. This also adds unit tests (and configures them to run on
presubmit).

Although this is not a significant improvement (we still only support
"arm64"), this gives fast, clear feedback when the device is unsupported
(e.g., emulators), and the logic should generalize as we support more
architectures. This also adds logging (which will be visible with
--verbose, to aid debugging).

This does minor refactoring in the script, to plumb arch where it's used
instead of reassigning to args.arch (which should help with testability
in the future).

R=aluo@chromium.org

Bug: 922854
Test: vpython android_webview/tools/run_cts_test.py
Test: android_webview/tools/run_cts.py (script still runs)
Change-Id: I6528ab836f30b5885ede59853acaeee69de26fa2
Reviewed-on: https://chromium-review.googlesource.com/c/1419840
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625376}

This reverts commit c13cea62.

Reason for revert: Fixed memory problem

Original change's description:
> Revert "Don't record first filling result for sign-in forms"
>
> This reverts commit 34d69265.
>
> Reason for revert: breaks msan
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/14500
>
> Original change's description:
> > Don't record first filling result for sign-in forms
> >
> > The new form parser may decide that a form has no current-password element, but
> > only new-password / confirmation elements. In this case, the parser sets the
> > unique_renderer_id to 'undefined'. The credentials will be sent to the renderer
> > for filling via manual fallback but the renderer won't ever fill (as there is
> > no password element defined for filling.
> >
> > This CL ensures that this case does not get recorded as a failure to fill. This
> > is important because we record two metrics about the first fill attempt:
> > PasswordManager.FirstWaitForUsernameReason and
> > PasswordManager.FirstRendererFillingResult For websites that have a sign-up
> > form followed by a sign-in form, we don't want to record the failure to fill on
> > the sign-up form.
> >
> > Bug: 918846
> > Change-Id: I79e9a73ae3573a81e121eaa483e0ecef0889184f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1422018
> > Commit-Queue: Dominic Battré <battre@chromium.org>
> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#625178}
>
> TBR=battre@chromium.org,dvadym@chromium.org
>
> Change-Id: I3c68004b67b5fcc65511c611c2d205297596e782
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 918846
> Reviewed-on: https://chromium-review.googlesource.com/c/1430581
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#625227}

TBR=dvadym@chromium.org,jam@chromium.org

Bug: 918846
Change-Id: I671bc4674f1660920eae0c73d5b1b01b49311383
Reviewed-on: https://chromium-review.googlesource.com/c/1431172Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625375}

In dark mode, the *icon* color differs slightly from the *text* color.

Screenshots: https://imgur.com/a/asWpYhY
Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g48a476f4a5_2_42

R=dpapad@chromium.org
BUG=883049

Change-Id: I67521d7505f1b27f212b4813c853074f88c28971
Reviewed-on: https://chromium-review.googlesource.com/c/1429196
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625374}

https://crrev.com/c/1427543 fixed the case where a custom background is
set and dark mode is disabled. However, this does not cover the case
where both a custom background and theme are not set.

Improve dark theme detection by only checking for dark mode if no
custom background or theme is set. Otherwise, default to the regular
dark theme detection.

Bug: 923797
Change-Id: If4f8863cc2a29ed3f8908bbc9d89a7b5ad92a336
Reviewed-on: https://chromium-review.googlesource.com/c/1428440
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625373}

Wait for the OnPersonalDataFinishedProfileTasks, rather than
OnPersonalDataChanged. Rename the class accordingly.

Bug: 919967
Change-Id: I6e1808f67c384d99cb4f88d33f6d5ffb7d83d972
Reviewed-on: https://chromium-review.googlesource.com/c/1427792
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625372}

This mainly affects section titles and subpage titles in settings.

R=dpapad@chromium.org
BUG=883049

Change-Id: I614cf44adb70becc5ef00479bd19c5372c4929c4
Reviewed-on: https://chromium-review.googlesource.com/c/1429661
Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625371}