- 11 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df70582bd999..d10454e66ac1 Created with: gclient setdep -r src-internal@d10454e66ac1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I612c2b1c82cf493921b40e50626dfe152c44707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797157Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695557}
-
Julie Jeongeun Kim authored
This CL converts ApplicationMediaCapabilitiesRequest and ApplicationMediaCapabilitiesPtr to new Mojo types. It uses ReceiverSet and PendingRemote or Remote instead of BindingSet and ApplicationMediaCapabilitiesPtr. Bug: 955171 Change-Id: I4b03e7bc1c4412e370d2fbd95d812a0ee53a08dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786705 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695556}
-
Sigurd Schneider authored
This CL displays the duration of a network task in the timeline view as a sum, for example: 15.10 ms = 12.66 ms network access duration + 2.44 ms resource processing The 12.66 ms match what is displayed for the resource in the network tab, but only if the resource has been loaded by the renderer. The numbers are still wrong for navigation requests issued from the main thread, but this is because the back-end reporting is wrong. (To be fixed in a follow-up). Bug: chromium:865066 Change-Id: Id5e2aa71349836352a4bf62f9a0bb17e8c8b59be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764146 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#695555}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/050abd8dd5c4..c5f9c0682125 git log 050abd8dd5c4..c5f9c0682125 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 khokhlov@google.com [Telemetry] Always serialize traces Created with: gclient setdep -r src/third_party/catapult@c5f9c0682125 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:981349 Change-Id: Iea64d0dbc517e81b8cb4a96b99f6f9cb8979b4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55f663f5ddff..70767cba4254 git log 55f663f5ddff..70767cba4254 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d65ce76c..95ebb2b7 (695395:695497) Created with: gclient setdep -r src/third_party/webrtc@70767cba4254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I99ffd71cd8c0dfa00deaa6df560f69da4397ae97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797087Reviewed-by:
-
Henrique Ferreiro authored
As part of the Mojo migration, there was a remaining reference to mojo::ChildProcessRequest from the content/common/child_process.mojom interface. Bug: 955171 Change-Id: Ic79fdcecca3f4cce29be5f027992999731f69ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796804Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#695552}
-
Fredrik Söderquist authored
This adds helpers to check if a time is before/after begin/end of the interval or is contained within an interval, as well as a method to check if the begin time has been resolved (== it's a usable/valid interval). Bug: 998526 Change-Id: I0d16fec31bd3b46f7bedda0f3815c785996f14dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795445 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695551}
-
Julie Jeongeun Kim authored
This CL converts ApplicationMediaCapabilitiesObserverPtr to new Mojo types. It uses Receiver, RemoteSet, and PendingRemote or Remote instead of Binding, InterfacePtrSet and ApplicationMediaCapabilitiesObserverPtr. Bug: 955171 Change-Id: I95a366faed461a5108f1abea78a4ee8ebf973aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787673 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
We are planning to provide a temporary policy escape hatch for the OOR-CORS enterprise-friendly rollout. With this policy, Chrome handles any webRequest API users as specifying "extraHeaders" option so that such Extension can work without any fix for a while. Before adding such enterprise policy, we want to run a field trial if such approach does not introduce any other problems. This patch adds this escape hatch as a base::Feature trial. We will run a field trials in non-stable channels for a while, and convert this to an enterprise policy for m79. Bug: 1000982 Change-Id: I27b96d4fbc70fb52eb2c878058d0fd22078fd339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792506Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695549}
-
Robbie Gibson authored
A few colors weren't updated in the first pass. The biggest thing is the "Clear Browsing Data" button, which was normal red, instead of the new Chrome dynamic red. Bug: 1002407 Change-Id: I09ec5bd06271748826b5dbe6e458eeec0ed1b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794863Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#695548}
-
Jan Wilken Dörrie authored
This change makes std::wstring usage explicit in //base/win. Exposing std::wstring in the //base/win interfaces will make it easier to prepare other Windows only code for a future where base::string16 is no longer std::wstring. Bug: 911896 Change-Id: I7f214d0ea1d72d80f8b510eb9e22ae7ef1a2f988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789388 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695547}
-
Elad Alon authored
Prior to this CL, clearing browsing history left behind traces of calls for which the log file is missing, but for which entries in the log index file exist. This CL fixes this problem. Bug: 826253, 992478 Change-Id: I4ceec22c99017e8e7826902195de5326f8123a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782904Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#695546}
-
vitaliii authored
Disable external/wpt/webdriver/tests/take_screenshot/screenshot.py>>test_format_and_dimensions because flaky. TBR=johnchen@chromium.org Bug: 855860 Change-Id: I5f8853cbc22d327d3cb48b99978de7ac2b8e0b77 No-try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796665Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695545}
-
Yoshifumi Inoue authored
This patch renames |NGPhysicalTextFragment::Length()| to |TextLength()| to simplify source code for improving code health. This patch is follow-up the CL[1] which introduced |TextLength()|. [1] http://crrev.com/c/1794542 Make NGTextFragmentPainter faster as before Change-Id: I617c5c9871a315b1df72e09c8e78f1780048f4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798062 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695544}
-
arthursonzogni authored
Content's embedders are not notified the visible URL has been invalidated. This CL adds a regression test showing this. Bug: 998284. Change-Id: Ib3a239d65f98209688b3b682cbe9a6184707c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780822 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695543}
-
Hiroki Nakagawa authored
This CL removes the "externalfile" scheme support from URLLoaderFactories for service worker updated script loading. The scheme is used for loading files from ChromeOS-specific local file systems (e.g., "Downloads" and "removable"): https://cs.chromium.org/chromium/src/chrome/browser/chromeos/fileapi/file_system_backend.h?rcl=7bd9f2e138d37076a1ed3380126be8d00ae3837c&l=38 Service workers never support the scheme: https://cs.chromium.org/chromium/src/chrome/common/chrome_content_client.cc?rcl=013d0ec7da2f2c1b4c78af14fa1bdc83290dfb35&l=645 https://cs.chromium.org/chromium/src/content/browser/service_worker/embedded_worker_instance.cc?l=1092-1095&rcl=183f7e64155459d1c5f50155234a176e4fce7b3f See the following comment for the context: https://chromium-review.googlesource.com/c/chromium/src/+/1669251/7/chrome/browser/chrome_content_browser_client.cc#4893 Bug: 648295, 964229 Change-Id: I4d18bb972f38eba4498b109e595627a43cfdc6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798102 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695542}
-
nancy authored
BUG=998004 Change-Id: I3bccc70e1a2d372585bf015ebc0b808b43b4be85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787618Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695541}
-
Julie Jeongeun Kim authored
This CL converts MediaCapsObserverPtr to new Mojo types. It uses Receiver, ReceiverSet, RemoteSet, and PendingRemote or Remote instead of Binding, BindingSet, InterfacePtrSet and MediaCapsObserverPtr. Bug: 955171 Change-Id: I26460b5c0a13f858997c6141d6ca437cb84a674d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786704 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds an explicit base::WriteInto overload for std::wstring for Windows. For now this method is called WriteIntoW, as otherwise it would cause redefinition errors with the other overloads as long as base::string16 is std::wstring on Windows. Bug: 911896 Change-Id: Icaa681c6d0e1bcefcd4096e59194213dace14f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796432Reviewed-by:
-
Fredrik Söderquist authored
This splits said method into a CheckAndUpdateInterval() and an UpdateActiveState(). CheckForNewRestartInterval() is also folded into the former. Bug: 998526 Change-Id: Ie1b10e06cfc0aed64e8576c820c59978596c5083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795428 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#695538}
-
Pâris MEULEMAN authored
This CL creates the java counterpart of the PrimaryAccountMutator, and modifies SigninManager java to use it instead of going through the C++ API. The aim is to have SigninManager.java interact with IdentityManager solely through its java interface, for which a few follow ups are required. Bug: 934688 Change-Id: Ic2b893d5831d53b2ea6df5184fd5f7894c665924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784721 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#695537}
-
Marc Treib authored
According to the linked bug, the reason for disabling the test has been long resolved. Bug: 84575 Change-Id: I21847fb8199ddedae72db3d58facc7f801db1453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796423 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695536}
-
Marc Treib authored
It was used in the old E2E test setup, which hasn't been active for a while. The new E2E setup won't need it (it'll have real invalidations). Bug: none Change-Id: I789bc07f10bfde6209ef01057e934893d8faf318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796343 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts MediaCapsRequest and MediaCapsPtr to new Mojo types. Bug: 955171 Change-Id: I8fd9b87f2027b5abc3ffbfda942894eaf19e5865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788430 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7f7236f1eba0..c0e9807094ef git log 7f7236f1eba0..c0e9807094ef --date=short --no-merges --format='%ad %ae %s' 2019-09-10 zoddicus@users.noreply.github.com Handle creating a new constant failing gracefully (#2848) 2019-09-10 afdx@google.com Rework management of probabilities in spirv-fuzz (#2839) 2019-09-10 afdx@google.com Fix add-dead-break and add-dead-continue passes to respect dominance (#2838) 2019-09-10 stevenperron@google.com Handle id overflow in the ssa rewriter. (#2845) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c0e9807094ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,syoussefi@chromium.org Bug: None Change-Id: I5550e6b4bb6d1089aca2a034e55137d097cf38f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797086Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea8664557d2e..df70582bd999 Created with: gclient setdep -r src-internal@df70582bd999 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4e4b398376507e8b7df62b610932a6f1f80f9c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797280Reviewed-by:
-
Javier Fernandez authored
This reverts commit a445d168. Reason for revert: It caused a performance regression (issue #1002700) Original change's description: > [css-grid] Clear the override width for computing percent margins > > When calculating the min-content contribution of a grid item of an auto > sized grid track we must consider the grid item's margin. When the grid > item's area is indefinite, a percent margin is resolved to zero. > However, when performing a relayout, the percent margin may be solved > against the previously computed grid area, since the grid item has > already an OverrideContainingBlockLogicalWidth value. > > In order to re-compute the percent margin properly, we need to clear > the previously override value. It's important be careful of not > clearing the override value set during intrinsic size, since we need > it for the actual layout phase. Hence, we only reset the 'override' > value when we are executing a definite strategy. > > Bug: 834643 > Change-Id: Ib936b26bee1da76afbdc886eb775746e13d40988 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782840 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694849} TBR=cbiesinger@chromium.org,jfernandez@igalia.com,rego@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834643, 1002700 Change-Id: I66f2b94417be0c74dc408bc55eee3a8d44447480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796803Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#695531}
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a completely mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format Bug: 646113 Change-Id: Ia29bc02040a056e518737f2b11f1cd0b66b0e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796430Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695530}
-
Miyoung Shin authored
This CL converts JsonParserPtr and JsonParserRequest in chrome, services and extension to the new Mojo type. Bug: 955171 Change-Id: I6f7ad277b5d2885c680b1c62681af6588d04c8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792395 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695529}
-
vitaliii authored
Mark virtual/compositor_threaded_scrollbar_scrolling/fast/scrolling/scrollbars/scrollbar-button-gesture-target.html as flaky on Linux. TBR=bokan@chromium.org Bug: 1002828 No-try: true No-Presubmit: true Change-Id: Iecae0559e773fe4c4925fdae3be66b1020710405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796552Reviewed-by:
-
Pâris MEULEMAN authored
As discussed in crrev.com/c/1784721, CoreAccountId.java and CoreAccountInfo.java should not assume that the CoreAccountId is a Gaia ID, until the completion of the Account ID migration, and rather align their behavior with their C++ counterpart. Bug: 934688 Change-Id: I9245811511c606dc4f56c8a5982cd937ef567d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795583 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts NetworkContextPtr in components, jingle, and services to new Mojo types. Bug: 955171, 978694 Change-Id: Ibf28021f468cb896bb529b7a041a936363a73858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787670Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#695526}
-
Makoto Shimazu authored
TBR=ricea@chromium.org No-Try: true Bug: 1002780 Change-Id: I3efb051c06fd15bb754cbf78269c6b6610bf78b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797944Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695525}
-
Yutaka Hirano authored
It seems always true. Bug: None Change-Id: I90c2022070f33c4042ed436627c853cf64e6fd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797524Reviewed-by:
-
Dominic Farolino authored
This CL addresses a problem with SecurityPolicy::GenerateReferrer when it comes to checking the same-origin-ness of a request. The WebAppSec Referrer Policy Standard defines a same-origin request [1] as one where the request's origin and current URL are same-origin with each other. This comparison is done in "determine a request's referrer" algorithm. The analogous place in our implementation is SecurityPolicy::GenerateReferrer. Before this CL, GenerateReferrer would determine a request's same-origin-ness by comparing the origin of the request's referrer string and the origin of the request's current URL. Most of the time this was sufficient, as the request's referrer string is almost always same-origin with the request's origin (initiator in Blink). With descendant module scripts and worklets however, the origin of the request's referrer string and request's origin (initiator) could be different, which breaks the correctness of our GenerateReferrer method. This CL introduces a blink::SecurityOrigin parameter to the GenerateReferrer method, so that correct same-origin comparisons can be carried out. In all GenerateReferrer call-sites, an appropriate origin is passed in. The original CL [2] was reverted because the semantics of SecurityPolicy::GenerateReferrer were not kept in sync with the similar logic in net::URLRequestJob::ComputeReferrerForPolicy, which caused a DumpWithoutCrashing bug seen in https://crbug.com/1000614, and request cancellations. This reland updates the ComputeReferrerForPolicy logic to match the corresponding Blink logic, and includes documentation mentioning that changes to one section should be reflected in the other. This CL also includes web platform tests for the scenario in the aforementioned bug, which pass with this CL, as well as net unit tests for RedirectInfo and URLRequestJob. [1]: https://www.w3.org/TR/referrer-policy/#same-origin-request [2]: https://crrev.com/c/1768501 Bug: 786862 Change-Id: I1deeaae8191b07856c593ddb2486297344e0b846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786260 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#695523}
-
Takashi Toyoshima authored
This patch adds test cases that an Extension injects response headers to deceive CORS checks. If OOR-CORS is enabled, such injections need 'extraHeaders' option to work in expected ways. Bug: 1000554 Change-Id: Ieef9223b1abd798bea215cfec1fb706aabd0a610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792207Reviewed-by:
-
Miyoung Shin authored
This CL converts BluetoothDeviceAccessProviderPtr and BluetoothDeviceAccessProviderClientPtr in chromecast to the new Mojo type, and uses pending_remote<BluetoothDeviceAccessProviderClient> in web_bluetooth.mojom of chromecast. Bug: 955171 Change-Id: Ibc71e633b842f52ea7c37e9e93d11d4bc293713a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786703Reviewed-by:
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ieaf6f34b8b13eb06f64743dfa1cbbcd9bd7e7fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795467 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::Value::GetList() followed by either emplace_back() or push_back() with base::Value::Append(). This is because of the upcoming change to GetList() to return a base::span instead, which does not support either emplace_back() or push_back(). This is a mostly mechanical change. Steps to reproduce: - sed -i 's/GetList().push_back/Append/g' - sed -i 's/GetList().emplace_back/Append/g' - git cl format - Manually fixing the breakage in cryptotoken_private_api_unittest.cc Bug: 646113 Change-Id: I78dace264e92ef39dcc18b094d064057e06c3d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796431Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#695519}
-
Gyuyoung Kim authored
This CL applies pending_receiver to the first argument of CreateBarcodeDetection in BarcodeDetectionProvider interface. Bug: 955171 Change-Id: Ib86754b3d5989d555a8c0ed536df78e22b540dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792212Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
