- 01 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2645e44ad6b..816506e1c600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I833b8b1330a42a52e0ea5279ac04cc335d7000fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803616}
-
Yuwei Huang authored
Stream requests unlike unary requests don't set the request timeout, since that would simply destroy the stream if it hasn't been closed within the timeout. This CL adds a OneShotTimer to ProtobufHttpStreamRequest to run the StreamClosedCallback with DEADLINE_EXCEEDED if the stream does not receive its first data within the timeout. Bug: 1123199 Change-Id: Iaeb9c5c4f896d2a24378bb83c57d2d39ab49312c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386280 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#803615}
-
Vidhan authored
This CL creates and registers the Autofill States Data Component. Change-Id: Ie6ad98363764101859ec775f64781db4dce82afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332585Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#803614}
-
Rahul Singh authored
Problem: UnregisterShortcutsMenuWithOs() was being called twice as part of uninstalling an Extensions based PWA. Reason: A refactor introduced OsIntegrationManager::UninstallOsHooks as part of which we call UnregisterShortcutsMenuWithOs(). https://chromium-review.googlesource.com/c/chromium/src/+/2294332 When an extensions based PWA is uninstalled, existing code in ExtensionService::UninstallExtension triggers observer code in BookmarkAppRegistrar::OnExtensionUninstalled which in turn calls out to OsIntegrationManager::UninstallOsHooks(). So, we end up with 2 calls to UnregisterShortcutsMenuWithOs(). One from OsIntegrationManager and the other from ExtensionService. Fix: Removed the second call to UnregisterShortcutsMenuWithOs() in ExtensionService::UninstallExtension. Bug: 1123777 Change-Id: I7e89c319aa8e346a3bdfe04cff62a008ce466741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386434Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803613}
-
Kalvin Lee authored
This change adds a new metric for recording the success rates in setting up Zeroconf printers in Chromium OS. Bug: chromium:1077326 Test: none Change-Id: Ie005fb686592177e430c65564663cb8be53eba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382883Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#803612}
-
Yulun Wu authored
Inkdrop color and opacity have been moved to ash_color_provider and are now adapted to system color scheme. Bug: 1110757 Change-Id: Id88812a12a11e510a3ea957c465e7754ebd95ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382222Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803611}
-
Donn Denman authored
Check the context for being null. Also make a few members final. BUG=1123514 Change-Id: Iade8ec0318464ef1e190aae46da1b8c6634be76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386199 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#803610}
-
Morten Stenshorne authored
The containing block of a spanner is always the multicol container itself. Bug: 1123710, 1123792 Change-Id: I3486e6ad2484396548f8682c842a6fb8a731e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386799Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803609}
-
Jared Saul authored
This bubble/button still exist because the Butter Status Chip is not yet fully rolled out. Once it is, these metrics can likely be removed. Fixed: 1109811 Change-Id: Ica83690035c2c880216a98663edcc926557e149a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386384Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#803608}
-
Erik Chen authored
This reverts commit da75e6c8. Reason for revert: No longer want this functionality. Original change's description: > Enable lacros on stable channel. > > Change-Id: I3a3efe60a3b53bbd6f431a257bbf8e6266f903e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377067 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801861} TBR=erikchen@chromium.org,hidehiko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8e5affae1020f948b3b18be3af858fd9ba052a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388345Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803607}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1c4a7f780f10..be53792880bc 2020-09-01 rharrison@chromium.org Roll 9 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I3e4dc368bca8378d43c422414c78a212d37c45a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803606}
-
Matt Wolenetz authored
Moves the core MediaSource interface into the core MediaSourceAttachment interface, centralizing much of the core interaction with the MSE API into the attachment interface. Concrete implementations of MediaSourceAttachments will perform the necessary proxying of behavior between HTMLMediaElement and MSE, which in future changes will include cross-thread attachment support. Implements a concrete same-thread modules MediaSourceAttachmentImpl. This refactor to proxy the MSE API via the attachment and move attachment and tracer implementations into modules has essentially unchanged externally visible behavior (other than debug log messages, for example.) Updates the core HTMLMediaElement to use the attachment interface with the MediaSourceTracer to accomplish existing MSE API operation. The next change will update the internals of the modules MediaSource, MediaSourceAttachmentImpl and MediaSourceTracerImpl to similarly communicate with the media element via the attachment rather than directly to the media element. That part is kept out of this initial change to reduce review complexity here. BUG=878133 Change-Id: Id90f3b5babe87907f884268dffcca799356553f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380571 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#803605}
-
Carlos IL authored
This reverts commit c82e8fea. Reason for revert: Bugs remained after this CL, so both bidi handling CLs will be reverted until the bugs are fixed, we'll also merge a change that disables elision for bidi URLs to 86. Original change's description: > Reset simplified_domain_bounds_ on each animation start > > simplified_domain_bounds_ is calculated on animation start via union, > but was never being reset, this was causing bugs when an animation is > reused (e.g. when switching tabs, or with URLs that redirect). This > adds a reset. > > Bug: 1117631 > Change-Id: I99d1eba536f39ad3c16fc09eca0aa79788b4bb62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382893 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Auto-Submit: Carlos IL <carlosil@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802826} TBR=tommycli@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1117631 Change-Id: I4af20299fbf5e4351c51f468e48d50f53554a2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387482Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#803604}
-
Weilun Shi authored
Update README and one-pager for the latest pattern histogram instructions. Reuse/Remove some of the legacy histogram-suffixes docs. Change-Id: I0bc63ea8d419c5ab861d5d64f39ecc150c6ad8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380344 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#803603}
-
Joshua Pawlicki authored
This requires opening global_prefs a bit earlier. The code will release global_prefs early if it determines qualification is necessary, and will also release it before attempting to self-uninstall (this was an oversight from earlier). As a side-effect of this CL, a candidate will not be able to start qualification while the active updater is running, since it cannot open global_prefs in that case. I also introduced a specific server exit code for when the server shuts down post-qualification. Bug: 1122739 Change-Id: Iad33f88ca438aee3fa2f5f0daf1105e2712baf0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385795 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803602}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4202dc47a417..928a02b1527d 2020-09-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b89144a4 to 09ccc6e0 (370 revisions) 2020-09-01 mtklein@google.com debug LSAN failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ib6ff5a0bfac910c23b52e2217e368ba62bee4008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803601}
-
Deepanjan Roy authored
We're running system health benchmarks on FYI bots to support development of experimental TBMv3 metrics. We realized the abridged version didn't include any accessiblity story, so we could not test the accessibility metric. In general, since we're interested in making sure TBMv3 metrics work well across a wide range of scenarios, it's best to turn on the non-abridged version so we can detect any strange errors early on. If the load on the bots proves to be too much we can rollback and manually pick a better subset of stories. Change-Id: I7c2538b36b41b414a33ade5749a2953603602914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388262Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Deep Roy <dproy@google.com> Cr-Commit-Position: refs/heads/master@{#803600}
-
Thomas Lukaszewicz authored
This CL updates the Tab Search keyboard shortcut to use the same code path as the TabSearchButton. This is necessary to ensure that the button is triggered correctly when the UI is invoked and prevents multiple instances of the UI from being created per browser window. Bug: 1099917 Change-Id: I3f31b0c6ba1620ca77a2197bd71a1241b904bb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387199Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#803599}
-
Kyle Horimoto authored
Removes oppressive language from //chromeos/components/tether. Bug: 1123072 Change-Id: I570c8e252828e6688cbb854ffedf28a7434521e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387340 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803598}
-
Kyle Horimoto authored
Renames |master_symmetric_key| to |session_symmetric_key|. Bug: 1123072 Change-Id: I1a13116206214e95d6bd43e3d9fc01b5b7ac4811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386462 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803597}
-
Mila Green authored
Bug: 1112522 Change-Id: Idcae3a8103e817fd1c70394a21680df4e6621163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387431 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#803596}
-
Fabio Rocha authored
Change-Id: Iec9da11c762c8090a8ef77110c802d766eb9704d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387486Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803595}
-
Evan Stade authored
When an intent attempts to start MediaSessionService but WebLayer has not been loaded, the service will no-op instead of throwing an exception. Bug: b/167388918 Change-Id: I0f191d0f620016c8ee072e0953d10ad1c257fa15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388404Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#803594}
-
Becca Hughes authored
This is a reland of 3bd3ee29 TBR=dcheng@chromium.org,msramek@chromium.org,steimel@chromium.org Original change's description: > Add public side implementation of "frameless" module > > Using the frame on the NTP to load the data is too > slow for what we want to do so this removes the frame > and does the fetching in C++ instead. The deserialization > and business logic is still handled by the JS but on > the NTP instead of in a child frame. > > BUG=1121360 > > Change-Id: Idad8c9403fd51cccaf4a8edff31d244ac2642432 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373384 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803181} Bug: 1121360 Change-Id: Id38f58f88d624002ee06a2e41fcc38316db92ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387197Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803593}
-
Liquan (Max) Gu authored
This reverts commit 124fb902. Reason for revert: The tests were disabled on Marshmallow because they were caused by crbug.com/1094008. Now that the root issue has been fixed, I am reenabling the tests. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2274329 Bug: 1101030 Change-Id: I2e8745df2cccc4aad9f42b822f3787841679875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380071Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803592}
-
Moe Ahmadi authored
Moves the logic to demote autocomplete matches with headers to ACResult where it is called after matches are deduped and sorted and before they are culled. This step needs to happen before matches are culled so that matches with higher relevance (remote ZPS) can be used to backfill matches with lower relevance (local ZPS) before the lower relevance ones are thrown away. The latter is a requirement for the Trending suggestions experiment. Also addresses a technical debt by grouping the matches with headers in addition to demoting them to avoid interleaving of groups. Bug: 1122669 Change-Id: Iba9fb9d02bc7ddd07805cfd31e32a84604da077c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386839 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#803591}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a4ec7f6e5af7..168986591cc1 2020-09-01 navil@google.com dependency: relevancy check should account for directories. 2020-09-01 dhaddock@google.com auto_updater: Remove code for getting the hostlog files. 2020-08-31 stevenjb@chromium.org cros_flash: Always log the SDK version 2020-08-31 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-30 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-30 gbiv@google.com scripts: add initial tricium clang-tidy bits 2020-08-29 andrewlassalle@chromium.org dlc_lib: Add galaxy board as test board 2020-08-29 gbiv@google.com osutils: add Path tests for CopyDirContents 2020-08-29 gbiv@google.com osutils: accept `Path`s in RmDir 2020-08-29 lamontjones@chromium.org api: regenerate python bindings 2020-08-29 gbiv@google.com osutils: add support for Paths in SafeMakedirs 2020-08-29 skau@google.com licensing: Add exemption for fuji-xerox printing package 2020-08-28 bpastene@chromium.org cros_chrome_sdk: Fix args.gn in out dirs when switching between flows. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I58310240a6becaf197ba51af2ab1bd4c0d7e7a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803590}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I25ea1361b9c9d921891b7e8fa05271808cb7d5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388265Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#803589}
-
Orin Jaworski authored
When the keyword button was clicked while a different suggestion was selected, the click was ignored. This CL fixes the problem by first selecting the appropriate suggestion and keyword button. Bug: 1117213 Change-Id: I3d900e0b610796a103f35c92bf44ce0d5e7e09b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387136Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#803588}
-
Lijin Shen authored
TBR=micantox@google.com, mcarlen@chromium.org Bug: 1123958 Change-Id: Ifea8ffdd73fc0204a2cb8a004378225691ebbcd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388149Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#803587}
-
Kyle Horimoto authored
This removes oppressive language from //chromeos/services/cfm. Change-Id: Ib8ad402716d5051bfae1f708432072c9e201b574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387421 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#803586}
-
Yue Zhang authored
This CL adds logic to TabbedNavigationBarColorController to update the navigation bar color based on scrim fraction. Also, expose TabbedNavigationBarColorController to scrim component by adding it to WindowAndroid user data. Right now there is no consumer for this part of logic so this CL should be no-op. Bug: 1119632 Change-Id: Ia0fa7fa881f86fb1270f9bde26a42d41da071594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378785Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803585}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/977b68ba4969..8ef8112b0c27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ramyan@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1123915,chromium:897470 Tbr: ramyan@google.com,tmartino@google.com Change-Id: Ibeea08482ba4e396bd6b6ab9e91cf3a98510d65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387437Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803584}
-
Sammie Quon authored
Second CL to allow chaining keyboard shortcuts. Follow up to crrev.com/c/2354798 which allows RootWindowDeskSwitch to handle more than two screenshots. This CL fills it out by handling taking third and fourth screenshots and placing them on the animation layer to get a nice smooth continuous animation. Tests in a follow up. Test: manual Bug: 1111445, 1068508 Change-Id: I33f4a26ae794fca799888953b23d617a9f8d0832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376418 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#803583}
-
Michael Hansen authored
The component is the first row on the subpage which displays the device name and the current user's identifier. Screenshot: https://screenshot.googleplex.com/8YdkgsFXnk3k3XH Specs in Carbon: https://goto.google.com/orazy Bug: b:154863194 Change-Id: Ib9d17426315c111c9ba855c22135f7f4c8d2c7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367651 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#803582}
-
Dana Fried authored
Bug: 1123809 Change-Id: Ifddfa6447685322b5a1fd3484718ddcdfa754c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387540Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#803581}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 87 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-11-30. TBR=chromium-metrics-reviews@google.com Change-Id: I2401e8caf4574aaa5bcbd799fdc8c4cd18bf97c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387556Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#803580}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63911905..f2e5606d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I195022cde8453c3fe75d513429678cac33005386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388300Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803579}
-
Regan Hsu authored
* PhoneHub tab in chrome://multidevice-internals includes new feature status dropdown. * Selecting a feature changes the feature on demand. Screenshot: https://screenshot.googleplex.com/7NwZJKgRF4WiNmT Bug: 1106937 Change-Id: Ibb53e737f29f4bc3e209928804cb2d1ff5876a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386322 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803578}
-
Mikhail Khokhlov authored
This metric will be useful to track CPU power optimization work. Bug: b/166816037 Change-Id: I7bbc7018345019db9f307b47ab7a8efbb61bb0b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388200Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#803577}
-