- 06 Oct, 2020 40 commits
-
-
Henrique Nakashima authored
Remove code and mark histograms as obsolete. Bug: 1123581 Change-Id: I66fabee84ecab2a40a45a25d85ed31a4a92798a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442900Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#814431}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Iac07646307622eaf3e6378e3a04205c5086127c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445497 Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814430}
-
Yuke Liao authored
Reason for reland: Original CL broke two classes of builders, and they have been fixed: 1. Third party projects, such as ANGLE, and the fix was landed in: https://chromium-review.googlesource.com/c/chromium/src/+/2427423 2. Code search builders, and the fix is in patchset #2. This CL is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/2416999. This CL supports also_build_ash_chrome arg to allow building ash-chrome in an alternate toolchain. A few other fixes are required to work, but they will be landed in separate CLs because they could affect existing builds, so landing them separately will make it easier to reason and detect potential breakages. Bug: 1129223 Change-Id: I5a29eef63a12a622d512f74d23098720aa9530aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425201Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#814429}
-
chinsenj authored
When users select a capture region in Capture Mode, they can fine tune it. To make this process more precise, we display a magnifying glass at their cursor. Currently the MagnifierGlass uses hard-coded values to draw its border which don't match Capture Mode's spec. This CL refactors MagnifierGlass to take parameters for its border so the magnifying glass for the capture region can be up-to-spec. Test: manual Bug: 1133751 Change-Id: I4867176e4a32e9f8271cf1168846caf37ca5d6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454269Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814428}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metatada from OWNERS files for //rlz. R=rogerta@chromium.org Bug: 1113033 Change-Id: I4312267fdb91685d312da369c56b192bbd8d4937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453448 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#814427}
-
Trevor Perrier authored
This CL adds some simple logging in AppLocaleUtils to observe what language splits are available to the application and what the override locale should be. Bug: 1128698 Change-Id: I95190ea9779cb562b3eea6b50f91e34b29cf1e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453954Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#814426}
-
Dale Curtis authored
R=liberato Fixed: 1134146 Change-Id: I0792f30c252eb8773b5c38a1e72ffb5c5c91cbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453917 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#814425}
-
Kai Ninomiya authored
With Dawn buildfixes for breaking Tint changes. Tint: https://dawn.googlesource.com/tint.git/+log/464928ed913b..90ee6c436017 Dawn: https://dawn.googlesource.com/dawn.git/+log/e85652b61d42..6620efb9a84f Bug: none TBR: enga@chromium.org Change-Id: I65120659c0c6c993270f9c394c06b5b57f83fd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453803Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814424}
-
Mehran Mahmoudi authored
When upgrading to the live tab, the paint preview can keep flinging. We need to disable this, among all other user inputs to avoid confusion. Bug: 1135688 Change-Id: Id3f25972f75a00bdbf070986ee0c4a529a6f3f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453496Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814423}
-
Michael Li (EDGE) authored
Bug: 1133844 Change-Id: I5c0c5baa21e591db236cebba80697eb75f9612ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450073 Commit-Queue: Michael Li <michli@microsoft.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814422}
-
David Dorwin authored
More tests will be added in future CLs. Also extracts TestLogListenerSafe for reuse and adds support for starting WebEngine for tests without redirecting logging as required for the new test to work. Bug: 1051533,1133984 Change-Id: I709dcecc82c5c4b5648c2c25a3bbf64dc7090cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440980 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#814421}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I0fa8b098db5e901aca896afb489c0d846bd700a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814420}
-
Meilin Wang authored
This CL makes the |ContinueBrowsingChip| focusable during tab traversal and adds a focus ring for it with a desired shape. Screenshot: https://screenshot.googleplex.com/8FbCDLZShLMsSUe.png BUG=1106937,1126208 Change-Id: I2aff8afe936de2b6861dd1568ae17200f3b34d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451323Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#814419}
-
Brian Geffon authored
When handling userfaultfd faults UFFDIO_COPYRANGE and UFFDIO_ZEROPAGE can both return -EAGAIN when memory mappings are changing. It will continue to do so until the event which was causing the change is read from the userfaultfd. This introduces a simple mechaism for fault handlers to return false when they couldn't handle a fault due to a -EAGAIN. Those faults will be queued and redelivered later. Bug: chromium:1067833 Change-Id: I6ef5ce6ded969be95d320c02bad5e33b91de6a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450702Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#814418}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b5b5a87753a..1432250e2c60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC domfc@google.com,fernandex@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: domfc@google.com,fernandex@google.com Change-Id: Ib363a02bb57ee1bff2adb27df037828e8dc156f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452601Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814417}
-
Muyao Xu authored
A "stop casting" button will show up for cast media notifications, which can be used to stop the Cast session Bug: b/161612403, 1107161 Change-Id: I677f32383e0ce213483333dcddf94c36bc4f2b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444509 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814416}
-
Tommy Martino authored
Cryptid rendering should be disabled whenever a Doodle is displayed. Currently, this condition is occasionally violated due to caching: we sometimes receive a cached response that there is no logo, followed by a fresh indication that actually there is one, but the first will have triggered cryptid rendering, causing overlapping. This CL solves this bug by invoking the OnLogoAvailable callback in the LogoService in the Revalidated case (which corresponds to a confirmation from the server that no logo is available), and tightening the conditions in NewTabPageLayout to pick up this new invocation. Bug: 1125889 Change-Id: Iceb36ebd5aa6eaebe6ec4064951eac4c3510feb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443890 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#814415}
-
Andrew Comminos authored
Requires strict cross origin isolation for the JS Self-Profiling API. Bug: 956688 Change-Id: I63e2bd9b51c264f7fc1bc0844ab0c0d0bc40829d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441533 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814414}
-
Ben Goldberger authored
Bug: 1099982 Change-Id: Idf30918efdc2710a7bf009e725b3c63f92486843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446355 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#814413}
-
Dave Tapuska authored
Testing Pepper Lock Mouse (for appropriate cleanup of RenderWidget) revealed I accidentally removed a line in https://chromium-review.googlesource.com/c/chromium/src/+/2446593. Verified with out/Release/chrome --register-pepper-plugins="out/Release/libppapi_example_mouse_lock.so;application/x-ppapi-example-mouse-lock" ppapi/examples/mouse_lock/mouse_lock.html BUG=1134674 Change-Id: Ibce92521985f6dbde4f8a210169d8f6fe5198912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453903Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#814412}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a3b213595b36..635de036d766 2020-10-06 srisser@google.com Replace WARN with a LOG_TRAP 2020-10-06 srisser@google.com Reflect VK_KHR_create_renderpass2 being core If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic6b4d7541d42d0650a6b53c54b12607077fb1048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454154Reviewed-by:
-
Jamie Madill authored
We don't have the CrOS run wrapper in place to be running these tests. Diasable them for now. Bug: 1135720 Bug: angleproject:5124 Change-Id: Iec032e0e5f0364fd9cc70caaac8e7ff726092032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454293Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814410}
-
Kartik Hegde authored
Tests whether the HTTPS latency is within established tolerance levels for the system. BUG=chromium:956783 TEST=unit_tests --gtest_filter=HttpsLatencyRoutineTest* Change-Id: I7a28b103321f9c62dc21c660a60cc4c7487534a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378664 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#814409}
-
Nina Satragno authored
Wire up the WebAuthn largeBlob extension `read` parameter for navigator.credentials.get. At the moment, no decompression of the data takes place. This patch also modifies GetAssertionRequestHandler to copy and specialize the request per-authenticator, similar to how the equivalent for MakeCredential works. This feature is guarded behind the WebAuthenticationLargeBlobExtension feature flag. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I8f15fe41e14ad71413ddb395c974483cf81c3de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446524 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#814408}
-
James Hollyer authored
There is a period of time before macOS gives us a signal of our location permission status. During this time we mostly assume that we do not have permission. This is mostly not even noticed by the user as it happens to quickly. However, if we dont have permission for location we start an animation to let the user know. This animation does not stop once permission is determined so it is very noticeable. This change only starts that animation once permission is actually determined. Bug: 1134741 Change-Id: I3af75da2b5fcfc80aa5f42d9e5aa88e8ee74d829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446023Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#814407}
-
Lei Zhang authored
This is a manual revert of https://crrev.com/810169. The linux-chromeos-rel trybots have Clang code coverage enabled. This causes the static initializers check to generate false positives [1] in some cases. Since there is no proper immediate solution, stop running the static initializers check to get it out of the way of landing CLs. [1] https://crrev.com/c/2450491 Bug: 537099 Change-Id: I6ce647aba388925fcb4ea4622128f2687d909b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454391Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#814406}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0faa4a3d2e56..82962a0d7aa7 2020-10-06 jmadill@chromium.org Capture/Replay: Complete RasterizerState capture. 2020-10-06 jmadill@chromium.org Add a --no-finish option to the perf tests. 2020-10-06 jmadill@chromium.org Capture/Replay: Fix temp shader ID. 2020-10-06 m.maiya@samsung.com Vulkan: Add OES_sample_shading extension support 2020-10-06 jmadill@chromium.org Perf Tests: Run at least 1 step. 2020-10-06 ianelliott@google.com Vulkan: Plumb OpenGL ES commands to AGI/debuggers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Iee8778a5354424913b4dcbbf56fe6f2dbc9e86e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453325Reviewed-by:
-
Angela Yoeurng authored
This CL adds a vertical bar on the left hand side of a suggestion to indicate focus state. This is gated behind the omnibox-refined-focus-ui feature flag. Bug: 1129612 Change-Id: I06dfa60a41e4efceafe6071cb39bfd681a92e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446713Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#814404}
-
Xianzhu Wang authored
- Add a mode of PaintChunkSubset defined by a chunk index range. This will be used to represent the paint chunks painted by a pre-composited layer (GraphicsLayer). - Let PaintChunkSubset hold a reference to the PaintArtifact, so that we can see all the painted result with a PaintChunkSubset, without needing to pass a PaintArtifact along with a PaintChunkSubset. - PaintChunkSubset can iterate not only paint chunks, but also display items in each chunk. Bug: 1132717 Change-Id: Ic97ec3d23803ebe084ebecc5079e1826d3b15b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447120 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814403}
-
Stephanie Kim authored
Analyze step is erroring: https://ci.chromium.org/p/chromium/builders/try/mac_chromium_11.0_rel_ng/22 nacl tests is specified in Mac Builder Next waterfall, but 11.0 trybots didn't have nacl enabled in mb_config Bug: 1135351 Change-Id: Ic3dbc55aa5257e6e801a879c1a32450fb2c940aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453499Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#814402}
-
Frank Liberato authored
NOTRY=true NOPRESUBMIT=true TBR=aleventhal,dmazzoni Bug: 1135795 Change-Id: I732949a7be9ec83e20b1814bc9ae71b041b0ac08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454489Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I1bcbaec983739d77189ff7a0f78d4079870380b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453922Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814400}
-
Mike Wittman authored
Re-enables the profiler at a low rate on the render thread in Android ARM32 canary, to test the hypothesis that the crashes seen in https://crbug.com/1135152 were due to the module loading occurring after sandbox initialization. The re-enabling moves ~50ms of work onto the main thread so is intended to be landed only temporarily. Bug: 1135152, 1004855 Change-Id: I66f71aa391c5f3369c77ef8ca1d7866221d9c66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453795Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814399}
-
Michael Hansen authored
The original change was reverted due to a test failing on linux-chromeos-dbg. Reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/2448510 The fix was to remove the browsePreload() override so that the test starts on chrome://os-settings to ensure that strings.m.js is loaded. Original change's description: > [Nearby] Validate device name in onboarding. > > This adds support for validating the device name that a user enters > during the Nearby Share onboarding flow. Validation happens as the user > types and also when they try to proceed to the next screen. If an > invalid name is detected, an error message will appear and the "Next" > button will be disabled. > > Screenshots: > https://screenshot.googleplex.com/3USR7ftg7QCwJhR.png > https://screenshot.googleplex.com/6Cr6pedUxWnUKju.png > > Bug: b:169582004 > Change-Id: I07d4822e0ea099b30d23ed34a5f70f01940a3009 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441150 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Michael Hansen <hansenmichael@google.com> > Cr-Commit-Position: refs/heads/master@{#813193} Bug: b:169582004 Change-Id: I48e1aa7325db74f673cb3e6bc60de49ca8b7af9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448665Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#814398}
-
Brian Malcolm authored
For managed users/devices, the manager for Dasher organizations will be a domain name (foo.com), but for FlexOrgs it will be an email address (user@foo.com). BUG=chromium:1081272 Change-Id: Ia5fe346a88c7e4d147a3d7e2182118ac84b3b54b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450726Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#814397}
-
Vladimir Levin authored
This patch ensures to restore a forced graphics update which is skipped when the layer is locked. This is a speculative fix for the referenced bug. TEST=Unfortunately, it seems to be a rare case that I cannot reproduce Bug: 1133244 Change-Id: I5526e2fb8fe52b598ba7eda7fe2159fe20047659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452929 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814396}
-
evliu authored
This CL removes the SODA builder test definitions from the Chromium repo as they will be added to the src-internal repo. Bug: 1122784 Change-Id: Id5bc7d77c1a61294c62fe49c8339dbd9a1b233c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453907Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#814395}
-
Tibor Goldschwendt authored
These histograms let us analyze usage of the shopping task module in more granularity than what NewTabPage.Modules.Usage.shopping_tasks allows. Bug: 1133904 Change-Id: Id7470f6b2f0cbb7553dba406e57d5f62afd788c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443392Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#814394}
-
Robin Lewis authored
When cloud policies is enabled, GCPW will try to read the list of allowed domains from Omaha policy if they have been fetched already. If not it will fall back to the registry entry as before. Bug: 1134817 Change-Id: Ia68a799af2216898e10e0c25ac94fbb2421e5afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446546Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#814393}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601985365-aec4f74ada9d9ee3d8abbdb4ce83b168ed5b8f37.profdata to chrome-linux-master-1602007017-f47632c7e04b048b996f98c97bed5ef2bab09ddf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I39546a1ebbcb36c75f9e4f6bc431fed4f4b73fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454151Reviewed-by:
-
