GitLab

Bug: 740842
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia7513ab41b6e684fec446d4f6232b4e29f09b0f5
Reviewed-on: https://chromium-review.googlesource.com/577975
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488166}

Bug: None
Change-Id: I2539556dbeafe0545dfd618ac74f45975e4b8614
Reviewed-on: https://chromium-review.googlesource.com/562819Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488165}

The NetworkChangeNotifier owns an object that checks it is destroyed
on the correct thread (HistogramWatcher). This requires the object
to be destroyed before the thread is stopped, so add helper function
to control when the NetworkChangeNotifier is destroyed.

For the same reason, do it also for MessageLoopForUI.

Call the new function from WebMainLoop destructor. This fixes a new
regression that was introduced during the refactoring of this code
that moved the object destruction till after the "main" function
returns (as they are owned by "static" globals).

To ensure the destruction happens in the same order as before the
refactoring in https://chromium-review.googlesource.com/558268,
use base::ScopedClosureRunner to register in which order the helper
functions are called.

As CroNet code was leaking those objects, do not add a call to the
destroy function there.

Bug: 746478
Change-Id: If2e5d1dea15c73bccd973222f9811660a5687b77
Reviewed-on: https://chromium-review.googlesource.com/577851
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488164}

The AutofillWebDataService APIs can be consumed on any thread, not just the DB
thread, so it's not necessary to post to the DB thread to call them.

The AwFormDatabaseService itself is only accessed on one thread, and blocks
while it has an ongoing HasFormData() call, so there can't be multiple requests
in-flight at once.  This lets us remove the entire result map.

Bug: None
Change-Id: I7b6cd5272cb569d00fcd4cc6f89f22082100184c
Reviewed-on: https://chromium-review.googlesource.com/578298
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488163}

Does not open a separate browser tab for SAML auth anymore, but moves
the auth page into a webview in the support app.

The old code (ab-)used the ToS negotiation code path to display the
AD auth page. The new code uses the authentication code path already
used by LSO auth. Apart from being clearer, this has the advantage
that Chromad Tier 1.0, which doesn't require SAML auth, does not pop
up any page. It also gets rid of an interstitial page. As soon as
SAML SSO is supported, we should be able to hide the page completely.

Reskins the AD auth screen to match the OOBE design.

BUG=chromium:719874
TEST=out/Release/unit_tests --gtest_filter=Arc*

Change-Id: I3d6b09c89ac41ef7e14c5e08adbaec146df98710
Reviewed-on: https://chromium-review.googlesource.com/569967Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488162}

Bug: 740842
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8a0826a93cb36588bda03b5acfbf633c35d8d11e
Reviewed-on: https://chromium-review.googlesource.com/577978Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488161}

BUG=667892

Review-Url: https://codereview.chromium.org/2952133002
Cr-Commit-Position: refs/heads/master@{#488160}

Remove the deprecated ChildProcessHost::CreateChannelMojo overload
and migrate its final user (service utility process) to the other
overload. This requires the service process to directly connect to the
service_manager.mojom.Service interface to bind interfaces and claim to
be the browser service when binding interfaces so ChildThreadImpl allows
the IPC bootstrap request.

Change replay process to support the non-deprecated approach of using
the initial mojo handle as a service_manager::mojom::ServiceRequest.

Change chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
to define its own constant for the channel token and remove the shared
content::switches::kMojoChannelToken.

Bug: 666605
Change-Id: Ib0721eecae5f53373262d320ebeb23745b62c7c1
Reviewed-on: https://chromium-review.googlesource.com/564914Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488159}

Since we can split marking SelectionState and invalidate painted
 LayoutObject.
SelectionPaintRange has both info but we should split it.
This patch introduces SelectionMarkingRange which is just
 copy from SelectionPaintRange class.
I will drop unused functionality from each class in later patches.

Bug: 739062
Change-Id: I6ffececbf96228f1b7593ac82e49632b1a348760
Reviewed-on: https://chromium-review.googlesource.com/578701Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488158}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2e867917..0850262f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I5f911c135d6900cd0be45a25aca76b93226b3e11
Reviewed-on: https://chromium-review.googlesource.com/578399Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488157}

We previously removed the optimization that this option turned off but
forgot to remove the option. It currently does nothing, so removing it
is a no-op.

Change-Id: Iefe122b9351dbe06f88fec098d4267b789b8e786
Reviewed-on: https://chromium-review.googlesource.com/578245
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488156}

Bug: None
Change-Id: I939a06f5d554101cea344f092f8de63bfb15e758
Reviewed-on: https://chromium-review.googlesource.com/575113
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488155}

This reverts commit 0627c931.

Reason for revert:
Link failure on some Windows bots.
e.g. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_Builder%2F42057%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original change's description:
> Remove unnecessary #includes from Assertions.h
> 
> Change-Id: I9d9a0ff0c56a10923e393d4eef7ccde7b33c4a2b
> Reviewed-on: https://chromium-review.googlesource.com/578532
> Commit-Queue: Yuta Kitamura <yutak@chromium.org>
> Reviewed-by: Yuta Kitamura <yutak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488149}

TBR=yutak@chromium.org,tkent@chromium.org

Change-Id: If9b9b1ada6a3b45bd3a670b9aaab908401530e9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/578829Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488154}

The issue which made this test flaky has been fixed in
https://chromium-review.googlesource.com/c/559769/, so we can turn this
test on again.

R=bsep@chromium.org

Bug: chromium:736676
Change-Id: I423782d2cd1f299f40a70a1f1595b573fa7646c2
Reviewed-on: https://chromium-review.googlesource.com/576033Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488153}

Calling one of these APIs results in creating a WebDataRequest object to allow
calling back with the result.  This object assumed the caller had a
ThreadTaskRunnerHandle, but there's no reason callers need to have such a
handle.  Instead, allow calling any task back, using the thread or sequenced
task runner if available, or simply PostTask() if not.

Bug: 689520
Change-Id: Icf901e6de5a5b629bcf9d17617baf46a45502844
Reviewed-on: https://chromium-review.googlesource.com/578572
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488152}

Only WebSocket connections from the main page were tested. WebSocket connections
from Workers should also lead to display of an interstitial.

Modify malware_websocket.html to accept a "type" query parameter indicating
which environment to create the WebSocket in. Make the MalwareWebSocketBlocked
tests be parameterised on the environment type.

Due to a recent change (https://codereview.chromium.org/2960703003), these
changes need to be tested by passing --enable-features=NetworkService to
browser_tests, as opposed to the --enable-network-service argument that was
needed before.

BUG=644744

Review-Url: https://codereview.chromium.org/2971333002
Cr-Commit-Position: refs/heads/master@{#488151}

This change adds a general window that overlays other windows, initially for the use case of picture in picture. This includes a partially stubbed views implementation. Cocoa work will be done in a separate CL.

BUG=726621

Review-Url: https://codereview.chromium.org/2905833004
Cr-Commit-Position: refs/heads/master@{#488150}

Change-Id: I9d9a0ff0c56a10923e393d4eef7ccde7b33c4a2b
Reviewed-on: https://chromium-review.googlesource.com/578532
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488149}

Network traffic annotation is added to network request of:
content/browser/frame_host/render_frame_message_filter.cc

BUG: 656607
Change-Id: Ie68e036d5e00aaf4cad0966e6a5e0ce2a1d624b0
Reviewed-on: https://chromium-review.googlesource.com/570029
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488148}

TBR=yzshen@chromium.org
NOTRY=true

Change-Id: I9d8fe29dc0a840e98d070164bb1171334cc32464
Reviewed-on: https://chromium-review.googlesource.com/578660
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488147}

The word-break:keep-all code was forked in [1]. This patch merges it
back to single template function, in preparation of supporting
after-white-space in LayoutNG.

Includes some cleanup to make IsBreakable() inline function smaller
without increasing non-inline function calls.

[1] https://codereview.chromium.org/1094863007

BUG=636993

Change-Id: I6471b83437e29f5ee2fcb30473c8eb8d526abf35
Reviewed-on: https://chromium-review.googlesource.com/575799
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488146}

We then change the style of all elements in the tree and benchmark the
time spent. This allows us to set up a benchmark for style manipulation
done using selectors.

This adds test to apply pseudo selectors on:
1. Children of elements
2. Grand children of elements
3. All elements (universal selector)
4. Checking for partrial match for an attribute

Bug: 741970
Change-Id: Idb1cb91fbbcc20044cf902bb5e193cb7a73343e0
Reviewed-on: https://chromium-review.googlesource.com/577330Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488145}

This patch adds an OWNERS file to the code generators found in
core/css. Currently there's only one file in that folder but this will
grow as we move css related code generators into that folder.

Bug: 732657
Change-Id: I5987cba699416d40194c029fd7621b1c269b6ef3
Reviewed-on: https://chromium-review.googlesource.com/574898
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488144}

https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#clamped-to-the-range

We had a bug that an attribute value greater than 2^32-1 was handled as a parse
error, instead of range overflow. We need to clamp such values to a maximum
value defined for a attribute.

Implementation:
The main change is to introduce blink::ParseHTMLClampedNonNegativeInteger(), and
use it in HTMLTableCellElement and HTMLTableColElement.

This CL introduces WTF::NumberParsingState in order to pass "fail by overflow"
information from platform/wtf/StringToNumber code.

Bug: 745376
Change-Id: Ie57a0538816f0f508324573cdcda6d96ad51afb2
Reviewed-on: https://chromium-review.googlesource.com/577428Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488143}

Moves the details text in with the title and the remove button.
Files to remove list now is a toggle instead of a expand-once section.

Bug: 690020
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0301598d48ce2734f9bda0b7a96993cdc2040978
Reviewed-on: https://chromium-review.googlesource.com/576382
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488142}

This reverts commit 5192ab32.

Reason for revert: crbug.com/746616 TL;DR: we're listening for compositor frame swap on browser-process compositor instead of on the renderer-process compositor (which composites the page, instead of the browser UI).

Original change's description:
> [Installed PWA] Waits for a frame swap before hiding a splash screen.
> 
> This patch fixes the flash of white between the splash screen and the
> web content in installed web apps. This is achieved with waiting for
> a compositor frame swap before starting splash screen hiding animation.
> 
> Adding callbacks for next frame swap in CompositorViewHolder might not
> be at the right level of abstraction - feedback welcome. I introduced
> a generic mechanism as we might need it different places as well.
> E.g. In CustomTabActivity the same issue is solved with a time delay,
> which I plan to change to this mechanism in a follow up patch.
> 
> Existing tests for a webapp splash screen cover showing/hiding it in
> various circumstances. Writing a specific test to assert flash of white
> is fixed would be more work than it's worth it.
> 
> FYI: On Google Pixel this causes the splash screen to be shown about
> 50-100 later, which seems like the time time when flash of white was
> visible.
> 
> Bug: 734500
> Change-Id: I70f8bde54f251c283e260d17a291685738f9e080
> Reviewed-on: https://chromium-review.googlesource.com/569552
> Commit-Queue: Piotr Swigon <piotrs@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487336}

TBR=mdjones@chromium.org,khushalsagar@chromium.org,dominickn@chromium.org,piotrs@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 734500
Change-Id: Ib8afce105fa818b76492b8fce7da7d17c8e07e6a
Reviewed-on: https://chromium-review.googlesource.com/578631Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488141}

BUG=738595
TEST=existing tests pass
TBR=wolenetz

Change-Id: I1076fc1a74b7064bff021c5c124f20216fc0867e
Reviewed-on: https://chromium-review.googlesource.com/578656Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488140}

Bug: 706046
Change-Id: I9bd0ff5d297f93ff3dbdc92f668c307630d46dc5
Reviewed-on: https://chromium-review.googlesource.com/578659
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488139}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5d7e07ff..2e867917

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I3e0211807103e7f6ce58386936e75d5570825d22
Reviewed-on: https://chromium-review.googlesource.com/578396Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488138}

https://pdfium.googlesource.com/pdfium.git/+log/67ccef73bf66..40870db0aade

$ git log 67ccef73b..40870db0a --date=short --no-merges --format='%ad %ae %s'
2017-07-19 drgage Add FPDFAnnot_GetFormFieldAtPoint() and embedder tests.
2017-07-19 drgage Add FPDFAnnot_GetFormFieldFlags() and associated embedder tests.
2017-07-19 tsepez Rename StringCs c_str() to unterminated_c_str().
2017-07-19 caryclark fix continue skia cache flush
2017-07-19 dsinclair Remove unused GetThisAppearanceStream
2017-07-19 dsinclair Create CPWL_AppStream.

Created with:
  roll-dep src/third_party/pdfium
BUG=59266,59266


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: If4c2a89080c44d782e6ae44431cfd20c33b2ffff
Reviewed-on: https://chromium-review.googlesource.com/578678
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488137}

Bug: 745958
Change-Id: I87c0de5d5c7e9d5fc8b6fd38d95dec8013934db8
Reviewed-on: https://chromium-review.googlesource.com/576359
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488136}

This CL lands the client-side implementation of the mojom::VEA
and unit tests for it. It doesn't connect it yet, but the 
final result can be found in https://crrev.com/c/558846.

Bug: 736517
Change-Id: I24f29c8893c59e1f16560026e0ed94b611b0651a

TBR=tsepez@ for adding [Sync] to the mojom interfaces
(that anyway reflects the current IPC).

Change-Id: I24f29c8893c59e1f16560026e0ed94b611b0651a
Reviewed-on: https://chromium-review.googlesource.com/566145
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488135}

On OnMemoryDump, base::SharedMemory's IDs are used to create ownership
edges. However, there is no guarantee that the ID is still valid when
OnMemoryDump is called. Actually, some crashes [1] are found when
MemoryAllocatorDumpGuid::UseSharedMemoryBasedGUIDs() is true [2].

This CL fixes this bug to avoid dumping when shared memory id is
invalid (empty). Also, this CL changes OnMemoryDump use SharedMemory::
mapped_id(), that returns an valid ID only when the shared memory is
actually mapped, so that we can avoid unnecessary dumps.

[1] https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/501311
[2] This is now always false, but we plan to make this return true to
    use new ownership edges.

Bug: 604726
Change-Id: I2400ba334860e57b9b83a785cd69f4a32b8ef151
Reviewed-on: https://chromium-review.googlesource.com/571386Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488134}

Certain permissions are always denied for insecure (HTTP) origins, and
notifications is one of them. Fix SiteDetails.DefaultSettingSource by using a
secure (HTTPS) test origin instead.

This is to fix a test that broke after r488086 landed.

Change-Id: Ieac59f3ff7b19dd64d0d299fb678ce7f6e9ec89e
TBR: dschuyler@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/578534
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488133}

Now it is equivalent to domain == "net" && reason == ERROR_ABORTED.

Bug: None
Change-Id: Ia39d123a8a15d79a3efbcc86fd1c70f225c51439
Reviewed-on: https://chromium-review.googlesource.com/575112Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488132}

Bug: 706071
Change-Id: Idcf5feefa594463a1b7295dd30025c1cbc489345
Reviewed-on: https://chromium-review.googlesource.com/578227Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488131}

These will help us understand user translate behaviour and how it is affected
by various UI decisions. We don't log the cross
(source language, target language) as there are too many combinations to use as
histogram buckets.

Bug: 742684
Change-Id: Idf6a72a6418db820431e75ba1982f260d92bad21
Reviewed-on: https://chromium-review.googlesource.com/572486
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488130}

The attempt to restore this feature in r469749 did not quite do the job
and has several issues.

BUG=731600,740830,746768

Change-Id: I417611e32e6d3e1bb29c96f6e5de6eee39abc846
Reviewed-on: https://chromium-review.googlesource.com/577374Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488129}

This CL replaces last use of MockCryptohomeClient by fake,
and then remove it.

BUG=739622
TEST=Ran trybot.

Change-Id: I9477b540b40789c663657147b8172f5ae189dfc3
Reviewed-on: https://chromium-review.googlesource.com/571244
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488128}

Two changes have landed recently which need to be reflected in
documentation for origin trials:

- Trials are disabled automatically in the virtual test suite, and do
    not have to be named explicitly in VirtualTestSuites.
- V8 bindings code is now generated automatically

This documentation change brings the developer docs up to date with reality.

BUG=685788, 615060

Change-Id: Icec69074b654bc749d790136de4e3a72855e3660
Reviewed-on: https://chromium-review.googlesource.com/578171Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488127}