GitLab

As of Blink r180944, Blink is no longer notifying the embedder of its
GeolocationController reference going away (as there's no need.) Follow
up and retire the notification implementation on the embedder side.

R=mvanouwerkerk@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/526123002

Cr-Commit-Position: refs/heads/master@{#292890}

https://chromium.googlesource.com/chromium/blink/+log/1954c458067aaa54cbfdbaa644903809cdfd7588..a437be840d7d26ff0cd4ee60d4cf048d78498de1
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/525423002

Cr-Commit-Position: refs/heads/master@{#292889}

MessageReceiver were given MessageWithHeader. This is incorrect as this
force validation code at the Connector level, while Connector should not
impose any format on the message it receives.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/525383002

Cr-Commit-Position: refs/heads/master@{#292888}

The timeout is now obsolete. The bubble stays infinitely if there is no user input.

BUG=394287

Review URL: https://codereview.chromium.org/520743002

Cr-Commit-Position: refs/heads/master@{#292887}

BUG=405016

Review URL: https://codereview.chromium.org/489183003

Cr-Commit-Position: refs/heads/master@{#292886}

Revert of Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remo… (patchset #1 id:1 of https://codereview.chromium.org/517803004/)

Reason for revert:
Breaks *lots* of browser_tests on Mac ASan. See e.g.:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%281%29&number=2036
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%282%29&number=2600
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Tests%20%283%29&number=2424

Original issue's description:
> Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.
>
> The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
>
> Unce upon a time the ASan runtime library used to be statically linked into
> the executables on OSX.
> Because that library provided a number of API functions needed by the shared
> libraries, we had custom ASan-specific .saves files that told the `strip`
> utility to preserve those functions when stripping the executables.
>
> Then ASan switched to using dynamic runtime library, which instantly broke the
> stripping step, because the executables weren't necessarily referencing all the
> ASan API functions (issue 242503).
> As a result, stripping has been disabled, and we haven't had .dSYM debug info
> for ASan builds for more than a year now (issue 148383).
>
> Because the ASan API functions are now undefined in the executables, it's
> actually senseless to use the .saves files to preserve those functions.
> This CL deletes the .saves files and turns mac_strip_release on for ASan
> builds.
>
> BUG=148383, 242503, 170739, 166857
> TBR=mark@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d5319a149964f953e7506c1ff2b33f90974d19ea

TBR=mark@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=148383, 242503, 170739, 166857

Review URL: https://codereview.chromium.org/522743003

Cr-Commit-Position: refs/heads/master@{#292885}

ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled needs to return false on Android, because there is no bubble for Android.

Unintentionally, I (vabr) misinformed dconnelly in https://codereview.chromium.org/444603003/diff/20001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode357 that IsTheHotNewBubbleUIEnabled is not compiled on Android at all, whereas the truth is, it is only not compiled for Androd WebView.
As a consequence, IsTheHotNewBubbleUIEnabled started to return possibly true on Android after https://codereview.chromium.org/505123002 landed, causing a crash on the bots.

BUG=328847,409622

Review URL: https://codereview.chromium.org/529743002

Cr-Commit-Position: refs/heads/master@{#292884}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/521303003

Cr-Commit-Position: refs/heads/master@{#292883}

This CL adds policy indicators to show that a protocol handler is installed by policy.

BUG=384361

Review URL: https://codereview.chromium.org/518673003

Cr-Commit-Position: refs/heads/master@{#292882}

This migration int -> float was still missing.

BUG=380463, 394315

Review URL: https://codereview.chromium.org/485103006

Cr-Commit-Position: refs/heads/master@{#292881}

https://chromium.googlesource.com/chromium/blink/+log/0f13ba4c4b4529d1118c049259c2fbbcaee50e07..1954c458067aaa54cbfdbaa644903809cdfd7588
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/530763003

Cr-Commit-Position: refs/heads/master@{#292880}

BUG=391005

Review URL: https://codereview.chromium.org/525493003

Cr-Commit-Position: refs/heads/master@{#292879}

Currently gamepad_seqlock_unittest.cc is not included in content_tests.gypi.
Also GamepadSeqLock was renamed to OneWriterSeqlLock some time ago as it
is used not only by the gamepad.
To rectify this situation this patch does the following:
- replace references to GamepadSeqLock
- include the unittest in content_tests.gypi

Review URL: https://codereview.chromium.org/507643002

Cr-Commit-Position: refs/heads/master@{#292878}

[Password Manager] Fix to recognise failed login attempt for sites where content server pushes new login form.

With current implementation chromium browser does not recognize the failed login attempt for sites where content server pushes different login form (e.g. http://www.xda-developers.com), and apparently it assumes a login success and offers to save an incorrect password.

With this patch in addition to submitted form's action URL to that of visible form's action URL it ignores the schemes for HTTP or HTTPS URLs as well.

BUG=400769

Review URL: https://codereview.chromium.org/488083002

Cr-Commit-Position: refs/heads/master@{#292877}

https://chromium.googlesource.com/chromium/blink/+log/1cf1b6f4079b8fa8b7319d081de8f3031a0eee62..0f13ba4c4b4529d1118c049259c2fbbcaee50e07
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/524413002

Cr-Commit-Position: refs/heads/master@{#292876}

Call snd_ctl_close() to free all the resources allocated with
the control handle.

BUG=409016

Review URL: https://codereview.chromium.org/517363002

Cr-Commit-Position: refs/heads/master@{#292875}

The problem was introduced in https://codereview.chromium.org/110643005.
The URLBlacklistManager used to build the blacklist in the FILE thread
but it's now using the blocking pool; however, FlushBlacklistPolicy
wasn't updated to flush the blocking pool instead of the FILE thread.

This test (and the URL blacklist tests too) have been flaking now
and then on every bot but this race is extremely hard to trigger.
DrMemory on Windows was a consistent repro though.

BUG=339240

Review URL: https://codereview.chromium.org/520703002

Cr-Commit-Position: refs/heads/master@{#292874}

Analogically to CreateFile, we should just return an EXISTS error code if the
entry already exists. The EXISTS error code is later converted to OK if the
operation was requested to be not 'exclusive'.

TBR=benwells@chromium.org
TEST=browser_tests, unit_tests: *FileSystemProvider*CreateDirectory*
BUG=393141

Review URL: https://codereview.chromium.org/528683002

Cr-Commit-Position: refs/heads/master@{#292873}

Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.

The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.

Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.

Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).

Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions.
This CL deletes the .saves files and turns mac_strip_release on for ASan
builds.

BUG=148383, 242503, 170739, 166857
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/517803004

Cr-Commit-Position: refs/heads/master@{#292872}

TBR=qinmin@chromium.org
BUG=398669

Review URL: https://codereview.chromium.org/527033003

Cr-Commit-Position: refs/heads/master@{#292871}

Cr-Commit-Position: refs/heads/master@{#292870}

https://chromium.googlesource.com/chromium/blink/+log/46b3b608360a078fb8ddae2c3c22042eacbc2e87..1cf1b6f4079b8fa8b7319d081de8f3031a0eee62
TBR=hclam@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/530553007

Cr-Commit-Position: refs/heads/master@{#292869}

We check if we have camera or mic access when devices are enumerated to determine if labels should be visible or not. We must ensure all settings are checked when doing this.

* Add interface to ContentBrowserClient for checking media access permission. Add implementation in //chrome.
* Refactor permission checking in MediaStreamDevicesController to be able to use them from elsewhere.
* Add checking policy and app permission to the existing content settings check.
* Remove old interfaces on ResourceContext and its implementations.
* Move the permission check from MediaStreamDispatcherHost to MediaStreamManager.
* Refactor MediaStreamManager to be able to mock the check function and update unit test to mock it.

TBR=jochen@chromium.org (for a few trivial changes)

BUG=406094

Review URL: https://codereview.chromium.org/483523006

Cr-Commit-Position: refs/heads/master@{#292868}

See the issue (http://crbug.com/407392#5) for the image of restyled design.

BUG=407392
TEST=manually tested

Review URL: https://codereview.chromium.org/528733002

Cr-Commit-Position: refs/heads/master@{#292867}

BUG=407388
TEST=manual

Review URL: https://codereview.chromium.org/518843002

Cr-Commit-Position: refs/heads/master@{#292866}

This patch makes chromecast always bundle the frontend,
and exposes all content targets via remote debugging.

BUG=none

Review URL: https://codereview.chromium.org/517493003

Cr-Commit-Position: refs/heads/master@{#292865}

Revert of Update V8 to version 3.29.35 (based on bleeding_edge revision r23537). (patchset #1 id:1 of https://codereview.chromium.org/530683003/)

Reason for revert:
This makes DevTools in device mode crash silently (crbug.com/409604).

Original issue's description:
> Update V8 to version 3.29.35 (based on bleeding_edge revision r23537).
>
> TBR=jarin@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5c3fee7d50d3f5984d4462fef9cfce694e1ae8a9

TBR=jarin@chromium.org,machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/530763002

Cr-Commit-Position: refs/heads/master@{#292864}

1) Use hash in inputview url to support fast inputview switching.
2) Add 'm17n:' to m17n keyboard layout id to avoid conflicts (e.g. 'si' in XKB vs. 'si' in M17n)
3) Change layout IDs for Chinese IMEs to support future compact layouts.

BUG=254398,406979
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/473603003

Cr-Commit-Position: refs/heads/master@{#292863}

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/522653004

Cr-Commit-Position: refs/heads/master@{#292862}

Remove a bunch of code that is already longer used or
will become unused when https://review.webrtc.org/22149004/
and https://codereview.chromium.org/505153002/ are landed.

Remove hardcoded paths to the WebRTC isolate files to make
it easier for us to make changes to them, since we can pass
the path to the .isolate file on test execution instead
(keeping the configuration in the WebRTC buildbot recipe instead).
Previously we had to roll our Chromium revision in WebRTC DEPS
every time a change was made before it became used.

Add support for a CHECKOUT_SOURCE_ROOT environment variable
used to make it possible to override the hardcoded path traversal
that is done to find the src/ directory (since it's different for
WebRTC bots). I considered passing a flag into the test_runner.py
scripts instead of using an environment variable, but my opinion is
that it would pollute the code too much since
constants.DIR_SOURCE_ROOT is used in 70 different places.

BUG=webrtc:3741
TEST=local building and test execution using command lines like this:
cd /path/to/webrtc/src
export CHECKOUT_SOURCE_ROOT=`pwd`
build/android/test_runner.py gtest -s tools_unittests --isolate-file-path=webrtc/tools/tools_unittests.isolate

R=navabi@chromium.org

Review URL: https://codereview.chromium.org/500423004

Cr-Commit-Position: refs/heads/master@{#292861}

This CL removes:
- "Move window to..." menu item from the gear menu.
- Remove APIs fileBrowserPrivate.onProfileAdded and fileBrowserPrivate.onDesktopChanged as they are used only for updating gear menu.
- Remove corresponding tests.

BUG=408965
TEST=run browser_test, unit_tests
TBR=benwells@chromium.org
# TBRing for just removing unused events from file_browser_private.idl

Review URL: https://codereview.chromium.org/530553006

Cr-Commit-Position: refs/heads/master@{#292860}

BUG=408949
TEST=manually

Review URL: https://codereview.chromium.org/529693002

Cr-Commit-Position: refs/heads/master@{#292859}

https://chromium.googlesource.com/chromium/blink/+log/78807df2ce8a43f50941cee9ae05458df0cc05bf..46b3b608360a078fb8ddae2c3c22042eacbc2e87
TBR=

Review URL: https://codereview.chromium.org/526033002

Cr-Commit-Position: refs/heads/master@{#292858}

The hotwording checkbox was moved from the 'Privacy' section
of the settings page in https://codereview.chromium.org/382123004/

This cl moves it back to the 'Privacy' section and shows and hides
the 'Voice' section according to the enable-experimental-hotwording flag.

BUG=407893

Review URL: https://codereview.chromium.org/523573004

Cr-Commit-Position: refs/heads/master@{#292857}

Previously WebSocketFrameTestMaskBenchmark.* were included in
net_unittests (with a small number of iterations to avoid slowing down
testing). Move them to net_perftests.

Also remove the command-line option to control the number of iterations,
and use the standard base::PerfTimeLogger output instead of custom logging.

BUG=407445
TEST=net_unittests, net_perftests

Review URL: https://codereview.chromium.org/502353002

Cr-Commit-Position: refs/heads/master@{#292856}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/530683003

Cr-Commit-Position: refs/heads/master@{#292855}

R=navabi@chromium.org

Review URL: https://codereview.chromium.org/517983002

Cr-Commit-Position: refs/heads/master@{#292854}

This changes monitoring of video frames delivered to MediaStreamVideoSource to be started when the source is started and stopped when the source is stopped rather than depend on
that the source object is destroyed since destruction is dependent on when blink runs garbage collection.

It removes the unused MediaStreamVideoTrack::SetMuted and GetMuted.

It reduces the need for a thread hop between the io-thread and the render thread for each monitor intervall by only trigger the monitoring callback on if a change has occured.

It reduces the test time of media_stream_video_source_unittest.cc from more than 7s to around 200ms.

BUG= 404106

Review URL: https://codereview.chromium.org/509873002

Cr-Commit-Position: refs/heads/master@{#292853}

BUG=400674
TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/496703002

Cr-Commit-Position: refs/heads/master@{#292852}

This patch makes the method providing additional metadata for entries available
for provided file systems too.

NOTRY=True
TEST=Tested manually. Files app works as before.
BUG=408017

Review URL: https://codereview.chromium.org/515033002

Cr-Commit-Position: refs/heads/master@{#292851}