- 30 Oct, 2020 40 commits
-
-
Mohamed Heikal authored
This reverts commit 0a352eeb. Reason for revert: breaking chromium perf Original change's description: > Migrate chime dfm definition downstream (Reland) > > chime is a downstream only DFMs, it should be defined downstream only > and not reference clank from the chromium repo. > > Followup downstream cl crrev.com/i/3358245 > > This reverts commit ba4e63fc. > > Reason for reland: Will be relanding downstream cl immediately > afterwards skipping downstream CQ. > > TBR=agrieve@chromium.org,xingliu@chromium.org > > Bug: 1142775,1143787 > Change-Id: I9042358b942b233e8657306c339b6345e91913ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508471 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822685} TBR=agrieve@chromium.org,xingliu@chromium.org,mheikal@chromium.org,nuskos@chromium.org Change-Id: I913d35a325abfb1b74d5a272093707e4ef6d194c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142775 Bug: 1143787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510212Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#822699}
-
Chris Hamilton authored
This lets it be depended on by components that are indirect dependencies of blink/public/common itself, severing the circular dependency that otherwise arises. Change-Id: I8b0bed42775f8e17dd800ee425d701c9d85986fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503230 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822698}
-
Matthias Körber authored
This CL changes Autofill to use the import from a unified section by default. Change-Id: I36a3835ff7e9c069f1d21a5978909bc543ad2254 Bug: 1097125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505893Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#822697}
-
Nick Diego Yamane authored
Context: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This is a follow-up change, that implements the animation disabling for the dragged window when there is extended-drag source attached to the active DnD wl_data_source. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=oshima@chromium.org Bug: 1099418 Test: Manually tested. Change-Id: Ib16842e4d5ca1e5a1f24313ddaddbe3373cfbc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411159 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#822696}
-
Robin Lewis authored
Login enforcement is done only when cloud policies is enabled. Bug: 1142903 Change-Id: If870ec909122a39b18af33ff95f90b49ef72a198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503810 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#822695}
-
Andrew Xu authored
ClipboardHistoryBitmapItemView contains a pointer to a RoundedImageView instance which is the item view's grandchild. This CL removes the pointer to RoundedImageView from ClipboardHistoryBitmapItemView. Instead, the pointer is kept by BitmapContentsView, the RoundedImageView's parent. This change should not bring any visual difference. Bug: 1139498 Change-Id: Ie3e2dacd32dcd6500394278c01e1903c35b5f8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508797 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#822694}
-
Tim van der Lippe authored
Required for landing https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2503953 R=aerotwist@chromium.org Bug: 1143170 Change-Id: I05d92cb184326ed8a1574257d0419a67058a92d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504267 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#822693}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a8c01862f57f..42ad02798240 2020-10-30 jmadill@chromium.org Omit types in EVENT macros. 2020-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from a72e7b987746 to f673b4e6ebf3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I7995daf8698827deaab29110e333965067831bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510316Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822692}
-
Liquan (Max) Gu authored
Reason for revert: The original CL breaks the clank build. Changes after revert: No change compared to the original CL. The clank CL[1] needs to be merged first before landing this patch. [1] https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3370809 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2503890 Reverting CL: https://chromium-review.googlesource.com/c/chromium/src/+/2508954 Bug: 1144005, 1129572 Change-Id: I774f8561cd96e9b057d169c38013c4d277b72783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509015 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822691}
-
Nick Diego Yamane authored
Context: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This is the third of a patch series which implements extended-drag in Exo compositor. This one implements cursor locking options, required for Chrome's tab dragging, otherwise DragDropController would update the cursor shape based on the widget under the cursor accept DND operation or not, which is meaningless for tab/window dragging purposes. Refer to the design doc for more details. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=oshima@chromium.org Bug: 1099418 Change-Id: Ie41f487b26e2eda72dd5be25590d8565e6a5edcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401358 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
-
Lukasz Anforowicz authored
This CL re-enables CrossSiteDocumentBlockingTest.BlockForVariousTargets because we speculate (as explained in https://crbug.com/1075663#c15) that the root cause of the flakiness was unrelated to the test and has been fixed by r792326 which fixed raciness in NestedMessagePumpAndroid in July. Fixed: 1075663 Change-Id: Ie370c65671d9d498056ffb95c4e75e8940e8d1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508910Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#822689}
-
Elvin Hu authored
Bug: 1138715, 1141522, 1141524, 1141523 Change-Id: I3f483577c27383be01f5150b72ad1d323d097f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471577 Commit-Queue: Javier Flores <javierrobles@chromium.org> Commit-Queue: Elvin Hu <elvinhu@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#822688}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7060721b4ec0..cf5f19d0ea8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pmonette@google.com,mastiz@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pmonette@google.com,mastiz@google.com Change-Id: I275a207b797d271af6b65a7509c462e47a7684c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510430Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822687}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iea0a6bdc633cc960d9c93ab1202d158284fc5f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510326Reviewed-by:
-
Mohamed Heikal authored
chime is a downstream only DFMs, it should be defined downstream only and not reference clank from the chromium repo. Followup downstream cl crrev.com/i/3358245 This reverts commit ba4e63fc. Reason for reland: Will be relanding downstream cl immediately afterwards skipping downstream CQ. TBR=agrieve@chromium.org,xingliu@chromium.org Bug: 1142775,1143787 Change-Id: I9042358b942b233e8657306c339b6345e91913ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508471 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822685}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e184bf1e5f83..c1ca9469d705 2020-10-30 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseController.js with TypeScript 2020-10-30 andoli@chromium.org Refactor Sources.SourceMapNamesResolver._scopeResolvedForTest to proper accesor 2020-10-30 changhaohan@chromium.org Update popover state to only allow one popover in Styles pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1126178,chromium:1142525 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9237c014c3782dfb5ddd52ffdc4359807a698eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510318Reviewed-by:
-
Roman Arora authored
Bug: 1143854 Change-Id: Ia4e311d04b09c7d90191066f9ad8174bfe34ed58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508183 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#822683}
-
Nick Diego Yamane authored
Context: Wayland Protocol needs to be extended to make it possible to properly support full Chrome's tab dragging experience. Further details in the Design document [1]. This is the first of a patch series which implements extended-drag in Exo compositor. More specifically, this implements the core feature of the protocol: Making it possible to drag toplevel shell surfaces during DND sessions. It does it by making ExtendedDragSource an implementation of the ash::ToplevelWindowDragDelegate interface and plumbing it into ash's ToplevelWindowEventHandler, delegating to it the actual toplevel window drag handling. Refer to the design doc for more details. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=oshima@chromium.org Bug: 1099418 Test: exo_unittests --gtest_filter='ExtendedDragSourceTest.*' Change-Id: I43908dda9f542e5813d96a2e331af8df0a703efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401280Reviewed-by:
-
Richard Knoll authored
This adds metrics for actions of the muted notification as well as stats once the screen capture session ends. Bug: 1131375 Change-Id: I47a5fc9bf6677f3cc248d727b9a95c4048983870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467941 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#822681}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I7ceebe66bc953a0a1211896244fe3bf9e47f1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508201 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#822680}
-
Parastoo Geranmayeh authored
Change-Id: Ib9e6c047c410e2060b8f08d91863fea8372eec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507669Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#822679}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010300700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/wwoFvUm67SLBY3_HfnEX0lkXxs04pITqyLjVOEmfCZAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/171158139,b/171263711,b/172022118 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib87fc65cd51378ba2059fb6acfe5d791ef54f7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510317Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie92ef5bf2825c272c5fb30774703e50aabdf7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510234Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#822677}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9615bcf71f2a..b7fc7a467710 2020-10-30 egdaniel@google.com Allow wrapping of protected AHB into vulkan SkSurfaces. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I76e9614f19f477d4d1262489e6e72b241501f731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510429Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603918565-280375955eaa6ff7fe0c1e66a947d33ea408d529.profdata to chrome-win32-master-1604026576-e94043a9563f776b405eb4e60412f883a861885d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I54ced00fa9656a8c1c0e749e99a6cb6bd4a0ee9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508567Reviewed-by:
-
Anastasiia N authored
Bug: 1135980 Change-Id: I904276282f6ede9d47c51b5316f528af4c84e017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487082Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#822674}
-
Nazerke authored
This CL creates a mediator for connecting TabStrip to WebStateList and as for now the TabStrip shows the number of tabs open. Bug: 1136834,1128249 Change-Id: I9082b675f88a30002f9113a363b1b1e7c2b62465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461010 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822673}
-
NORTHAMERICA\samtan authored
Adds and binds a blink feature flag to control web app protocol handling features. A previous CL has already added the runtime_enabled_features.json5 entry: https://chromium-review.googlesource.com/c/chromium/src/+/2211200 Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/URLProtocolHandler/explainer.md Design doc: https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE/edit Bug: 1019239 Change-Id: I5ef9ac247f180f5edd4f0734422de5826c0d3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506395Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Samuel Tang <samtan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822672}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010300700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/yybQT1NgYyoLnnwaj0ajD2KILEngxWARvh81yQLwFQEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/162467266,b/168070003,b/171263711,b/171332474 Tbr: media-app@grotations.appspotmail.com Change-Id: I33ed1adedde8cff267f1217a6cd70b9b03818d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510315Reviewed-by:
-
Fredrik Söderqvist authored
These need to take any potential view spec into account, so it makes more sense to let them live in SVGSVGElement. Other users are trivial and can be open-coded. Bug: 427650 Change-Id: Ib0c9d3378cb08613356207ac3f062d66747ee14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510129Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#822670}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1459d852b166..e0de282e678b 2020-10-30 sugoi@google.com Merge changes Idde36437,Id477959d,I68027fa8,I8e6cf710 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id1d25ec38d634ac9be2d775ef736d342bdd640b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510313Reviewed-by:
-
Mark Yacoub authored
As erasing hardware display controller for mirrored displays happen after the modeset occurs, no checks for mirroring is needed at modeset time. Even if a controller is mirrored, perform a regular Modeset and handle erasing the extra controller at update. BUG=1082882 TEST=enabling mirror mode on an eDP and 2 monitors (DP & MST) Change-Id: Ia2417c501833b4f95afcdbbe4c10d839e3fe04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505586 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#822668}
-
Ryan Sturm authored
This clears all prefetches and timers in the search prefetch service when the user clears their data (time is not considered in determining which prefetches to clear). Added a couple of nullptr checks to prefetch service as well. Bug: 1138645, 1138644 Change-Id: Icbfbd0c7363e55f758c801faa91b100eaa7a365f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493727Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#822667}
-
Avi Drissman authored
Bug: 1142508 Change-Id: I8e310994740653c0d5174528b5b0ef36e9b0e32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499881Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822666}
-
danakj authored
Currently it's created with the ChromeContentBrowserClient, and a raw pointer is passed to it, which it stores. It is primarily used by ChromeContentBrowserClient. The ChromeMainDelegate has to manage the lifetime of the two objects instead of one. We can simplify the relationship here by having the StartupData owned by ChromeContentBrowserClient instead. Since ChromeMainDelegate already has a pointer to the ChromeContentBrowserClient it creates, it can use the StartupData from there. This makes it clear in the ChromeMainDelegate code that it depends on the ContentBrowserClient being created already when using the StartupData. R=avi@chromium.org Bug: 811470 Change-Id: Ia099042e11f2adc6abb5186f57925fae05343da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508231 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822665}
-
Tanmoy Mollik authored
Replace register and unregister with onAttached and onDetached methods in SignInPreference Bug: 1127990 Change-Id: If4f385691b44ea2845428c9c76143d566c82cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409964 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#822664}
-
Xiyuan Xia authored
ui::AnimationMetricsReporter is deprecating. Replace it with ui::AnimationThroughputReporter for simple layer animations and ui::ThroughputTracker for complicated ones. Bug: 11434673 Change-Id: I8e1b8319c0142dcea3f64a9a0ac7428d8a35a298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508184Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822663}
-
Ramin Halavati authored
Enabling user triggered screenshots in Incognito mode is not possible now due to an external dependency (b/145247758). As a short term solution until the dependency is fixed, a flag is added to enable it for users/developers who need it. Bug: 985245 Change-Id: Ib1b467ec4ad0f9aa216f040b19dc2670aa0184d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505211Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#822662}
-
Fredrik Söderqvist authored
This provides a more succinct way to express a potentially missing value, and allows dropping the separate HasIntrinsic{Width,Height}. For the usage in SVGSVGElement::CurrentViewBoxRect, just drop the use of IntrinsicWidth/Height() since we resolve percentages against the current viewport - which matches what a plain SVGLengthContext resolve does in this case. Change-Id: I0f6b36e4f34e3ef42adc374100d6a82647301c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509853Reviewed-by: -
Fredrik Söderqvist authored
This is just an alias for documentElement(), which should preferably only be used by the SVGDocument (DOM) property. Change-Id: I2bae17b4efd30b5be6488166d511879eaa0196b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509577 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
