GitLab

This is a target I converted to GN and it is known to run fine.

Tested on Linux with the following command lines:

$ gn gen out-gn
$ ninja -C out-gn device_unittests
$ out-gn/device_unittests

BUG=None
TEST=see above
R=dpranke@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/990653002

Cr-Commit-Position: refs/heads/master@{#319772}

Those filters are generic to non-Android ARM platforms, and should be
available to all products.

BUG=

Review URL: https://codereview.chromium.org/986673003

Cr-Commit-Position: refs/heads/master@{#319771}

Removing [Reset tracking data] was approved by jar@. It was never fully implemented (only for the browser process) and is superseded by taking and comparing snapshots in chrome://profiler tab.

BUG=456354

Review URL: https://codereview.chromium.org/980333004

Cr-Commit-Position: refs/heads/master@{#319770}

Start upstreaming Layout/LayoutManager files.

BUG=428821

Review URL: https://codereview.chromium.org/987883002

Cr-Commit-Position: refs/heads/master@{#319769}

ChildProcessConnectionImpl.mAlwaysInForeground is used
for the GPU process and indicates that it does not participate
in hiding like renderers. The 'important' binding gives it the
same priority as the main application, so upon termination we
should just use the app's foreground status to determine whether
the GPU process was in the foreground or not.

BUG=462422

Review URL: https://codereview.chromium.org/987193003

Cr-Commit-Position: refs/heads/master@{#319768}

Advertise "h2" token with ALPN and accept "h2" token in NPN.  This is the final,
almost-published version of HTTP/2.

Add "h2" to relevant tests.

Also add placeholder values (in comment) for drafts 16 and 17.  They might be
used for testing, or for collecting statistics about servers in the wild (not to
be released on Stable channel though).

BUG=401166

Review URL: https://codereview.chromium.org/987123002

Cr-Commit-Position: refs/heads/master@{#319767}

Having 'using' declarations in header files polutes the global
namespace and that is not what we want.

BUG=438860
R=piman@chromium.org

Review URL: https://codereview.chromium.org/972713002

Cr-Commit-Position: refs/heads/master@{#319766}

Tested with the following command lines on Linux:

$ gn gen out-gn
$ ninja -C out-gn native
$ ninja -C out-gn gpu/gles2_conform_support/native
$ gn check out-gn //gpu/gles2_conform_support/native/*

BUG=432959
TEST=see above
R=dpranke@chromium.org,sievers@chromium.org

Review URL: https://codereview.chromium.org/992463002

Cr-Commit-Position: refs/heads/master@{#319765}

Use linked hash map for broken alternative service queue in
HttpServerPropertiesImpl.  This container has efficient lookup by key, allowing
us to use it as the definitive set of broken alternative services in an upcoming
CL.

Also rename broken_alternate_protocol_map_ to
recently_broken_alternative_services_ for consistency and because it makes more
sense.

BUG=392576

Review URL: https://codereview.chromium.org/989253005

Cr-Commit-Position: refs/heads/master@{#319764}

BUG=392576

Review URL: https://codereview.chromium.org/986413003

Cr-Commit-Position: refs/heads/master@{#319763}

Some old devices are getting lollipop update without updated drivers.

BUG=

Review URL: https://codereview.chromium.org/982153002

Cr-Commit-Position: refs/heads/master@{#319762}

Because for each overscroll session, OverscrollStarted() and
OverscrollCompleted() (in TouchEditableImplAura) are not necessarily
called the same number of times, TouchEditableImplAura could be stuck in
a state of thinking that there is always an scroll in progress which
prevents handles from appearing after a long-press.

BUG=430176

Review URL: https://codereview.chromium.org/963103003

Cr-Commit-Position: refs/heads/master@{#319761}

Revert of [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (patchset #2 id:20001 of https://codereview.chromium.org/986743004/)

Reason for revert:
I think this CL is responsible for tree closing compile failure https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26672/steps/compile/logs/stdio.

Original issue's description:
> [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.
>
> In this change:
> - Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00
> - Remove AttachmenService::GetStore. Now attachment store is owned by
>   model type, there is no need to get it from AttachmentService
> - Introduce AttachmentReferrer. There is no functionality behind it yet
>   and interface is not complete for it. These will come in the next change.
>
> BUG=457735
> R=maniscalco@chromium.org
> TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests)
>
> Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847
> Cr-Commit-Position: refs/heads/master@{#319733}

TBR=maniscalco@chromium.org,cjhopman@chromium.org,pavely@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457735

Review URL: https://codereview.chromium.org/996473005

Cr-Commit-Position: refs/heads/master@{#319760}

BUG=462362

Review URL: https://codereview.chromium.org/957283003

Cr-Commit-Position: refs/heads/master@{#319759}

GYP target policy_templates is now enabled for android as well.
Remove code that generated Policy resources w/o translation for Android.

roll grit 186:187

187: Add a Policy template writer that generates Android resources which can be exposed through Android's App Restriction Schema.

Depends on:
https://codereview.chromium.org/865563002

BUG=450548

Review URL: https://codereview.chromium.org/865573002

Cr-Commit-Position: refs/heads/master@{#319758}

All clients have switched to the new method.

BUG=461148

Review URL: https://codereview.chromium.org/996493002

Cr-Commit-Position: refs/heads/master@{#319757}

The test actually didn't test anything. Calling sock1.reset() would cause the
socket to disconnect before tlslite completed the handshake. tlslite doesn't
insert the session into the session cache.

This is a preparatory CL to get the tests in shape before reworking the session
cache implementation.

BUG=454044

Review URL: https://codereview.chromium.org/988223004

Cr-Commit-Position: refs/heads/master@{#319756}

Each profile creates new instance of SignedInDevicesManager so, for example,
opening incognito window and then closing it, destroyes an instance of
SignedInDevicesManager created for this profile. The code has forgot to remove
itself from the list of observers in EventRouter.
That caused crash when that event was triggered later in a normal profile as
EventRouter would reference stale pointer.

In tests observer is not added and profile_ is null so null-checking it.

R=rdevlin.cronin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/980663002

Cr-Commit-Position: refs/heads/master@{#319755}

I'm proposing to add meacer to:
chrome/browser/interstitials/OWNERS
chrome/browser/ssl/OWNERS

For his work on captive portals and general code cleanup.

BUG=
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/982343002

Cr-Commit-Position: refs/heads/master@{#319754}

This CL also adds a generic persistence mechanism for //net, separate
from Chrome user preferences, that loads asynchronously on startup (i.e.
doesn't block startup).

This is a reupload of rdsmith@'s existing CL at
https://codereview.chromium.org/881413003/; see that CL for earlier discussion.

BUG=374915
R=mmenke@chromium.org
R=rdsmith@chromium.org
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/901303002

Cr-Commit-Position: refs/heads/master@{#319753}

Field trial "CreditCardScan" enables scanning credit cards. "Credit card
scanning" flag can force enable or disable the feature.

BUG=462381

Review URL: https://codereview.chromium.org/991983003

Cr-Commit-Position: refs/heads/master@{#319752}

Prefer DCHECK_EQ(a, b) over DCHECK(a == b) when possible as this
provides more data on a failure. Similar for other operators such as
>=, <, !=, etc.

This also applies to CHECK, EXPECT, and ASSERT macros.

R=Nico
BUG=464816

Review URL: https://codereview.chromium.org/985723003

Cr-Commit-Position: refs/heads/master@{#319751}

When a ConnectJob failed and there was another socket request pending
for the same group, a new ConnectJob would always be created, even if
the pending request already had its own ConnectJob.

BUG=463960

Review URL: https://codereview.chromium.org/981643002

Cr-Commit-Position: refs/heads/master@{#319750}

Previously, the historic network stats values on the net-internals
page were only updated every hour. Now, instead of using local
prefs, HistoricNetworkStatsInfoToValue reads from statistics prefs,
and the values are up to date.

BUG=403867

Review URL: https://codereview.chromium.org/989663002

Cr-Commit-Position: refs/heads/master@{#319749}

Make the chrome://extensions page use chrome.developerPrivate API for
'inspect' calls.
Also convert the api function to a UIThreadExtensionFunction.

BUG=461039

Review URL: https://codereview.chromium.org/989843002

Cr-Commit-Position: refs/heads/master@{#319748}

New component extensions should default to the front of the visible icons. The
user can still reposition them, but for the first startup, they will now appear
at the beginning.

BUG=463938

Review URL: https://codereview.chromium.org/981603002

Cr-Commit-Position: refs/heads/master@{#319747}

between what Chrome thinks and what the driver is.

This is caused by we intercept invalid program and generate an error on
LinkProgram rather than passing it to the driver, so the driver still have
a valid program if the previous link succeeds.

BUG=463599
TEST=test case in the bug
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/978193003

Cr-Commit-Position: refs/heads/master@{#319746}

BUG=454983

Review URL: https://codereview.chromium.org/993703002

Cr-Commit-Position: refs/heads/master@{#319745}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/719867b..796d284

TBR=jbroman@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/993683002

Cr-Commit-Position: refs/heads/master@{#319744}

Add a map from stream ID to priority to track which stream IDs are already in
the write blocked list.  And git cl format.

This CL lands server change 86595615 by birenroy.

BUG=

Review URL: https://codereview.chromium.org/989523005

Cr-Commit-Position: refs/heads/master@{#319743}

BUG=None
R=msw@chromium.org

Review URL: https://codereview.chromium.org/968923004

Cr-Commit-Position: refs/heads/master@{#319742}

The script follows mojo/services/html_viewer/view_url.py. See the script for
how to use it.

BUG=410451
TEST=Run the script to test.

Review URL: https://codereview.chromium.org/991963003

Cr-Commit-Position: refs/heads/master@{#319741}

Revert of Roll src/third_party/skia 86e31a1:d2737ad (patchset #1 id:1 of https://codereview.chromium.org/995473002/)

Reason for revert:
The font patch included in this roll seems to be causing a crash on the N7 GPU bot.

http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/18522/steps/webgl_conformance_tests/logs/stdio

(search for GrBitmapTextContext::onDrawPosText)

Original issue's description:
> Roll src/third_party/skia 86e31a1:d2737ad
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/86e31a1..d2737ad
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=mtklein@google.com
>
> Committed: https://crrev.com/83109ac5eab7187ec595c487bdd5bab74c1847c1
> Cr-Commit-Position: refs/heads/master@{#319715}

TBR=mtklein@google.com,skia-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/992073002

Cr-Commit-Position: refs/heads/master@{#319740}

Also extensions::Dispatcher::WillReleaseScriptContext.

R=nasko@chromium.org

Review URL: https://codereview.chromium.org/985643004

Cr-Commit-Position: refs/heads/master@{#319739}

This CL removes the calculate_top_controls_position flag and instead
always creates the top controls manager. The methods of the manager
become no-ops if the top controls height is 0 so that it becomes
effectively enabled when a top controls height gets set.

This fixes the attached bug because some Android Chrome UI pages don't
have top controls but the manager was still created. These pages set
the height to 0 to hide the top controls but the methods of the
manager were still getting called. This caused a crash in Blink since
ScrollBy would try to calculate the shown ratio with a 0 height, causing
a NaN to propagate into Blink.

BUG=460007

Committed: https://crrev.com/7610e74eacde3468853c9765bd3f726c14df04c1
Cr-Commit-Position: refs/heads/master@{#319257}

Review URL: https://codereview.chromium.org/961023002

Cr-Commit-Position: refs/heads/master@{#319738}

Moves a subclass Tab method up to superclass to eliminate the dependency
on the downstream Tab implementation. Removes the no longer necessary
method from TabDelegate.

BUG=464934

Review URL: https://codereview.chromium.org/988323005

Cr-Commit-Position: refs/heads/master@{#319737}

Add AwContentsClient#hasWebViewClient so chromium layer knows when the
WebViewClient is null, and can fallback to default implementations.

Then move the default implementations to chrome layer.

Changes in implementation:

Use ContextWrapper instead of view.getContext(). This means the
"context instanceof Activity" check will never return true.
Use ContentViewCore.activityFromContext to check instead.

Call ContentViewClient.shouldOverrideKeyEvent directly instead of
keeping another copy of the implementation.

BUG=464491

Review URL: https://codereview.chromium.org/985833004

Cr-Commit-Position: refs/heads/master@{#319736}

Reason for revert:
Broke "compile" on "iOS_Device".

http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/26659/steps/compile/logs/stdio

Undefined symbols for architecture armv7:
  "net::SpdyPriorityIR::SpdyPriorityIR(unsigned int, unsigned int, unsigned char, bool)", referenced from:
      net::SpdyFramerTest_CreatePriority_Test::TestBody() in spdy_framer_test.o
      net::SpdyFramerTest_ReadPriority_Test::TestBody() in spdy_framer_test.o
ld: symbol(s) not found for architecture armv7
clang:error: linker command failed with exit code 1 (use -v to see invocation)

Original issue's description:
> Test dead code.
>
> Test a log method that could be helpful for debugging.  Also inline SpdyPriorityIR constructors for code convergence.
>
> This CL lands server change 87053738 by birenroy.
>
> BUG=
>
> Committed: https://crrev.com/e44eb0a35c11f8ff743873f5f382b5d5c5353325
> Cr-Commit-Position: refs/heads/master@{#319724}

TBR=rch@chromium.org,bnc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/992613005

Cr-Commit-Position: refs/heads/master@{#319735}

Add methods in AwContents that mirrors WebView exactly. And have
WebViewChromium call through to AwContents directly.

Unfortunately the code to post to UI thread now needs to be duplicated
in WebViewChromium for each method.

BUG=464491

Review URL: https://codereview.chromium.org/986953002

Cr-Commit-Position: refs/heads/master@{#319734}

In this change:
- Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00
- Remove AttachmenService::GetStore. Now attachment store is owned by
  model type, there is no need to get it from AttachmentService
- Introduce AttachmentReferrer. There is no functionality behind it yet
  and interface is not complete for it. These will come in the next change.

BUG=457735
R=maniscalco@chromium.org
TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests)

Review URL: https://codereview.chromium.org/986743004

Cr-Commit-Position: refs/heads/master@{#319733}