GitLab

Original method expects only a single equal sign in each
query parameter and that the query string is only in lower
case. However, body may contain a URL with may have an
unescaped equal sign. And query string keys may be in mixed
case.

As part of this fix, also removed -supportedHeaders from
public API and use GURL for query parameter processing.

Bug: 747949
Change-Id: Ia157983e946d7301300d22f41e007bd10ce8b786
Reviewed-on: https://chromium-review.googlesource.com/594873
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491280}

The prefetch store SQL table was missing retry counter columns for some of the
pipeline operations that needed those counters. This CL adds those columns and
also changes their current naming pattern. A new store test and a mock item
generator are also added to verify that saving and loading a prefetch item is
consistent.

Note: Some of the functionality being used only in tests here will support the
upcoming addition of a pipeline task to deal with expired entries.

Bug: 701939
Change-Id: Iaa26975fb17ec8ab979925613b4af743ef176cd6
Reviewed-on: https://chromium-review.googlesource.com/585334
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491279}

R=dpranke@chromium.org
CC=thestig@chromium.org

Change-Id: I311cf3d81d3d642532be7534763ddeb918852c49
Reviewed-on: https://chromium-review.googlesource.com/596678Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491278}

ParentDocument() can be nullptr.

Bug: 750836
Change-Id: Idff5feeececa8ad32f3248c565c878902dd24ffc
Reviewed-on: https://chromium-review.googlesource.com/597370
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491277}

Test suit is added to network traffic annotation extractor clang tool.

Bug: 656607
Bug: 690323
Change-Id: Ie7adc46694eba1bf1dc05bd08ccacf4c8e42743b
Reviewed-on: https://chromium-review.googlesource.com/590236
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491276}

Bug: 740070
Change-Id: Ida0ce2080e724784cfb775d30004805cc70812f4
Reviewed-on: https://chromium-review.googlesource.com/595301
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491275}

- we insert annotations only to describe the context of the current selection's ancestry
- we don't annotate things outside of the selection to avoid cluttering small displays
- output module extended to support braille specific only rules
- added brl specific msgs for table and cell

Test: updates made to existing editing tests. Manually test against tables.
Bug: 719654
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac8a62d666d217a7046ea33b78517d1f29dce027
Reviewed-on: https://chromium-review.googlesource.com/592166
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491274}

ARIA booleans that are not "false" and not explicitly undefined should be exposed as true.
ARIA object attributes that expose token should expose the error values and let the AT decide what to do with them. (This enables experimentation with new ARIA experiences, without changing the shipping browser code).

Bug: 746621
Change-Id: I91381f17db5ad179f26b02b81434b36f78492f0d
Reviewed-on: https://chromium-review.googlesource.com/584018
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491273}

Bug: 718235
Change-Id: I39d763bec2a12ff2e77e67e201c1137983a8dc00
Reviewed-on: https://chromium-review.googlesource.com/592608
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491272}

After offline discussion with jamescook@, the prefs reading is skipped
in the case of config::MASH until crbug.com/751143 is fixed.

This CL combines https://chromium-review.googlesource.com/c/572144 and 
https://chromium-review.googlesource.com/c/595123. TBR because the
entire CL has been reviewed.

Please note there's another CL
(https://chromium-review.googlesource.com/c/592228)
depending on this one. (specifically, Shell::RegisterLocalStatePrefs)

TBR=jamescook@chromium.org,derat@chromium.org,bshe@chromium.org
lhchavez@chromium.org,xdai@chromium.org,ochang@chromium.org

Bug: 733409
Change-Id: Ibeb260c94a174819322121efe12c2865f5df78c7
Reviewed-on: https://chromium-review.googlesource.com/596801Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491271}

Dialog text on ChromeOS is grey (via kButtonEnabledColor =
gfx::kChromeIconGrey == #5a5a5a). Disabled text needs to be more grey
so that it looks disabled. On ChromeOS, readonly textfields currently
use SK_ColorDKGRAY (#444444) which is actually darker. r483968 meant
that, for ChromeOS, this color would also get used for disabled
Comboboxes.

Other platforms (gtk, mac, windows) were using a lighter "disabled"
grey already (for disabled comboboxes as well as readonly textfields),
so were not affected. --secondary-ui-md on ChromeOS was also not
affected - it's using other constants for these colors.

There are exactly 2 readonly textfields in Chrome: Cookies dialog and
the Omnibox for popup windows. The Omnibox always overwrites colors
anyway, so isn't affected by this.

So this change makes disabled comboboxes, and the readonly textfields
in the cookies dialog, on ChromeOS (only) a lighter grey, making them
consistent with Windows, gtk3, and --secondary-ui-md. (#a1a192 is what
disabled combo boxes used before r483968).

Bug: 745071
Change-Id: I0296ee2d7290c27ffc47c23db40724c9ca94f2af
Reviewed-on: https://chromium-review.googlesource.com/595370Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491270}

ScopedAsyncTaskScheduler is deprecated.

Bug: 708584
Change-Id: Ia368d30ef1fd7b93519bf66845e5234505b0464c
Reviewed-on: https://chromium-review.googlesource.com/592164
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491269}

https://skia.googlesource.com/skia.git/+log/943e77368b89..19391ac4d393

$ git log 943e77368..19391ac4d --date=short --no-merges --format='%ad %ae %s'
2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ 5788d24bb..44183ccea (1 commit)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I30adc8c1e2bf7e3ae4af746312c3d4a73a6f6592
Reviewed-on: https://chromium-review.googlesource.com/597052Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491268}

Bug: 750341
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I26a75ee076b3a9a5d22e18b71e0a35105ee7b552
Reviewed-on: https://chromium-review.googlesource.com/592309
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491267}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6a944af5..79e7abbd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ifdaab8c25f9722db52e976bfddcc88ab490c9723
Reviewed-on: https://chromium-review.googlesource.com/597448Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491266}

This patch gets rid of redundant member variable |selection_type_| from
|VisibleSelectionTemplate| to simplify |VisibleSelectionTemplate| for improving
code health.

Bug: 657237
Change-Id: I9a45a73d719bc9aa6300fd59b982ec820dd1c0ea
Reviewed-on: https://chromium-review.googlesource.com/579896Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491265}

Pass only the URL from ResourceFetcher/ResourceLoader to InspectorNetworkAgent::ShouldBlockRequest()

This makes reading ResourceFetcher/ResourceLoader easier by clarify that
the probe is interested only in the URL.

Bug: 736308
Change-Id: I62b7cdfe7f81d20a225f416221df0a43ac447f23
Reviewed-on: https://chromium-review.googlesource.com/596108
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491264}

Now it's possible to enable MediaCodecVideoDecoder via MojoVideoDecoder
by setting enable_media_codec_video_decoder to true.

Bug: 660942
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia1d16b20ecb26102e44e18946cb1d8046c4493b2
Reviewed-on: https://chromium-review.googlesource.com/552875
Commit-Queue: Chris Watkins <watk@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491263}

Removed app_list. Added web_share.

Also added +watch to tapted by request.

Change-Id: Ie86fe718cc15f0091d9b6ad8d5e6343d21f32c48
Reviewed-on: https://chromium-review.googlesource.com/597371Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491262}

Currently, gesture nav affordance uses a single layer that paints
everything in each frame. This CL moves the arrow to its own layer which
is drawn once and then appropriate transform and opacity are applied on
it. This is needed for implementing pull-to-refresh which needs the
arrow be rotated. Also, generally we want to decompose the affordance
into a few layers to avoid painting it on each frame.

BUG=702404,743239
TEST=none

Change-Id: I9140471d6b6edbbb84f97fd5148994fea58e5a90
Reviewed-on: https://chromium-review.googlesource.com/594840Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491261}

Using wpt-import in Chromium 4297bf0f.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/409

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bajones@chromium.org:
  external/wpt/gamepad
domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org:
  external/wpt/streams

TBR=qyearsley@chromium.org

No-Export: true
Change-Id: I78edba357e58a94680ca4f9a6f01c86c4395e6ba
Reviewed-on: https://chromium-review.googlesource.com/597123
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491260}

Comments should match between these files:
device/bluetooth/public/interfaces/test/fake_bluetooth.mojom
third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js

TBR-ing documentation update.

Bug: 569709
TBR: scheib@chromium.org
Change-Id: Ida2f65d2e50c7d0d1b05010893bd24277fb98171
Reviewed-on: https://chromium-review.googlesource.com/596685
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491259}

MessageLoop is no longer a friend of RunLoop :)!

The only minor dependency remaining shows up in tests as allowing
nestable tasks in a scope (different from allowing nested loops on a
thread in general) is still a MessageLoop concept. I plan to move that
to RunLoop as well in a follow-up.

R=danakj@chromium.org

Bug: 703346
Change-Id: I0a6269c94de179d97c14855499edd70be9e1d1af
Reviewed-on: https://chromium-review.googlesource.com/594352Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491258}

on Mac Retina Debug (NVIDIA)

BUG=751328
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic5f1b6ca6a83fdbf93b8bdda7fca86cc5c36176c
Reviewed-on: https://chromium-review.googlesource.com/597287
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491257}

Bug: none
Change-Id: Ie7994e0006349c6c8f9a0eec223320a863f76ab0
Reviewed-on: https://chromium-review.googlesource.com/596526Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491256}

Remove reference to non-existant AddIntermediateCertificate method.

Clarify Equals documentation regarding intermediates.

Fix typo.

Bug: 751298
Change-Id: I630fd51176cc9de7e14a5917ab77f9a60a81f1e5
Reviewed-on: https://chromium-review.googlesource.com/596724Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491255}

This CL adds UMAs for system swap metrics during session restore. The
implementation uses SwapMetricsDriver to collect the swap metrics during
session restore, and computes rates (e.g. swaps in/second) as an average over
the entire session restore interval. Swap metrics are platform-specific.
Currently, swap in/out rate is available on Linux and Mac, and page
compression/decompression rates are available on Mac only.

Bug: 740625
Change-Id: I3dfb4268759e6900e768756b8939ad64de603a06
Reviewed-on: https://chromium-review.googlesource.com/585405
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491254}

Bug: 446329
Change-Id: I017d80e4025d0d823d33d87b28c9eca83f759204
Reviewed-on: https://chromium-review.googlesource.com/587426
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491253}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3ec578154f4f..95988f787423

$ git log 3ec578154..95988f787 --date=short --no-merges --format='%ad %ae %s'
2017-08-01 benjhayden Group related memory alerts across testsuites.
2017-08-01 sullivan Fix 'examples' link in API docs.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I5dbadcecc9f36117d76342b9175aa47d466f4d62
Reviewed-on: https://chromium-review.googlesource.com/596471
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491252}

It appears to be passing reliably.

BUG=694958

Change-Id: I8ae576736fd59835cfcac787c52aa864a2b96625
Reviewed-on: https://chromium-review.googlesource.com/596414
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491251}

This matches the discard button that already has 2px rounded
corners at the bottom.

BUG=721647

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I82bd6069280c6d1df0bdf972d563ed3e26fe3dc8
Reviewed-on: https://chromium-review.googlesource.com/593209Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491250}

https://chromium.googlesource.com/webm/libvpx.git/+log/8836e46ffd84..c22b17dcefe0

$ git log 8836e46ff..c22b17dce --date=short --no-merges --format='%ad %ae %s'
2017-07-31 marpan vp9: Adjust noise estimation for 360p.
2017-07-28 marpan vp9: Fix denoising condition when pickmode partition is used.
2017-07-30 jianj Revert "Revert "vp9: Speed feature to adapt partition based on source_sad.""
2017-07-30 jzern highbd_inv_txfm_sse4: make << of neg. val a multiply
2017-07-29 jzern Revert "vp9: Speed feature to adapt partition based on source_sad."
2017-07-29 jzern Revert "Rewrite vpx_highbd_idct8x8_{12,64}_add_sse2"
2017-07-28 jianj vp9: Adjust logic in source sad for screen content.
2017-07-28 marpan vp9: Speed feature to adapt partition based on source_sad.
2017-07-28 urvang Remove the DP version of vp9_optimize_b().
2017-07-28 jzern Revert "quantize ssse3: declare all variables"
2017-07-21 linfengz Update vpx_idct16x16_10_add_sse2()
2017-07-20 linfengz Add vpx_idct16x16_38_add_sse2()
2017-06-30 linfengz Rewrite vpx_highbd_idct8x8_{12,64}_add_sse2
2017-06-30 linfengz Refactor highbd idct 4x4 and 8x8 x86 functions
2017-07-19 jianj vp8: Remove isolated skin & non skin blocks.
2017-07-25 jzern inv_txfm_{sse2,ssse3}: clear conversion warnings
2017-07-25 jzern highbd_idct*_sse*.c: clear conversion warnings
2017-07-25 jzern vpx_variance16x16_sse2: correct cast order
2017-07-24 jzern vpx_get16x16var_avx2: correct cast order
2017-07-18 johannkoenig quantize ssse3: declare all variables

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Bug: 
Change-Id: I8b26cd0a399df47482300a0c8d9395f2b28669f2
Reviewed-on: https://chromium-review.googlesource.com/596499
Commit-Queue: Jerome Jiang <jianj@google.com>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#491249}

Bug: 634443
Change-Id: Ibb03ad7dcede776c4b97ba839107d4ec916b6235
Reviewed-on: https://chromium-review.googlesource.com/596516
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491248}

Currently we have  many calls to function
CreateVisiblePosition(selection_.Extent(), selection_.Affinity())
in SelectionModifier. So to reduce the source code
introduced ComputeVisibleExtent() in SelectionModifier.cpp

BUG=749380

Change-Id: I31521e1d4956817131719b30f3dede21fe0221ba
Reviewed-on: https://chromium-review.googlesource.com/591727Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491247}

This file is ppapi CDM specific. Move to media/cdm/ppapi folder. When
ppapi CDM is depreacted, this file will be removed along with other
files in media/cdm/ppapi folder.

BUG=403462
TEST=No functionality change.

Change-Id: I188f8636a9b47062ef325e3c45820f4d64ac3319
Reviewed-on: https://chromium-review.googlesource.com/596544Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491246}

Bug: 738277
Change-Id: Ib9e8bf977a491054e4be2abbf104481805dff7d6
Reviewed-on: https://chromium-review.googlesource.com/564904Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Renjie Liu <renjieliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491245}

Bug: 731467
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I785ddcb08e90910c508bc38e7bb2a524de854949
Reviewed-on: https://chromium-review.googlesource.com/595194Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491244}

This is part of the gradual process of putting all types that derive from
CSSValue into blink::cssvalue:: namespace.

Bug: 667961
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ida38ef3b65ff8977c286e4bcd71fa9e416fe1ff2
Reviewed-on: https://chromium-review.googlesource.com/595369Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491243}

Previously, run_telemetry_benchmark_as_googletest would check the
validity of the benchmark run by opening results.json. This file
was generated using the --output-format=json flag. By removing
that flag in https://chromium-review.googlesource.com/c/589820,
I broke all the Telemetry benchmarks on the perf waterfall o.O my
bad. This change should fix the failing tests by checking the
validity of the benchmark run by opening test-results.json,
generated using the --output-format=json-test-results flag now
being used for all Telemetry benchmark runs on the waterfall.

BUG=751346, 748638

NOTRY=true  # This script is not run on trybot/CQ, hence should be safe to notry

Change-Id: I75e0abb5801f1cbaa480e65ade1827335a1195fd
Reviewed-on: https://chromium-review.googlesource.com/597428
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491242}

I do not have a local repro... As Derek mentioned, DialAPI is destroyed on the IO thread, but somehow referenced after deletion on the UI thread. Not quite sure how that could happen since
it is scoped_refptr<DialAPI>.

It might relate to delete RefCountedKeyedService on the IO thread. Tentatively fix it by destroying DialAPI instance on the UI thread.

BUG=740489

Change-Id: I3e638c14a77ffa9c5726519571d25874a20cd5f0
Reviewed-on: https://chromium-review.googlesource.com/567025
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491241}