- 15 Oct, 2020 40 commits
-
-
Kyle Horimoto authored
This class manages startup/shutdown of the Nearby utility process by using a reference count of the active clients. It is used by a future CL to connect to the process for Nearby Sharing. This CL leaves a TODO for a future CL to add the asynchronous shutdown flow. Tests for this new class are omitted in this CL and are added in the follow-up CL which adds the asynchronous shutdown flow [1] to prevent unnecessary churn in the test. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2460230 Bug: 1130069 Change-Id: I72782c4c2d8c5024cbcc7613497b7efbd46ecb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459112 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#817634}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios. R=rohitrao@chromium.org Bug: 1113033 Change-Id: Ibe0f5032e497668b9b6327dc07fc0c43a719b470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469221 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#817633}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41fc174d7967..ec64d037bd04 2020-10-15 mtklein@google.com cond_stack/mask_stack for CPU backend 2020-10-15 kjlubick@google.com [canvaskit] Expose Perlin Noise shaders. 2020-10-15 kjlubick@google.com [canvaskit] Clean up Shader docs/types/names 2020-10-15 adlai@google.com Migrate debugger & canvaskit to GrDirectContext 2020-10-15 bsalomon@google.com Ref GrDirectContext in MakeBackendRenderTargetSurface 2020-10-15 ethannicholas@google.com moved SkSL InterfaceBlock data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I24dcaab427c4af24778f6a4944b79907e8e496f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817632}
-
Ian Kilpatrick authored
Previously LayoutGrid performed a simple logical-height change check to determine if a grid-item needed relayout. This wasn't correct as when setting an override logical-height the definiteness can change causing %-height children to resolve differently. This became troublesome after we moved relative-positioning into NG as %-block-start, %-block-end offsets weren't resolving correctly. This however also fixes other issues such as test: percentage-size-subitems-002.html Where LayoutGrid wasn't performing a relayout causing grandchild to size incorrectly. This may have a performance hit for any legacy children being having layout performed by a LayoutGrid, however should be fine for an NG child as we have much more precise cache logic for this case. The following tests have been marked as failing: virtual/layout-ng-grid/external/wpt/css/css-grid/relative-grandchild.html virtual/layout-ng-grid/external/wpt/css/css-grid/grid-items/percentage-size-subitems-002.html as GridNG doesn't correctly set up the constraint spaces yet. Bug: 1138504, 1018439 Change-Id: Iac2484f1b175f152e491f421449fb7b555c9e125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474917 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#817631}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/53380f9ed76f..481ecff293db 2020-10-15 dsinclair@chromium.org [ast] Require StructType to have a name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: enga@google.com Change-Id: Ia8ad636e8e50cddc1a5aaff97f3428fd37d5b844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476572Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I286bf611e9142af7ed21facdbf2814e6568e4904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476777Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#817629}
-
Peter Boström authored
Fixes regression where the dialog had to be explicitly accepted to apply pending updates. Bug: 1137491 Change-Id: I9c8166aa013714b08280eaf1d51c7831dcd6b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476719 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817628}
-
Omer Katz authored
Extending from M88 to M92 (roughly 6 months). Bug: 1138253 Change-Id: Id3c584d6c83f856d89ceeeb7f6883b21294988c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472118Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817627}
-
Tim Judkins authored
This fixes the case for APIs which support promises to be able to explicitly mark the field as optional, which is important for contexts which don't support promises and need to know if the callback is optional or not. It also adds to a test to cover this case. Bug: 978538 Change-Id: I34399ac11c075bbbaaf470ca911a06731c0669f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472710Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#817626}
-
Andrew Grieve authored
Cronet tests assume no whole-program optimizations. Bug: 1136962, 1136963 Change-Id: Iead196d725adcbaad4a64508f3e9c213d5c83d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463458Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#817625}
-
minch authored
Add slider colors as the spec. Live update for the slider's colors. Bug: 1133063, 1131543 Change-Id: I9dd022a3b75932cba972c458ab4bdf4b89acddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472479 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#817624}
-
James Vecore authored
Fixed: 1134810 Change-Id: Id46b76dc22328b826a3359344e8d33366661459d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476685 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#817623}
-
Greg Thompson authored
base/win/registry.h includes more than it uses. These files were inadvertently relying on that fact. This CL adds missing includes so that registry.h can be cleaned up. BUG=None This CL was uploaded by git cl split. R=eroman@chromium.org Change-Id: I204ca677225511983881927d46f7344442ea4ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475074 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#817622}
-
Miriam Zimmerman authored
See screenshot in bug. TEST=deploy on chromebook, open feedback window. Fixed: chromium:1138774 Change-Id: I91249d08dbb2bde7ba65b15adf5fed5c43cc1855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476565Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#817621}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 678eb60a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I18c17d92d7c393844c6f7743469de183fe1dc4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476140Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817620}
-
Jan Wilken Dörrie authored
This change replaces "Found n security issues" with "Found n weak passwords" in the case where the user is signed out and has no compromised credentials. Translation Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/8f393f395ae0dda9238b4f170c9d9940cd2a60a9 Bug: 1138468 Change-Id: I0cb563ee35f60f63bfd4dd503efe955c8876b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475913 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#817619}
-
Chris Palmer authored
This CL 'zaps' (`memset`s) the allocated region on free. This may help detect some instances of UAF, causing them to crash (with nullptr deref). Rather than doing so on every free, we zap probabilistically to reduce the performance impact. If the perf bots show an unacceptable regression, we'll revert this. But, it might be acceptable. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/2469840. Bug: 1005070, 1013329, 1013326, 1013324 Change-Id: I7ae007767b31cab139c6b27c5e4667309d4d707d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473041Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#817618}
-
Wan-Teh Chang authored
Update to libavif v0.8.2. https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/e67f9369d50e..33ece0a9f897 $ git log e67f9369d..33ece0a9f --date=short --no-merges --format='%ad %ae %s' 2020-10-14 jdrago v0.8.2 2020-10-14 jdrago Stop being lazy about CHANGELOG (catch up!) 2020-10-14 jdrago Re-contribute my oss-fuzz decoder implementation under the same license as libavif itself 2020-10-12 wtc Detect file read error by calling ferror() 2020-10-13 wtc AVIF_RESULT_NO_IO renamed AVIF_RESULT_IO_NOT_SET 2020-10-13 jdrago Add oss-fuzz implementation to tests/ 2020-10-12 wtc Miscellaneous cleanup changes to apps/ and tests/ 2020-10-12 wtc avifIO read() should require readFlags == 0 Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1136922 Change-Id: I6ac03fa84b87a9699cbf24fda498a4262d4bb4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476613Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#817617}
-
Elaine Chien authored
Bug: 1130078 Change-Id: I1f1941981229996029488c2d0b001d720f84f259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463769Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#817616}
-
Austin Eng authored
This reverts commit 08c8cfe5. Reason for revert: Dawn now matches the value of Chromium's use_x11 so it should not longer be necessary to set manually. Original change's description: > set dawn_use_x11 = false for headless builds > > headless_shell build with build/args/headless.gn should not > depend on x11, and https://crrev.com/c/2368534 > brought x11 via dawn to all linux builds. > > Bug: 976495 > Change-Id: I65c0371f97e2c7eeda5381f890d52c8b06c60b34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473444 > Reviewed-by: Peter Kvitek <kvitekp@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817311} TBR=caseq@chromium.org,kvitekp@chromium.org,enga@chromium.org Change-Id: Iae829a6e8ae612cbe82c632d7897018e1f1a8b40 Cq-Include-Trybots: luci.chromium.try:linux-lacros-rel Bug: 976495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476953Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#817615}
-
harrisonsean authored
When the user performs a safety check that finds no issues, clear the timestamp, it is odd to have no issue states on the screen and see issues last found x time ago. Bug: 1078782 Change-Id: Ieb9dee1c9428643df05c5c541e6b4de472a623df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474914Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#817614}
-
Alex Gough authored
It is opened FILE_READ here: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/media_galleries/fileapi/supported_audio_video_checker.cc;drc=0e22286ee95d2bd711f81d73f1178343fbacc890;l=63 Bug: 1130762 Change-Id: I2b245847ac1b1a67d07d52eeb99e495044d53803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463812Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817613}
-
Lloyd Pique authored
This patch adds a new "wayland_client_compatibility_test" test target, which runs the Chrome OS server sources with a custom, generated-code client test. The purpose of the test is to ensure the server never sends an event to the client that is not supported, given the interface version the client is using. On a typical client using the core Wayland client code from freedesktop.org, sending an unsupported event can cause an array access out of bounds, or potentially other undefined behavior. (Note that this compatibility test client is built from the same protocol sources, and supports all the versions the server could potentially support, so there can be no undefined behavior here.) The intent is to eventually run this test as part of the Chrome CQ or similar, to catch protocol version violations as early as possible. Not all interfaces will be the subject of a generated test. Only interfaces that have events added with a "since" version after the initial version of the interface will be tested. Also the test only tests the versions of each interface that make sense to test. The bulk of the source code for this patch is in the Python 3 code generator and the related Jinga2 templates which expand into the client test. The code generator will generate a fixture for each interface, with the fixture containing the code to obtain the target interface as well as all other interfaces needed. Also generated are some additional helpers that allow the client to use std::unique_ptr with the various Wayland interfaces, as well as to obtain global interface pointers using compile time type information. The special header file wayland_client_event_receiver_version_fixtures.h contains any optional manual override fixtures needed to get the various interfaces, to "nudge" the server to ensure it sends certain key events so that that each test passes. Or if needed, the fixture can be configured so that the test is skipped. Currently the code generates sixty-three test cases covering various versions of fifteen interfaces. The test runs in about a minute under Linux with xvfb-run. This patch sets up the framework, but does not include all the changes needed to get all the tests to pass. The framework works as is to properly test FIVE of the fifteen interfaces. The other ten interfaces are configured to have their tests skipped for now. Subsequent patches will be needed to ensure these ten interfaces are actually tested. As this patch is all about automatically generating new tests when the protocol files are changed, thought went into: 1) Limiting work. Again, only interfaces where versions need to be checked for events will have a test generated. A brand new interface with its initial events will not have any tests generated, and therefore not need any customization. 2) Not breaking the build. The build will not be broken if by any (valid) protocol addition. The default generated code is expected to always compile. 3) Server interface support. Only the interfaces and their versions actually exposed by the server will be tested. Interfaces and versions not exposed by the server will be automatically skipped. 4) Messaging part 1. If a test fails for any reason, and no custom/override fixture has yet been defined, the test will output minimal details for defining one that causes the test to be skipped. This is in particular intended to help any sheriffs that encounter a failure. 5) Messaging part 2. If a test fails because expected events were not received, again it will be clear about the possible need to define overrides of certain helper functions in the manually maintained fixture overrides, to ensure that the server sends the expected events. Other notes: If desired, the test generation conditions can be relaxed to cover all events, though that would almost certainly require more significant manual help to get the tests for existing interfaces to work, and it would certainly increase the burden of work for adding new interfaces. BUG=b:157254342 TEST=wayland_client_compatibility_tests Change-Id: I756e52408951b7d63653d7e65e138a41859d494f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402148Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Lloyd Pique <lpique@chromium.org> Cr-Commit-Position: refs/heads/master@{#817612}
-
Jeremy Roman authored
It is also timing out on Mac 10.12: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/38444 Bug: 626703 Tbr: pkasting@chromium.org Change-Id: Ib62dbe51a54f888fd9bd2164fd754d553f13dfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476955Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817611}
-
Bailey Berro authored
Adds the ability to bind the SystemDataProvider interface. Bug: 1128204 Change-Id: I523618794ecfd8454e7195aabb7bf1e7df25f470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446192 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817610}
-
Cattalyya Nuengsigkapian authored
Testing: - check that dark and light mode look as expected in the spec (https://www.figma.com/file/rQFGy3iAMfNdDnydTGkvHr/Style-%7C-Semantic-color-system-surface-theming?node-id=0%3A1). - check that if DarkLightMode feature flag is disabled, the UI looks the same. Videos and spec can be found here: https://drive.google.com/drive/folders/1e1P8gJdj3TtJR--3xG3YoK3zc5c-xmSj?usp=sharing Bug: 1128761 Change-Id: I5e358b2d9d2b0593b301f4ac299227666aea6ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464124 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#817609}
-
Wei Lee authored
For window management, since platform app version uses Chrome App Window API to manage windows while SWA version uses our own implementation in WebUI controller on C++ side, we should abstract it first and implement the logic for SWA version in a latter CL. Bug: 980846 Test: Test with the latter CLs and CCA works normally Change-Id: Id9deadc129db3a123a7ff0e7c078ea732b3ae18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345897 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#817608}
-
Jeroen Dhollander authored
Currently the device-id changes from test run to test run, which will start causing issues after the next Libassistan uprev, as that contains http://libassistant-internal/c/147561 which starts rejecting server responses with mismatching device-id's. Bug: b/170170824 Change-Id: I1e55239947f5b5d083c01bf85e6f891fa8de69c1 Tests: browser_tests --gtest_filter="AssistantBrowserTest.*" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472469 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#817607}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a39689cc986e..4c54f8638cc4 2020-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37c343f0..9b1cb285 (817356:817475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I09dd88095ec200412b6b4c46a6e68f341d44cd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476559Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010150700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/92sajF7l5YU_FHOF0S5XbbEL1anK6DQMIxOzfUm2nZQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I800c2f19f7aec37794194ff10795a9ea2dcfb10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475008Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817605}
-
Jeremy Roman authored
Remove bad Win7 baseline for virtual/dark-color-scheme/fast/forms/color-scheme/scrollbar/horizontal-scrollbar-basic.html. It looks like this was intended to match other Windows versions, like the other pixel baselines, but slipped through the trybots because of a lack of a Win7 trybot running this test. Removing the baseline causes it to share the /win/ expectation, which appears to match the actual result on Win7 bots. See, for example: https://test-results.appspot.com/data/layout_results/Win7_Tests__1_/108950/blink_web_tests/layout-test-results/results.html Bug: 1096729 Cq-Include-Trybots: luci.chromium.try:win7-rel,win7-blink-rel Change-Id: If2e3e8b10a479e3e81bf61c4c0cc3f3d302669b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475953 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b0248ea45f6e..c9206a08c352 2020-10-15 jmadill@chromium.org GLES/GL/Win: Suppress all constancy samples tests. 2020-10-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e72c6099f946 to 52c1a859d9eb (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I41020c73f6bd2e999a85ba61accd912622cfb2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476553Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08ffb75d06d1..9dfc25eb5de2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,jbroman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pkasting@google.com,jbroman@google.com Change-Id: Ic59d0a75770d1a6734c98d75e1bf0acc6e51d0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476561Reviewed-by:
-
Reilly Grant authored
Bug: 878979 Change-Id: I5c24970070e6e6bba0e129efa9bcc3e5e317efd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472447 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#817601}
-
Noam Rosenthal authored
See https://github.com/whatwg/html/pull/5574 Currently applies to JPEG only. Use the EXIF resolution/size information we read from the JPEG image to determine a density-corrected preferred size, which overrides the intrinsic size of the image. We only apply this intrinsic size when an image has both resolution and size information in its exif. When asking an Image for display size, the preferred size is returned, and the source rect for reading from the image is scaled when applicable. Added many WPT reference tests. Bug: 1069755 Change-Id: I01a38c72bb46974a0c112175934cd3c2c48607a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292219 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#817600}
-
Prakhar authored
Reference: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2472980 Bug: 1024915 Change-Id: Ie5338dec1421a2cef04d940b63380bf345508923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476873 Commit-Queue: Prakhar Asthana <pasthana@google.com> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Prakhar Asthana <pasthana@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#817599}
-
Owen Min authored
The following metrics will now expired in M95 Enterprise.PolicyUpdatePeriod.MachineLevelUser Signin.AuthenticatedLaunchUserEvent Bug: 1138274, 1138327 Change-Id: I60f548c3bb0d16df3e06761469b1a7ae23050003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476954Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817598}
-
Fredrik Söderqvist authored
Bug: 1138917 Change-Id: I406730e0d673ac7f58cc9309f8b95141c9623f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476156 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
ProfileSyncService has logic to delete the legacy Directory files on shutdown if the sync engine doesn't exist (normally the engine would do the deletion). One consequence of crrev.com/c/2461325 is that the engine implementation and this deletion no longer have ordering guarantees. If sync is immediately restarted, it's possible that a new engine will be created before the deletion finishes, which is a race condition. This CL fixes the issue by exposing a deletion method in SyncApiComponentFactory (the class responsible by creating engines) which is guaranteed to run sequentially with the implementation of any engine it creates. As a bonus, this removes some assumptions made by ProfileSyncService that the underlying SyncEngine is actually a SyncEngineImpl. Fixed: 1123881 Change-Id: I55528019863eeca9f90c09172c410a87f74e0bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476434 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#817596}
-
Fredrik Söderqvist authored
Point the tests: external/wpt/css/css-masking/clip-path/clip-path-polygon-006.html external/wpt/css/css-masking/clip-path/clip-path-polygon-007.html external/wpt/css/css-masking/clip-path/clip-path-polygon-008.html external/wpt/css/css-masking/clip-path/clip-path-polygon-009.html external/wpt/css/css-masking/clip-path/clip-path-polygon-010.html external/wpt/css/css-masking/clip-path/clip-path-polygon-011.html external/wpt/css/css-masking/clip-path/clip-path-polygon-012.html to crbug.com/694218 because that is their primary (known) reason for failing. Sort this section of the expectations because that made finding the tests easier. Bug: 694218, 843084 Change-Id: Ib55a1a4fd721e1b86782b1f943e009edccdde5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475114 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
