- 22 Oct, 2018 40 commits
-
-
Dianna Hu authored
Add tests for HpackVarintDecoder based on hardwired values. This is in contrast with HpackVarintRoundTripTests that generate input values using HpackVarintEncoder. This allows testing handling of bogus input that HpackVarintEncoder would never generate. NOTE: To comply with Chromium presubmits, this change uses base::size() instead of arraysize. I have added a TODO to create a platform API for array size (such a SPDY API already exists), which I will then use here and backport to Google3. This CL lands server change 214792906 by bnc. BUG=488484 Change-Id: Id697f1cf5f7c1fefe9ae2ce400e9d46e45088c1f Reviewed-on: https://chromium-review.googlesource.com/c/1291815Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601603}
-
Justin Cohen authored
Moves ownership of the NTP coordinator from the NTP tab helper to the BVC. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I470d344778f844145bbd4a615f3753b3980f1614 Reviewed-on: https://chromium-review.googlesource.com/c/1287321Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601602}
-
Fady Samuel authored
Mac no longer needs FirstSurfaceActivation notification so this CL saves an IPC and deletes some unnecessary plumbing. Bug: 893850 Change-Id: Ie8fceb0de65ff9148ff349e8c298eb20be6aa7b5 Reviewed-on: https://chromium-review.googlesource.com/c/1292261 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#601601}
-
Gabriel Charette authored
The Lock is causing hangs because of priority inversion mixed with priority boosting (ScheduleWork() tends to boost the destination thread which may deschedule the posting thread; if the posting thread is a background thread this boost-induded-desched-while-holding-lock can cause a livelock). See https://crbug.com/890978#c10 for example crashes catching this. The Lock was only necessary for startup/shutdown and is being replaced by a lock-free atomic scheme in this CL. MessagePump::ScheduleWork() itself was already thread-safe (but the Android impl did unnecessarily check a non-atomic bool) This adds a WaitableEvent in ~MessageLoop(); hence the requirement for a wait-allowance in net's EmbeddedTestServer. TBR=zhongyi@chromium.org (embedded_test_server.cc side-effects) Bug: 890978, 874237 Change-Id: I0916e5a99035a935b0a23a770af256f334e78c43 Reviewed-on: https://chromium-review.googlesource.com/c/1278631 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#601600}
-
Justin Cohen authored
This is in preparation for the BVC owning the NTP coordinator instead of the NTP tab helper, where the PageDisplayState saving logic will soon be removed. Bug: 826369 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I70e64e9822246a62bd00ab0fc09b167006b4bac5 Reviewed-on: https://chromium-review.googlesource.com/c/1287320 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#601599}
-
Yi Gu authored
TBR=tkent@chromium.org NOTRY=true Bug: 897764 Change-Id: I3a2dee4561c5f7f22436dcc002a5ba6d57a5502c Reviewed-on: https://chromium-review.googlesource.com/c/1293989Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601598}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80c6909bf7ee..294861ff957a git log 80c6909bf7ee..294861ff957a --date=short --no-merges --format='%ad %ae %s' 2018-10-22 bsalomon@google.com zero-init preallocated vertex/index space in drawing manager Created with: gclient setdep -r src/third_party/skia@294861ff957a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:897409 TBR=brianosman@chromium.org Change-Id: I3beb2578a27feed9699d0e3ef0693548c39c8f2a Reviewed-on: https://chromium-review.googlesource.com/c/1292264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601597}
-
Scott Violet authored
The bubble implementation no longer needs the parent, instead it uses Screen::GetDisplayForNewWindows(), which is what the code was using parent for before. BUG=756059 TEST=none Change-Id: Ia58b6144cc6133027827f23ab240e094027c9a36 Reviewed-on: https://chromium-review.googlesource.com/c/1292513Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601596}
-
Jaeyong Bae authored
This status code is unused. So, it could be removed. Change-Id: I182eeca626434d8dcadfd35eec32350f081ae828 Reviewed-on: https://chromium-review.googlesource.com/c/1292930Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#601595}
-
Deepanjan Roy authored
This trace event is still actively used by catapult, and since network instrument v2 project is no longer being worked on, we should keep this event. Change-Id: Ia61df9fd01ecbb8bdc440cf76b826fc8e7fb7d68 Reviewed-on: https://chromium-review.googlesource.com/c/1286872Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#601594}
-
jdoerrie authored
This change applies clang-tidy's modernize-loop-convert [1] in /base. Reproduction steps: - run clang-tidy's modernize-loop-convert - run git cl format - manually remove unused constants due to -Wunused-const-variable [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-loop-convert.html This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 895746 Change-Id: I17cca09164d7ef795ae221994ecc65ca20abe0f2 Reviewed-on: https://chromium-review.googlesource.com/c/1282406 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fa20b7a3bd3c..8c0d048e784b git log fa20b7a3bd3c..8c0d048e784b --date=short --no-merges --format='%ad %ae %s' 2018-10-22 fmayer@google.com Move heapprofd into perfetto::profiling namespace. Created with: gclient setdep -r src/third_party/perfetto@8c0d048e784b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia7e17b7e3f3a7a41973a9748bec2bcb10c06d9da Reviewed-on: https://chromium-review.googlesource.com/c/1293709Reviewed-by:
-
Ken Rockot authored
This corrects the expectations of fast/canvas/OffscreenCanvas-placeholder-image-source.html to align with reality. There does not appear to be any kind of guarantee that the placeholder canvas will be updated within the two scheduler iterations the test was designed to wait for. Instead the test now keeps checking the placeholder canvas until it's updated, which still happens very quickly in practice. If something breaks, the test will timeout. Bug: 872076 Change-Id: Idd1a3018e63f5ad2df540d642f5abb17b80410d5 Reviewed-on: https://chromium-review.googlesource.com/c/1292717Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#601591}
-
Florian Uunk authored
When Wallet sync is inactive, we can't rely on the cards being present. The Wallet Metadata sync integration relies on Wallet data to prune no-longer relevant metadata entries. This CL changes the metadata syncable service to only do this pruning of old metadata entries when we're sure that the wallet data bridge is running. Bug: 890709 Change-Id: Iaad482326ae0b147bf343d71e95c3bbe3e413d99 Reviewed-on: https://chromium-review.googlesource.com/c/1273297Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601590}
-
Joe Downing authored
TBR=michaelpg@chromium.org Bug=876971 Change-Id: Ibb98fa46406252e5827b900771f65a9dd12cc27a Reviewed-on: https://chromium-review.googlesource.com/c/1293755Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601589}
-
Stepan Khapugin authored
Creates a shared file with NTP tile-related constants. Bug: None Test: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I315b5c6fee67356c70b315771980d7654381dcf6 Reviewed-on: https://chromium-review.googlesource.com/c/1288789 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL starts to clean up the TabSwitcher interactions. It: - removes unused methods from TabSwitcher - Clarifies in MainController that the tab switcher is always the tab grid. - Factors away the dismissTabSwitcherWithoutAnimationInModel: method in MainController, which was only called from one place. - Removes a call to displayCurrentBVCAndFocusOmnibox: which was always a no-op for the tab grid. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id911796f0e0d419da79aaf2181c7adca64f6c558 Reviewed-on: https://chromium-review.googlesource.com/c/1249088Reviewed-by:
-
Christian Biesinger authored
This reverts commit a7afe430. Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi# Original change's description: > Perfetto: Optimization to avoid string table lookup for _END events > > If we're emitting an _END trace event, we know that the string > table entries for the name and the categories have already been > emitted and so we don't need to check the string table in this > case. > > R=primiano@chromium.org,skyostil@chromium.org > > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f > Reviewed-on: https://chromium-review.googlesource.com/c/1258043 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600183} TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520 Reviewed-on: https://chromium-review.googlesource.com/c/1293612Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#601586}
-
Anna Malova authored
Init is potentially heavy call which is run on the UI thread during dynamic module loading. Add UMA to measure its execution time. Change-Id: I09d98f8efcc7183d04846dc694516e2eeb35154f Reviewed-on: https://chromium-review.googlesource.com/c/1291310 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#601585}
-
Anna Malova authored
Remove the WeakReference in the LoadModuleCallback. Add check to not create the second loading task if dynamic module if it is currently loading. Bug: 853793 Change-Id: Ie02a7dd63e3f9e8a21e48d18affb3c25d90ab0ed Reviewed-on: https://chromium-review.googlesource.com/c/1286661Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
Nico Weber authored
Bug: 897742 Change-Id: Id980269ea623f9800b62aead3896d107690a64eb Reviewed-on: https://chromium-review.googlesource.com/c/1293559Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601583}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7090b273..e696a0e1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie661f39815765357d3aa2e86f8dee2982a1ff645 Reviewed-on: https://chromium-review.googlesource.com/c/1292804Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601582}
-
Matt Falkenhagen authored
Re-enabling with looser expectations so there is still test coverage of this case. The failure was that the preload request came after the fallback request. The order actually might not be guaranteed if they are on different loading pipelines/http connections? Anyway, the important thing is that the page loads and it's not worth investigating more as network fallback from navigation preload is an anti-pattern. Bug: 896230 Change-Id: Idadfc573fbbeb2c0703c3a3ffa1efef14b991614 Reviewed-on: https://chromium-review.googlesource.com/c/1290573Reviewed-by:
-
Yi Gu authored
This reverts commit 3b62417e. Reason for revert: Suspecting this patch caused gclient runhooks failing on ios simulator. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-xcode-clang/58250 Original change's description: > [iOS] Updating enable/disable items in the Google Services settings > > "Google activity controls", "Encryption", and "Manage synced data..." > is enabled when the user is authenticated and disabled otherwise. > > Screenshot shared with Chromium accounts: > + Signed out: > https://drive.google.com/open?id=19lXF2SdgpLdHUlTZ4WpxipDBdQNCshbU > + Signed in with consent accepted: > https://drive.google.com/open?id=1SV3HhbG3hAbre5mSe06Dhjda4dJC4cck > + Signed in with consent not accepted: > https://drive.google.com/open?id=1r5umMw6vf8yzh8X7V8V6LzRJVJLq8Rxs > > Bug: 883101 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: I3e2180c83f42adccb2717f2fdb96efa254751bbc > Reviewed-on: https://chromium-review.googlesource.com/c/1290937 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601537} TBR=jlebel@chromium.org,sczs@chromium.org Change-Id: Iac738ad46478cda09124b37b22b8936a8f8d7e20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883101 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1293758Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28c3dd83af31..d8fd32bf4423 Created with: gclient setdep -r src-internal@d8fd32bf4423 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibd4b8043eddd9a119df277b20922fbce4c8c0f1c Reviewed-on: https://chromium-review.googlesource.com/c/1293669Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601579}
-
Vaclav Brozek authored
Initially, the bug tracked properly separating sync-specific code from the password_manager core. Later, this decision was reversed (details on the bug), and the sync layer was dissolved. The one forgotten TODO comment is obsolete by now, so this CL removes it. Bug: 515108 Change-Id: Iad3d97b4e63a32512075d70452a756333c871eec Reviewed-on: https://chromium-review.googlesource.com/c/1292056 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601578}
-
Mohamed Amir Yosef authored
BookmarkModelTypeProcessor::GetStatusCountersForDebugging() falsely assumed the initial sync is done by the time this method is called which isn't necessarily the case. The bookmark_tracker_ is only instantiated after initial sync is done. This caused reported crashes. This CL address this properly by not emitting counters in that case, but run the callback directly. Bug: 516866 Change-Id: I2a6d605154694d8ab0ddb2a1e7d1ea4c31ddb620 Reviewed-on: https://chromium-review.googlesource.com/c/1291410 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c98849cf92c3..ff292f30d9a4 git log c98849cf92c3..ff292f30d9a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 magjed@webrtc.org Remove deprecated barcode scanning functionality 2018-10-22 jonasolsson@webrtc.org Compute RTCConnectionState and RTCIceConnectionState. 2018-10-22 srte@webrtc.org Adds support to change transport routes in Scenario tests. 2018-10-22 srte@webrtc.org Adds field trial to do safer reset on route change. Created with: gclient setdep -r src/third_party/webrtc@ff292f30d9a4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a41229a354b1a7e1d0371a93b1c1fa52cf71e3a Reviewed-on: https://chromium-review.googlesource.com/c/1292262Reviewed-by:
-
Bryan McQuade authored
The existing implementation for UKM.Sources.SerializedCount ends up counting some sources that don't get serialized. This change fixes that, versions the histogram to reflect the change, and adds SourceIdType-specific breakouts for this histogram. The SourceIdType-specific breakouts are useful because navigation id sources are a more stable representation of the number of distinct navigations being tracked by UKM. Change-Id: I958bc36f6a37a2e7f2e02b6ba05dee939b711298 Reviewed-on: https://chromium-review.googlesource.com/c/1291594Reviewed-by:
-
Juan Antonio Navarro Perez authored
Disable some stories currently flaking on internal perf bots. TBR=nednguyen@google.com NOTRY=true Bug: 892704 Change-Id: I9d9ddf82c0818598c5c0b655f1813ad341feea49 Reviewed-on: https://chromium-review.googlesource.com/c/1293578Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#601574}
-
Justin Donnelly authored
I'm the only person who currently uses this list and I've been ignoring CLs in these directories unless they touch any of the other omnibox directories. Change-Id: Id85e3e5fa525a151823a353666dbe2571c4a6835 Reviewed-on: https://chromium-review.googlesource.com/c/1293169Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#601573}
-
Michael van Ouwerkerk authored
Bug: 872711 Change-Id: Iec7589f94a4162befce59e2622fba8307fcf12c5 Reviewed-on: https://chromium-review.googlesource.com/c/1291392Reviewed-by:
-
Charlie Harrison authored
This CL adds new breakouts to the existing ContentSettings.Exceptions histograms, for cookies, popups, and subresource-filter settings. Bug: None Change-Id: I2967cd82ba9dd23b73a466f40b980f303ed48373 Reviewed-on: https://chromium-review.googlesource.com/c/1277548Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#601571}
-
Nicolas Ouellet-Payeur authored
This enables the build on Mac OS X, and refactors AlternativeBrowserDriver to work correctly on Mac OS. Bug: 881589 Change-Id: I6e73d33d83af5bc1c0d8bb3ec3e76fcf8409ee2e Reviewed-on: https://chromium-review.googlesource.com/c/1283835Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#601570}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6e85d1a6fc75..20bbfb6f4da6 git log 6e85d1a6fc75..20bbfb6f4da6 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 33432579+alan-baker@users.noreply.github.com Layout checks should recurse through runtime arrays (#1999) 2018-10-22 33432579+alan-baker@users.noreply.github.com Better checking of the index operand (#1992) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@20bbfb6f4da6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8c5827547dc76f931152dce4738dbd85ea39e0a3 Reviewed-on: https://chromium-review.googlesource.com/c/1292259Reviewed-by:
-
Stepan Khapugin authored
Creates a collection view, cells, and plumbing for most visited sites in zero-state of omnibox. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifcc5af9806178fc6a53af64587086a504f957aca Reviewed-on: https://chromium-review.googlesource.com/c/1286418 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Yi Gu authored
The newly added test LoggingTest.LogMessageMarkersOnStack caused consistent crash on Win10 Test. Disable it ATM and TBR the owner. TBR=wez@chromium.org NOTRY=true Bug: 897735 Change-Id: Ic775ac5a5cccbe6c5064407ac17534018561468b Reviewed-on: https://chromium-review.googlesource.com/c/1293670Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a20a50c6f2c7..fa20b7a3bd3c git log a20a50c6f2c7..fa20b7a3bd3c --date=short --no-merges --format='%ad %ae %s' 2018-10-22 fmayer@google.com Merge "profiling: Add tool to verify sampling strategies." 2018-10-22 primiano@google.com Merge "Docs: Fix links" 2018-10-22 primiano@google.com Infra: update perfetto site to mirror github pages Created with: gclient setdep -r src/third_party/perfetto@fa20b7a3bd3c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifbb79f2bd812ae9d9ae76bc18e2abe989a76984f Reviewed-on: https://chromium-review.googlesource.com/c/1292260Reviewed-by:
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/1293550 fixed an initializer regression. TBR=dpranke Bug: 94925 Change-Id: I5cab9614798588424a97c1fc3635d1d2e0ea398c Reviewed-on: https://chromium-review.googlesource.com/c/1293556Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601565}
-
Victor Costan authored
Change-Id: Ie63379b3002521a1badac056809edbf8b8d40b71 Reviewed-on: https://chromium-review.googlesource.com/c/1292956 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601564}
-
