- 21 Jan, 2021 40 commits
-
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I7512620397af04415592611083c4aba2b21e4a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642372 Commit-Queue: David Bertoni <dbertoni@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#845808}
-
Tomasz Śniatowski authored
This header uses size_t and should include something to get it. This happens to work in the default libc++ config, but can cause a build failure in builds with libstdc++. Change-Id: I1fd3af74bc19b491ae9f4c3529a536f0b93735ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640578 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845807}
-
Jeffrey Kardatzke authored
There's 2 things that were wrong. We were not initializing the VAEncryptionParameters structure we were using, causing bad values to be present. We also had a regression error where we then were resubmitting the VAEncryptionParameters during decode of full sample content. This fixes both of those. BUG=b:178039332 TEST=Full sample H264 protected content plays on volteer Change-Id: I47b82a5f022292290151178cc26266c55b9dff42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643536 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845806}
-
Xianzhu Wang authored
Previously we rasterized fully recorded tiles only, requiring that blink must expand the recording rect by at least the tile size, which was fragile. CompositeAfterPaint calculates cull rect before painting and compositing so we don't know the bounds of a composited layer and how it intersects with the visible area, and we don't know which paint chunk will be indirectly composited later, so we can't ensure we meet the recording rect expansion requirement for every composited layer. Allowing rasterization of partially recorded tiles will remove the requirement, and this allows more flexibility of blink recording rect expansion and cc tile size. Bug: 1046544 Change-Id: Ibfe86eeecd46925deacc7a74afa2fee789e65867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628491Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845805}
-
Xianzhu Wang authored
This reverts commit 17de3187. Reason for revert: the root cause of crbug.com/1164610 has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2636883. This is a clean reland of the original CL. Original change's description: > Revert "Cleanup for LayoutView overflow clips" > > This reverts commit 49dd6b58. > > Reason for revert: The scale of the devtool override frame size seems > incorrect, causing crbug.com/1164610. > > Original change's description: > > Cleanup for LayoutView overflow clips > > > > 1. Move the code checking requirement of overflow clip for printing > > from PaintPropertyTreeBuilder into LocalFrame::ClipsContent(). > > > > 2. Combine LocalFrameView::ClipPaintRect() into > > LayoutView::ViewRect(), so that all code paths calling ViewRect() > > (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport > > overriding aware. This means that the overriding viewport is > > reflected in the paint property tree, and > > CompositedLayerMapping::RecomputeInterestRect() no longer needs to > > apply the viewport clip separately. > > > > Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388 > > Reviewed-by: Stefan Zager <szager@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#841701} > > Bug: 1164610 > > TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I18249c79339935b381ae3a05984d5f139d5194a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622514 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842140} # Not skipping CQ checks because original CL landed > 1 day ago. TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Bug: 1164610 Change-Id: I38bd98f55387ac85e441ab3cfa4dc7a310e1c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628315 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845804}
-
Andrew Grieve authored
The desugaring thing is more nuanced than it sounds, and now affects only Android L & M, and so is less relevant. Change-Id: I27e6e38644590b320fc60047806bed9389fe8203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642962 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845803}
-
chrome://policyIgor Ruvinov authored
When a policy conflicts with another and their values are the same, the policy page now displays a message under the status "Info", as well as labeling the conflict as "Superseding". The wording of the conflict status messages is also adjusted to increase clarity. Screenshot SHAs depicting the new labels and messages are included in this CL. In addition, support for various conflict types is implemented by adding a new EntryConflict class. The conflict type is determined based on the two conflicting policies' values. If the values are equal, the conflict is treated as superseding. Otherwise, the conflict is overriding. Policy table before update: http://screen/7RMnvFaR3S3xcC6 Policy table after update: http://screen/5JE3yrUsn5JKsVT Bug: 1104043 Change-Id: I36dea4b14f8068854d8d7713892187d930956e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625896 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#845802}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611230296-dcf016b3b57961245ab4f6b250bc80f143758478.profdata to chrome-mac-master-1611251835-293c4fab8514e5eb6bd360b905bded2a6927bf71.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If066f9a38e8f411cff37e77ce46852ca690fa9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845801}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e306939..bba017b4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4bb26531b0421e425cb341f83dfc5f8cfcf3a71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642642Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845800}
-
Keren Zhu authored
DOMAgent’s OnUIElementRemoved() DCHECKs if the UIElement to be removed exists. Yet, elements of a bubble are currently being removed twice, breaking this DCHECK. The first removal is in WidgetElement::OnWidgetDestroyed(). The second is in WidgetDelegate::DeleteDelegate(), where eventually ViewElement::OnChildViewRemoved() is called. Because the whole DOM tree is removed in the first call, the DCHECK fails in the second call. This change removes the above DCHECK and sends the removal request only when the node exists in the DOM. Bug: 1167240 Change-Id: Ia6fc327a8fc5004dce7333f232b323f7b677fbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639134 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#845799}
-
Yaron Friedman authored
Change-Id: Id92fbd938838b8c52fae59ff07d1d0ed9e060e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640744Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#845798}
-
Michael Crouse authored
Bug: 1160820, 1160821, 1160822 Change-Id: Iaa846223faf3201598625d93299a3d93bb9796c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642753 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845797}
-
Charlie Hu authored
This CL adds a PRESUBMIT check on document policy code generation to compare the generated .cc file with the reference file. Note: the test is suffixed with '_presubmit_only', so that it will be excluded from 'run_blinkpy_tests.py' task, where jinja2 module is not available. Bug: 1166698 Change-Id: I4d2a1f3a9960c79e79d526ab8445d0ade74b4143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633734 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845796}
-
Dave Tapuska authored
Change WebRect -> gfx::Rect. BUG=738465 Change-Id: I8603045e47cbfa5a2549f724b29de5521cef4dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641081 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845795}
-
Dave Tapuska authored
No behavioral changes intended. BUG=738465 Change-Id: I6849f610370625fec5cec7267404e1fb56c70da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639223 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845794}
-
kylechar authored
These data members were carried over from GLRenderer but are never actually used. This is a no-op change. Bug: 1161653 Change-Id: I2167b728b754a36200a21a7d18b461cec35e1cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643437Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845793}
-
Aleks Totic authored
Painting code assument that: - all child fragments of a section are rows - all child fragments of a row are cells This is not true when row/section is a absolute container. Modified wpt test to trigger the crash Change-Id: Ife8102412a2ef3f2d5bae07a6031739759c3c994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636881 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845792}
-
Nektarios Paisios authored
This work is required before we can merge the two position classes: AXNodePosition and BrowserAccessibilityPosition. This patch fixes AXNode::IsIgnored so that it won't mark focused nodes as ignored. This is for consistency with AXNode::IsVisibleOrIgnored. The merged AXPosition class will need to rely on IsIgnored extensively and there shouldn't be a mismatch with platform code that uses IsInvisibleOrIgnored. Also improves method comments and simplifies the name of AXNode::IsFocusedWithinThisTree. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Bug: 1049261 Change-Id: Ic8fc261b10afcf5db2a458bf9081e17036ccc82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637596Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845791}
-
Stefan Zager authored
Bug: 1103427,918186,1036525,936655 Change-Id: I661fdfdc9dac1168a65ebab2d3c28cd0cadf0448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636885 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845790}
-
Scott Violet authored
I suspect I'm going to need some tuning of exit. Unfortunately chrome shutdown path is pretty hard to observe outside of the code itself. BUG=1167296 TEST=SessionServiceLogTest* Change-Id: Iae2647695be8f6e6932406bbb88df2dd2ab76504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641117 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845789}
-
Sky Malice authored
Previous attempt to fix this https://crrev.com/c/2605393 was flawed in that it used the wrong suffix string. Also not sure how IPH_NewTabTip appeared in my previous CL, but removing it here. Sorry for the churn. Bug: 1162103 Change-Id: I1584d6cfeaa43d23d76a4fc31b0f1f47acc4676b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641564Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#845788}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611230296-a0d70aa7451b9c0a65b3b69ada45b93ac77ab251.profdata to chrome-linux-master-1611251835-492ad3518ecdcc200059acbff6fa6ac0a2007e2f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iee71048315dcd7f7dfe2381d78dbb9c6fd25e549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845787}
-
danakj authored
OnRenderFrameCreated will send to frames when they are created in the renderer process - avoid sending the model to frames that do not exist. Previously this was silently dropped, and in this case the code handles things by sending the message later. R=drubery@chromium.org Bug: 1169066, 1158869 Change-Id: I7daffcce74c568f1c09f18288ab3e7cde3bc6b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642880 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#845786}
-
Yuanyao Zhong authored
Make sure a set the semantic's role as kList only when it has actionable children. Otherwise it is just a GenericContainer. Bug: b/178063833 Test: test on assistant device. Change-Id: Ie309e7bd3b87907fea19dbd1896f886965c7752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643478Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#845785}
-
Ben Wagner authored
Pull latest from https://github.com/webrtc/samples. In particular, this includes https://github.com/webrtc/samples/commit/583fc1a6efacd19d9485be381a8698d12748b671 which is a followup to https://chromium.googlesource.com/chromium/src/+/4eab15e1d4e2c0c9e4a6369c9d65ac2f543d489a to resolve the perf regressions in bug 1167426. PS1 has all manual changes. PS3 is the result of: $ ./tools/perf/page_sets/update_webrtc_cases $ git restore tools/perf/page_sets/webrtc_cases/datatransfer.js (Necessary because https://chromium-review.googlesource.com/c/chromium/src/+/2579968 is not present in the upstream yet.) Tested locally on Mac with: ./tools/perf/run_benchmark run webrtc --browser=system ./tools/perf/run_benchmark run webrtc --browser=canary ./tools/perf/run_benchmark run webrtc --browser=exact --browser-executable=/Applications/Google\ Chrome\ Beta.app/Contents/MacOS/Google\ Chrome\ Beta Bug: 1167426 Change-Id: I9d4605e8149dc5dafcfcee13cbfd3a7cd6d7b92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642360 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#845784}
-
Christian Biesinger authored
R=masonfreed@chromium.org Change-Id: I885b95fb269e2f9f239233fedc825739b674b7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642858 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#845783}
-
Nektarios Paisios authored
This is required before merging BrowserAccessibilityPosition and AXNodePosition. In UI Automation, we expose an "embedded object replacement character" \xFFFC in the text representation of all empty controls, so that they will be treated by AXPosition as word, character and line boundaries. This patch moves some of the logic for determining which node is an empty control to AXNode in the form of the AXNode::IsEmptyLeaf method. Note that the definition of a control is quite loose and it encompasses all leaf nodes that expose no inner text or hypertext. This is in order to cover all possible future additions to our rendering engine and in order to extend this behavior to possibly other elements which meet the same criteria. This behavior is not new, but it has been moved from AXPosition::IsEmptyLeaf. This patch also fixes AXNode::IsLeaf to properly mark ignored nodes that have children as not leaves. A leaf node should be, either a node with no children (including ignored and unignored), or any unignored node whose entire subtree is not exposed to platform APIs. Ignored nodes that are already in an ignored subtree, should not be marked as leaves too, otherwise AXPosition::AsLeafTextPosition() might stop unexpectedly while traversing the AX tree to find a leaf node: ++kTextField "Some Text" (leaf node) ++++kGenericContainer ignored (should not be marked as a leaf node) ++++++kStaticText "Some text" ++++++++kInlineTextBox "Some text" (leaf node) For optimal performance AXNode::GetInnerTextLength() is introduced and is used by AXNode::IsEmptyLeaf(). Concadenating strings is much slower than adding up their lengths. Finally, AXNode::GetHypertext() is fixed so that descendants of leaf nodes have the correct hypertext per the existing IA2 and ATK behavior. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Bug: 1049261 Change-Id: I4ea5b578dded79920f07bf6a66df208dd4a88fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637515Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845782}
-
Xianzhu Wang authored
It fails in pre-CompositeAfterPaint and succeeds in CompositeAfterPaint. Bug: 148499 Change-Id: I8c755bb3c12d01a7187bd175aa5b871e83e16766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643045 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#845781}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I803b68b1341ee0faa382b9d37d2decaa7d6899e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626180 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845780}
-
Ella Ge authored
This goes through the RenderFrameHost to get to the Impl under content, similar to the HeavyAdIssue. Then build up the message and send to devtools protocol. This CL also adds passing the package name and signature to jni when violation type is DIGITAL_ASSET_LINK, so that they can be use for displaying the issue. Design doc https://docs.google.com/document/d/1Dsw4bYttTODZJ7QbRlS4-iN7nBFnJJ1-JGmUY6gdMiE/ Issue string https://docs.google.com/document/d/1nlYeWlwCOva7M9EoT6YKQZ4s-Ug8aXbQIp4Oc1cL8WE/ Bug: 1147479 Change-Id: I57b5fb9b415889efc998cf88223ef0a87b77ade8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568749Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#845779}
-
Lily Chen authored
Change-Id: Ife6e67c51e755f38dad7c1795fd2c0979943e67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642829Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#845778}
-
Tomasz Wiszkowski authored
This change adds TILE_NAVSUGGEST suggestion to the list of special match types that are excluded from GroupBySearchVsUrl. Bug: 1165941 Change-Id: I36791175c81289d752b69b01bfddf5844dd12d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641144Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#845777}
-
Austin Sullivan authored
Bug: N/A Change-Id: I3d0b3b83c35b322b650bba7bd636f71f2364275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630009 Auto-Submit: Austin Sullivan <asully@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#845776}
-
Evan Stade authored
Bug: 1147268 Change-Id: I7b67ba260d5b2f818ee52308a25cec8d496dac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638218Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845775}
-
Ajit Narayanan authored
Records how the Select-to-speak actions of sentence/paragraph navigation and exit were triggered (i.e. through button click or keyboard shortcuts). Bug: 1143814 Change-Id: I17b524d9683f1298ce3cfb4d5fa97fbdc3bc4415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602854Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Cr-Commit-Position: refs/heads/master@{#845774}
-
Austin Eng authored
This follows the deprecation of the old vertex_idx identifier in the WGSL spec. Bug: none Change-Id: If3cf3d3b985b79b85b9807b17e5458bacd0805dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643238 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#845773}
-
Michael Lippautz authored
A past refactoring translated `unique_ptr<TaskRunnerTimer>` to `Member<DisallowNewWrapper<HeapTaskRunnerTimer>>` to preserve semantics. Inline HeapTaskRunnerTimer which avoids a dynamic allocation. Change-Id: Id3c788c3dedab1dbf3022e0d8ebe5dfca47235b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640373 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845772}
-
Jan Wilken Dörrie authored
This change extends expiring PasswordManager and PasswordGeneration histograms and marks "PasswordManager.OtherPossibleUsernamesUsage" as obsolete. R=chromium-metrics-reviews@google.com Fixed: 1165103, 1165104, 1165114, 1165115, 1165116, 1165118, 1165119 Change-Id: Ib2bd28896c05ddb9c24fe7f191299a7e58e39321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632651 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#845771}
-
Michael Crouse authored
This is a reland of 3f534050 This resolves the builder issue for neon performance warnings. Original change's description: > Reland "[TFLite] Enable tflite in build for android and desktop." > > This is a reland of a4df03d0 > > This addresses the revert by removing neon from the TFLite build > for chromeos. > > > Original change's description: > > [TFLite] Enable tflite in build for android and desktop. > > > > Bug: 1165517 > > Binary-Size: Expected increase due to inclusion of TFLite in binary. > > Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845026} > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Bug: 1165517 > Binary-Size: Expected increase due to inclusion of TFLite in binary. > TBR: Andrew Grieve <agrieve@chromium.org> > TBR: Tarun Bansal <tbansal@chromium.org> > Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845478} Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. Change-Id: I6f3b3a4a8b4bfda89eae49f9c24b684ff8ec8dab Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642742 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845770}
-
Yuwei Huang authored
This CL makes the host uninstaller delete the settings file. Change-Id: If03663338817dba6b15f15ae4493e6edfce9290d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640652 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#845769}
-