- 16 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c018fc6ae667..61b7de3c39f0 git log c018fc6ae667..61b7de3c39f0 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 stevenperron@google.com Remove unreachable code. (#3304) 2020-04-15 afdx@google.com spirv-fuzz: Fix to outliner (#3302) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@61b7de3c39f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I014b7f784c0e83bf79741f3c865a51b1d2abadae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759586}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/b4mdc.....Eheze... Created with: gclient setdep -r src/third_party/aemu-linux-x64@Eheze... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I39970cda14024a233a7f0c936e4074a910d361d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151639Reviewed-by:
-
Alex Ilin authored
https://crrev.com/c/2144200 introduced a regression that broke the javascript bridge in the remote consent flow. "inject.js" should be injected in all pages within the consent window. A recent change made webview.executeScript() execute only once, after the first page is loaded. This CL modifies 'loadstop' listener so the script is injected for all pages but the window is shown only once. Bug: 1026237 Change-Id: I9f70d99f9cda7c4c6dd7194630a5b2fa1ede5d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151865 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759584}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I8b0881035d4ca718c2f973276bf4411356dbfbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143888Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#759583}
-
Kenichi Ishibashi authored
This is a reland of 6d769734. Difference from the original CL is to rebase after 85a40bf3. Original change's description: > Add ServiceWorkerStorageControl::UpdateLastUpdateCheckTime() > > This is a wrapper of ServiceWorkerStorage::UpdateLastUpdateCheckTime(). > > Bug: 1055677 > Change-Id: I3bf89d2c227d5b6f0a1c41e108843ae1d51a778b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147435 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759541} Tbr: shimazu@chromium.org, kinuko@chromium.org Change-Id: Id03cd5f3afa0c7338f924e8569f7d01cb50acb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152327Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759582}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a887423b..d7247aad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee6720fc9fffba7793e7d025b9ee0dfdb86b402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151549Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759581}
-
Viktor Semeniuk authored
This change fixes the bug when Compromised passwords are not displayed in passwords section if check was not finished successfully e.g. Canceled although some number of compromised passwords were found. Bug: 1070897 Change-Id: I73068029f0c02979520bc7caddabc7d72e7b1faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148323Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#759580}
-
Gyuyoung Kim authored
This CL migrates flex-item-grid-container-percentage-rows [-expected].html from fast/css-grid-layout to external/wpt/css/css-grid/grid-items with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to flex-item-grid-container-percentage-rows-001[-ref].html to be align with existing tests. Bug: 1063749 Change-Id: I2959664d4f110190f87ba66416e46df747257cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147762 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759579}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I1f8fca66a8d0e6561dae79058171fa1243aecee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152219Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759578}
-
Kenichi Ishibashi authored
This is a reland of d69aec62. Difference from the original CL is to rebase after 85a40bf3. Original change's description: > This is a wrapper of ServiceWorkerStorage::UpdateToActiveState(). > > Bug: 1055677 > Change-Id: I1444227429fd4c4647198702db79b0d414514571 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147983 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759540} Tbr: shimazu@chromium.org, kinuko@chromium.org Change-Id: I045b9beefe73ed004075f70ebd7aff092675e635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152054Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: Iacb1ae872d38e57df2bee90e3dba9583a334877c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148748Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#759576}
-
Kuo-Hsin Yang authored
The mem_usage and chrome_user_log log items in feedback reports contain tab titles which may include SPII, these tab titles should be removed. Individual items in Feedback could be excluded based on dialog input. Added a new log item mem_usage_with_title that will be send with user consent. BUG=chromium:1070935 TEST=check mem_usage in chrome:://system Change-Id: I8f2ee0b21181ddd194e18009f68e5805f6ad2c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149741 Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759575}
-
Ewann authored
This CL removes the top separtor of the Cookies tableView. Bug: 1064961 Change-Id: I4a91b8ee567642d838c93034b57bbba87e41d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149654Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#759574}
-
Guido Urdaneta authored
This test has been timing out on several bots. Bug: 1071329 Change-Id: I3c85843fa202f2adf1f1965f96931ccc6f180881 No-Try: true TBR: hta@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151867Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#759573}
-
edchin authored
This CL corrects the behavior of managed bookmarks in the following ways: 1) Long press is enabled for managed bookmarks and folders. But the 'edit' and 'move' options are disabled. This is also fixed in search results. 2) Fixes a bug where swiping managed nodes was possible in search results. 3) In editing mode in search results, 'regular' bookmarks can be selected/checked into an editing set. But managed bookmarks cannot. This CL also adds EG tests for these behaviors. Bug: 1065187 Change-Id: I4d5d47e3f8b884407fce31ceccc9bc2eab7ea8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148230 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#759572}
-
Armando Miraglia authored
Fixed: 1066041, 1066040, 1066039 Change-Id: I2b82a25199621cc42acfb53c230d0940c0a75afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145885Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#759571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c22240b1a04..a6fbe4e685f0 git log 8c22240b1a04..a6fbe4e685f0 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6e0d718a48d8..49ad8eaae192 (9 commits) 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src cddb357f..59d22330 (395 commits) 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 81e08df29531..2430d665d3f2 (4 commits) Created with: gclient setdep -r src/third_party/skia@a6fbe4e685f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I1037582f3570e0d0b1f2f02931f580571b1ade95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152347Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/953cd08e70a0..159f3561ccfa git log 953cd08e70a0..159f3561ccfa --date=short --first-parent --format='%ad %ae %s' 2020-04-16 dberris@chromium.org Pinpoint: Do not double-cache Isolate entities 2020-04-16 fancl@chromium.org Add group_report for AlertGroup Created with: gclient setdep -r src/third_party/catapult@159f3561ccfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955,chromium:1070753 Tbr: skyostil@google.com Change-Id: I40b55e42c50ac3ef83e4ce34923a649a18901417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151063Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf0cc7170286..157451f9900a git log bf0cc7170286..157451f9900a --date=short --first-parent --format='%ad %ae %s' 2020-04-16 sigurds@chromium.org [issues] Make types more precise Created with: gclient setdep -r src/third_party/devtools-frontend/src@157451f9900a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I346e72163dc23813fd45be0be730525d5d66ef4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152350Reviewed-by:
-
Mike Dougherty authored
Returning a PolicyDecision which was created with CancelAndDisplayError from ShouldAllowRequest will cancel the request and display the error to the user. This can be used to display to the user why a request was cancelled. Bug: 1065161 Change-Id: I4418cb099aa7fab01a3bca6fa08d3c5e67fce986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140958 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759567}
-
tby authored
Link the OS settings search provider with the settings SearchHandler, by querying it for results on each search. These results: - Set their metadata from the returned SearchResultPtr. - Launch the settings app via chrome::SettingsWindowManager::ShowOSSettings. Bug: 1068851 Change-Id: I2f7236fcec3401c14f54934dee03302c3fbf7ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147132Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#759566}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6364c48eb481a4d8d289e7506b70d019bda1b90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152345Reviewed-by:
-
Alice Wang authored
This CL fixes the flaky test testDialogIsDismissedWhenRecreated by replacing the original Activity.recreate() with a blocking call to ensure the execution is blocked till the activity is resumed. Bug: 1054855 Change-Id: I841cbc6668dc0d8df3ccbc9c9005023baebdc07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144026Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759564}
-
Anders Hartvoll Ruud authored
I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/tOHolEkBeY8/jX0jvQqkBAAJ Bug: 579788 Change-Id: I7282552f4b8339adc63ffc262cfb59cda2c3f7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146908Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759563}
-
Guido Urdaneta authored
This reverts commit b79724f8. Reason for revert: Causing flaky failures in Mac10.14 Tests bot. First failure here: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/3374 telemetry_perf_unittests on (none) GPU on Mac failed because of: measurements.rasterize_and_record_micro_unittest.RasterizeAndRecordMicroUnitTest.testRasterizeAndRecordMicro Original change's description: > Collect reasons of disallowing LCD text > > (TBR for passive change in tools/perf/measurements/rasterize_and_record_micro.py.) > TBR=wangxianzhu@chromium.org > R=pdr@chromium.org > > Bug: 642885 > Change-Id: Ia5c8313ea9e34139e06ff11fcc5d751ff0768c75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149914 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759474} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ic25a88c23e6f504461d3100fbf3bc8f8429c81f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 642885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151450Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline-margins-2.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-003.html. BUG=1063749, 767015 Change-Id: I24861becfc1be0554f02e3a3491398a07b0f039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145747 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759561}
-
Miyoung Shin authored
CL migrates grid-baseline-margins-1.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-002.html. BUG=1063749, 767015 Change-Id: I704b393b1c257c9a79b70903014f13fc5cf54039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143188 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Miyoung Shin authored
CL migrates grid-baseline.html to external/wpt/css/css-grid/alignment, adding links to the relevant specs and a test assertion describing its purpose, renaming it to grid-baseline-001.html. BUG=1063749, 767015 Change-Id: Ia642e5876f5a936f11fc268adf93dd9ddf9479c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147988 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Add checks for the completion. Call completion when |fileURL| is nil. Completion is always called on the main thread. Bug: 1045457 Change-Id: I74be7d0cf110efe30be6ced0ce4172395d966193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148324 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf321a18..a887423b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2303169cf49925203f887fb591ce5766af98707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151967Reviewed-by:
-
Guido Urdaneta authored
This reverts commit ca4ccac9. Reason for revert: Suspect of causing consistent failure in Win7 Tests (1) bot. First failure: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/101716 device_unittests failed because of: All/BluetoothRemoteGattCharacteristicTestWinrt.WriteRemoteCharacteristic/1 All/BluetoothRemoteGattCharacteristicTestWinrt.ReadRemoteCharacteristic_WritePending/1 All/BluetoothRemoteGattCharacteristicTestWinrt.RemoteCharacteristic_Nested_Read_Write/1 All/BluetoothTestWinrtOnly.ConstructFakeAdapterWithoutRadio/0 ...46 more failure(s) (50 total)... [ RUN ] All/BluetoothRemoteGattCharacteristicTestWinrt.Notification_During_WriteRemoteCharacteristic/1 ../../device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc(1544): error: Expected equality of these values: notification_value Which is: { '\xDE' (222) } characteristic1_->GetValue() Which is: {} Original change's description: > Remove BluetoothTest::PlatformSupportsLowEnergy() > > Remove BluetoothTest::PlatformSupportsLowEnergy() since it always > returns true (all dead code hiding behind it is also removed). > Note: BluetoothLowEnergyWrapper::IsBluetoothLowEnergySupported() is left > as-is since it's still used, but no longer used > BluetoothLowEnergyWrapperFake::IsBluetoothLowEnergySupported() is > removed. > > Bug: 971817 > Change-Id: I6d2b53bf6b840d3015a736c56a58055863ba6a3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144190 > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759318} TBR=nsatragno@chromium.org,odejesush@chromium.org,bershanskiy@pm.me Change-Id: I7ce54a52b9f4f3082ad2f5e168d829c972c91980 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 971817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151566Reviewed-by:
-
Koji Ishii authored
This patch changes |NGFragmentItemsBuilder| to make an initial reservation when the inline formatting context is expected to be huge. r759327 crrev.com/c/2150327 changed to expand more aggressively than before, but still a huge inline formatting context can require several buffer reallocations. This patch computes an estimated size from the text of the inline formatting context, and make an initial reservation when it's large enough. Also contains changes for: * |NGFragmentItemsBuilder| constructor was changed to take |NGInlineNode|. The old argument |NGBoxFragmentBuilder| was removed because it was not used any longer. * |SetTextContent| was removed. Inline pre-layout is already ran at the point |NGFragmentItemsBuilder| is constructed. * Some |NGBlockLayoutAlgorithm| functions are changed so that it can keep once computed |FirstChild()| and pass to |NGBoxFragmentBuilder|. Bug: 982194 Change-Id: I62837da60d6651dad36880639880f605d5a46212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149487Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759555}
-
Guido Urdaneta authored
This reverts commit e4effcd8. Reason for revert: Suspect of causing consistent failure First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49293 browser_tests on (none) GPU on Mac failed because of: WebBluetoothTest.NavigateWithChooserCrossOrigin SerialTest.NavigateWithChooserCrossOrigin WebUsbTest.NavigateWithChooserCrossOrigin [ RUN ] WebBluetoothTest.NavigateWithChooserCrossOrigin [2504:3843:0415/131012.437247:WARNING:notification_platform_bridge_mac.mm(563)] AlertNotificationService: XPC connection invalidated. ../../chrome/browser/bluetooth/web_bluetooth_browsertest.cc:492: Failure Value of: waiter->has_shown() Actual: false Expected: true Stack trace: 0 browser_tests 0x0000000101095a49 (anonymous namespace)::WebBluetoothTest_NavigateWithChooserCrossOrigin_Test::RunTestOnMainThread() + 617 1 browser_tests 0x0000000106fff6ee content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 718 2 browser_tests 0x0000000106a5b62a ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 3994 ... Original change's description: > device chooser: de-flake tests > > Right now, the count of extant bubbles is used to keep track of > how many bubbles exist. This leads to flaky tests though: the bubble's > view is only deallocated after closing the bubble finishes, and since > closing the bubble is async, whether the view has been deallocated or > not at the end of the test is variable. > > This change has the tests instead ensure that the close process has > *started* at the end of the test, which is always true. > > Bug: 1069695 > Change-Id: I29535149fd3f318c22b44d8f93d22c5b248816da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149685 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759330} TBR=ellyjones@chromium.org,reillyg@chromium.org Change-Id: I380bb34779c4623775826d02ce6bd10a7d1c6870 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151507Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fit, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: I6191eede67d85a8c84bca16a52fdc43e2249541c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148894Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#759553}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/694ec49ed075..8c22240b1a04 git log 694ec49ed075..8c22240b1a04 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 582e5284d0f6..0721c1cf2a52 (14 commits) Created with: gclient setdep -r src/third_party/skia@8c22240b1a04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I90003d70f73c0467c23d230fd49c3c3f6c6d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151059Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 555fd40a. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 788a3bf1 "[css-grid] Migrate grid-auto-repeat-intrinsic.html to WPT" f9b790bb "[css-grid] Fix percentage track sizing functions in size containment" a2328fd6 "[css-grid] Migrate grid-element-remove-svg-child.html to WPT" 3fb5d786 "Roll external/wpt/webgpu and create wpt_internal/webgpu" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I4f6559885bc0fd542d3bb473f290ae27a64824a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151966Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759551}
-
Kent Tamura authored
- Make LayoutNGMixin<LayoutRubyBase> a friend of LayoutRubyBase because LayoutNGMixin<LayoutRubyBase> accesses some private functions. - Add an Element* argument to LayoutRubyBase constructor. LayoutNGMixin assumes that the constructor of its base class has an Element* argument. This CL has no behavior changes because changes are behind a runtime flag. Bug: 1069817 Change-Id: I0876d76efa8a66a39ba06b4c6df3ccd6f7e3f31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151378Reviewed-by:
-
Luciano Pacheco authored
The code was performing a regex in all open windows several times, refactor to perform only once. Bug: 1067478 Change-Id: I31d481dfb153f0f47f65bac081f1b4d73dccc8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148793 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759549}
-
Jesse Schettler authored
Make the scanning UI a page of the Print Management app. This allows the page to share API setup and resource loading with the rest of the app. The scanning page can be accessed by navigating to chrome://print-management/scanning.html when the print-job-management-app and scanning-ui feature flags are enabled. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningPageBrowserTest.All Change-Id: I90c235bdc00d7c2599d790b819fa5ced19ad3711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109819Reviewed-by:
jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#759548}
-
Yuki Shiino authored
The behavior of On{BeforeUnload,Error}EventHandler has already been supported, but the notation in *.idl files has not yet been supported. This patch makes it possible to write them in *.idl files, and helps the new bindings generator dintinguish error handler types. Bug: 839389 Change-Id: I1cc52407f634bc6ecfd740cf488413901e75cc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150352Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759547}
-
