- 20 Jul, 2020 40 commits
-
-
Chris Sharp authored
Bug: 1018157 Change-Id: I974bd644b14af88b753c29258f56968572501e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295707Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789933}
-
Bo Liu authored
Missing a null check that's similar to the one in DemandDrawHw. Bug: 1104821 Change-Id: I4a1199171edee81220d59f6bc42a06f88df18e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305919 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789932}
-
Yuki Shiino authored
There are two ExecutionContexts; one of the creation realm, and the other of the document tree. Explains the difference in a document. Change-Id: I9aa90c1d57fa4cb8528629f69e4209d1554a2109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307389Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789931}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..0c5bb2f776a5 2020-07-20 robertphillips@google.com Clean up some GrContext in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Iffb5c6989a63db91bae17759a4db4ce058212eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789930}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ia2649c3aa4b105607eed3efd38e0e1b7c6615000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295710Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3cb2d92..343030c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I374386622d6a58d45583b050ece351f5a8742400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789928}
-
Maksim Moskvitin authored
This reverts commit 982dfeb9. Reason for revert: new tests are extremely flaky. Original change's description: > [Autofill][SlimShady] General Hybrid Structure Component. > > The CL introduces a data structure to manage address components that > must support the duality of an structured and unstructured > representation. > > Change-Id: I435d82f608718c29821671dd1fa303c5fb3caa24 > Bug: 1099202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238191 > Commit-Queue: Matthias Körber <koerber@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789886} TBR=battre@chromium.org,dvadym@chromium.org,koerber@google.com,schwering@google.com Change-Id: If50e7a0ab480b96734d6325f1a7104197174aee3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099202, 1107419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307489Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789927}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I3744931b8d0dd72b1b9a60db1d4890a057a245b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295709 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Peter E Conn authored
Change-Id: Iaf465c19c4478af20538722def8133c63af13239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302759Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789925}
-
Andrey Zaytsev authored
When the latest version on the Omaha server matches the installed one, the server doesn't return a version string; instead, status="noupdate" is returned. Bug: 1070620 Change-Id: I114b3b67f0461f65d5db7f05009cd7dfa106a8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307210 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789924}
-
Antonio Gomes authored
... and use WTF::Vector instead, where possible. Note that the left-over use of std::vector happens because it is used as parameter to media::MockGpuMemoryBufferVideoFramePool(). BUG=704136 R=guidou@chromium.org Change-Id: I2fcaa54a7888ad4a30fa69f16e705da4391f2837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307409 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#789923}
-
Bartek Nowierski authored
This test is based on MTECheckedPtr implementation that supports offset from the beginning of the allocation. Bug: 1073933 Change-Id: Ifc5ff61c4a75d9073525da2b13f6ee5b9178f543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306126 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ic16373bc593270e42f6f1881aa7c47dae4f6346b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295711 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Wei Lee authored
Bug: None Test: Manually Change-Id: I74060c929b5887092b1a850941484ec5319da6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306133 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789920}
-
Antonio Sartori authored
The logic checking the X-Frame-Options header in the AncestorThrottle was manually parsing the Content-Security-Policy headers for finding out whether the 'frame-ancestors' directive was used (since the X-Frame-Options header should be ignored if the 'frame-ancestors' CSP directive is being used). With this change we use instead the already parsed Content-Security-Policy in parsed_headers for checking that. This avoids unnecessary additional parsings of the CSP headers in the AncestorThrottle. Bug: 1032139 Change-Id: Ibe0c64cd7eb1e6f8ff0fa915a81db6248399da1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292051Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#789919}
-
Luca Hunkeler authored
Currently when we have an error we go into the stopped state and we destroy the controller. However this means that if we have a tab showing an error message and we switch away from it and switch back the error will not be showed again because we rely on the controller to rebuild the UI on tab switched. With this CL, when an error happens, we keep the controller and we destroy it only when the UI is destroyed (by navigating away or tapping on the close button). Bug: b/152949732 Change-Id: I92d443ca433052a8a4e0fe7cb28e27463d752c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296080 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789918}
-
Mikel Astiz authored
Some users have a huge amount of bookmarks (>100K) and ordered STL containers can run into performance issues. To reduce UI jank during browser startup, let's trivially adopt unordered containers. This can help reduce the time spent in SyncedBookmarkTracker::InitEntitiesFromModelAndMetadata(). Change-Id: Id789a1d8f0aa14a94aa0974b939568b966be6300 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306253 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#789917}
-
Mugdha Lakhani authored
Write equivalent tests to verify task manager behavior for NoStatePrefetch and delete them from the Prerender test suite. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: Ibdb1d1996cfcb6866ee6cc257e5992e32e3bcd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299235Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#789916}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595224759-e1768d31ec00790ba2a6883a1e8e7f5013b1d5d0.profdata to chrome-mac-master-1595246042-98b0c1a3c65c5614c7a736e7fb083fada959e352.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ib3ee6e1718f21f0b5ea0cd5376178285aab2efd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307362Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/741a98d1bbcf..fd5df6887258 2020-07-20 landrey@webrtc.org Reduce time that video analyzer holds the frame in pc level framework If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia4e97d136a5f8123d03ccbc634064d5f1127c02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307358Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0997f358ce07..1dcc3cfc0639 2020-07-20 eseckler@google.com processor: No indents when exporting JSON 2020-07-20 treehugger-gerrit@google.com Merge "Port the queuing delay computation over to TraceProcessor." 2020-07-17 khokhlov@google.com Merge "trace processor: Override thread names based on priorities" 2020-07-17 lalitm@google.com tp: bump versions of tp and traceconv 2020-07-17 lalitm@google.com Merge "Build without -Wno-implicit-int-float-conversion." 2020-07-17 lalitm@google.com Merge "Update jsoncpp to remove deprecated API usage" 2020-07-17 lalitm@google.com tp: parse tracing_started event and drop ftrace packets before it 2020-07-17 treehugger-gerrit@google.com Merge "ui: Add a dedicated Info page for errors, metadata and stats" 2020-07-17 treehugger-gerrit@google.com Merge "Add in scroll causes query so we can easily add in new causes." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:154156099 Tbr: perfetto-bugs@google.com Change-Id: I50313de10cfad4d9c2520e74c7abd1147ebfb379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307357Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic97947afc3c246adf825f08ba5dfbc3121767e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307354Reviewed-by:
-
arthursonzogni authored
The initial patch was making hundreds of navigation. This was reaching a timeout on Android + ASAN. The reland split the test into many smaller parts. 1. Initial: https://chromium-review.googlesource.com/2279767 2. Revert: https://chromium-review.googlesource.com/2288430 3. Reland: This patch Bug: chromium:1090273 Revert "Revert "[COOP] Test allow-popup vs virtual-BCG."" This reverts commit 651e82f5. Change-Id: Iee600ba78cfe255002999387e8b58faad80ea662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306042 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789911}
-
Miyoung Shin authored
This CL uses VisualStateRequest Mojo API in FrameWidget mojo interface introduced at https://crrev.com/c/2178480 since WidgetMsg_WaitForNextFrameForTest has the same implementation with VisualStateRequest Mojo API notifying that the frame swap has occurred. Bug: 1071588 Change-Id: If317b98320ec3fb85fcf7a5d1e39f0fa202d4cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216145 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d0dd661f1805..92ebe87b74f1 2020-07-20 xinghua.cao@intel.com Vulkan: Set apiVersion dawn targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0e0bcec28a6d4af84a60639ae67a833f2b8d8304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307138Reviewed-by:
-
Tim Volodine authored
Disable failing MediaCapture tests on Lollipop and Marshmallow Tablet Tester bots. Tests: MediaCaptureTest#testMediaCapture_basic MediaCaptureTest#testMediaCapture_rememberPermission MediaCaptureTest#testMediaCapture_twoStreams MediaCaptureTest#testMediaCapture_twoStreamsNotification Also adds a dependency on //ui/android:ui_java_test_support for the weblayer_private_java_tests test target. BUG=1107380 TBR=estade@chromium.org Change-Id: Id682278331e379d7165f3a9801353977faae8185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306043Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789908}
-
stkhapugin authored
Disable this test that's failing in all configurations Bug: 1107378 Change-Id: I17c62b65d4a077b42fa629d6826be979aa4790fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306257 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789907}
-
Maksim Moskvitin authored
This reverts commit d0b5f5ca. Reason for revert: likely the culprit for compile failure (https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/15899?) Original change's description: > Roll DevTools Frontend from 270e6f332c41 to edad8321ca15 (4 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/270e6f332c41..edad8321ca15 > > 2020-07-20 pfaffe@chromium.org [wasm debug] Add an API for Language Plugins Extensions > 2020-07-20 jacktfranklin@chromium.org Migrate `front_end/bindings` to `devtools_entrypoint` > 2020-07-20 alexrudenko@chromium.org Add showTrackSizes to the grid overlay > 2020-07-20 petermarshall@chromium.org tests: Always specify a timeout for waitFor/Function > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1083146,chromium:1101738,chromium:1105808 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Ifb947b680923d8f750a5d3d8ef575c47d70334d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307350 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789900} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7687a2d49c07b3020bb897e1d324c0f80b2b1c1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1083146 Bug: chromium:1101738 Bug: chromium:1105808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306045Reviewed-by:
-
Yi Gu authored
This reverts commit fb77bf14. Reason for revert: Test is still flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=AtMostOneSmsRequestPerOriginPerTab Original change's description: > [WebOTP] Tentatively re-enable SmsBrowserTests > > There were 3 tests disabled in Feb due to flakiness (RunLoop timeout). > This patch re-enables one of them to verify whether the flakiness has > been fixed by recent changes and gather up-to-date failure logs if not. > > Bug: 1052385 > Change-Id: Ib9dcabf769a4ff03d31e1ec1601c69717f590040 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302409 > Reviewed-by: Sam Goto <goto@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789789} TBR=yigu@chromium.org,goto@chromium.org Change-Id: I9dc46de890dd869ccc1324e72065beac7713471d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305831Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789905}
-
Rohit Agarwal authored
This CL adds a UI placeholder for going incognito mode from MICE account picker dialog. The process of going incognito gated behind the incognito interstitial would be followed up in later CLs. This CL also adds an instrumentation test to verify the button is shown after the bottom sheet is expanded and update the existing unit tests in AccountPickerMediatorTest. Bug: 1103262 Change-Id: I3762747ebb7b9bb50ebc32447635daf858876336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288498Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789904}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ee58ef3895b..de55e0b54668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmoskvitin@google.com Change-Id: I1af7a22fdbff7e1fedf11c02e9a076cd427b5bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307136Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789903}
-
Stepan Khapugin authored
This reverts commit 90cc207c. Reason for revert: These tests (testLookalikeUrlPageNoSuggestionClosePage, testLookalikeUrlPageNoSuggestion) are failing on the waterfall: https://ci.chromium.org/p/chrome/builders/ci/iphone-device/10094 https://ci.chromium.org/p/chrome/builders/ci/ipad-device/10820 https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/12443 Original change's description: > [iOS] Add lookalike_url_egtest and update comments > > Bug: 1058898 > Change-Id: I80883ee1258493eb0ac56950d654606c393ee65e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284144 > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788917} TBR=eugenebut@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058898 Change-Id: Iac4277e189e737c9afa6d1de65fdaf966dfabf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306091Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1860aed6436d..3ba1777cebcd 2020-07-20 kjlubick@google.com [npm] Support npm publish flow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I5fedde0ea6d45caef944fbb4eb9fdee1b959675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307352Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/270e6f332c41..edad8321ca15 2020-07-20 pfaffe@chromium.org [wasm debug] Add an API for Language Plugins Extensions 2020-07-20 jacktfranklin@chromium.org Migrate `front_end/bindings` to `devtools_entrypoint` 2020-07-20 alexrudenko@chromium.org Add showTrackSizes to the grid overlay 2020-07-20 petermarshall@chromium.org tests: Always specify a timeout for waitFor/Function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1101738,chromium:1105808 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifb947b680923d8f750a5d3d8ef575c47d70334d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307350Reviewed-by:
-
Andrew Shulaev authored
Bug: 160139330 Change-Id: Ida257b6075deaebb37f95296ad8df50dd182f2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294660 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789899}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d1e8e6122c75..741a98d1bbcf 2020-07-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 046ea7f6..9a6944e0 (789730:789857) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I34dcda3d64d47bc62b693d09b2c99ba766977c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307349Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3d231ec..c3cb2d92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d09346df705e8848993562edba316ba4fa8562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305917Reviewed-by:
-
Bartek Nowierski authored
Technically, it shouldn't make a difference for CheckedPtr2 from performance point of view, but just in case, let's make it equal to MTECheckedPtr. Bug: 1092288 Change-Id: Ic4295450e984ac2263608e17a499e9b4dc4154d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305828 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
The following now-irrelevant Prerender tests have been deleted: PrerenderServerRedirectInIframe SafeBrowsingTest:Iframe The following have equivalent tests in NoStatePrefetch tests and have been deleted: SafeBrowsingTest:TopLevel SafeBrowsingTest:Subresource The following test has been ported over: SafeBrowsingTest:ServerRedirect Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: Ib99d58fc833f7c65adb3a908fc12d239ec635b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300118Reviewed-by:
-
sandromaggi authored
It appears that waiting for the URL is flaky. This check is not really required for the test, as we only want to see the error appearing once the URL is committed (we can assume that the URL being entered into the location bar will eventually load). Bug: 1105146 Change-Id: I68ac2f5c5591dbcf8f85665429720152df9889b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306090Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#789894}
-
