- 20 Jun, 2018 40 commits
-
-
Mustaq Ahmed authored
Bug: 802286 Change-Id: I618811046ccbda914b5dcc673c62ba4ea4a550eb Reviewed-on: https://chromium-review.googlesource.com/1106553 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#568881}
-
Miguel Casas authored
This CL teaches VaVDA to use client VASurfaceIDs to decode onto, saving a buffer copy and removing a costly blit (DownloadFromSurface) on the GPU Main thread. Three groups of changes: 1. In AssignPictureBuffers(): if |vaapi_picture_factory_| Create()s a VaapiPicture with a VASurfaceID, we use those to decode onto and set a new flag: |decode_using_client_picture_buffers_| 2. When the decoder calls CreateVASurface(), instead of giving it the first |available_va_surfaces_|, we need to figure out the first VASurfaceID in this |available_va_surfaces_| such that the corresponding VaapiPicture in |pictures_| is available (i.e. in |available_picture_buffers_|). Reason: libva holds on to some VASurfaceIDs, there's no simple one-to-one correspondence like on ToT. 3. When we're ready to OutputPicture() to |client_|, instead of using the first |available_picture_buffers_|, we find the corresponding one for the passed |va_surface_id| (we could search all over |pictures_| but there's always less |available_picture_buffers_|. Some other notable developments: - s/output_buffers_/available_picture_buffers_/ - OutputPicture() loses a parameter. - |decode_using_client_picture_buffers_| is still false for e.g. VP9 Profile 2 or the ImportBufferForPicture() path. - Pictures is made a base::small_map. (Originally from crrev.com/c/988512). Bug: 822346, 717265 Test: v_d_a_unittest vp8/vp9/h264 passing on eve, running crosvideo changing resolutions for a long time. No hickups, no dropped frames. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3d5a4d3c83002c8d0977702c9b97ffec52b1db23 Reviewed-on: https://chromium-review.googlesource.com/1021675Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#568880}
-
Roman Sorokin authored
* Adds new step to decrypt configuration seed which comes from DM Server. * Adds configuration selection UI. BUG=chromium:829361 TEST=TBD Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I299cdf7b8994fd929a7f15303bfb21ebf78996ba Reviewed-on: https://chromium-review.googlesource.com/1090714 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#568879}
-
Stefan Zager authored
BUG=823365 R=skobes@chromium.org,sclittle@chromium.org Change-Id: I400bae2f5a35075b06e42a2b2796772c3a0a687f Reviewed-on: https://chromium-review.googlesource.com/1107164Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#568878}
-
Jan Wilken Doerrie authored
This change provides an implementation of Windows::Foundation's IReference interface. This class is supposed to be used for optional POD types, as a null value usually is not possible here. Bug: 821766 Change-Id: Icc6ff4f5313e2cfa13ca33f8d54e150efa616d76 Reviewed-on: https://chromium-review.googlesource.com/1106385Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#568877}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b6e0117285a9..b3345feca274 git log b6e0117285a9..b3345feca274 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 bungeman@google.com Replace SkTSwap with std::swap/swap. 2018-06-20 tsepez@chromium.org c_str() calls not needed when writing to ostream Created with: gclient setdep -r src/third_party/pdfium@b3345feca274 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0065584e5b867d194ccc848f4d4b9f9a1d8ed55f Reviewed-on: https://chromium-review.googlesource.com/1108217Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568876}
-
Gauthier Ambard authored
This CL adds margins to take into account the toolbars in the incognito NTP. Bug: 834276 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I853f4f43629ddf8d87742144f5cc9e1a36824294 Reviewed-on: https://chromium-review.googlesource.com/1107922 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568875}
-
Becky Zhou authored
Bug: 850996 Change-Id: I20e1fa1e03c8c55d41f5a5a4e77f3c5059500b86 Reviewed-on: https://chromium-review.googlesource.com/1107306Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568874}
-
Moe Ahmadi authored
Bug: 849433 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ief1cca17a562786a6d838b9bdf27778918232dff Reviewed-on: https://chromium-review.googlesource.com/1104969Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568873}
-
Peter Kasting authored
This fixes a bug where the window cannot be dragged from the space between tabs and new tab button once the strip goes into overflow. BUG=none TEST=none Change-Id: I2b4d244c8dc306fffe07fc8676c8eaffc19ec5d2 Reviewed-on: https://chromium-review.googlesource.com/1107381Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568872}
-
chrome://accessibilityDominic Mazzoni authored
WebUI doesn't allow remote network connections anymore for security reasons. Bug: 854410 Change-Id: I448b24e87659e1f4f0aa6955d9a0cda4bfe8c8ac Reviewed-on: https://chromium-review.googlesource.com/1107202Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#568871}
-
Peter Kasting authored
The comment said "make sure none of the tabs are more than 90 apart", but the code didn't do that. Plus the functionality was obscured by the use of a helper function that duplicated the "90" from the caller (but, as noted, only in the comment), and didn't use all its args. BUG=none TEST=none Change-Id: I979d7313286ac16234afad66de19350c136c156d Reviewed-on: https://chromium-review.googlesource.com/1107385Reviewed-by:
-
Peter Kasting authored
Especially in refresh, 400 feels too slow. In testing, 200 seemed much better. BUG=none TEST=none Change-Id: Ib7a8519fac9baadbd6853d6b5810644e4e2b7433 Reviewed-on: https://chromium-review.googlesource.com/1107383Reviewed-by:
-
Mathieu Perreault authored
Some members were being created on UI thread and used on IO thread which is definitely not recommended. Bug: 843205 Change-Id: Id1d6f0e66e8e11347e4ba4ef1a60d0559952d28d Reviewed-on: https://chromium-review.googlesource.com/1108137 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568868}
-
Joel Hockey authored
Remove shadow DOM support from waitForElement used in UI tests. Reverts part of crosreview.com/1090517 Bug: 852324 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If64176b0a9eee107afde06a2adb6bc076fb87e24 Reviewed-on: https://chromium-review.googlesource.com/1098910 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#568867}
-
Peter Kasting authored
This conditional was apparently an attempt at an optimization, but it doesn't appear in the case of painting tabs before the active tab, only ones after. AFAICT in testing it makes no visual difference, and it makes the code harder to understand. BUG=none TEST=none Change-Id: If57e860df045fba45529e618530a3a2c4fe0d7df Reviewed-on: https://chromium-review.googlesource.com/1107382Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568866}
-
Xi Cheng authored
Change-Id: Ib57fa2a98d6270721df67ff890b7961d09e209b9 Reviewed-on: https://chromium-review.googlesource.com/1107386Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#568865}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/056a68da896d..de212ca0391c git log 056a68da896d..de212ca0391c --date=short --no-merges --format='%ad %ae %s' 2018-06-20 mbonadei@webrtc.org Removing some MSVC warning suppression flags. 2018-06-20 mbonadei@webrtc.org Add mbonadei@ to build configs OWNERS. 2018-06-20 mbonadei@webrtc.org Adding mbonadei@ to build_files WATCHLIST. 2018-06-20 sakal@webrtc.org Fix a bug where TestAudioDeviceModule crashes if destroyed uninitialized. 2018-06-20 kthelgason@webrtc.org Revert "Remove deprecated mac capture code." 2018-06-20 buildbot@webrtc.org Roll chromium_revision 20579735..e1ef7d4b (568689:568794) 2018-06-20 yvesg@webrtc.org Let git-hyper-blame ignore format commit. Created with: gclient setdep -r src/third_party/webrtc@de212ca0391c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8569aeb7d47e8f8e5ad9767b9edb44016264e63e Reviewed-on: https://chromium-review.googlesource.com/1107940 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568864}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b73eba800574..d40463e208e0 git log b73eba800574..d40463e208e0 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 treehugger-gerrit@google.com Merge "perfetto-ui: Refactor bundle build rule" 2018-06-20 hjd@google.com Merge "traced_probes: Fix clock bug" 2018-06-20 hjd@google.com perfetto-ui: Refactor bundle build rule 2018-06-20 hjd@google.com traced_probes: Fix clock bug 2018-06-20 hjd@google.com Merge "perfetto-ui: Refactor sorcery build rule" 2018-06-19 hjd@google.com perfetto-ui: Refactor sorcery build rule Created with: gclient setdep -r src/third_party/perfetto@d40463e208e0 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:110356412 TBR=perfetto-bugs@google.com Change-Id: I2c3980ca6c464b33452c432694bb603377e880be Reviewed-on: https://chromium-review.googlesource.com/1107939 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568863}
-
James Cook authored
This reverts commit e959c2d7. Fixed by adding EXPORT macro on the new struct. Original change's description: > Revert "Add InitParams for views::AuraInit" > > This reverts commit dfd53f11. > > Reason for revert: GPU FYI Windows bots compile failure > crbug.com/854442 > > Compile error: > [40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb > FAILED: task_viewer.service.exe task_viewer.service.exe.pdb > C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp > C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ > >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ) > C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ > >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ) > > Original change's description: > > Add InitParams for views::AuraInit > > > > It's up to 7 parameters and I'm about to add an 8th. > > > > Bug: 851578 > > Test: existing tests > > Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1 > > Reviewed-on: https://chromium-review.googlesource.com/1106431 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: James Cook <jamescook@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568594} > > TBR=jamescook@chromium.org,sky@chromium.org > > Change-Id: Iea7d59178394a95cbc6f419cd7079d00d66a8ac6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 851578, 854442 > Reviewed-on: https://chromium-review.googlesource.com/1107139 > Reviewed-by: weiliangc <weiliangc@chromium.org> > Commit-Queue: weiliangc <weiliangc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568678} TBR=jamescook@chromium.org,sky@chromium.org,weiliangc@chromium.org Change-Id: Id0a3e75d0e02c87165375ecc345553041ecc4252 Bug: 851578, 854442 Reviewed-on: https://chromium-review.googlesource.com/1107997Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#568862}
-
Lukasz Anforowicz authored
There is a desire to add more kinds of hang timeouts - in addition to having an input-event-ack-timeout we also want to have navigation-commit-timeout and possibly other timeouts. This means that HungRendererDialogView::Accept (handling "Wait" button in the "hung renderer dialog") shouldn't be hardcoded to always call RenderWidgetH::RestartHangMonitorTimeoutIfNecessary, but should instead call a generic callback that will vary depending on the original source of the dialog. This CL enables future CLs (e.g. https://crrev.com/c/1089797) that need to provide different ways of restarting the hang timeout. This CL refactors RWH::RestartHangMonitorTimeoutIfNecessary into a generic base::RepeatingClosure passed as an argument of WebContentsDelegate::RendererUnresponsive method. I've tested this CL manually (on Linux) by: 1. Navigating 1st tab to https://peteblois.github.io/tmp/iframe_scrolling2/ 2. Opening a second tab, navigating it to https://peteblois.github.io/tmp/iframe_kill/ and switching back to the 1st tab. 3. Interacting with the OOPIF (for example double-clicking to select some of the words) and waiting 30 seconds for the hung renderer dialog to appear. 4. Clicking "Wait" button in the dialog 5. Verifying that the dialog reappears after 30 seconds Bug: 848821 Change-Id: I2d133483832ca3d640a74c9f23fc9677f478721d Reviewed-on: https://chromium-review.googlesource.com/1096362 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#568861}
-
Nicolas Ouellet-payeur authored
This allows the user to enable/disable the Translate popup, either in chrome://flags, or by using the `--disable-features=TranslateUI` command-line flag. Bug: 770776 Change-Id: I66af0ce5de568bafb45e0e501cb4f481ac6d6fb3 Reviewed-on: https://chromium-review.googlesource.com/1105311 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#568860}
-
Scott Violet authored
WindowTreeFactory owns any WindowTrees that were created by way of ui::mojom::WindowTreeFactory. So, WindowTreeFactory needs to be deleted before the DCHECK that there are no more WindowTrees. BUG=854336 TEST=covered by test Change-Id: Idba2928244721579e694b434415b95cbbdf4b360 Reviewed-on: https://chromium-review.googlesource.com/1107136 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Wez authored
Since dom_keycode_converter is a static_library(), having it be a public dependency of a component() doesn't make sense - consumers of the events_base target can import the headers, but they refer to symbols that the component's dynamic library doesn't export. Change-Id: I859764fb50324fed1d22bc0ee8335d057c73771d Reviewed-on: https://chromium-review.googlesource.com/1107310Reviewed-by:
-
Joel Hockey authored
Bug: 852324 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I534f67d93048d4e2e87db2fb3098513511a509ac Reviewed-on: https://chromium-review.googlesource.com/1098912Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#568857}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4359d529121f..53418da8c647 git log 4359d529121f..53418da8c647 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 mtklein@chromium.org exclude _none_imagefilters.cpp in Google3 2018-06-20 rmistry@google.com Fix license file in compute/skc/main.c 2018-06-20 rmistry@google.com [Bookmaker] Point to new fiddlecli location 2018-06-20 robertphillips@google.com Fix degenerate case handling in fill_in_2D_gaussian_kernel 2018-06-20 borenet@google.com Update skia swarming task template to git 2.17.1 2018-06-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 4004ae0e033a..a914f7ff310d (1 commits) Created with: gclient setdep -r src/third_party/skia@53418da8c647 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849016,chromium:847597 TBR=kjlubick@chromium.org Change-Id: I25d536203c78f4d829ab7a0bda506415688d9e87 Reviewed-on: https://chromium-review.googlesource.com/1107937Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568856}
-
Theresa authored
Move most code controlling the search provider logo, fake search box, bookmarks/downloads shortcuts, and most likely tiles from NewTabPageView to NewTabPageLayout. These views are all children of NewTabPageLayout, so organizationally it makes more sense for NewTabPageLayout to own and control them. This is a step toward making NewTabPageLayout re-usable for the FeedNewTabPage. There will be additional work to finish cleaning up and refactoring NewTabPageView and NewTabPageLayout to bring them closer to the new MVC architecture. BUG=827334 Change-Id: Ia08a0f9636ee7919fea2582c7b15fb9a57ed28bf Reviewed-on: https://chromium-review.googlesource.com/1103388Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#568855}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cabdc464313..49083eaa9300 git log 1cabdc464313..49083eaa9300 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 vapier@chromium.org pylint: update to 1.4.5 Created with: gclient setdep -r src/third_party/depot_tools@49083eaa9300 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I25691eba67aba0610b1fbf02545bc3b4cba06881 Reviewed-on: https://chromium-review.googlesource.com/1108017Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568854}
-
David Roger authored
IsAccountConsistencyMirrorEnabled is deprecated, because Mirror can now be enabled on a per-profile bases. This CL replaces the calls by the new API (AccountConsistencyModeManager) and cleans up unnecessary calls. TBR=sky Bug: 777774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19e9ecc779b90911f6e4e63a11850417c9eddbdf Reviewed-on: https://chromium-review.googlesource.com/1104682 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#568853}
-
Gauthier Ambard authored
This CL changes the toolbar so when the location bar is focused in iPhone landscape, the cancel button is shown, as it is done in portrait. Bug: 847847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I351d166e52d80975579bf6c74fd44230543b4ce1 Reviewed-on: https://chromium-review.googlesource.com/1107634 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568852}
-
Makoto Shimazu authored
PaintTiming.NavigationToFirstPaint is one of key loading metrics, and we'd add it before starting ServceWorkerServicification (a.k.a NetS13nServiceWorker) experiement. Bug: 852698 Change-Id: I2d7b7ad9ef3df94d428e1fbcbc1148de27e45c6a Reviewed-on: https://chromium-review.googlesource.com/1107418Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568851}
-
Alexander Hendrich authored
This CL adds a list attribute 'BlacklistedHexSSIDs' to ONC's global configuration. This attribute can be used to block connections to certain WiFi SSIDs. Current connections to blacklisted networks are disconnected, once the policy is applied. This policy is only enforced in Chrome. However, by disabling auto-connect for all blacklisted networks, we can prevent Shill from re-connecting to those networks while searching for the best network to connect. DesignDoc: http://go/cros-blacklist-ssids Bug: 837205 Change-Id: I1d80929a00dd042db7aef877d663febc3f170d05 Reviewed-on: https://chromium-review.googlesource.com/1091053 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e005dc33c31a..b6e0117285a9 git log e005dc33c31a..b6e0117285a9 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 rharrison@chromium.org Add in a size guard to JPX fuzzer Created with: gclient setdep -r src/third_party/pdfium@b6e0117285a9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:834561 TBR=dsinclair@chromium.org Change-Id: I4ac1250c2e205994b6594b5a06bb34e6bd07e7fc Reviewed-on: https://chromium-review.googlesource.com/1107938Reviewed-by:
-
Peng Huang authored
Bug: 848388, 850745 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6bacef1ca791ff7e00769258f3bce99ef4954b59 Reviewed-on: https://chromium-review.googlesource.com/1106614Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568848}
-
Matt Menke authored
Accidentally left in a line of the old setup in https://chromium-review.googlesource.com/1089661. It's harmless, but not needed any more. Bug: 837354 Change-Id: Ic7a01e407d8666b2eede34d65a7186f212d1fddb Reviewed-on: https://chromium-review.googlesource.com/1106008Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568847}
-
anthonyvd authored
This reverts commit d201cbeb. Reason for revert: FindIt identified this CL as the culprit for several failures: crbug.com/854600 Original change's description: > Run some file manager browsertests with DriveFS enabled. > > Bug: 848126 > Change-Id: Ifd3cf1996fdb33f5d0d93f5c5cf721abd5440d29 > Reviewed-on: https://chromium-review.googlesource.com/1102279 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568339} TBR=noel@chromium.org,sammc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848126 Change-Id: Ifc9b0a77c76ba647bd5a85102b286fd5b2d1073f Reviewed-on: https://chromium-review.googlesource.com/1107998Reviewed-by:
-
Fabio Tirelo authored
This reverts commit dbbd9b76. Reason for revert: contrast ratio for links is below 4.5:1 threshold Original change's description: > [Views] Adjust secondary info and link style colors for MD2 > > Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 > > Bug: 852094 > Change-Id: I0bbfc28d214bed310fdb4a23cd804442d5751590 > Reviewed-on: https://chromium-review.googlesource.com/1099560 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567152} TBR=msw@chromium.org,estade@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852094, 853637 Change-Id: I169e1f39d120c714e37c0534115d692a499c591f Reviewed-on: https://chromium-review.googlesource.com/1106457 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568845}
-
mrefaat authored
Rename to AppLauncherAbuseDetector because the PolicyDecider is going to be used for the webstate policydecider in the AppLauncherTabHelper Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0b39ca366d1e34a9b6db8217a89a1d5b68405ecb Reviewed-on: https://chromium-review.googlesource.com/1107038Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#568844}
-
Jérôme Lebel authored
Disabling EarlGrey tests from SigninInteractionControllerTestCase: + testSignInSwitchAccountsAndKeepDataSeparate + testSignInSwitchAccountsAndImportData + testSignInSwitchManagedAccount Those tests seem to trigger an issue in the sync code when doing enable disable enable too fast. Bug: 854446 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75 Reviewed-on: https://chromium-review.googlesource.com/1107881Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568843}
-
Devlin Cronin authored
https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a added support for IPv6 patterns with URLPattern and activeTab, so we can now enable the tests for captureVisibleTab using IPv6 URLs. Bug: 839857 Change-Id: I29eec17b176c54a312cfdf5dc7d11c50b7b245f9 Reviewed-on: https://chromium-review.googlesource.com/1107243Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568842}
-
