- 08 May, 2019 40 commits
-
-
Lutz Justen authored
It returned a copy of the data, not the original data, which goes wrong when the data is written to as in FakeKerberosClient::AcquireKerberosTgt(). BUG=chromium:952237 TEST=None Change-Id: I0f39314d0c44e31e6586963f3d60ae439b0e062a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590095 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#657620}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ee1963a2. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3accd9093830a1844fb0c660dfa5bb5abb2a181c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600746Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657619}
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 960294 Change-Id: I21f264874f2b64267acbb8b23eb52a39958a4893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599812Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#657618}
-
Rakib M. Hasan authored
The command line --all will be used in place of --also-run-disabled-tests, which was removed in a previous CL. This CL also refactors gpu_integration_test_unittest.py and provides documentation for pre submit checks which look for collisions between test expectations. Bug: chromium:937516 Change-Id: If1c3dd820da6fc72bb837a98be5f60972de1bf31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600612Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657617}
-
Marijn Kruisselbrink authored
And fix up existing mojom files that had CRLF line endings. Bug: 932129 Change-Id: I83585e5f43e72ebeac1bc44a05584a9b1632524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600672 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#657616}
-
Hirokazu Honda authored
All planes share the modifier. Thus, it makes more sense NativePixmapHandle has the modifier variable rather than each NativePixmapPlane. TBR=sandersd@chromium.org, yusukes@chromium.org, dcastagna@chromium.org, dcheng@chromium.org, rjkroege@chromium.org Bug: 957381 Test: Launch ARC++ App Test: Play video with/without HW video decoder Test: Record video with GCA Change-Id: I3d21d336aae149bb5028893a7c23f21a310878ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601013Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#657615}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/51e15a69ce5b..4497ac179949 git log 51e15a69ce5b..4497ac179949 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b01f2559e017..d5ed0a31ce88 (10 commits) Created with: gclient setdep -r src/third_party/skia@4497ac179949 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I8ffcb719e4caa704e15d81b245fe8f4203389b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657614}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5e444045846..e7f0b4c62c55 git log e5e444045846..e7f0b4c62c55 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 mmoss@chromium.org Revert "git-cl: Keep git push traces" Created with: gclient setdep -r src/third_party/depot_tools@e7f0b4c62c55 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:955206 TBR=agable@chromium.org Change-Id: I121c4bf99c722c9308a73bfbc86e71cf1b3add1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657613}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/62d707af087a..3047a81d2430 Created with: gclient setdep -r src-internal@3047a81d2430 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org Change-Id: I7c317cbbf3a76431807a36943cce76b2ba7500ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600975Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657612}
-
David Tseng authored
Previously, when ChromeVox encounters a change in editable text that remains within a single line, e.g. move by one character, it would compare the plain text diffs of the previous and current lines. This would miss the rich structure of automation including images. The logic prior to this change would sometimes emit output accidentally when the move within line was detected as a move across lines. This change makes it so whenever either side of the selection (while within a single line) is not on a text node, ChromeVox will describe the entire DOM selection. Test: browser_tests --gtest_filter=ChromeVoxEditing*.*ImageByCharacter Change-Id: I53f7d9e15edfaa13c90fb4cc498d83f140cbdf35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596194 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#657611}
-
Kent Tamura authored
This CL simplify the code. This CL has no behavior changes. Change-Id: Ia9f966124edeed790db2e9dfc4b6162ad66a69fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600734Reviewed-by:
Abhijeet Kandalkar <abhijeet@igalia.com> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#657610}
-
Jay Harris authored
Previously, this code path was never executed, which is how the bug wasn't discovered. Bug: 829689 Change-Id: I636536914ca24ba4872c275d705c8f75f2f9b9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597934 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#657609}
-
khachatryan authored
Bug: chromedriver:2899 Change-Id: I2643802d5b9f9a2f2e91b512414631c12521d2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600377Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657608}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ia09502ebaca1bbdeda116acf4ac76db247a93c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600389Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#657607}
-
Lutz Justen authored
The Kerberos daemon exposes a D-Bus method to get the list of all existing Kerberos accounts. This CL adds support for this method on the Chrome side. BUG=chromium:952237 TEST=None. Change-Id: I28d953e926a97c4506ea8388ec13cd19b8da96f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588254 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#657606}
-
Kunihiko Sakamoto authored
This is in preparation of making --ignore-certificate-errors-spki-list also ignore the SignedExchange certificate requirements. SignedExchangeCertificateChain::ShouldIgnoreErrors() returns true iff errors for its main certificate should be ignored. This is pure refactoring; no behavior changes. Bug: 956471 Change-Id: I94770fa4428e3dd560f0a126dc7e746c6716207c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583027 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#657605}
-
rbpotter authored
The PDF viewer is the only user of paper-fab. Changing it to use cr-icon-button instead will allow paper-fab to be removed from the repository. Bug: 959483 Change-Id: Idc73f270d65b4ed25d05bdca2006f0ec4e20d455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586354Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#657604}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75362025a46a..52e432e7d136 git log 75362025a46a..52e432e7d136 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 jclinton@chromium.org README: Run mdformat on file Created with: gclient setdep -r src/third_party/chromite@52e432e7d136 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iea2484b850cbc4e35aa036f4ab4b63ad5964be84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657603}
-
Timothy Loh authored
This CL adds plumbing so that clicking the Plugin VM launcher icon will launch it once everything else is set up, although this can not yet be triggered as we require the pref indicating installation is complete does not yet get set. Bug: 904853 Change-Id: Ie52c2bc58ba3801cf6df8f465f0d885d15be43df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594379 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657602}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6bb591e..c6d66c4d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8062ca9f0050d7fafe1888278d70a1f0bd242e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657601}
-
Akihiro Ota authored
Bug: 88072 Change-Id: Ia11f4f6b874065319771df524e3347b3a6ea2839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1584852Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#657600}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/81404f2d6e94..d5ed0a31ce88 git log 81404f2d6e94..d5ed0a31ce88 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 sugoi@google.com External Memory Host tests should be unsupported Created with: gclient setdep -r src/third_party/swiftshader@d5ed0a31ce88 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iafac9b4465b6833874813a9df9df9cdb19decb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600745Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2db64812c02..62d707af087a Created with: gclient setdep -r src-internal@62d707af087a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org Change-Id: If2ace5106791371d91d4031f524df2a9dd0d6e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600743Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657598}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib113dde612c959a035b89e77e36ae8ef2b320744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657597}
-
Rebekah Potter authored
This reverts commit a4c5377b. Reason for revert: Tests still seem flaky on Mac 10.13 bot, see https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/13116 Original change's description: > Extensions Web UI: Restore polyfill test > > Fix the test to pass on Mac 10.13. > > Bug: 925517 > Change-Id: Ifc630605dfd8de124a3d4af77d35f4374ca0c316 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597910 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657433} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Ie0eb5498d810abf674bb3ea86ab10e6d4119f01a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600953Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#657596}
-
Yuwei Huang authored
This CL allows mobile clients to use FtlSignalStrategy once the FTL ID is set. Bug: 954594 Change-Id: I18c51391f1c767c08480414a9867746197e3a54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597961 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#657595}
-
Harley Li authored
The 'title' for each SW section at Application>Service Worker is the scope URL, and scopes are sensitive to port numbers. Bug: 601286 Change-Id: Ib718652a9132dc17ef5adfc4828f0c43e439d1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595124Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#657594}
-
Nektarios Paisios authored
1. Changes the Cursor class in ChromeVox to allow tree positions on richly editable nodes Due to bugs in the old selection code in Blink, a ChromeVox Cursor could not be set on a content editable root or any of its descendant nodes, other than a text node. The new selection code does return selection endpoints that are tree positions on richly editable nodes, and so ChromeVox should both handle as well as set such endpoints. 2. Completely eliminates the use of anchor and focus objects in ChromeVox editing handler. This patch uses the newly added attributes selectionStart/End which are guaranteed to be in document order. To determine if selection has been altered from the start vs. the end, which is important for determining what needs to be spoken or brailled, this patch relies on a boolean "isSelectionBackward" that is sent directly from Blink, instead of relying on checking which endpoint has been modified. 3. Modifies Select to Speak based on a patch provided by katie@ and augmented by me. Uses "isSelectionBackward" to switch anchor and focus around so that they will always be in document order. R=dmazzoni@chromium.org, dtseng@chromium.org Bug: 639340 Change-Id: I072f9c9dfff5b6c9a107e66207fb9cc80f8d4cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572523 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#657593}
-
Yuwei Huang authored
This CL implements a MessageTracker that tracks message IDs and makes FtlmessagingClient drop messages with duplicated IDs. Bug: 952376 Change-Id: I3b03be0953a1178128835fba96c9ac139db5cb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595426 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#657592}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a41b430df52b..75362025a46a git log a41b430df52b..75362025a46a --date=short --no-merges --format='%ad %ae %s' 2019-05-08 gbiv@google.com afdo: format sources Created with: gclient setdep -r src/third_party/chromite@75362025a46a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ibfe8af68424bdfba0672311c389f902f1f297cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657591}
-
Makoto Shimazu authored
This metric is to measure the time spent for looking up a matching registration. Perhaps this is mostly measuring the time for disk access to read registration info. We want to analyze this to see if putting registration in memory could improve performance. Bug: 953598 Change-Id: Icef0444ccec3ae3701073ff96afb0d8b3769e6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583177 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#657590}
-
Alan Cutter authored
This is a future proofing bug fix. BookmarkAppRegistrar was not filtering its extensions for only bookmark app extensions and would fire for any extension install. This wasn't an issue because the only listener at the moment (WebAppTabHelperBase::OnWebAppInstalled) already filters to PWAs only via FindAppIdInScopeOfUrl(). This change ensures we don't over signal for any future listeners. Bug: 891172 Change-Id: Id8bcf275326a03819658eca8d36d5cbffec2ba5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600534 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#657589}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1300ba188eee..81404f2d6e94 git log 1300ba188eee..81404f2d6e94 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 sugoi@google.com Ignore VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT at pipeline creation Created with: gclient setdep -r src/third_party/swiftshader@81404f2d6e94 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie3b12f771147016eed819c5fe2d24e5bbd151804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657588}
-
sangwoo.ko authored
Previously, animations were ticked by base::Timer. This wasn't aligned with Compositor so animation can jank or stutter. Thus, we need a way to use custom animation runner which is aligned to compositor's frame. In favor of layering, we should inject custom animation runner from a layer views/ or chrome/ to animation system. For this reason, AnimationRunner is introduced and clients can inject this dependcency via AnimationRunner. For example, Widget provides CompositorAnimationRunner which observes compositors animation frame. TODO: We need to investigate other callsites where gfx::Animation/LinearAnimations are used. Bug: 824026 Change-Id: Id4d7d88a38a823fea7c860510f11ba38f7eb4e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475023 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#657587}
-
Kent Tamura authored
This CL fixes a regression by crrev.com/632459. Suppose that we have the following XML document: <root xmlns:x="uri1"> <table xmlns="uri1"/> </root> XMLSerializer generated the following result: <root xmlns:x="uri1"> <x:table xmlns="uri1"/> </root> We don't need to run "retrieving a preferred prefix string" algorithm if the element has no prefix and its namespace matches to the default namespace. This is an error of the specification, and Edge, Firefox, and Safari match to this CL's behavior. This CL adds a testcase following the specification error, and the testcase fails with all major browsers. Bug: 958298 Change-Id: I3af9e643a9f91221e56024192f7257a82b6f18cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598929Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#657586}
-
Anne Lim authored
When Project Butter and the credit card upload cardholder name fix flow are shown at the same time, their respective (i) help icons are merged and tooltip messages get combined. Bug: 958637 Change-Id: I3cad0dc45b6ee4b0f4e6b006a538a1ac09e926eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595116Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#657585}
-
Asanka Herath authored
Setting the auth_path_ field of HttpAuthController was intended to be set to an empty string if the target of authentication was a proxy. Due to a typo, this branch was never taken. Instead HttpAuthController uses the full URL as provided by the caller. This change removes the unused condition and assumes that the input URL is already well formed. Bug: 927182 Change-Id: I79211e9c9e071dab8730255c56ca95409f8d7f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597109Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#657584}
-
Nate Fischer authored
This deletes a redundant block of code which manually checks arguments (this is already done by the argparse module). This resolves a bug, since this code references an undefined `actions` variable. Bug: 960598 Test: tools/grit/pak_util.py # useful help output Test: tools/grit/pak_util.py not-a-command # useful help output Test: tools/grit/pak_util.py repack # useful help output Change-Id: Idda7d8c16878c2cc99a1407eaeeb7c7d56f8d8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600605 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#657583}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d22a780f989..b2db64812c02 Created with: gclient setdep -r src-internal@b2db64812c02 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org Change-Id: I5a5eb27fb28531cf7844d4c47ea084006822a59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600383Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657582}
-
Maggie Chen authored
This reverts commit 4a3bc42c. Reason for revert: <The needed V8 change has been rolled in version 7.6.116. This CL can be checked in now. > Original change's description: > Revert "Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase" > > This reverts commit 23971187. > > Reason for revert: <Waiting for the other V8 change rolling up into Chrome build. Revert this CL for now.> > > Original change's description: > > Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase > > > > Increase max_old_space_size to 4 GB based on availability of physical memory. > > The purpose of this finch is to support web apps that require more heap space > > for their data sets > > > > Bug:958974 > > > > Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792 > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Brian White <bcwhite@chromium.org> > > Commit-Queue: Maggie Chen <magchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656851} > > TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 958974 > Change-Id: I304ebbd702a000ee5f4a6d5956d3c61075144711 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598484 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657461} TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org Change-Id: Ifdd7cee050d3e9855539fee14dfd5dee608029ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600715Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#657581}
-