Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 26 Mar, 2018 24 commits
    • Ben Wells's avatar
      Revert "RDH: Ensure there's at most one LoadInfoList in flight." · 472c6863
      Ben Wells authored 
      This reverts commit d03adf5a.

Reason for revert:

This has caused some tests to fail flakily and reflect a crash that could happen in the wild. See http://crbug.com/825448

Original change's description:
> RDH:  Ensure there's at most one LoadInfoList in flight.
> 
> ResourceDispatcherHost pushes pending load state of all frames to the UI
> thread once every 250 milliseconds when there's a pending load.  This
> happens even when the UI thread is blocked.  Apparently it's causing an
> OOM when the UI thread is blocked.  Whatever is blocking the UI thread
> is another issue entirely, but we shouldn't use unbounded memory in the
> browser process.  This CL prevents load state updates from being sent
> until the previous set was ACKed by the UI thread.
> 
> Bug: 824869
> TBR: jam@chromium.org
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I3b68522c5281d477d3a621ac02e5df1f75153d99
> Reviewed-on: https://chromium-review.googlesource.com/978383
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545616}

TBR=jam@chromium.org,mmenke@chromium.org,csharrison@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 824869
Change-Id: I350dd7b357c32ffc7fb85a2417afaf779552ff77
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/979674Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545741}
      472c6863
    • Joel Hockey's avatar
      CrOS FileManager UMA ClickBreadCrumbs · 5be40566
      Joel Hockey authored 
      Added ClickBreadcrumbs user action for click in breadcrumb.

Fixed handling of MockFileSystem root to always include trailing slash.
The root dir is referenced in the breadcrumb and causes errors
in tests  with inconsistency of trailing slash.



Bug: 824607
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ff72f4d2542c25f87fd495bdb088d0d3315424f
Reviewed-on: https://chromium-review.googlesource.com/977381
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: default avatarSasha Morrissey <sashab@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarNaoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545740}
      5be40566
    • Dominic Battre's avatar
      Disable flaky AccessibilityFullscreenBrowserTest.InsideIFrame · ebabf635
      Dominic Battre authored 
      The test fails flakily on Linux, Windows and ChromeOS.
See bug for details.

TBR=foolip@chromium.org, dmazzoni@chromium.org

Bug: 825735
Change-Id: I5953f23c9c87e7b4ab2b0a6b9fd9d604a1bf27c3
Reviewed-on: https://chromium-review.googlesource.com/979799Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545739}
      ebabf635
    • Tetsui Ohkubo's avatar
      Fix crash on notification settings by keyboard. · 26872015
      Tetsui Ohkubo authored 
      When notification inline settings is opened from the top right gear icon
using by keyboard, it crashed as animation requires the event to be
LocatedEvent but it's not.

TEST=manual
BUG=823646

Change-Id: Ia683de86e042f010ac4bb0ee645fff170547b9fa
Reviewed-on: https://chromium-review.googlesource.com/974922
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: default avatarYoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545738}
      26872015
    • Blake O'Hare's avatar
      Random Cleanup: Floating keyboard dragging code · 5efc817a
      Blake O'Hare authored 
      Was trying to fix something in this code for an unrelated bug and came
across a few things that could be improved:
* There were too many stateful booleans making the code unnecessarily
complex.
* The type of event that initialized the drag should be in the
DragDescriptor, because it describes the drag and also has the same
life cycle.
* Flatten complicated if statements into chains of if/else's that only
use simple conditions.
* Use a switch statement for the event type.

Change-Id: I74712df2502960c6a98be0a705a5ced94a61ec75
Reviewed-on: https://chromium-review.googlesource.com/979378Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545737}
      5efc817a
    • Joel Hockey's avatar
      CrOS FileApp convert create_new_folder.js · a6d19f5c
      Joel Hockey authored 
      Fix MockFileSystem to delete entries rather than nulling them.
As null, the key is still iterable which causes errors.

Make root path consistent to always have trailing slash which
matches prod behaviour.

Set default size/date metadata for MockDirectoryEntry.

Put all test helper methods in 'test' namespace.

Replace waitUntil with repeatUntil/pending from
integration_tests/test_util.js which provides better error reporting.


Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie648388a7d6fe6c79951d5b4330234c378ffe2ee
Reviewed-on: https://chromium-review.googlesource.com/965722
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: default avatarNaoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545736}
      a6d19f5c
    • Yoshifumi Inoue's avatar
      Record current behavior of NGInlineNode::CollectInlines() with inline-block and float · ec917131
      Yoshifumi Inoue authored 
      This patch introduces tests for hanling of "inline-block" and "float" of
|NGInlineNode::CollectInlines()| to avoid regression for improving code health.

This patch is a preparation the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ifead65d6df83a19dbe2b82b509ef39427b56962c
Reviewed-on: https://chromium-review.googlesource.com/979751
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545735}
      ec917131
    • Dominic Battre's avatar
      Label media/video-transformed.html as flaky · 062b4653
      Dominic Battre authored 
      See bug for details.

TBR=hubbe@chromium.org,dalecurtis@chromium.org
notry=true

Bug: 754986
Change-Id: I33b05a30137c2c793d1704242dbb28d15c5aefe3
Reviewed-on: https://chromium-review.googlesource.com/979800Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545734}
      062b4653
    • Yue Li's avatar
      Add platform network provider to assistant · 6a95bc93
      Yue Li authored 
      Bug: 824566
Test: Manual
Change-Id: I58609375c31f9fc86e16ef2e214747ced8f24218
Reviewed-on: https://chromium-review.googlesource.com/974572
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545733}
      6a95bc93
    • Luciano Pacheco's avatar
      A11y fix for "Open With" dialog · eb94dea3
      Luciano Pacheco authored 
      Accessibility fix for "Open With" dialog that wasn't being read by
Chromevox.

Change DefaultTaskDialog to set tabindex=-1 for dialog items, so they
can be navigated via JS focus() method, but not via TAB key.

Change cr.ui.List to issue an focus to the item when navigated via
keyboard arrow up/down.

Dialog items already have the correct text to be read, see bug for
screenshot.

Bug: 435010
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2abc1d2d3d6cb6e78a373ccc51c79e34a0b756bd
Reviewed-on: https://chromium-review.googlesource.com/968004Reviewed-by: default avatarNaoki Fukino <fukino@chromium.org>
Reviewed-by: default avatarSasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545732}
      eb94dea3
    • Chandan Padhi's avatar
      Rectify comments in media_devices.mojom · f8e30387
      Chandan Padhi authored 
      This CL is a follow-up on https://crrev.com/c/956383.

Bug: 817769
Change-Id: I83a87fc0ee5889e9efa2c6e7a86ae8f2c6c70b90
Reviewed-on: https://chromium-review.googlesource.com/978225Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarGuido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545731}
      f8e30387
    • Dominic Battre's avatar
      media/color-profile-video-seek-filter.html fails · 8ff82dc9
      Dominic Battre authored 
      The media/color-profile-video-seek-filter.html fails flakily on Win7. See bug
for details.

notry=true
TBR=chcunningham@chromium.org

Bug: 825733
Change-Id: I42edc7907e4de80e2201689796de4ff5d10ff487
Reviewed-on: https://chromium-review.googlesource.com/979795Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545730}
      8ff82dc9
    • Darren Shen's avatar
      [css-typed-om] Fix crash for css-wide keywords in custom properties. · 91057d4c
      Darren Shen authored 
      When converting CSSCustomPropertyDeclaration to CSSUnparsedValues, we
used to assume that CSSCustomPropertyDeclaration will always have a
CSSVariableData, but it turns out that css-wide keywords are stored
as a CSSValueID instead of a CSSVariableData.

This patch handles css-wide keywords on CSSUnparsedValues correctly.

We added a unit test and not a WPT since this is likely a blink-only
implementation detail.

Bug: 824740
Change-Id: Iefbdca4abc736562b81f5c6a3f0332975b842961
Reviewed-on: https://chromium-review.googlesource.com/977141
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545729}
      91057d4c
    • Adam Rice's avatar
      Explicit WebSocket ownership in WebSocketManager · e6cb368b
      Adam Rice authored 
      Previously network::WebSocket objects were stored as raw pointers
in a set and deleted manually. Use a set<unique_ptr<WebSocket>,
UniquePtrComparator> instead, making ownership explicit and reducing the
risk of leaking.

Change-Id: I0337551d8fd073341241723538cf9864eb206c87
Reviewed-on: https://chromium-review.googlesource.com/978282Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545728}
      e6cb368b
    • Darren Shen's avatar
      Disable flaky BackgroundTest.ActiveDescendantUpdates test · 2a606682
      Darren Shen authored 
      TBR=dmazzoni@chromium.org

Bug: 825429
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I677963581b6594c014f05a717330f4b5f827a372
Reviewed-on: https://chromium-review.googlesource.com/979745
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545727}
      2a606682
    • Giovanni Ortuño Urquidi's avatar
      desktop-pwas: Block mixed content in Desktop PWAs · c8836696
      Giovanni Ortuño Urquidi authored 
      Bug: 788251
Change-Id: I328cb3c1c812fab565eafc4009e0210653e236c7
Reviewed-on: https://chromium-review.googlesource.com/958768Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Reviewed-by: default avatarMatt Giuca <mgiuca@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545726}
      c8836696
    • Matt Falkenhagen's avatar
      Revert "Refactor BrowserThreadImpl, BrowserProcessSubThread, and BrowserMainLoop" · fa239c8c
      Matt Falkenhagen authored 
      This reverts commit d260e9cf.

Reason for revert: In Windows Canary versions since 67.0.3377.0, where this commit landed, IO thread hang reports have spiked dramatically. It is now the #1 browser crash report on Windows Canary at 33% of reports. I'm speculatively reverting this to see if the crash rate heals.

Original change's description:
> Refactor BrowserThreadImpl, BrowserProcessSubThread, and BrowserMainLoop
>
> This brings back the invariant that BrowserThread::IO isn't available
> before BrowserMainLoop::CreateThreads(). This was broken to fix issue
> 729596 to bring up the thread earlier for ServiceManager but it is
> important that code that posts to BrowserThread::IO statically have an
> happens-after relationship to BrowserMainLoop::CreateThreads(). Exposing
> it statically earlier put that invariant at risk.
>
> Thankfully fixing issue 815225 resulted in finally reaching the long
> sought goal of only having BrowserThread::UI/IO. Now that the IO thread
> is also kicked off before it's named statically, BrowserThreadImpl no
> longer needs to be a base::Thread, hence this refactoring.
>
> Before this CL:
>  * BrowserThreadImpl was a base::Thread
>    (could be a fake thread if SetMessageLoop was used)
>  * BrowserProcessSubThread was a BrowserThreadImpl
>    (performed a bit more initialization)
>  * BrowserProcessSubThread was only used in production (in
>    BrowserMainLoop)
>  * BrowserThreadImpl was used for fake threads (BrowserMainLoop for
>    BrowserThread::UI) and for testing (TestBrowserThread(Impl)).
>  * BrowserThreadImpl overrode Init/Run/CleanUp() from base::Thread to
>    perform some sanity checks as well as drive IOThread's Delegate (ref.
>    BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread re-overrode Init/Run/CleanUp() to perform
>    per-thread //content initialization (tests missed out on that per
>    TestBrowserThread bypassing BrowserProcessSubThread by directly
>    subclassing BrowserThreadImpl).
>
> With this CL:
>  * BrowserThreadImpl is merely a scoped object that binds a provided
>    SingleThreadTaskRunner to a BrowserThread::ID.
>  * BrowserProcessSubThread is a base::Thread and performs all of the
>    initialization and cleanup specific to //content (this means it now
>    also manages BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread can be brought up early before being bound to
>    a BrowserThread::ID (BrowserMainLoop handles that through
>    BrowserProcessSubThread ::RegisterAsBrowserThread())
>
> Unfortunate exceptions required for this CL:
>  * IOThread::Init() (invoked through BrowserThreadDelegate) perfoms
>    blocking operations this was previously performed before installed
>    the ThreadRestrictions on BrowserThread::IO. But now that //content
>    is initialized after bringing up the thread, a
>    base::ScopedAllowBlocking is required in scope of IOThread::Init().
>  * TestBrowserThread previously bypassing BrowserProcessSubThread by
>    directly subclassing BrowserThreadImpl meant it wasn't subject to
>    ThreadRestrictions (unfortunate becomes it denies allowance
>    verification to product code running in unit tests). Adding it back
>    causes DCHECKs, as such
>    BrowserProcessSubThread::AllowBlockingForTesting was added to allow
>    this CL to pass CQ.
>
> Of note:
>  * BrowserProcessSubThread is still written as though it supports many
>    BrowserThread::IDs but in practice it's mostly always
>    BrowserThread::IO (except in ThreadWatcherTest I think). This change
>    was big enough that I didn't bother also breaking that
>    generalization.
>  * BrowserThreadImpl's constructor was made private to ensure only
>    BrowserProcessSubThread and a few select callers get to drive it (to
>    avoid previous missed initialization issues)
>  * Atomics to manage BrowserThread::SetIOThreadDelegate were removed.
>    Restriction was instead added that this only be called before
>    initialization and after shutdown (this was already the case).
>
> Follow-ups to this CL:
>  * //ios duplicates this logic and will need to undergo the same change
>    as a follow-up
>  * Fixing ios will allow removal of base::Thread::SetMessageLoop hack :)
>  * Removing BrowserThreadGlobals::lock_ to address crbug.com/821034 will
>    be much easier
>  * BrowserThread post APIs should DCHECK rather than no-op if using a
>    BrowserThread::ID before it's registered.
>
> Bug: 815225, 821034, 729596
> Change-Id: If1038f23079df72203b1e95c7d26647f8824a726
> Reviewed-on: https://chromium-review.googlesource.com/969104
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544440}

TBR=gab@chromium.org,jam@chromium.org
NOPRESUBMIT=true

# Not skipping CQ checks because original CL landed > 1 day ago.
# falken: Skipping presubmit to use deprecated ThreadResrictions::DisallowWaiting().

Bug: 815225, 821034, 729596
Change-Id: I2be97c5d8183497c005ab397c871f625b034d850
Reviewed-on: https://chromium-review.googlesource.com/979752
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545725}
      fa239c8c
    • Khushal's avatar
      cc: Add some diagnostic CHECKs for sw image cache crashes. · fb48059c
      Khushal authored 
      Change a few DCHECKs to CHECKs to validate if some crashes are
resulting from using unlocked images, or incorrectly unlocking them
earlier.

R=enne@chromium.org, ericrk@chromium.org

Bug: 802976
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibe0b9ef6ac52e6fafc9fd2670e20a9eefac17234
Reviewed-on: https://chromium-review.googlesource.com/979160
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: default avatarenne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545724}
      fb48059c
    • Chih-Yu Huang's avatar
      v4l2 vea: Correct the timing of sending "force key frame" signal. · b000535f
      Chih-Yu Huang authored 
      Originally, the thread to update parameter
"V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME" is different from QBUF the
frame, so we cannot make sure the parameter is updated right before
the key frame is QBUF. This CL queues the parameter |force_keyframe|
with the frame, and update the parameter before QBUF the frame.

BUG=b:74501913
TEST=pass GTS RtcVideoCodecTest#testRequestSyncFrameH264

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1733f8ee474a0adeb8a31e6d196fdf27596a9f57
Reviewed-on: https://chromium-review.googlesource.com/958791
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: default avatarPawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545723}
      b000535f
    • Eugene But's avatar
      Add Download.IOSDownloadedFileNetError to New Download Manager. · f363f54c
      Eugene But authored 
      This is an existing histogram logged for the Old Download Manager.
The histogram is already a part of histograms.xml file.

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I720221f6a5b395d947a96a99ce7e4d6fe7bee09e
Reviewed-on: https://chromium-review.googlesource.com/979267Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545722}
      f363f54c
    • Darren Shen's avatar
      [css-typed-om] Support font properties. · 077ec79c
      Darren Shen authored 
      We try to support as many font properties as possible. However, several
font properties have not been implemented in Blink yet. Also, the
computed value for font-stretch is wrong (it should be as specified,
and no rounding should occur).

Spec: https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue

Bug: 820299
Change-Id: I744d03a08856bd6d0df6bd07230ec80138e6e3b7
Reviewed-on: https://chromium-review.googlesource.com/977247Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545721}
      077ec79c
    • Daniel Bratell's avatar
      Gave two kBufferSize constants unique names. · aa60d106
      Daniel Bratell authored 
      In some (extreme) jumbo configurations on Mac two kBufferSize
constants ended up in the same translation unit and caused
a compilation error. This patch gives them unique names to
not cause any future problems.

Change-Id: I96d5e51024ff99fcb838346726aa1635127841eb
Reviewed-on: https://chromium-review.googlesource.com/978209
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545720}
      aa60d106
    • Kent Tamura's avatar
      Remove wtf/DataLog.* · 95767e0e
      Kent Tamura authored 
      Remove DeprecatedDataLogF() usage from platform/heap/.

Bug: 720442
Change-Id: Iac1a3ca91c932001ecb7f0e6beee3842108668c1
Reviewed-on: https://chromium-review.googlesource.com/977843Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545719}
      95767e0e
    • Daniel Bratell's avatar
      Avoid clashes between the kLeftToRight in OSX SDK and WTF::Unicode. · 90eb1cda
      Daniel Bratell authored 
      There is a kLeftToRight in OSX's SDK and in WTF::Unicode. If
WTF::Unicode is imported into global scope those might clash and
this happens in some non-standard (extreme) jumbo configurations.

Since "using namespace" isn't allowed per the coding standard,
this just adds the WTF::Unicode namespace to those symbols
that need it.

Change-Id: I97c59e5ffed7d2bd0f8340f5d14b69dc532175d6
Reviewed-on: https://chromium-review.googlesource.com/978205
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545718}
      90eb1cda
  3. 25 Mar, 2018 15 commits
  5. 24 Mar, 2018 1 commit
    • Ian Vollick's avatar
      [vr] Update fullscreen toast · 3d4b80f7
      Ian Vollick authored 
      This CL changes constants and strings to match the spec.

Bug: None
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2d94a15c72e247cfc047fc54e9c7cdeda3b4a4f6
Reviewed-on: https://chromium-review.googlesource.com/979411Reviewed-by: default avatarYash Malik <ymalik@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545702}
      3d4b80f7