- 16 Oct, 2019 40 commits
-
-
Himanshu Jaju authored
GetDeviceCandidates + RenameDevices had become a bit complicated to understand. Also, the number of calls to GetDeviceName has been halved (at most once per device). Bug: 1014107 Change-Id: I1f5a04f63cef1b3e94b719fc376ae4d47cfbf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865173 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706528}
-
Yuki Shiino authored
Makes SymbolNode's constructor easy to call. It turned out that most callers will pass simple template text. Bug: 839389 Change-Id: Id27031efbbb5b216866c38a62fb805349652b380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862596 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#706527}
-
Daniel Hosseinian authored
Change-Id: I8f99b6ac598d280780b1569c1deabb512312b4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860284 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706526}
-
Xiaoqian Dai authored
If after drag ends, we should go to home launcher screen, do the window scale down and opacity fade out animation. The window will scale down to the middle of the display and disappear. During the window scale down animation, the backdrop should be disabled. Also fixed an issue that if the drag is cancelled, overview should be dismissed if it was opened during dragging. Bug: 997885 Change-Id: I6a27c8e4bf9021e14ed0d26260c89c97adec614b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863256 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706525}
-
Aran Gilman authored
Enabling the flag appears to break rendering of most pages on ChromeOS, including chrome://flags. This CL removes the option to enable it for now. Bug: 1011696 Change-Id: I818be2add7c34e181297477244805e02f7ffcb85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848478Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#706524}
-
Olivier Li authored
This is ground work for moving ProfileSyncService to the ThreadPool (see bug) but also a logical change by itself since these functions have no specific need to be run on a dedicated thread. Change-Id: I45bdbeb0a768af838700a37945613c1ddc475ea0 Bug: 1014464 Change-Id: I45bdbeb0a768af838700a37945613c1ddc475ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862666Reviewed-by:
-
Aga Wronska authored
The feature is enabled since February and no problems were reported. Bug: 1013650 Change-Id: Iec095972123022e2b0d0e0a116a373c99daaeee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856629Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#706522}
-
zhaoyangli authored
Moved ensureAppLaunchedWithFeatures from -setUp to overriding launchAppForTestMethod to eliminate unnecessary relaunches. CQ bot run results show significant improvement without the relaunches. BUG: 1009017, 1010463 Change-Id: I650304daaa9e4271310e180635a8fb6ff865f717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854786Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706521}
-
John Budorick authored
Bug: 1014754 Change-Id: I0e3e24f8c43d9835937f47e95ece0ca9f3efd82f Tbr: bsheedy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864375Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706520}
-
Daniel Hosseinian authored
Change "Fit to page" string to "Fit to printable area." "Fit to paper" will center and scale the page contents of a PDF to fit the borders of the paper being printed on. In contrast, "fit to printable area" will center and scale the page contents of a PDF to fit within the margins of the printer's printable area. Bug: 989978 Change-Id: I5caf319959fb8d9bd32f3c78c86a27379cffe166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812129 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706519}
-
Yuki Shiino authored
LiteralNode is a literal text, not a template text, so the template rendering engine will output the text as is without applying any template magic. Bug: 839389 Change-Id: Ie1c83e442ba68ff242854f491b0d042ad940b73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864753Reviewed-by:
-
Elly Fong-Jones authored
While the Ok/Cancel messages appear to be dynamically computed, in fact this dialog never calls DialogModelChanged, so the initial messages are always the ones used. As such, this change will cause no behavior difference. Bug: 1011446 Change-Id: Ib23484c83eaa8c64b8e5062d922b0365b4e65d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854684Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706517}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/45deba856dba..2f8a97068d48 git log 45deba856dba..2f8a97068d48 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 taylori@google.com Merge "perfetto-ui: Go to thread state" 2019-10-16 taylori@google.com Merge "perfetto-ui: Move details panel into it's own component" 2019-10-16 fmayer@google.com Merge "Set correct fields on fist packet in sequence." 2019-10-16 tneda@google.com Merge "perfetto-ui: Show heap profile track even if the trace has only heap profiles inside" 2019-10-16 zakerinasab@google.com Merge "Fix minor issue in setting arg id" 2019-10-16 lalitm@google.com Merge "trace_processor: fix dcheck failure when we get an out of order upid counter" 2019-10-16 fmayer@google.com Merge "Fix incorrect comment." 2019-10-16 lalitm@google.com Merge "trace_processor: fix support for optional<stringid> columns" 2019-10-16 eseckler@google.com Merge "Revert "processor: Move TimestampedTracePiece into its own header"" 2019-10-16 lalitm@google.com Merge "trace_processor: add support for remaining operations on new tables" 2019-10-16 eseckler@google.com Merge "processor: Move TimestampedTracePiece into its own header" 2019-10-16 eseckler@google.com Merge "processor: Import and export legacy flow event args for all TrackEvents" 2019-10-16 tneda@google.com Merge "perfetto-ui: Fixing SQL error for ambiguous name" 2019-10-16 tneda@google.com Merge "New track with flamegraph for heap profiles" Created with: gclient setdep -r src/third_party/perfetto@2f8a97068d48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I8a168ac61ce0bcb5f8b210fc92301209a14032f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706516}
-
Elly Fong-Jones authored
This change migrates all the other overrides in //chrome/browser/ui/views/autofill of GetDialogButtonLabel over to set_button_label. Many of these dialogs dynamically compute their label text based on the state of their models/controllers. That causes some difficulty with the "push-based" (client sets properties) design DialogDelegate is migrating to from its existing "pull-based" (DialogDelegate asks client for properties) design. This change migrates: 1) CardUnmaskPromptViews, by adding an UpdateButtonLabels private method to this class that pushes updated label text to DialogDelegate when needed and calling it at every point that DialogModelChanged is called. 2) LocalCardMigrationBubbleViews, which uses a static ok button text. 3) SaveCardBubbleViews, which uses controller-generated text but never updates it in use (no calls to DialogModelChanged) 4) WebAuthnOfferDialogViewImpl, which already has a RefreshContent method, by pushing new button text in that method. Bug: 1011446 Change-Id: Iaf497223e3c44c3a6227e264e40e441f2fbe389f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854689Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
-
Samuel Huang authored
This reverts commit 168860e0. Reason for reland: Fixed problem: The target source_set("dev_ui_loader") had missing dependencies, and doesn't reach. third_party/blink/public/mojom:mojom_platform Two ways to fix this are: A: Add the missing dependencies to chrome/browser/dev_ui/android:dev_ui_loader B: Remove chrome/browser/dev_ui/android:dev_ui_loader, and fold its {sources, deps} into chrome/browser:browser. We're choosing B for simplicity, but may adopt A eventually. Original change's description: > Revert "[DevUI DFM] Change install flow to use NavigationThrottle." > > Reason for revert: Seems to have broken android-archive-rel compile, though this may be exposing some pre-existing bad dependency elsewhere: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/5717 > > Change-Id: I7eff36d7e01c31a76f39250a255d27972b0962d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864392 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Original change's description: > > [DevUI DFM] Change install flow to use NavigationThrottle. > > > > Bug: 927131,987040,1013522 > > Change-Id: I5c384671c858d26a303afc58c03f4314c8ef0117 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854524 > > Commit-Queue: Samuel Huang <huangs@chromium.org> TBR=pkasting@chromium.org,creis@chromium.org,huangs@chromium.org,thestig@chromium.org,dbeam@chromium.org,agrieve@chromium.org,tiborg@chromium.org Bug: 927131, 987040, 1013522 Change-Id: I526f3194b0115171721a53fca60fa6ffa6e3c441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864411Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706514}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I935953fc0afa563c2bcb453ac4ae1e53fd755905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864749Reviewed-by:
-
Alexander Timin authored
Before restoring a RenderFrameHost from the back-forward cache, cleanup existing pending RenderFrameHost. Without the back-forward cache, this is done automatically when GetRenderFrameHostForNavigation is used. R=arthursonzogni@chromium.org,lowell@chromium.org CC=alexmos@chromium.org,nasko@chromium.org BUG=1003744 Change-Id: I52375bca1c69f02cca367434342670ae287c1ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855924Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706512}
-
ckitagawa authored
The current code is too lax. It doesn't enforce bounds checks strongly enough. It claims to be for RVAs, but allows all sections through. This results in downstream code being unable to trust that the regions created are safely within the image resulting in issues when Fuzzing if the data is ill formed. To fix the fuzzers we should be remove this forgiveness. However, long term a better check for RVA forgiveness should maybe be investigated. Bug: 1013823, 1013842, 1013871, 1014124 Change-Id: Ic164fc76d687711c496f57b3bfe33ced6b8ad838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863070Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#706511}
-
Hiroshige Hayashizaki authored
This CL splits some WPT tests into - wpt/import-maps/core/ that tests the core features after https://github.com/WICG/import-maps/pull/176, and - wpt/import-maps/builtin-support.tentative/ that requires pre-#176 built-in module and fallback support, in order to test builtin- and non-builtin- versions easier. Bug: 1010751 Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706510}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the viz::mojom::FrameSinkManagerClient interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ice2d034ac1b5eed866c7296046cf031eb0f00f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859987 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#706509}
-
Robbie McElrath authored
See https://crbug.com/1010625 for background. This CL does the following: * Whitelist prefs needed to record the SeedFreshness metric * Change the SeedInfo.date field to use the device's current time rather than the server's time from the Date header * Copy the seed that VariationsSeedLoader finds to the pref that VariationsSeedStore uses so its metrics recording code will work Test: Manually verified SeedFreshness was being recorded Bug: 1010625 Change-Id: I8b3eda5967672b4fd4218bab288157dfd06ce38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828235 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706508}
-
Amr Aboelkher authored
Add ChromeVox support to indicate for each accessibility feature, whether its forced on, and is being controlled by a policy, in the tray accessibility menu. Bug: 552439 Change-Id: Ia6066725deeaa4587192c6b309de7dfdfc4b10fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863020Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#706507}
-
rbpotter authored
Update extensions.html to use relative paths like the rest of the page. This reduces the differences in the generated output file when updating to Polymer bundler v4. Update print preview's icons.html file to not rely on "xlink:href", which is deprecated and no longer necessary. This link also breaks when passed through Polymer bundler v4. Bug: 921285 Change-Id: I8b68c4e91db141065cce8a1cc83a86a9e8e051b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862085Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#706506}
-
Cliff Smolinsky authored
The test was incorrectly expecting >1 dll to be enumerated for the case when a target module is specified. Bug: 1014527 Change-Id: I1e8fd5474411f5e4286a171e0353e24e46e668b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863450Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706505}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba97f6065ed1..a0568178808d git log ba97f6065ed1..a0568178808d --date=short --no-merges --format='%ad %ae %s' 2019-10-16 ehmaldonado@chromium.org depot-tools: Remove support for --auth-refresh-token-json. Created with: gclient setdep -r src/third_party/depot_tools@a0568178808d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756 Change-Id: I554e1bee3eec2c1f055509132b974249ea735488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864401Reviewed-by:
-
Brian Sheedy authored
Removes the LUCI config and test spec entries for the GPU Mac 10.14 testers, as the build-side bot configs were removed in crrev.com/c/1860147. Bug: 1005378 Change-Id: Ie1b54734874723cbd993ffc02ef7952154e97572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863740 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706503}
-
Sebastien Marchand authored
This database isn't needed anymore now that sites can opt out from freezing via an Origin Trial. Change-Id: I91608ecc2e1bc77ddf3da762ff332674f403f1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862723Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#706502}
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..e180b591d166 $ git log 1093c4de2..e180b591d --date=short --no-merges --format='%ad %ae %s' 2019-10-16 cwallez Fix compilation with shared_library components on Windows 2019-10-16 cwallez Add missing header for MSVC 2019-10-16 enga Split generation of dawncpp headers from libdawncpp 2019-10-16 natlee D3D12 replace ASSERT_SUCCESS with better error handling 2019-10-16 hao.x.li Prioritize discrete GPU in end2end tests 2019-10-15 senorblanco clang-win compile files for skia-dawn. 2019-10-15 cwallez Add dawnGetProcAddress. 2019-10-15 cwallez Split the libdawn target in components with a single purpose. Created with: roll-dep src/third_party/dawn TBR=kbr@chromium.org BUG=dawn:22 Change-Id: I03fdfed640f8a1c6747e369f34e9be26903de27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865168Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#706501}
-
John Budorick authored
Bug: 1014952 Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694 Tbr: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351Reviewed-by:
-
Alex Ilin authored
The test removes the sole profile, waits for the browser removal from the BrowserList and then expects that the new browser is already added. This seems not to be always true, since the new profile/browser is created asynchronously. This CL modifies ProfileHelperTest.DeleteSoleProfile to wait for BrowserListObserver::OnBrowserAdded() event before checking that the BrowserList isn't empty. Bug: 1008238 Change-Id: Ie7b6a705d7cba5a03e943ed6ec0ab4c3ea08c36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863294 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Koji Ishii authored
Bug: 988015 Change-Id: I9a070297c2b3f0422e94f555d2637d15cd498002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719913Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706498}
-
Parastoo Geranmayeh authored
This reverts commit 1901912d. Reason for revert: potential cause for flaky tests. Please see bug. Bug: 1014966 Original change's description: > Composited Worklet Animations: Fixed updating local time on main thread. > > This CL changes how local time of composited worklet animations is updated on main thread: > instead of polling local time on main thread, the local time is posted via animation events > by the composited thread to the main thread. > > Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing > > Changes made: > - Expanded AnimationEvent to support worklet animation time update event type. > - Reused existing mechanism of posting animation events to the main thread to support new > event type. > - Removed "peek" logic. > - Enabled tests that previously failed. > > > Bug: 943787 > Change-Id: I2d285506739ea623e292927d21e54910fb7e24bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826872 > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#706078} TBR=flackr@chromium.org,majidvp@chromium.org,gerchiko@microsoft.com Change-Id: Ic5bfd6532578276fe9e0de80f96f343a863e4f0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865350Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706497}
-
Livvie Lin authored
Don't downgrade to DANGEROUS on form edits when kMarkHttpAsParameterDangerWarning is enabled. This also means that DevTools will no longer show the form field edited warning in these cases. Bug: 1008218 Change-Id: Ie3b94406824494f1fb8e2b8d6edf9208ff08a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860396Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706496}
-
Ionel Popescu authored
According to https://w3c.github.io/html-aam/#el-datalist the aria role for datalist should be listbox (currently it is menu). For datalist options according to https://w3c.github.io/html-aam/#el-option the aria role should be option (currently it is menuitem). The unit test is also updated to use the new aria roles. Bug: 1011133 Change-Id: Ia3541067e3d8ada622c5c3776f3b1b0ce0a26c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838997Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706495}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/59e72b71b5cf..36446f281ca2 git log 59e72b71b5cf..36446f281ca2 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 senorblanco@chromium.org Reformat BUILD files. 2019-10-16 senorblanco@chromium.org Roll Dawn to ToT. 2019-10-16 robertphillips@google.com Start disentangling tessellation from pipeline creation in GrTextureOp 2019-10-16 halcanary@google.com canvaskit: add helpful message to compile.sh Created with: gclient setdep -r src/third_party/skia@36446f281ca2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I1b5590ce88ef6512b1922f5a489963d041bb42d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865197Reviewed-by:
-
Istiaque Ahmed authored
On windows, filename with (.| )+ suffix is ignored, i.e. "foo.html." and "foo.html" are treated the same. VerifiedContents is already aware of this and it stores a canonicalized version of filename for filenames containing (.| )+ suffix. This CL makes ComputedHashes aware of the change too, so that searching for hashes will consider canonicalized version of the filename as candidate. This makes ComputedHashes::Reader and VerifiedContents treat this suffix behavior consistently. This CL also adds unittest and browsertest for the fix. Bug: 696208 Test: See bug for test repro. Change-Id: I7c59add5c035815673259ef1f995c7b9ed01a75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772643 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706493}
-
Eric Karl authored
Currently, when Display is destroyed, it tears down DisplayScheduler midway through destruction. This is problematic as DisplayScheduler can call back into Display in a partially destroyed state. We could force DisplayScheduler to be destroyed earlier, but this is still somewhat brittle. Instead we allow DisplayScheduler to have a null DisplaySchedulerClient and null this before destroying Display. Bug: 1012943 Change-Id: I5892ed2746ba29ef5c3c027e9564e52ee6c659ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863674 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706492}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1c80a64. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5d8180308c7bf43416d51e0e2bf042910475cc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864874Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706491}
-
sczs authored
- Creates InfobarSaveCardCoordinator and implements stop and infobarWasDismissed which is common between all InfobarCoordinators. - Creates kInfobarTypeSaveCard and expands infobar_metrics_recorder to handle this case. (The Histogram suffix is being updated on https://crrev.com/c/1862867) Bug: 1014652 Change-Id: I86e70ce67f01e63622d83834094fb4bd4fded68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862863Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706490}
-
Christian Fremerey authored
Bug: None Change-Id: Id480b5ff4951b72408bf26765bff53fb4e447901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811279Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706489}
-
