- 23 Oct, 2020 40 commits
-
-
Michael Bai authored
Check the system setting instead of using Chrome's Bug: 1141646 Change-Id: I43d8bfc8dd3462da21cc040d2c5e4bc3b7469bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492964Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#820380}
-
Maria Kazinova authored
Forms that do not have a <form> tag are treated by Passwordmanager as one synthetic form. This might negatively affect websites that allow navigation via JS scripts, without committing the actual navigation. Password fields might be added/changed, but the already existing PasswordFormManager can store outdated server predictions and treat the form as previously filled. This CL makes sure that the valid server predictions are used when the form changes. Bug: 1140480 Change-Id: I68475dc0c55e8878781351f3f28b3f3f70429271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489990 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#820379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1315d1d2d5a5..1bec20b5b70c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141127 Tbr: sky@google.com,mohsen@google.com Change-Id: I889b09de8551b518b95d0512e08987229fa8165e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495046Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820378}
-
Livvie Lin authored
Enables the component updater logic to be moved into a component and used in iOS. Bug: 1140271 Change-Id: If3714b26d9a0dc02f540b67f071a3774d49e94ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486700Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820377}
-
Andre Le authored
This is a reland of 55f62f27 BUG=1140857,1140980 Original change's description: > [CrOS PhoneHub] Disable Locate Phone button when Silence Phone is on. > > - Add an observer for state change in Silence Phone so that Locate Phone > can be disable when Silence Phone is on. > - Refactor InitQuickActionsItems() since Locate Phone and Silence Phone > is no longer independent. > > BUG=1106937,1126208 > > Change-Id: I6f015e868d6d00df6a40447de62f3efd0b2f2ad0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480662 > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819161} Bug: 1106937 Bug: 1126208 Change-Id: I3bcae322124af80f0947a26c7b0e776757f2ccfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490380 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#820376}
-
Reilly Grant authored
The SerialPort close() method internally calls this.readable.cancel() and this.writable.abort() to close its data streams before closing the port itself. When either of these streams is already erroring the Promises returned by these methods can be resolved before the underlying source or sink has actually finished closing the stream. This patch adds logic to wait until the streams are actually closed before continuing the close process. Bug: 1137563 Change-Id: Ic2c1fd10524292f5b33dfc8279804fe89b00ce7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462711 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#820375}
-
Zachary Kuznia authored
This will still work after git "master" branch is renamed to "main", and makes inclusive language dashboards easier to interpret right now. Bug: none Change-Id: I628be29ce14257b82aa0f88448a9650b56671359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493186Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Zork <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#820374}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ia203016d23ba52d8cb1cc33164a9a56988aaba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492546 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#820373}
-
Daniel Cheng authored
Bug: 1047547 Change-Id: I4feb88f042b31c02f6616a1ccf250d38af1a16c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494514Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820372}
-
dpapad authored
This was intentionally postponed in previous CLs that converted them to JS modules to make it easier to review. Fixed: 1139849 Change-Id: Id3399caabcc2057de545b73cf275ee6f813161f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491975 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#820371}
-
Matt Mueller authored
Bug: b/170619368 Change-Id: I9ff06c3ef7dee571936dee89ab5e45c64163b1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488906Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#820370}
-
Xianzhu Wang authored
This reverts commit 22c627b9. Reason for revert: Performance regressions, e.g. crbug.com/1141834. Need to improve performance of copying subsequences. Original change's description: > Unify PaintController for CompositeAfterPaint and pre-CAP > > This lets pre-CompositeAfterPaint also use a single PaintController > for each local frame tree to reduce the differences between CAP and > pre-CAP. Each GraphicsLayer will create a subsequence. During paint, > when we don't need to repaint a GraphicsLayer, we copy the cached > subsequence for the GraphicsLayer. > > Bug: 1132717 > Change-Id: I27abe8f0f8380b8d4de73b47d3e1fd9f4860365c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466266 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820136} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I67fd3e149059fa0c3413609e4f14be25675eeb1d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495860Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820369}
-
Chait Pinnamaneni authored
Original PR https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Bug: 1137050 Change-Id: I9772601823cac56518d7bbedc6320d3970ad6a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463929Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#820368}
-
Jamie Madill authored
The standalone and non-standalone ANGLE tests are now duplicates. We can switch the bots to use the non-standalone named tests and then remove the duplication. Also removes the old main files that interact with the base test launcher. These are no longer used. Must land after http://crrev.com/c/2491932 rolls into Chrome. Bug: angleproject:5124 Bug: 1141838 Change-Id: Id2fb314ff46562b40473af5224282f70ea3b890a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#820367}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4280.20-1603100572-benchmark-88.0.4296.6-r1 to 88-4280.20-1603100572-benchmark-88.0.4300.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I063a6f78cd97374f3a8596f03e64fbd7972b95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820366}
-
Justin Cohen authored
Bug: 1140474 Change-Id: I74c00893e6c69cb1cfcbbeed906448d0958f524a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495245 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820365}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/88d705dc85ff..1b1d2a590744 2020-10-23 dneto@google.com Fix doxygen comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I0d89a433c66ef7f00403533b18898ea1bc8353ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495390Reviewed-by:
-
Xiyuan Xia authored
Make stopSmoothnessTracking to return ThroughputTrackerAnimationData that contains raw metrics data so that tast side could calculate jank metrics as well as smoothness. Bug: 1132017 Change-Id: If1a64d1b681505d0baece3bd7650c1e8a04351b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488664 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#820363}
-
Sergey Ulanov authored
Bug: 1067477 Change-Id: Ib15b394124e01337c39c311d69f38df39ef5af6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446542 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820362}
-
Mario Sanchez Prada authored
This CL migrates this legacy IPC message out of page_messages.h to the PageBroadcast mojo interface from Blink, by using the newly defined method UpdateRendererPreferences() in that interface. This patch focuses on migrating from legacy to IPC only, follow-up CLs will move RenderViewImpl::OnSetRendererPreferences into Blink itself as a separate step. Bug: 1102442 Change-Id: If49aead29a6bc2c36136eb69256795ea7a8239f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412309Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#820361}
-
Mohamed Adel authored
In the new API, dismissing all notifications from the notification center does not trigger an event, so instead we poll over them. This is similar to what the windows NPB does. In addition to that, this CL makes sure that each notification can only have one category, otherwise updating the notification will result in using the wrong categories. Bug: 1138470, 1140586, 1141437 Change-Id: Ica2f4f9e9159e041ea67f275ef54ce58bc6e2996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488401Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#820360}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b3c8d667a5f..4cd11945c5a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2682d7b7d401967e141d7bdcf7cc3ba8aedc1db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495339Reviewed-by:
-
Tab Atkins authored
Change-Id: I9dcbfa938adf76afa650e441da9144a280c7601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495383Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#820358}
-
Adam Langley authored
This flag expired in M88. It's taking longer than hoped, but this is still a going concern so unexpire for another six months. BUG=1002262 Change-Id: I4c8e98e393bd0f30eece8f5065fe574cf47fedb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495706 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#820357}
-
Elaine Chien authored
Bug: 1132244 Change-Id: I0486856cffc8c567d70dc2d4cb3a9aa14ad44214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482031Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#820356}
-
John Chen authored
This reverts commit f8b7ec28. Reason for revert: Causing all builds to fail on android-pixel2-perf failing Original change's description: > Reland "Android: Use locally-build devil deps only when build_with_chromium=true" > > This reverts commit b47e9c83. > > Reason for reland: Updated more .pydeps files. > > Original change's description: > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true" > > > > This reverts commit 49fdeca1. > > > > Reason for revert: Breaking presubmit due to stale .pydeps file: > > android_webview/tools/run_cts.pydeps > > > > Original change's description: > > > Android: Use locally-build devil deps only when build_with_chromium=true > > > > > > Bug: 1120190 > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842 > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#819489} > > > > TBR=agrieve@chromium.org,bpastene@chromium.org > > > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1120190 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819668} > > TBR=agrieve # reland > > Bug: 1120190 > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819810} TBR=agrieve@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1120190, 1141891 Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820355}
-
Kartik Hegde authored
Make some of the problem descriptions more succint. TEST=unit_tests --gtest_filter=CaptivePortalRoutineTest.* BUG=chromium:956783 Change-Id: Ie3b666e0aa999a4d387ef0ed4634364df18966dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490176Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#820354}
-
Ian Wells authored
This is a reland of 8699ff59 Original change's description: > Enable JDK library desugaring by default > > Bug: 1056751 > Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817575} Bug: 1056751 Change-Id: I7d6f7336057afd80960d3b6c6a37c595b7c84629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493362Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#820353}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15d8174fc944..530933006d3c 2020-10-23 johnstiles@google.com Add unit test demonstrating recursion codegen bug. 2020-10-23 johnstiles@google.com Fix use-after-free discovered by fuzzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I7eaee3483812115ed06f9f6a5803ab774bbfd9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495683Reviewed-by:
-
Yuke Liao authored
Besides test targets, the lacros chrome target also depends on ash chrome to run. Bug: 1129223 Change-Id: I75e94cd2de624d0cb3740b6596cb14609a5c0af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495508Reviewed-by:
-
Joshua Berenhaus authored
There's a notice on the top of base/test/metrics/OWNERS that mentions a fixed bug. Cleaning that up. Bug: 846421 Change-Id: Ia9131cabc24a54ec698b71d55d9be5e15fa98ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491101 Auto-Submit: Joshua Berenhaus <joshber@microsoft.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#820350}
-
Lei Zhang authored
Avoid conflicts with LOG_FOO in sys/syslog.h on Linux. Convert LOG_FOO to LOGGING_FOO in base/, but leave the rest of the code base untouched. Keep LOG_FOO defined for now to make it possible to convert the rest of the code base in smaller increments. BUG=849450 Change-Id: Icce5121f7cd036e9e9eddd7de68f57474f4ab73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1086147Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820349}
-
Dave Tapuska authored
The only usage of this API is for the RenderViewImpl notifying observers that a commit has happened. This callback can simply occur on the WebViewClient API. BUG=1097816 Change-Id: Ic9f5fd946c18498ee87d6a3d5f58b04729b5081b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492887Reviewed-by:
-
Dylan Cutler authored
This is part of a larger cleanup effort of the Chrome cookie codebase with the long term goal of making the CanonicalCookie constructor private. The cookie manager code checks whether the serialized/deserealized cookie is valid, and since this code is a security boundary we think this check is worth keeping with test coverage. In order to do so, we need to remove the DCHECK in that relied on the check we are removing. CanonicalCookie: :FromStorage and include new checks at the callsites Bug: 1102874 Change-Id: I9c9436827d668042ba41229ce8819ef925cb5d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490242Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#820347}
-
David Van Cleve authored
The Trust Token API (https://github.com/wicg/trust-token-api) adds Web Platform support for executing certain cryptographic operations alongside resource requests. We're implementing an expansion, "platform-issued trust tokens," where one of these operations ("issuance") can be executed against OS-mediated providers (e.g. registered by some kind of system service). This CL expands NetworkContextClient's interface to provide a method that can answer Trust Tokens issuance requests locally. This will subsequently be implemented by querying an embedder-provided Mojo remote. This change's child (crrev.com/c/2491300) wires this interface to the network service Trust Tokens implementation. Design doc: bit.ly/platform-provided-trust-tokens Bug: 1130273 Change-Id: Iea07b36cdd3369ca51a667e0f4f0cada05c2aad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433104 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820346}
-
Mitsuru Oshima authored
This reverts commit e0f87dec. Reason for revert: next fuchsia-x64-cast build passed without this revert. https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/97041 Original change's description: > Reland "Introduce gfx::MaskFilterInfo to define a filter based mask on a layer." > > This reverts commit 593a7819. > > Reason for revert: Suspect this of breaking the build https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/97040? > > Original change's description: > > Revert "Introduce gfx::MaskFilterInfo to define a filter based mask on a layer." > > > > This reverts commit 41d30701. > > > > Reason for revert: to investigate crbug.com/1139657. I did run revert and ony saw 0.5~0.9% improvements. I'll revert this first and reland with ctor change. > > > > Original change's description: > > > Introduce gfx::MaskFilterInfo to define a filter based mask on a layer. > > > > > > This is a preparation to add GradientMask[1] support. > > > > > > [1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit# > > > > > > Bug: 1039003 > > > Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#817987} > > > > TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1039003 > > Change-Id: If5c3d49100e0bbb4dcd712b0e158c29536f79d34 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491242 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819954} > > TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,khushalsagar@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1039003 > Change-Id: I135ae3074fb1e4af6bc44b21fb10910e7f09b5b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493221 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819989} TBR=sky@chromium.org,dcheng@chromium.org,oshima@chromium.org,robertocn@chromium.org,khushalsagar@chromium.org Change-Id: I3052d170cfc7551510b1777ffe73ebd4de1c11d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495712Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#820345}
-
Krishna Govind authored
This reverts commit 448e1b37. Reason for revert: Breaks translation, crbug.com/1141934 Original change's description: > WebUI: Add support for producing/consuming grdp files in generate_grd.py > > This will be leveraged in follow up CLs, to auto-generate parts of > webui_resources.grd. > > Bug: 1132403 > Change-Id: I5bd5f8a411c2cbc1f023220a779d74be209e902c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489920 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820148} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Ie0e71ef0d9a7dd8bbe5c0da452692b3e9c3f96db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495518Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#820344}
-
Justin Miron authored
This change records UKM, AdsIntervention_LastIntervention on page loads to origins that have previously triggered ads interventions. This UKM tracks the subresource filter activation status and the ads violation that triggered the intervention. This allows analysis of an ads interventions benefit to a user and their frequency across different sets of sites. BUG=1099741 Change-Id: I653b0468c387727902f95e00c14cba1da9ae6996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419118 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Zentaro Kavanagh authored
- Currently just initializes the result list and disables the button - Follow up will run the tests and reenable the button on completion Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id5c4999e34f843e12bc51f329e32bdb6807a9773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470016 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#820342}
-
kylechar authored
This flag controls a GPU workaround with the same name. Bug: 1138979 Change-Id: I9e900aab600b5652fbc46e4b65d098d27de73cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490991 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820341}
-
