- 29 Nov, 2017 40 commits
-
-
Bill Orr authored
Change-Id: If9e9d590cc59d9af204eb3a3f8bf975173ed00de Reviewed-on: https://chromium-review.googlesource.com/794309Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520179}
-
Xianzhu Wang authored
Previously there were too much repeated output during no-op document lifecycle updates (e.g. when moving mouse in the document). Now log only when the output has changed. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I911be0b3078c923e72131a7091b895449a67bfc5 Reviewed-on: https://chromium-review.googlesource.com/794833Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520178}
-
Robert Sesek authored
Forgetting to test compilation on Android {arm,arm64,x86,x64,mips} has repeatedly caused internal/downstream breakages in the past. This should add a modicum of sanity. Change-Id: Ibc43d4f118c0ccfa532240d00b2f799722df9700 Reviewed-on: https://chromium-review.googlesource.com/797332Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520177}
-
Adrian Elder authored
This API is intended for use by an app to read "WebRTC Logs" files generated for debug purposes on devices within Google. I initially proposed making it purely read-only to prevent contention with the creation and writing to audio debug files; however, the app can restrict itself to acting on files that the aec dump process has finished with (as indicated by getting a callback from startAudioDebugRecordings/stopAudioDebugRecordings). While a low volume of debug recordings would eventually be cleaned up after 5 days and a reboot (per WebRtcLogUtil::DeleteOldWebRtcLogFilesForAllProfiles), the needed frequency and volume of recordings would be more flexible if the app could clean up files it generated. Bug: 775961 Change-Id: I8492b0619ee1c98737f0248190d68a1e3bee5bca Reviewed-on: https://chromium-review.googlesource.com/795671Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Adrian Elder <aelder@chromium.org> Cr-Commit-Position: refs/heads/master@{#520176}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1ff9b7ffa653..7829b7048d5c $ git log 1ff9b7ffa..7829b7048 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 vtsyrklevich [CFI] Enable type generalization for LCMS Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I77d48526f4798f1f6ac785ab2bea642df50a7276 Reviewed-on: https://chromium-review.googlesource.com/796913 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520175}
-
Mircea Trofin authored
Use ScriptState::ForCurrentRealm in static methods, instead of ForRelevantRealm(). Bug: chromium:788453 Change-Id: I63bd25e3f5a4e8d7cbaff945da8df0d71aa65527 Reviewed-on: https://chromium-review.googlesource.com/795096 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#520174}
-
John Z Wu authored
Includes unit test. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie224a70867a1e6113b5d58eeb870b17bc23d7d98 Reviewed-on: https://chromium-review.googlesource.com/794411 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#520173}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/935a35bce4ca..329c5a6d826b $ git log 935a35bce..329c5a6d8 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 jvanverth Bundle resources and skps directories into iOS app. 2017-11-29 rmistry Exclude URLs only for some page sets 2017-11-28 benjaminwagner Temporarily add Ubuntu IntelHD4400 jobs. 2017-11-29 bsalomon Revert "Revert "Make PathGeoBuilder use consistent iterators."" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Iaac049b0fe96a57ae38fdd92dc6ad2269e89b8e2 Reviewed-on: https://chromium-review.googlesource.com/797113Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520172}
-
Xianzhu Wang authored
This is a reland of f01abd36 The original patch failed on Windows bots because there was no "/tmp" directory. This new patch saves the generated layers-overlay.html in the results directory (existence ensured). Original change's description: > Update paint/invalidation/repaint-overlay/layers-overlay.html > > It is generated by a python test case > (TestRepaintOverlay.test_generate_repaint_overlay_html). > I should have updated it when changing repaint_overlay.py. > > Updated the test to fail and print a message if the file needs an > update. > > Bug: 789272 > Change-Id: I2e6ba6573788177dfbc09d2bd4d3d80023d4b21f > Reviewed-on: https://chromium-review.googlesource.com/794875 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519912} TBR=pdr@chromium.org Bug: 789272 Change-Id: I17de00b123520be148bba4aacd923f21d3f18e9c Reviewed-on: https://chromium-review.googlesource.com/797110Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520171}
-
Lei Zhang authored
Split it into version specific upgrade functions. Also fix nits in the unit test and elsewhere in components/drive. Change-Id: Ifda20a32115bcd006addaf0801c09512142fa15c Reviewed-on: https://chromium-review.googlesource.com/786630Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#520170}
-
Sergey Berezin authored
This reverts commit 30ff548c. Reason for revert: A-lab devices still have no internet connectivity, causing them to become "unavailable". Original change's description: > [iOS] Re-enable test 'testNetworkConnection' in device_check_egtest.mm > > Since we are beginning to run external URL test again, and labs now has > wifi. We need to re-enable the wifi checker test for swarming_cron use. > > Bug: 763582 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I261b46c63c63160bfae49590fae9248f5d8ffdab > Reviewed-on: https://chromium-review.googlesource.com/794341 > Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519867} TBR=sergeyberezin@chromium.org,baxley@chromium.org,liaoyuke@chromium.org,huangml@chromium.org,shenghuazhang@chromium.org Change-Id: I13642410635d4abf7cc91d3539d6a06236317370 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 763582 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/797490Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520169}
-
John Z Wu authored
Removing suggestions will remove the underlying autofill data from which it originated. It is possible to remove both autocomplete suggestions as well as profile data for addresses and credit cards. This method will be covered with integration tests in follow up CLs. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I53a273eed33024e42c89b85cd10dd718cea00884 Reviewed-on: https://chromium-review.googlesource.com/792256Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#520168}
-
Caleb Rouleau authored
Bug: 785554 Change-Id: Ia73174808a48a942bcb2d893c60944f94efc6c4c Reviewed-on: https://chromium-review.googlesource.com/784124Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#520167}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b0b1ce2c6e90..c5bfbbc86903 $ git log b0b1ce2c6..c5bfbbc86 --date=short --no-merges --format='%ad %ae %s' 2017-11-29 yfriedman Remove left over references to 'work chrome' Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8dca3d97e50f3d97aa5ec4baf7461bfa59be264a Reviewed-on: https://chromium-review.googlesource.com/796914 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520166}
-
danakj authored
No layers with empty bounds should paint. Because masks were doing so incorrectly they can end up with a RasterSource with empty bounds which hits a DCHECK as it is not expected. R=enne@chromium.org Bug: 787719 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib7fbb6ec8e2339db58339af15aae51186bbe4126 Reviewed-on: https://chromium-review.googlesource.com/794535Reviewed-by:
enne <enne@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#520165}
-
Biao She authored
Bug: 787544 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idee5839a230fbef3df7b681c5c822cca1e4d62c0 Reviewed-on: https://chromium-review.googlesource.com/794770Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#520164}
-
Tommy Steimel authored
Currently, the Window menu shows "Mute Tab", which used to match the tab dropdown's "Mute tab". However, the tab dropdown text has been changed to "Mute site" for site muting, so we want to change the Window menu text to "Mute Site" to match. This should in theory be behind the SoundContentSetting feature flag, but that's not doable in a .xib file. Bug: 788982 Change-Id: If36c57b9fbc536d1eed95e13d23032c38da22499 Reviewed-on: https://chromium-review.googlesource.com/792299Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#520163}
-
about://flagsclamy authored
BrowserSideNavigation has launched on all chromium platforms (except Android WebView), and the old navigation codepath is no longer supported at the Chrome layer. Removing the option to turn off browser-side navigation in regular Chrome. BUG=789577 Change-Id: I6e450f1e33108aa5b5cfe5241a7fd3af188d6394 Reviewed-on: https://chromium-review.googlesource.com/796857Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#520162}
-
Donn Denman authored
A tap that's far from the previous tap should generally be ignored, and just dismiss our UI instead of starting a new tap-handling sequence. This CL updates our logic to look at whether there was any selection before the tap rather than whether the previous tap was suppressed. Our old logic ignored whether there was any selection before the tap, and used whether the previous tap was suppressed as a proxy for no-selection. Recent code changes make it fairly easy to determine if there was a selection just before a tap gesture so we use that instead. The difference becomes clear when "invalid taps" are considered. These are taps on non-text characters, e.g. a period or comma. These taps don't select, but they also are not technically suppressed, so a subsequent tap would be ignored. Now any tap that's far from a previous tap will be ignored only if there was a selection before the tap. BUG=713471 Change-Id: Ie94e345a87cf580a3d1993370938982e6e273e89 Reviewed-on: https://chromium-review.googlesource.com/794020Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#520161}
-
Xianzhu Wang authored
Now always set chunk properties for fragments (including the first fragment). Remove the chunk properties dedicated for the first chunk. Also create chunks whenever chunk id changes to avoid unnecessary full chunk raster invalidation due to the above change. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iaed5999fb5c9dcb85fdf5135e686cd2d491b0dca Reviewed-on: https://chromium-review.googlesource.com/793894 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#520160}
-
Antoine Labour authored
mojo::SharedBufferHandle::Create has the necessary indirection to do the right thing for client process vs browser process, so we can use the ui::Gpu implmentation everywhere, and merge it directly into CommandBufferProxyImpl. This simplifies GpuChannelHostFactory implementations. A follow-up will remove GpuChannelHostFactory altogether since it is trivial now. Bug: 566273 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifad42634246a9036af1c5fe458064b53296f796f Reviewed-on: https://chromium-review.googlesource.com/794348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520159}
-
Marc Treib authored
This should prevent screen readers from reading the image URL, which is useless. And any non-empty caption would be redundant with the thumbnail. Bug: 777167 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0264417bac1378f554573d887d86f43d8bfba65 Reviewed-on: https://chromium-review.googlesource.com/796791Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#520158}
-
danakj authored
R=kylechar@chromium.org Bug: 730660 Change-Id: I20a0ba1b77a394c5e51fd755a0e68dcddd313af0 Reviewed-on: https://chromium-review.googlesource.com/789810 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#520157}
-
marcin authored
Change removes Prone warning: [FloatingPointLiteralPrecision] Floating point literal loses precision float start = 0.36787944117f; // 1/e == exp(-1) ^ (see http://errorprone.info/bugpattern/FloatingPointLiteralPrecision) Did you mean 'float start = 0.36787945f;'? Bug: Change-Id: Ide3f12ff1bbe9698efc7fba72cf5a4ddf812ff6d Reviewed-on: https://chromium-review.googlesource.com/793512Reviewed-by:Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520156}
-
Justin Novosad authored
There was a flickering bug with OffscreenCanvasResourceProvider:: SetTransferableResourceToSharedGPUContext(), probably due to state tracking of the GL texture object. Instead of fixing it, we can just use the nice pre-canned RAII model provided by AcceleratedStaticBitmapImage. This makes the code much simpler and it fixes the glitch. BUG=788439 TBR=xlai@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ifb19e96802c4ed1e41c8a01101066a0d7e3ab22a Reviewed-on: https://chromium-review.googlesource.com/794108Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#520155}
-
Pavel Feldman authored
Change-Id: I56dd006e98e485e6fd686fc12d04544fa99d1975 Reviewed-on: https://chromium-review.googlesource.com/792498Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#520154}
-
David Roger authored
Bug: 789578 Change-Id: I18b4189417a803a21b37bb1ab29f792ad53085d9 Reviewed-on: https://chromium-review.googlesource.com/796858Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520153}
-
Mythri Alle authored
Add --future variants of v8.browse* benchmarks. Adds v8.browsing_desktop-future v8.browsing_mobile-future These are same as v8.browsing_desktop and v8.browsing_mobile benchmarks but run --future configuration of V8. These test the features enabled on --future flag. Bug: chromium:789571 Change-Id: Ib0934ff43753eb9d4d52622f1111ba8ecf289580 Reviewed-on: https://chromium-review.googlesource.com/784871Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#520152}
-
Marc Treib authored
This includes the features UseGoogleLocalNtp, DoodlesOnLocalNtp, and VoiceSearchOnLocalNtp. The latter already had a testing config, which is now merged into this one. Bug: 583289 Change-Id: I00246241281f5365dcaab9f2d7bdc89ea3123e23 Reviewed-on: https://chromium-review.googlesource.com/789835 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#520151}
-
Andrew Grieve authored
Change-Id: Ic989f7f2636120fdfe91e559ca6f5428e20b382e Reviewed-on: https://chromium-review.googlesource.com/792433Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#520150}
-
Bo authored
This reverts commit ea0f96c8. Reason for revert: Causing resource errors in the real webview (not on cq) https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/10729 Original change's description: > Merges process and package resources script > > process_resources.py and package_resources.py are currently both required to > create the final apk. They currently communicate using zipfiles. This ends up > having 3-4 zips/unzips during the final build of the same apk in order to > perform modifications. This merger allows all the required processing to be > done before apk creation with no need for zipping. It also simplifies the > process_resources.py script to separate the code that runs during library > builds vs apk builds. > > Bug: 782316 > Change-Id: I958c1d107d593b0932275d3c4452c2c51c499b55 > Reviewed-on: https://chromium-review.googlesource.com/791152 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519850} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: If0d30f7e57b18ff56bd17c2c918398158fb3dffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782316 Reviewed-on: https://chromium-review.googlesource.com/796717Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520149}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3cc809294788..935a35bce4ca $ git log 3cc809294..935a35bce --date=short --no-merges --format='%ad %ae %s' 2017-11-28 benjaminwagner Remove temporary image Swarming dimension. 2017-11-29 robertphillips Revert "Make PathGeoBuilder use consistent iterators." 2017-11-29 bsalomon Revert "Make PathGeoBuilder use consistent iterators." 2017-11-28 bsalomon Make PathGeoBuilder use consistent iterators. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I5aa9de0fa6139dae7d815a472cd16a44ee6ffd6c Reviewed-on: https://chromium-review.googlesource.com/797070Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520148}
-
Matthew Jones authored
This reverts commit 70baccad. Reason for revert: Missing import causes compile failure. Original change's description: > Disabled flaky testCallCanMakePayment() > > In PaymentRequestServiceWorkerPaymentAppTest.java. > It's flaky, see bug. > > TBR=rouslan@chromium.org,mathp@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789532 > Change-Id: I62d087abd95c37fd32fdef123c2d4bf847d2e4ac > Reviewed-on: https://chromium-review.googlesource.com/796417 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520097} TBR=rouslan@chromium.org,mathp@chromium.org,hbos@chromium.org,gogerald@chromium.org Change-Id: I496a3e9099f1a89a2356b035f9fc24873f963295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789532 Reviewed-on: https://chromium-review.googlesource.com/797170Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520147}
-
Xiangjun Zhang authored
This CL added the control logic to stop/disable Media Remoting when user indicates always do traditional mirroring through the MR dialog. Bug: 788855 Change-Id: I16a81b25af3815bc89e5480db775f745a86153a3 Reviewed-on: https://chromium-review.googlesource.com/791631Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#520146}
-
Mihai Sardarescu authored
This CL also enables the feature to remove the programmatic auth endpoint from Chrome. The plan is to continue to use the finch experiment as a kill switch in case we discover any issues with the server-side signin pages. For more info, please relate to https://bugs.chromium.org/p/chromium/issues/detail?id=780808#c20 Bug: 780808 Change-Id: I786b21fcbb041fb9266e5fdfe8a42e98f3942e7f Reviewed-on: https://chromium-review.googlesource.com/793690 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#520145}
-
Eric Lawrence authored
The comment suggested that "must-revalidate" might be a reason not to reuse a response. This is misleading because must-revalidate is a poorly named directive which simply means that the cache freshness lifetime should not be ignored. It does not forbid caching or require revalidation of resources within their freshness lifetime. Change-Id: Ib8e9f9c9f588fb018fc256445dc1f88bd2961a9c Reviewed-on: https://chromium-review.googlesource.com/794049Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#520144}
-
Tobias Sargeant authored
Change-Id: Ib41d0b741d76a2dc5dfc70f2369263e16980974b Reviewed-on: https://chromium-review.googlesource.com/796410Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#520143}
-
Xiaocheng Hu authored
This patch refactors ComputeInlineBoxPosition() by breaking it into: - ComputeInlineAdjustedPosition for adjusting a position into text or atomic inline anchored - ComputeInlineBoxPositionForInlineAdjustedPosition, which takes a position returned by the previous function and computes an InlineBoxPosition from it This is the first patch to convert callers of ComputeInlineBoxPosition into NG versions. The full plan is at: https://goo.gl/6WtiUm Bug: 771398 Change-Id: Ifb324939e940afb3f2afa490af4b9c5ae5bd1731 Reviewed-on: https://chromium-review.googlesource.com/786784 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#520142}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/f13cadd8bd5f..54a29ffd82e7 $ git log f13cadd8b..54a29ffd8 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 oetuaho Refactor TSymbol to follow naming conventions 2017-11-27 oetuaho Fix scalarizing vec and mat constructor args Created with: roll-dep src/third_party/angle BUG=772653 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I06e2ac5b82354070505d5314e67eef11790a37ff Reviewed-on: https://chromium-review.googlesource.com/796714Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#520141}
-
Bence Béky authored
Do not send HTTP/2 PING if there is a CheckPingStatus() posted on the message loop, because it might get confused about which PING to expect a response to. Imagine the following scenario: * SpdySession sends out a preface PING then a request. * A CheckPingStatus() is posted on the message loop with delay. * SpdySession receives PING ACK right away. * Later, SpdySession sends out another preface PING then another request. * CheckPingStatus() gets executed shortly after. |last_activity_time_| is when the first ACK was received. CheckPingStatus() sees that there is an outstanding PING, and thinks that it timed out (even though it was just sent), so it tears down the connection. One could make the argument that this is impossible with the current values of kDefaultConnectionAtRiskOfLossSeconds and kHungIntervalSeconds (or at least very unlikely, depending on how much one trusts PostDelayedTask() timing), but that is not very transparent. This CL introduces two functional changes. The first one is that it returns early from SendPrefacePingIfNoneInFlight() (freshly renamed to MaybeSendPrefacePing) if |check_ping_status_pending_|. There is little harm in not sending another preface PING within kHungIntervalSeconds (10 seconds) since the last preface PING was sent. The other functional change is only increment PING opaque data by one with each PING frame. "Receivers of a PING frame that does not include an ACK flag MUST send a PING frame with the ACK flag set in response, with an identical payload." according to RFC7540 Section 6.7, so this is acceptable. This CL also does some cleanup: rename SendPrefacePingIfNoneInFlight() to MaybeSendPrefacePing(), shuffle around some base::Time and base::TimeDelta in inequalities for easier readability, improve comments, inline SendPrefacePing(), and sharpen some expectations in unit tests. Bug: 784975 Change-Id: Ic278ea87041120443fc73304d266b2f7a4eb54a2 Reviewed-on: https://chromium-review.googlesource.com/779670Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#520140}
-