- 18 Jun, 2020 40 commits
-
-
Colin Blundell authored
For the translate infobar WebLayer needs a couple Material Design resources. Allow these as an exception to the exclusion of material design resources in system_webview_apk_tmpl.gni, as without this allowance TriChrome (and presumably standalone WebView)-powered WebLayer crash when showing the translate infobar. I didn't detect this when landing the initial CL enabling translate in WebLayer because the default weblayer_shell build doesn't do this exclusion. Needed resources are the ones referenced here: third_party/android_deps/libs/com_android_support_design/com_android_support_design.info: "res/layout/design_layout_tab_icon.xml", third_party/android_deps/libs/com_android_support_design/com_android_support_design.info: "res/layout/design_layout_tab_text.xml", Bug: 1025620 Change-Id: I63543aaa17b45829897cee999d372aecc156d750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250109Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#779819}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8514078e455e..55ac3e87d96a 2020-06-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17c42dc78ce2f586c44f7fd5ee2ba4c96a4b7280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779818}
-
Side Yilmaz authored
This CL changes ImageFetcherBridge behaviour for different profiles. Today, ImageFectherBridge is singleton, so there is only one instance created for one regular and multiple incognito profiles on Android. To avoid data leak between profiles, we need to create different instances for each profile. By this CL; - Each call to |ImageFectherBridge#getForProfile| function creates an instance of ImageFectherBridge that stores profile as member variable. - Each call to any other function of ImageFectherBridge will directly hit the native services through native bridge. - Native image_fetcher_bridge is a wrapper to reach the service that belongs to the given profile. There is no member functions anymore, but all are static. Bug: 1075562, 1041781, 1083923 Change-Id: Ic96d1c8fa1a7bd093abcf8939375f8934fd3cd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231124 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#779817}
-
Raymond Toy authored
This is the Arm/Neon equivalent of the x86/simd version of the main k-rate processing loop. The Web Audio Bench (100 runs of 10 sec) shows that we have about a 33% improvement in speed (on a Pixel 2). The difference is statistically significant. Without CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1778 1778 1888 2013 2498 3363 2225.6 437.41 Oscillator 1388 1388 1597 2104 2427 5244 2079.37 581.86 With CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1757 1757 1863 1955 2378 3280 2164.5 424.23 Oscillator 897 897 1001 1224 1764 4068 1399.1 515.9 Manually ran the tests in webaudio/Oscillator and all tests pass. Bug: 1013118 Change-Id: I738dfc9e9f108ac6a421099c69f11aab7750605f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233003 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779816}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/e9d517989f66..e6613e91b26e $ git log e9d517989..e6613e91b --date=short --no-merges --format='%ad %ae %s' 2020-06-16 junyer Distinguish between missing ')' and unexpected ')'. 2020-06-16 junyer Make RE2::Set and FilteredRE2 movable. 2020-06-15 junyer Herp derp. It's actually constant-time append. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org CC=mmoroz@chromium.org Change-Id: Idda604a248dd85373905c069aa0db96b9a6c396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250476 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779815}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a84ab4815027..581c407cd20b 2020-06-18 cwallez@chromium.org Fix TypedInteger hash compilation failure with stdlibc++ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I34be8a79c857ec2b08a1b54b373c624e27870132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252018Reviewed-by:
-
Maria Kazinova authored
FormJsTests. This is a small fix to stop tests from hanging forever in case something goes wrong. Change-Id: I334d85e97b0f290ecf011a0b8ef40e1300275aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238156Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#779813}
-
Mikel Astiz authored
No behavioral changes. This patch removes some dead code and in particular the notion of sync IDs from APIs used by models (specific features integrating with sync via SyncableService), as well as obsolete concepts and APIs in SyncChangeProcessor. Change-Id: I2a4654cb295ae070ea3e91cd3bde345cb75ba497 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249931 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779812}
-
Alex Ilin authored
Some new strings are not referenced in code yet, but we'd like to upload the final strings ASAP. Bug: 1045515 Change-Id: I6f7a831f4066d27170c80bd600d86392b20f74c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241526 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
This CL should make the test run consistently and always finish; we break out early from the test that was failing rather than waiting forever. Bug: chromium:869126 Change-Id: Ic52fbf0dea69a03645165a073354f61a3d28ad81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250065 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779810}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: If3ebac4df104b607d3fd68588263f4ea19a63edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237501 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779809}
-
Alice Wang authored
This CL removes the redundant teardown in ShareButtonControllerTest, as the ChromeTabbedActivity is ensured to be destroyed in ChromeTabbedActivityTestRule. Bug: 1083138 Change-Id: Ic33e5b1d08804525d737bab44fe5fdbd4573a470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245625Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#779808}
-
Vikas Soni authored
1. Refactor SharedImageBackingFactoryAHB to pull out GenGLTexture() method into ahardwarebuffer_utils* so that it can be re-used by multiple classes. This will eliminate code duplications in future. 2. Make few private members of gles2::Texture as public since those members were used by too many friend classes. Bug: 1091945 Change-Id: I0e82cd93d431d900fce2787478a97bef19b11eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249582 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#779807}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53f973c22a26..81454dfaa92a 2020-06-18 bsalomon@google.com Use hardware wrap mode in perlin noise effects. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I5b8fa92fd1a162b6815daa94db6ccfd26b4b31d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251733Reviewed-by:
-
Marc Treib authored
If EnablePasswordsAccountStorage is enabled, then SaveUpdateBubbleController is not used at all - SaveUpdateWithAccountStoreBubbleController is used instead. This CL adds DCHECKs in both classes about the feature state, and explicitly enables/disables the feature in their unit tests. Bug: 1093310 Change-Id: I7d0d960725053e3371d3a0c81d4f1ce8aa9d22b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249933 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#779805}
-
Colin Blundell authored
I brought in these resources in the initial fork of infobars (https://chromium-review.googlesource.com/c/chromium/src/+/2224869), before I realized that Android resources effectively reside in a global namespace and thus any resources with the same IDs between //weblayer and //chrome will collide in Monochrome. Hence, the //weblayer resources either need to be renamed or shared. As we now already have infobar resources in //components and these resources are unlikely to be changed by WebLayer, it is cleaner to just componentize and share them than rename them. Bug: 1093846 Change-Id: I1f90394109be509488f036ac9ac4a966b2ccccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250198Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#779804}
-
Robert Sesek authored
It was previously disabled and is now unused. Bug: 925998 Change-Id: I504065c37a4436369021f8f20928f3f071b0f143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250579Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779803}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: Ib5be18e72766eac66f627569186a2803f5db4cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249840 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779802}
-
Maxim Kolosovskiy authored
This reverts commit c3de1340. Reason for revert: IconLoaderBrowserTest.LoadGroup failures. Builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests First failed build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24355?blamelist=1#blamelist-tab Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1987273 TBR=avi@chromium.org,robliao@chromium.org,wfh@chromium.org Change-Id: I90479f28ef4849c382b28cfdbd40db4b84ad3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250202Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I18629d5a41bfdb7e691592c73e9ddb6cc57b88fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251740Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779800}
-
sauski authored
CL changes incorrect usage of IsUserControlled to IsUserModifiable for checking whether a preference could be changed by the user. Also updates test cases that set the user preference to establish a known test state, to instead set default preferences. Bug: 1096471 Change-Id: I5d7fb02e438331e92d91d9d50b36b69250468667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250185Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#779799}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592459911-64171aa0ec184a29370607ccffd98ff29f1f78e8.profdata to chrome-mac-master-1592481559-9b531f50abff54ae1c92c78422a2cf2d21554f30.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I775e55aaa8a2abf22bb9ea4247359c6594768a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251734Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL adds a histogram to record the number of account passwords that are unsynced by the time the user signs out. We also use the occasion to update the term "passwords account storage" to "account-scoped password storage" in the description of another b4p histogram, and also replace @chromium with @google in the owners emails. Bug: 1063852 Change-Id: Ide376f40664112ada7ee62a404e019d53a2833bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251826 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779797}
-
Nigel Tao authored
Prior to this commit, the code looked like: etc.Deserialize(&error_code, etc); ASSERT_EQ(foo, error_code); which could be misinterpreted as testing that a side-effect of calling Deserialize was setting error_code to foo. In fact, error_code was set to foo before the Deserialize call, and what was actually being tested was that Deserialize has no effect on error_code when there's no error. That should be clearer after this commit. Bug: 1069271 Change-Id: I20045c24c098f792a87622762d58fb085f6fbaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248395Reviewed-by:Robert Sesek <rsesek@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779796}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1b2c5e463ebe..8514078e455e 2020-06-18 mathias@chromium.org Avoid pathlib dependency in CSS lint script 2020-06-18 sigurds@chromium.org Remember frameId for DevTools-initiated loads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I51123517fd0b16e19319b998b256ebc5c28682ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251732Reviewed-by:
-
Clemens Arbesser authored
Before this CL, it was possible that an action ended before it was initialized. In particular, this could happen if view inflation failed. This is problematic, because any calls immediately after SetGenericUi assumed that the action still existed. With this CL, most of the action is only initialized after a successful view inflation. This CL also includes a small change to how EndAction works. Before, the action was allowed to send data to backend, as long as view inflation succeeded. Now, this is only possible if EndAction is called with an ok() status. Bug: b/145043394 Change-Id: I8d7dc3d143d37ca4220b9d8f9c40a02964609d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249766Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#779794}
-
Darren Shen authored
The shared library is no longer needed after: https://crrev.com/c/2206855 Bug: 1019541 Change-Id: Ia57e89c5e8fe2e1b05e040c05438daea91aa00e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224478 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#779793}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592467151-bf53acbeb3a2f5db843a60a3b97cc31d9344243a.profdata to chrome-win32-master-1592470587-41d382284b84615cf61150faa274f216b9eaf19d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5ae02119f090dda4aeb389143e88436a77d9b699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251730Reviewed-by:
-
Jazz Xu authored
Bug: 1093968 Change-Id: I4a9d9de174a3a48713f7333c45e2aee3c7f8f07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240896 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#779791}
-
Eleonora Rocchi authored
This CL adds the Check passwords preference button in the Passwords settings menu, the button will be only shown if the corresponding feature flag is enabled. It adds tests to check whether the button is correctly shown. Bug:1092444 Change-Id: I35221b8f4af66f3a4e3a3b5fbbbef42650c7324f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246590 Commit-Queue: Eleonora Rocchi <erocchi@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779790}
-
Rohit Rao authored
BUG=1096151 Change-Id: I2ad7e76edfdf8a0cf42baf04e45aa6a95bebc315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250498Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779789}
-
Rohit Rao authored
BUG=1096117 Change-Id: I8f02f2c9a5f3da8c3e4560d33a2f04287abd901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248730Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779788}
-
Jochen Eisinger authored
Don't assume that time doesn't proceed between two calls to updateNewUrlLoading. Bug: 1096237 Change-Id: Id6e4089b94f6c4dd3c89d321430faf54fc6c9272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250041Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779787}
-
François Beaufort authored
This CL makes sure we're testing the value of pan_tilt_zoom_supported() when checking VideoCaptureDeviceDescriptors on macOS. Bug: 1095718 Change-Id: I5d3502b571735dd5f1f305f9face2217235944aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247728 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#779786}
-
Philipp Hancke authored
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in https://github.com/fippo/simulcast-playground/pull/7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785}
-
Michele Mancina authored
[Autofill Assistant] Create label for profile if null, this only happens for those profiles that are created within the CollectUserData action. Bug: b/158464101 Change-Id: Ia5df15a8d5244d981f42ad08588710d30b5e9067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246155 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592452187-d8b5060216a94a83da3c0624280c3c37a480cfb4.profdata to chrome-win64-master-1592474334-e0477f022b6eb5a61c43375c0dcd8da0fde9e8a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I35cb025a19b74cef6be6ae72b75760a7edac91db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251728Reviewed-by:
-
Nektarios Paisios authored
This enhances readability when debugging. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I4e0bcf1ccb7ded6b0204b9c06b9965bde76b05f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249934Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#779782}
-
Oriol Brufau authored
Some functions check whether a LayoutObject is anonymous, and then they exclude it if it's a list marker. However, since r745012, list markers can never be anonymous, they are always generated by a ::marker pseudo- element. Therefore, the condition is useless and can be removed. BUG=457718 Change-Id: I5e2636f68fab483838e8a5227ccace34b6de22cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250102Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#779781}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d02a81b1877..1b2c5e463ebe 2020-06-18 mathias@chromium.org Enable stylelint on presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie70ebeab1963f01641a31af0c6b2ef0a436d89d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251727Reviewed-by:
-
