- 28 Sep, 2018 40 commits
-
-
Kinuko Yasuda authored
Bug: 884220 Change-Id: I02ab44bb09d69a75bfdc5336fb1250a7b574c758 Reviewed-on: https://chromium-review.googlesource.com/1250501Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595009}
-
Kent Tamura authored
"The Great Blink mv" renamed CamelCase file names to snake_case, but it didn't update comments. This CL fixes it in core/{dom,editing,html}. Such comments were found by |git grep "//.*\\b[A-Z][a-zA-Z]*\\.[a-z]"| This CL has no behavior changes. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7a71e9252625fd80338a2739c139f9eaf82f6322 Reviewed-on: https://chromium-review.googlesource.com/1250322 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595008}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45984b703fb3..466fcd2bc4b3 Created with: gclient setdep -r src-internal@466fcd2bc4b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I559106edb89775922e322983a8950a6beacb9bdc Reviewed-on: https://chromium-review.googlesource.com/1250117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595007}
-
Yuki Yamada authored
This CL adds blink::Event::IsErrorEvent() and also defines the type cast ToErrorEvent() as blink::BeforeUnloadEvent does. These will be used in following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1215512 Bug: 872138 Change-Id: Iaa2f6a1eb54dc8f4baecaeac44dc4cf48c6d8f04 Reviewed-on: https://chromium-review.googlesource.com/1250502Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#595006}
-
BUG=762641 TBR=minch@google.com Change-Id: If91d77ac45a938440f5fe90843bf405017ad106e Reviewed-on: https://chromium-review.googlesource.com/1249739Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595005}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e8dd07969872..c0b82333ab27 git log e8dd07969872..c0b82333ab27 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 jgilbert@mozilla.com Polyfill BitCount for ARM/ARM64 on MSVC. Created with: gclient setdep -r src/third_party/angle@c0b82333ab27 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I3553bab8ded47484da804e803954e085ead62c10 Reviewed-on: https://chromium-review.googlesource.com/1250112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595004}
-
Leo Zhang authored
FATAL:binding_state.cc(90)] Check failed: !is_bound(). Attempting to bind interface that is already bound: chromeos.ime.mojom.InputChannel ::TestClientChannel::CreateInterfacePtrAndBind() Bug: 859432 Change-Id: I7b2ac928afe97b8adb1a1f89348a904d47be851b Reviewed-on: https://chromium-review.googlesource.com/1250564Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595003}
-
Tsuyoshi Horo authored
Before this patch: The SXG accept header is sent to all origins when SignedHTTPExchange feature or SignedHTTPExchangeOriginTrial feature is enabled. After this patch: The SXG accept header is sent when - SignedHTTPExchange feature is enabled. or - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader feature are enabled and the origin of the URL is in the OriginList of SignedHTTPExchangeAcceptHeader field trial. Bug: 887201 Change-Id: Ic67a8bc0644b1b6172030ff75162c04663dd33f0 Reviewed-on: https://chromium-review.googlesource.com/1242768Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595002}
-
Jennifer Apacible authored
More organisational work. Change-Id: If77efd0bd31b0355069fa633538548152d92f3d0 Reviewed-on: https://chromium-review.googlesource.com/1250084Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#595001}
-
John Z Wu authored
Bug: 886956 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ida9f92b1bea9093d6a46b5d9eeb4ee7da4306141 Reviewed-on: https://chromium-review.googlesource.com/1249919 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#595000}
-
Yoshifumi Inoue authored
This patch makes line dirty marking faster introduced by the patch[1] as below[2]: - layout/attach-inlines.html +19.6% - layout/line-layout-repeat-append.html +1.5% - paint/appending-text.html 932.06ms to 152.46ms (on local machine) For "layout/line-layout-repeat-append.html" and "paint/appending-text.html", |MarkLineBoxesDirtyFor()| for no longer source of slowness and isn't appeared in profiling resulting. This patch does two things: 1. Change |LayoutText::RemoveAndDestroyTextBoxes()| makes number of calls of DirtyLinesFromChangedChild() as same as both legacyn and LayoutNG. 2. Change |NGPaintFragment::MarkLineBoxesDirtyFor()| not to scan next siblings. [1] http://crrev.com/c/1235267 Introduce line dirtiness to NGPaintFragment [2] https://pinpoint-dot-chromeperf.appspot.com/job/144d34a7640000 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I95262ba6f4b525e7e452ab866cfff5b78ba3a757 Reviewed-on: https://chromium-review.googlesource.com/1248622Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594999}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a82c66710062..45984b703fb3 Created with: gclient setdep -r src-internal@45984b703fb3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I629fb43b01bd5730e2c4d6bf00fae2bb6635094d Reviewed-on: https://chromium-review.googlesource.com/1250116Reviewed-by:
-
Koji Ishii authored
These tests fail because of stale or no-longer-necessary flag-specific expectations. Updated or removed by reviewing the recent test results. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I83fb87ec7820c9e99342f37aeabc292e711f61f2 Reviewed-on: https://chromium-review.googlesource.com/1250384 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Koji Ishii authored
popup-allowed-from-gesture-initiated-event was changed to testharness.js. LayoutNG had flag-specific expected.txt due to different space collapsing in text dump. This patch removes the stale expected.txt. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id6b262611153d3cc0ad44a6454c3d7ede44d7d48 Reviewed-on: https://chromium-review.googlesource.com/1249472 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Koji Ishii authored
These failures are due to recent changes in its base expectations, but LayoutNG flag-specific rebaselines were still old. Re-reviewed the differences from the new base, they are only inline positioning differences. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7261b7a2a380acb46da3832c780c2d5dbe7e61a7 Reviewed-on: https://chromium-review.googlesource.com/1249470 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 3e67df64. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 594943 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlNjdkZjY0YmJmOTFkOGE3YjYxZDliZGYwYjBmMWVkZTNmMDViZmEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8744 Sample Failed Step: chromeos_unittests Original change's description: > Install Messages PWA when host is set or verified. > > This change moves the logic for installing the Android Messages PWA into > a helper class which is a HostStatusProvider::Observer. This allows it > to install the PWA when a host is set and also when signing into a new > Chromebook if the account already has a valid host. > > Bug: 887775 > Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b > Reviewed-on: https://chromium-review.googlesource.com/1248130 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594943} Change-Id: I7c249598402a82eaa23aca2e8c06acb429d9097c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887775 Reviewed-on: https://chromium-review.googlesource.com/1249737 Cr-Commit-Position: refs/heads/master@{#594994}
-
Hayato Ito authored
It looks we forgot to move these at https://crrev.com/c/640275. Bug: 738794 Change-Id: I0cd4cf3f90068619a8899dddcf4dd1d5fc871378 Reviewed-on: https://chromium-review.googlesource.com/1250385Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#594993}
-
John Z Wu authored
- Placed behind sync flag. - Hooked up signinclient and tokenprovider to use CWVSyncController. - Don't persist signin state between cold launches. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Icf49e985aadec33b690552ff9973aadb4a5d1dba Reviewed-on: https://chromium-review.googlesource.com/1211976 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
Removes the FilteredSender abstraction that was created specifically for tests, and replaces it with a simpler method to initialize GpuChannel for tests. Should make it simpler to change IPC channel initialization for associating image decode accelerator mojo interface. Bug: 868400 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifc57407fe8fac36daa0ace155c88cd54c04b39b4 Reviewed-on: https://chromium-review.googlesource.com/1250139Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#594991}
-
Xu Xing authored
Also move more GLRenderer API from protected into private. BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I56a923febc502ab68cda4680d6f006f2f6ebd121 Reviewed-on: https://chromium-review.googlesource.com/1235341 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594990}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5315071e31be..a82c66710062 Created with: gclient setdep -r src-internal@a82c66710062 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id04ecffe20de19ca9c5a228ffe66a0e9cb1ec13b Reviewed-on: https://chromium-review.googlesource.com/1250115Reviewed-by:
-
Morten Stenshorne authored
The special code was already in place and working, but with this CL it will be skipped for fragments with block children. This eliminates the need for checking whether an object is inline-level in AssociateWithLayoutObject() (and bailing if it's not). Just DHCECK that it's the case instead. Multicol was the only known case where this could happen, but once we support NG painting of fragments with block children, this will happen a lot. This is a preparatory patch for NG fieldset painting. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac13f27c51993dc5f3c211941d11a282201469bf Reviewed-on: https://chromium-review.googlesource.com/1249273Reviewed-by:
-
Christopher Cameron authored
Add to chrome::mojom::AppShim a CreateContentNSViewBridgeFactory method. This will instantiate a content::NSViewBridgeFactoryImpl. The caller of this method (AppShimHost, in the browser), creates a content::NSViewBridgeFactoryHost to manage this interface. This may be used (e.g, by content::RenderWidgetHostViewMac:: MigrateNSViewBridge), to create NSViews in an app shim process. Add content/browser as a dependency of app_shim. R=dominickn TBR=avi Bug: 821651 Change-Id: Ice2b46f2d75a9725f5e8e8ad7d2c05e3d70b18eb Reviewed-on: https://chromium-review.googlesource.com/1240154 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#594987}
-
Yutaka Hirano authored
As we now have CORS-cross-origin, we don't need to rely on kNotSharableCrossOrigin for scripts coming from network. This CL completely removes kNotSharableCrossOrigin by migrating occurences to either kSharableCrossOrigin or kOpaqueResource. Bug: 875153 Change-Id: I12d12e9d67ca3329fe8b5e1dd7b74798f4817729 Reviewed-on: https://chromium-review.googlesource.com/1179509 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#594986}
-
Hayato Ito authored
There members are no longer necessary after Incremental Shadow DOM is shipped. Bug: 887827 Change-Id: Ic1e389f248de401f367d031f5ae13242e1fe6dca Reviewed-on: https://chromium-review.googlesource.com/1249474Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#594985}
-
Hiroki Nakagawa authored
This flag is no longer necessary because updateViaCache was enabled by default in M68: https://www.chromestatus.com/feature/6059838387781632 Bug: 675540 Change-Id: I03c5e00b83b150f83edd7022dd38d1fa657d324f TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1249471 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#594984}
-
Aleks Totic authored
This is not the kind of fix I like, that gets to the core of the problem and fixes it for good. BUG ANALYSIS: The bug was that the floats were not being painted. Floats were supposed to be painted by NG container. They were not being painted because layer did not paint with PaintPhase::kFloat. PaintLayer did not paint with kFloat because it did not have needs_paint_phase_float_ flag set. The flag was not set because float's ContainingBlock().ContainsFloats() returned false. ContainsFloats() returned false because none of the floats it knew about had ShouldPaint() == true. ShouldPaint() was false because in first part of the test float was self-painting. In 2nd part of the test, float becomes not self-painting, and should have its flag reset. This does not happen in NG, because LayoutBlockFlow::InsertFloatingObject never resets the flag because flags do not get set if floating object is already there. How does the flag get reset in Legacy? In Legacy, all floats get cleared on Layout, so when float is added again, the flag gets set correctly. Removing all floats in NG on layout would be the "correct" fix, matching existing behavior. But, this cannot be done easily. Float descendants from cached fragments do not get added back on relayout. Adding descendants from cached fragments would be a big fix, we'd need to keep a list in cache. We can talk about whether we want to do this. I can imagine there are other not-tested float scenarios, that fail even with this patch. But since I am not a float expert, I can't come up with any. Long term, the need for legacy float list will go away. I'd hold off on complicated fix until we encounter real-world problems. THE FIX: Instead of resetting flag by removing the float, NG resets the flag after insertion. Bug: 864398 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib09b59669644ebe574a6e41cb1ef6426598296c5 Reviewed-on: https://chromium-review.googlesource.com/1249839Reviewed-by:
-
Koji Ishii authored
TBR=mstensho@chromium.org NOTRY=true Bug: 890135 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic9cdb318551df65d26a7d4c52749f48278fd7b33 Reviewed-on: https://chromium-review.googlesource.com/1250462 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Malay Keshav authored
Adds the skottie animation class that is a wrapper around the Skia's implementation of lottie player. The class manages its own timeline with the help of a timer object. This is the phase 1 implementation of native skottie which rasterizes the animation on the UI thread. Subsequent changes will move this rasterization to worker threads(phase 2) and then to GPU (phase 3). Adds unittests as well. Design Doc: go/cros-skottie Bug: 867147 Change-Id: I2501710a38874f247ab3ab56a743675e3d07edfb Component: gfx, skottie, vector animation Reviewed-on: https://chromium-review.googlesource.com/1189056 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#594981}
-
Charles Zhao authored
This will allow us to try different weights from finch. Bug: 871674 Change-Id: I20412f7a0d15fab4c2f1fc45aba4e817b472ea0b Reviewed-on: https://chromium-review.googlesource.com/1248404 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594980}
-
Kent Tamura authored
The Great Blink Rename renamed all data members named in m_fooBar format, but it didn't update comments. This CL corrects m_fooBar in comments, found by code search query [1]. This CL also updates other errors in comments around m_foo. This CL has only comment changes. No behavior changes at all. [1] https://cs.chromium.org/search/?q=//.*%5Cbm_%5Ba-z%5D+file:blink/renderer/core/(dom%7Cediting%7Chtml)&sq=package:chromium&type=cs Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9494ad83ebdb04d79fe1480890cb27fc17d7559a Reviewed-on: https://chromium-review.googlesource.com/1248881 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
TBR: hubbe@chromium.org Bug: 890124 Change-Id: Ic8e40e59883f43fcee5ad263ac6f551ecd2e59c0 Reviewed-on: https://chromium-review.googlesource.com/1250343 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594978}
-
Noel Gordon authored
The zip archiver NaCl module is lazily loaded crrev.com/594919. Remove the browser_test special case handling added to control when that NaCl loaded (only for zip tests); lazy loading should do that for us. Bug: 889703 Change-Id: I726f32849a6278765a4932a405328faff78bd594 Reviewed-on: https://chromium-review.googlesource.com/1250341Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#594977}
-
Hayato Ito authored
Use AssignedNodes() directly. The abstraction here is no longer necessary since we removed IncrementalShadowDOM flag. Bug: 887827 Change-Id: Id5c7e4139ad89ce2ade6efd62bdfc1cbb50c0340 Reviewed-on: https://chromium-review.googlesource.com/1249467Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/10f3ee914d20..8241a7599974 git log 10f3ee914d20..8241a7599974 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 dgarrett@google.com Create a "buildspec" builder. 2018-09-28 yunlian@google.com cros_chrome_sdk: add options to enable thinlto and cfi 2018-09-28 dgarrett@google.com CIDB: Add index for build_config, branch, id. 2018-09-28 bpastene@chromium.org cros_vm: Add an option to create and boot from a temporary qcow2 image. Created with: gclient setdep -r src/third_party/chromite@8241a7599974 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If9e075185d7baf16d23594f897c9ca137d156bf8 Reviewed-on: https://chromium-review.googlesource.com/1250114Reviewed-by:
-
rbpotter authored
Put radio buttons in a paper-radio-group. Also ensure that behavior stays the same. Specific behaviors that were tested: (1) Selecting "custom" radio button when "all" radio button was previously selected should automatically focus the custom input. However, focusing it if it was already selected does not have this effect. (2) Shifting focus from an empty custom input field, or from the "custom" radio button while it is selected and the input is empty, automatically reselects the "all" radio button, unless the focus is shifting to the custom radio button or input. (3) left/right arrow keys in the custom input move through the user's entered text and do not change to the "All" radio button. (4) Keep feature of radio group that the radio-button that is not selected is not in the tab order. However, if custom is selected, the custom input should be in the tab order as well as the custom radio button. (5) Behavior for which bug was filed - i.e. up/down arrow keys should work to change between the radio buttons. Bug: 884645 Change-Id: I88bb990db3a3c760892c65e704ac6ca877a15d96 Reviewed-on: https://chromium-review.googlesource.com/1248129 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594974}
-
Rakina Zata Amni authored
This reverts commit 5dea8c2f. Reason for revert: Causes TabCaptureApiPixelTest.OffscreenTabEvilTests is flaky Original change's description: > Don't update the surface range at every activation > > Updating the fallback lowerbound is not necessary anymore and will just > waste time by causing an unnecessary commit and draw. > > Bug: 870456 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Icd553c179c5a2eb98c1608524d9c1caf42a27835 > Reviewed-on: https://chromium-review.googlesource.com/1226366 > Commit-Queue: Saman Sami <samans@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594380} TBR=fsamuel@chromium.org,khushalsagar@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870456, 890084 Change-Id: Ia3cb2aa4b405f9e9f9c2a282ae0ec7fdc62e8682 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1249284 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
These changes are necessary to eventually integrate the zip archivers unit tests. Changes include: - virtual -> override - Un-inlining overridden functions - Correcting types BUG=889703 Change-Id: I83030c6b77dda026c4a3fee50df2ecbcedb898f6 Reviewed-on: https://chromium-review.googlesource.com/1250281Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594972}
-
Anand K. Mistry authored
There's no reason to keep this flag, zip creation should always be enabled. BUG=None Change-Id: Id88aeeff60bf220f4a0457a807e7a321a1cc1f85 Reviewed-on: https://chromium-review.googlesource.com/1242644Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#594971}
-
Shakti Sahu authored
Bug: 881499 Change-Id: Icbf4bdeabbe59f60ff4ca971fd7db868c13e9426 Reviewed-on: https://chromium-review.googlesource.com/1250138Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594970}
-
