GitLab

This results in significant overlap with the existing
SafeBrowsingExtendedReportingOptInAllowed policy, which is being deprecated here.

We continue to support SBEROptInAllowed as a legacy preference until it the
associated policy is deprecated, but we also need the pref for WebView.

Bug: 798808
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0d0f32dff4575196a0d6b3e7120c3a76ff165751
Reviewed-on: https://chromium-review.googlesource.com/888859
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540273}

Adding a UKM metric to track whether a page was specifically requested
via voice search.

Bug: 808584
Change-Id: Id20c93ccf3c193e9559a2fbf5bcb87987e08fc1e
Reviewed-on: https://chromium-review.googlesource.com/940605Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540272}

The mesa packages were originally added because of an issue with installing
libgbm-dev on Saucy.  The CL description is inlined below:

------------------------------------------------------------------------
commit: 419a9a64
Author: primiano@chromium.org <primiano@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 19 18:26:18 2014 +0000

Fix installation of libgbm-dev package in install-build-deps.sh

crrev.com/106633002 has recently introduced a dependency on libgbm-dev.
Unfortunatelly, this package is a bit more trickier to install, for the
following reason: it depends on mesa-glx and, conversely to most of the
other packages, only one version of mesa (w.r.t backports) can exist in
the system. Google's workstations are configured to use the -lts-saucy
version of mesa. The right package in this case is libgbm-dev-lts-saucy
and attempting to install just libgbm-dev ends up in a failure.
This change fixes install-build-deps.sh, installing the matching version
of libgbm-dev (w.r.t libgl1-mesa-glx), falling back to libgbm-dev.
------------------------------------------------------------------------

Currently, this is causing issues on Googler's machines (see chrome-linux
mailing list).  Since the Saucy days are over, just depend on libgbm-dev
directly.  Tested on Ubuntu Trusty, Ubuntu Xenial, Debian Stretch, and Debian
Testing.

R=dpranke

Change-Id: I43568ab8b8c66c2aa6cd394c67f2cf90d6d1762c
Reviewed-on: https://chromium-review.googlesource.com/944047Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540271}

Collect Event.VizHitTest.AggregateTime, Event.VizHitTest.HitTestRegions,
Event.VizHitTest.TargetTime and Event.VizHitTest.TransformTime.

Bug: 817673
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iaae1009aa74f679a2e40c56f62e24a6fb3422be4
Reviewed-on: https://chromium-review.googlesource.com/942604
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540270}

The new lint rule checks for non-existence and duplicate items.

Updated LayoutTests/SmokeTests for tests that have been moved or
deleted.

Change-Id: I3de74e519d36c08871af872d3a439ba28fe1bdc2
Reviewed-on: https://chromium-review.googlesource.com/942606
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540269}

ClipRect has a ToString function but did not have a stream operator
defined. This patch adds operator<<(..., ClipRect) which enables:
ClipRect clip_rect;
LOG(INFO) << "Clip rect: " << clip_rect;

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9f34867fb50dd71c76779223ac7871e5e77dc568
Reviewed-on: https://chromium-review.googlesource.com/943679
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540268}

Bug: 817873
Change-Id: Ib22851d80508d65e5f9fa651af8dc629da17ddd4
Reviewed-on: https://chromium-review.googlesource.com/943830Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540267}

TabManager discards tabs, but also ARC processes.
LifecycleUnit is an abstraction to help us having one
code path for all discards.

Bug: 775644
Change-Id: I4d2e89a710afe097cc2d6222a6c156f57c774144
Reviewed-on: https://chromium-review.googlesource.com/842306
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540266}

These will be turned into deprecation warnings when we
start deprecating SDES crypto and the constraint.

Bug: 804275
Change-Id: I0c5763406b9f4bd32890708e34a132ad6553a929
Reviewed-on: https://chromium-review.googlesource.com/941955Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540265}

Fix browser tests that use host_resolver() and navigate in SetUpOnMainThread with the network service.

These currently silently fail, as we only sync the host_resolver() rules after SetUpOnMainThread returns. Improve this by watching the main window's WebContents for navigations and syncing the rules immediately.

This won't cover all corner cases, i.e. if a test navigates a new tab or window. However it should cover the majority of cases.

Bug: 729848
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie14daf47582d187f6d4aa6bf0a36885997fee6c8
Reviewed-on: https://chromium-review.googlesource.com/940165Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540264}

This CL removes net/tools/get_server_time now that
//components/network_time_tracker is using a different mechanism
(x-cup-server-proof). This utility is no longer
relevant.

Bug: 801668
Change-Id: I0bc75a9d21244a0c3bbe0ed50da2783e7169c61c
Reviewed-on: https://chromium-review.googlesource.com/943343Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540263}

Regular upgrade to the newest public release of the VR APKs.

Change-Id: I3f6aa68192fc35d52cdfb946c8c1e197c06ecfdd
Reviewed-on: https://chromium-review.googlesource.com/942227
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540262}

Currently turning on the P2P sharing flag can lead to a crash in two
ways while trying to set up the file for sharing.  This patch checks
for a null file path, and returns instead of crashing if we do not
have a file path.

The two cases leading to this will be addressed separately.

In the first case, we might end up with a null file path.  This can
happen if we are sharing a content URI, which does not have an
associated file.  The proper fix is to re-share the content URI.
https://crbug.com/817608 is tracking the proper fix.

In the second case, (https://crbug.com/817611), we are trying to share
from a private directory.  We need to detect the attempt to share from
a private directory and prevent it. This will largely be mitigated
when we implement the planned upgrade task to move all offline pages
out of the private directory and into a public location, but we still
need to fix the bug in case a file fails the upgrade.

Change-Id: Iec2453b6051e9e535450214d27b02a696499b4cf

Bug: 758690
Change-Id: Iec2453b6051e9e535450214d27b02a696499b4cf
Reviewed-on: https://chromium-review.googlesource.com/937842
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540261}

This reverts commit 58866fc9.

Reason for revert: broke the build -- https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63495

Original change's description:
> Update Crashpad to 71d90608828da0b6c987f018c96306bfa964a65a
> 
> 14dbd3531d98 gn win: Get main test binaries building
> 6cf4f928eb08 gn win: Add auxiliary test binaries used by
>              end_to_end_test.py
> 36679d572ba0 win: Don't assume offsets the same when
>              kDoesNotObserveDaylightSavingTime
> 9ab4fbf1e1a7 win: Improve child crash location test
> 798f6540435f gn win: Use new toolchain names to support both x86 and x64
> 83a83c5b0050 Roll mini_chromium to e7e8237
> a483e2c599b8 Fix names of Windows trybots after server-side rename
> 38b20ca57efc Relocate CaptureContext to misc and implement on Linux
> a8ad3bdbdfb1 linux: fix incorrect fallthrough
> 73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
> b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
> f878f155172b fuchsia: Add flock() stub to get test binaries linking
>              again
> e5bbdaff87a9 Pass FilePath to Settings in Initialize()
> c45ba7920e01 Make NewReport objects own their associated database
>              resources
> 7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
> c406797ce620 Add  UploadReport to manage database resources during
>              upload
> 7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
>              symtab
> 8d0d999d9245 Add a cross-platform database implementation
> b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
>              implementations
> 6667fa25595a fuchsia: Fixes to TestPaths
> 90cde8e30f7d Disable upload on Android
> 4094c2628d33 Address review comments for 8d0d999
> a4d7fb4cc390 Use .long for pointers on 32-bit platforms
> 5e5b927b38ca Build crashpad_client_linux.cc on Android
> eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
> 4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
> f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
> 6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
> 0429216f59b1 linux: Add CrashReportExceptionHandler
> f38af628c9dc fuchsia: Don't fail rename if source == dest
> 040360239343 Fix
>              CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
>              ions
> 10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
>              functional
> 5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
>              Settings
> 4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
> 8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
>              source root
> 4a9d422652a1 Turn fuchsia trybots on by default
> ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
>              from SDK
> 8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
> d2a866978b89 Makes 'all' build on Linux
> d8d03172c278 arm: Capture context around pc and registers
> ebad8bd925c3 Don't spawn an upload thread if url is empty
> 0520fdff1edc linux: Move ScopedPrSetPtracer to util/
> 38540eaf71cb Add handler options for Linux/Android
> 01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
> 3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
> cab259330f2e fuchsia: Pass more data out of module snapshot
> 1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
>              ModuleSnapshotElf
> 4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
>              ProcessSnapshotFuchsia
> 2290a826af1e Pull (most) platform-specific MemorySnapshots out
> 3030ae54171a fuchsia: Fix ninja auto-regen after run
> 61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
>              test
> c69ba3d52783 non-win: Add
>              Multiprocess::SetExpectedChildTerminationBuiltinTrap()
> f130822b9f4b linux: Add CrashpadClient tests
> 2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
> fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
> cd3afe616e63 Linux: Pull and use clang toolchain in third_party
> 8e80a575d15f Linux: Pull a sysroot if pulling a local clang
> fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
> a869ae18d256 Workaround for death test failure when in threadsafe mode
>              on Mac
> 8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
> 9affa2a0e72d Optionally stub out the libcurl-based implementation of
>              HTTPTransport
> dec23bef5769 win gn: reintroduce flags to disable warnings
> 746ce1a63703 Roll mini_chromium to 987bde8
> 493e29bc3df0 win: Use correct format specifier
> a45e88602b90 Skip ELF notes with a p_vaddr of zero
> 71d90608828d Add Linux trybots to CQ
> 
> Also:
> Add new metrics enums values.
> Use new CrashReportDatabase interface.
> 
> Bug: crashpad:30
> Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
> Reviewed-on: https://chromium-review.googlesource.com/941512
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540253}

TBR=jperaza@chromium.org,mark@chromium.org,siggi@chromium.org

Change-Id: I0f0866b62d41f53b702d17681b6540c766db98b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Reviewed-on: https://chromium-review.googlesource.com/944122Reviewed-by: Xi Cheng <chengx@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540260}

Currently, if you're in the Android tab picker and you're dragging to close a
tab, but your finger hits the other stack, we treat this as if you immediately
lifted your finger once it hit the other stack. This feels kind of weird and
jarring.

This CL fixes the behavior so the tab keeps getting dragged until you actually
lift your finger.

Bug: 817885
Change-Id: I5ea113d28dccfa33b29c33575f0b6e29f9dfb9ef
Reviewed-on: https://chromium-review.googlesource.com/935667
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540259}

Previously we did not handle the case of computing the value of an
interpolated transform, which occurs when we interpolate between
two different transform types containing percentages.

The correct result is currently not spec'd [1], so this patch fixes this
by just returning "none" in this case.

[1] https://github.com/w3c/css-houdini-drafts/issues/425

Bug: 816803
Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6
Reviewed-on: https://chromium-review.googlesource.com/942595Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540258}

We now use the BACKGROUND_SYNC permission to decide whether or not to
upload reports for a particular origin.  Note that as currently written,
we don't use this permission to decide whether to *collect* the reports,
only whether to *send* them.  Whether or not to collect is controlled
by the site's cookie settings.

Bug: 704259
Change-Id: I059019ab85106c26f4d156e9f5d61e2f8b8fa757
Reviewed-on: https://chromium-review.googlesource.com/937572Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Douglas Creager <dcreager@google.com>
Cr-Commit-Position: refs/heads/master@{#540257}

While presenting to a local display, if we remove the display with a
fullscreen presentation, the presentation can move to the display with
the controlling window while still being fullscreen and cover the
controlling window. This CL makes the presentation window exit
fullscreen in such cases.

Bug: 805139
Change-Id: I02c4234d95ee9477683550fdad454e1aee6b460b
Reviewed-on: https://chromium-review.googlesource.com/902889Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540256}

These tests originally passed the CQ mac bots because they are allowed
to crash due to http://crbug.com/816534 , and the CQ mac bot runs with
DCHECK enabled. Unfortunately however that hide the fact that on
non-DCHECK macs, the test has different output.

Bug: 772014
Change-Id: I4bbaeb853426ad48488111a667a6caf4ba7284f6
Reviewed-on: https://chromium-review.googlesource.com/939670Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540255}

The following CT Logs have passed their monitoring period and
are being added as trusted Logs in Chrome:

Google Argon2018, Argon2019, Argon2020, Argon2021
Cloudflare Nimbus2018, Nimbus2019, Nimbus2020, Nimbus2021

Bug: 756814, 756817, 756818, 756819, 780654, 780655, 780656, 780657
Change-Id: I6b8671db0dc7ba34b666345049934ed3e2b5705a
Reviewed-on: https://chromium-review.googlesource.com/942688Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540254}

14dbd3531d98 gn win: Get main test binaries building
6cf4f928eb08 gn win: Add auxiliary test binaries used by
             end_to_end_test.py
36679d572ba0 win: Don't assume offsets the same when
             kDoesNotObserveDaylightSavingTime
9ab4fbf1e1a7 win: Improve child crash location test
798f6540435f gn win: Use new toolchain names to support both x86 and x64
83a83c5b0050 Roll mini_chromium to e7e8237
a483e2c599b8 Fix names of Windows trybots after server-side rename
38b20ca57efc Relocate CaptureContext to misc and implement on Linux
a8ad3bdbdfb1 linux: fix incorrect fallthrough
73e862e15a6c fuchsia: Exclude capture_context_test.cc from test build
b83f4c731d8f Let UUID::InitializeFromString accept StringPiece16 too
f878f155172b fuchsia: Add flock() stub to get test binaries linking
             again
e5bbdaff87a9 Pass FilePath to Settings in Initialize()
c45ba7920e01 Make NewReport objects own their associated database
             resources
7d5487fc44b3 minidump: add switch cases to handle linux/android and ARM
c406797ce620 Add  UploadReport to manage database resources during
             upload
7faa2ef89872 Get CrashpadInfo address via a .note, rather than dynamic
             symtab
8d0d999d9245 Add a cross-platform database implementation
b43858c9903f fuchsia: Start of ModuleSnapshot and ProcessReader
             implementations
6667fa25595a fuchsia: Fixes to TestPaths
90cde8e30f7d Disable upload on Android
4094c2628d33 Address review comments for 8d0d999
a4d7fb4cc390 Use .long for pointers on 32-bit platforms
5e5b927b38ca Build crashpad_client_linux.cc on Android
eec1e17ab558 Fix two bugs in memset()ing CrashpadInfo on size mismatch
4717300fa4ce Reset CrashpadInfo after CrashpadInfoReader tests
f9d160ffc6bb Revert "Reset CrashpadInfo after CrashpadInfoReader tests"
6798ba912e96 Reset CrashpadInfo after CrashpadInfoReader tests
0429216f59b1 linux: Add CrashReportExceptionHandler
f38af628c9dc fuchsia: Don't fail rename if source == dest
040360239343 Fix
             CrashpadInfoSizes_ClientOptions/CrashpadInfoSizes_ClientOpt
             ions
10222b12362c fuchsia: Disable TimeZone.Basic test as timezones are non-
             functional
5cb869392eed fuchsia: Compile out LoggingLock/UnlockFile, add DCHECKs to
             Settings
4b7895615808 Add .hidden to CRASHPAD_NOTE_REFERENCE
8ee14eef08f3 fuchsia: Fix some packaging when run isn't from Crashpad
             source root
4a9d422652a1 Turn fuchsia trybots on by default
ec33c25797f9 fuchsia: Don't include sys/resource.h, recently removed
             from SDK
8b738cd24d59 Don't include crash_report_database_generic.cc on Win/Mac
d2a866978b89 Makes 'all' build on Linux
d8d03172c278 arm: Capture context around pc and registers
ebad8bd925c3 Don't spawn an upload thread if url is empty
0520fdff1edc linux: Move ScopedPrSetPtracer to util/
38540eaf71cb Add handler options for Linux/Android
01105719d767 linux: add CRASHPAD_SIMULATE_CRASH()
3dd85dc12638 fuchsia: Make ImageAnnotationReader[Test] work
cab259330f2e fuchsia: Pass more data out of module snapshot
1aae5cedaf1e Refactor ModuleSnapshot(Linux|Fuchsia) into
             ModuleSnapshotElf
4d96e4e504ef fuchsia: Return ModuleSnapshot* out of
             ProcessSnapshotFuchsia
2290a826af1e Pull (most) platform-specific MemorySnapshots out
3030ae54171a fuchsia: Fix ninja auto-regen after run
61f1013ee4ef fuchsia: Add some thread reading to ProcessReader and a
             test
c69ba3d52783 non-win: Add
             Multiprocess::SetExpectedChildTerminationBuiltinTrap()
f130822b9f4b linux: Add CrashpadClient tests
2b05eb522fa4 Rename ProcessReader to platform-suffixed versions
fa2a03fbdd0f linux: Add CrashpadClient::SetFirstChanceExceptionHandler()
cd3afe616e63 Linux: Pull and use clang toolchain in third_party
8e80a575d15f Linux: Pull a sysroot if pulling a local clang
fae18c2fc492 fuchsia: Add implementation of ThreadSnapshot
a869ae18d256 Workaround for death test failure when in threadsafe mode
             on Mac
8a12f5893050 fuchsia: Take bots off CQ pending flake investigation
9affa2a0e72d Optionally stub out the libcurl-based implementation of
             HTTPTransport
dec23bef5769 win gn: reintroduce flags to disable warnings
746ce1a63703 Roll mini_chromium to 987bde8
493e29bc3df0 win: Use correct format specifier
a45e88602b90 Skip ELF notes with a p_vaddr of zero
71d90608828d Add Linux trybots to CQ

Also:
Add new metrics enums values.
Use new CrashReportDatabase interface.

Bug: crashpad:30
Change-Id: I19a858387630409f40e0f42b79f0cf46d9f4e13b
Reviewed-on: https://chromium-review.googlesource.com/941512Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540253}

Turned out the rounding made to calculate count could add significant
errors to the samples on regular allocation patterns. The patch
replaces count with the total value attributed to the sample.

BUG=803276

Change-Id: I2f40ad403275817696330d502dadfd76657a552a
Reviewed-on: https://chromium-review.googlesource.com/941734
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540252}

Bug: 807015
Test: None
Change-Id: I6b9ae265f6105dc7160f041b7e752785180889f3
Reviewed-on: https://chromium-review.googlesource.com/941389Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540251}

Before this CL, high contrast was applied to the contents of
the viewport twice (once on the copied contents, and another
since the viewport is a child of the root layer), resulting
in undoing its effect.
This CL updates the "inverted" status of the viewport layer.

BUG=817431
TEST=Added test coverage.

Change-Id: I4d946e5ae22f1232db74fecf7b32311073124055
Reviewed-on: https://chromium-review.googlesource.com/942602
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540250}

These are tests failing because of image (and image+text) diff.

Steps:
1. Tried on mac10.13_blink_rel.
2. Filtered out image & image+text failures.
3. Rebaselined these tests on Mac ports *only* (otherwise, many Win &
Linux expectations would be modified unwarrantedly).
4. Added back all the flaky expectations (these tests were not flaky in
this single job, which doesn't mean they are not flaky).

Lastly, a bunch of failure expectations associated with issue 701047 were
automatically removed by rebaseline-cl. After examination of the new
baselines, it seems the issue is indeed gone ("m" and "w" display correctly
on Mac 10.12 now).

Bug: 774301, 701047
Change-Id: I649a7973ca24752ae23f5f10bd82f0cf1c6901e9
Reviewed-on: https://chromium-review.googlesource.com/899783
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540249}

This test is failing on the Nougat bot. Since the feature is unshipped
and currently unowned, it's best to just disable for now. We'll block
the feature bug on reenabling it.

Bug: 773076
Change-Id: I30d019267116fcae937e86f5f514f2a260829dc4
Reviewed-on: https://chromium-review.googlesource.com/943246Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540248}

https://pdfium.googlesource.com/pdfium.git/+log/198792b7e860..71cdd20e9d74

$ git log 198792b7e..71cdd20e9 --date=short --no-merges --format='%ad %ae %s'
2018-03-01 rharrison Disable XFA tests without embedded fonts
2018-03-01 thestig Add a test for FPDFImageObj_GetBitmap() with a JBIG image.
2018-03-01 thestig Break up CFX_DIBSource::ConvertBuffer().

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iba02fd7b624598f40cf91a2f9b8a71f9750fbd6d
Reviewed-on: https://chromium-review.googlesource.com/943604
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540247}

This is temporary while PIP is being wired up and worked to be more
stable through the media controls entry point.

The menu item is not removed because we intend to continue using it
and it is currently hidden behind a flag.

BUG: 817598
Change-Id: I9156d81b40dd6c97e19c6eef3f5fbbe13e350639
Reviewed-on: https://chromium-review.googlesource.com/942305
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540246}

Bug: 817810
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib6b945dd2a15cee871affab13dade50d1b06149e
Reviewed-on: https://chromium-review.googlesource.com/943726Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540245}

It was disabled years ago and seems to be passing consistently now.

Bug: 111399
Change-Id: I5c2095c101d6dc20891d7787d9e360f3c48d2f77
Reviewed-on: https://chromium-review.googlesource.com/943063Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540244}

For ease of review copy the files over. A follow up patch
(https://chromium-review.googlesource.com/c/chromium/src/+/941911) will be
made to actually change the implementation. Presubmit skipped so this is
exactly just a copy file otherwise it errors out on the banned functions
used in this file. (Fixed in followup)

BUG=817501
NOPRESUBMIT=true

Change-Id: I71caaca96f8b722717632d32f8c4187fc0ebaf7d
Reviewed-on: https://chromium-review.googlesource.com/943342Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540243}

DeviceDescriptionFetcher and DialAppInfoFetcher have some common code.
Create a DialURLFetcher class to get rid of some duplications.

The common URLFetcher class can also be used to launch and stop Dial
apps when we implement DIAL launch at browser side.

Bug: 816628
Change-Id: I26bdfbbf7e2d59a68e3bf5aeaba8b6e3664bf430
Reviewed-on: https://chromium-review.googlesource.com/938158Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540242}

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'
git grep -l MakeUnique< base | xargs perl -pi -e 's/MakeUnique</std::make_unique</'

Presubmit bypassed due to unrelated existing errors in touched lines.

Bug: 755727
No-Presubmit: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iedc5caf5bc04e119dadd0e3e8cc5c4dbf2fddc80
Reviewed-on: https://chromium-review.googlesource.com/943728Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540241}

This CL adds user gesture plumbing to cross-process postMessage, so
that when a frame sends a postMessage to a cross-process frame while
processing a user gesture, the target frame's onmessage handler can
utilize that user gesture as well.

For now, the plumbing is only for one bit, has_user_gesture, which is
restricted so that it can be forwarded at most once.  This prevents
unbounded forwarding of a user gesture via OOPIFs.

This solution is temporary and should eventually be superceded by one
of the following approaches:

- Browser process starts tracking user gestures and enforcing
  constraints like at-most-one-popup-per-gesture.  This plumbing
  should then pass a user gesture ID instead of a bool.

- UserActivation V2 ships (see https://crbug.com/696617).  This should
  allow us to remove this plumbing altogether.

Bug: 161068
Change-Id: Ib7de03bb51470f6ff924d2e178b26e80b597321d
Reviewed-on: https://chromium-review.googlesource.com/915101
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540240}

Adding a callback to SimpleURLLoader to get notified when the request
started, i.e. when the headers are available.

Bug: 817458
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1b53ba5b64a4c1cc406d03638f733a177ec863be
Reviewed-on: https://chromium-review.googlesource.com/941881
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540239}

Splits the Ranker predition UMA logging to always log the prediction
regardless of whether the UI was shown.

BUG=

Change-Id: I6593e3163113ea7201d71b587cbd7f2552ba085b
Reviewed-on: https://chromium-review.googlesource.com/942058Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540238}

The perf bot perf.chromium-rel-mac12 has alerted on a ~50% slowdown in
http___webglsamples.org_dynamic-cubemap_dynamic-cubemap.html .
In the regression range was my seemingly closely
related CL: https://crrev.com/c/923103
But that commit should improve performance, not regress it.

So this CL adds an exception to the workaround in 923103, so that
that workaround does not apply on perf.chromium-rel-mac12.
This should help determine whether my CL really caused a regression.

I'm expecting this CL to cause a regression in
http___kenrussell.github.io_webgl-animometer_Animometer_tests_3d_webgl.html
(undoing the recent improvement caused by 923103).

Bug: 815154
Change-Id: I335133a127bb7cfcb92ba29065641dfd55b63166
Reviewed-on: https://chromium-review.googlesource.com/938844
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540237}

This change adds a SimulateAdvertisementReceived function to the
FakeCentral interface. The design for this class is detailed in the
following document:
https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg

BUG=719826

Change-Id: I618dc68c967e6d9942f99f1807da6fb1985cd676
Reviewed-on: https://chromium-review.googlesource.com/916554Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540236}

The general pow function is pretty expensive when computing 10^x and
2^x.  Replace it with the more specific exp and exp2 functions.

This is only done for the routines for the BiquadFilterNode.

Using https://jsfiddle.net/8vo0gbav/1/ (with dezipper = true to use
setTargetAtTime) as a test, perf top on my Z840 machine said:

+   29.01%    28.98%  __ieee754_pow_sse2
+   22.65%    22.61%  __exp1

With this CL, the same test reports

+   17.15%    17.12%  __expf_finite

This isn't enough to make the test case use less than 100% CPU, but
audio with glitches is now heard.

Two tests needed to have the thresholds modified.  Apparently there's
a difference in round-off between exp and pow for this change to
change the results slightly.

Bug: 813504
Change-Id: I7c517c558bbb54c344f10dc3c057d21404679995
Reviewed-on: https://chromium-review.googlesource.com/942091Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540235}

This CL disables ParallelDownloadTest.ResumptionLastSliceUnfinished on
Android.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug: 817801
Change-Id: Icb2ce3a43d00ee1e74a005b2af91cea6045f3694
Reviewed-on: https://chromium-review.googlesource.com/943802
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540234}