GitLab

Field trials can only be initialized once, so the FactoryGet() method cannot
be called each time to check the value of the trial.

BUG=470278

Review URL: https://codereview.chromium.org/1023673011

Cr-Commit-Position: refs/heads/master@{#322212}

As part of the Telemetry public API refactor, I wrote a tool that sorts imports.
The tool will be checked in separately, but here's all the import changes in Telemetry and its dependencies.
It'll be easier to test the refactor tool if we do the import sorting in advance, so it doesn't clutter the diffs for the module moves.

Style guide rule: "Within each grouping, imports should be sorted lexicographically, ignoring case, according to each module's full package path."

BUG=449308
TEST=trybots (tools/telemetry/run_tests; tools/perf/run_tests)

Review URL: https://codereview.chromium.org/1029263003

Cr-Commit-Position: refs/heads/master@{#322211}

This reverts committ: https://crrev.com/ebbf3c1bf5f41b0133657515302e3b110abedee1

Broke on the Win8 gn bot which doesn't appear to be in the CQ and treats
signedness of characters differently than all other configurations.

BUG=467176
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1012773009

Cr-Commit-Position: refs/heads/master@{#322210}

This saves us from having to build app_mode_common.mm twice, and works
around an LTO bug on Mac.

BUG=469377
R=jam@chromium.org,jackhou@chromium.org

Review URL: https://codereview.chromium.org/1026833004

Cr-Commit-Position: refs/heads/master@{#322209}

Adds @UsedByReflection to the CronetUrlRequestContext constructor. This is necessary for UrlRequestContext to instantiate this class after proguarding.

BUG=

Review URL: https://codereview.chromium.org/1018213007

Cr-Commit-Position: refs/heads/master@{#322208}

This cleans up the API a bit and allows the code to be unit tested.

This also prevents ftruncate from being used on Android where
shared memory is backed by Ashmem. Ashmem doesn't support ftruncate.

BUG=466509
TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.Shrink

Review URL: https://codereview.chromium.org/1018743003

Cr-Commit-Position: refs/heads/master@{#322207}

$ git log b61a1802f..53ef01328 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-03-20 phajdan.jr Add support for writing swarming.py query results to a file
2015-03-17 maruel Do not throw if the json file is missing or invalid.
2015-03-16 maruel Fix regression from 3c979cb54e which broke run_on_bots.py.
2015-03-13 maruel Handle race condition in terminate().
2015-03-13 maruel Change subprocess42 maxsize and timeouts arguments to be callable.
2015-03-11 maruel Switch most paths to be unicode and enforce it.
2015-03-10 cmassaro Switching from /content-gs/ to Endpoints API.

R=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1028693003

Cr-Commit-Position: refs/heads/master@{#322206}

BUG=470116

Review URL: https://codereview.chromium.org/1035603002

Cr-Commit-Position: refs/heads/master@{#322205}

BUG=433984
For:
extensions/common/api/networking_private.json
third_party/closure_compiler/externs/chrome_extensions.js
TBR=jamescook@chromium.org,dbeam@chromium.org

Review URL: https://codereview.chromium.org/987963002

Cr-Commit-Position: refs/heads/master@{#322204}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6c126cd..7dd2b95

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1029263009

Cr-Commit-Position: refs/heads/master@{#322203}

This matches WorkerTest.SharedWorkerTlsClientAuth and inline disables make it
clearer a subset of the tests don't run on some platforms.

BUG=none

Review URL: https://codereview.chromium.org/1032033003

Cr-Commit-Position: refs/heads/master@{#322202}

Now that the image resources that blink depends on are in the blink
repository, we depend on the blink resources directly, delete the ones
in the chrome tree, and use these resources in the html_viewer.

BUG=467176

Review URL: https://codereview.chromium.org/1033733004

Cr-Commit-Position: refs/heads/master@{#322201}

BUG=None

Review URL: https://codereview.chromium.org/1033733007

Cr-Commit-Position: refs/heads/master@{#322200}

BUG=470091

Review URL: https://codereview.chromium.org/1031163002

Cr-Commit-Position: refs/heads/master@{#322199}

It doesn't change anything to the current official build configuration ! 'size' is already the default value for the 'optimize' variable (https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=5411), but we override this value when doing a PGO build, so this is just preventing the mini_installer from being PGO optimized.

BUG=309849

Review URL: https://codereview.chromium.org/1037793004

Cr-Commit-Position: refs/heads/master@{#322198}

Include certain qualifications in the view names reported to analytics, like 'with-media-dir', or the FSP provider extension id.

Background:

Note there was a potential race condition relating to sendAppView and other events. In order to qualify events by view, we needed to be certain to send appView before any other activity that might be kicked off by a directory change event (like importing).

BUG=None
TEST=manual

Review URL: https://codereview.chromium.org/1022423005

Cr-Commit-Position: refs/heads/master@{#322197}

Previously the condition was reversed. We can only do incremental linking when symbols are disabled. I was hoping it would work for minimal symbols but I tested and it still fails.

This patch only does incremental linking when symbols are completely disabled.

Review URL: https://codereview.chromium.org/1027543003

Cr-Commit-Position: refs/heads/master@{#322196}

BUG=
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/1032143003

Cr-Commit-Position: refs/heads/master@{#322195}

BUG=465201
TBR=cjhopman

Review URL: https://codereview.chromium.org/1032203002

Cr-Commit-Position: refs/heads/master@{#322194}

There was an unfortunate bug that swallowed Java stacks.
Issues were discovered when Java stacks started surfacing:
https://codereview.chromium.org/476453002/

So change the way remoting is built. It doesn't need to be
built on all bots by default: they have undefined Java versions
and likely weren't working before (and shouldn't differ).

Instead, run when run_jscompile=1 is defined in GYP:

  export GYP_DEFINES=run_jscompile=1 && build/gyp_chromium
  # or add in ~/.gyp/includes.gypi or $SRC/../chromium.gyp_env
  # or build/gyp_chromium -Drun_jscompile=1

and on the Closure Compilation Linux FYI bot:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux

This also fixes some GYP inputs problems (if I changed compile_js.gypi or
other things in remoting/ ninja wouldn't rebuild anything).

R=jamiewalch@chromium.org
BUG=none
TEST=green bots, remoting runs on Closure Compliation Linux FYI bot

Review URL: https://codereview.chromium.org/1037613002

Cr-Commit-Position: refs/heads/master@{#322193}

We were missing the single-threaded task graph runner, which was
required for blink's layout tests that checked for pixels.

BUG=468928

Review URL: https://codereview.chromium.org/1036693002

Cr-Commit-Position: refs/heads/master@{#322192}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/698efc0..6c126cd

TBR=jchaffraix@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/1024463011

Cr-Commit-Position: refs/heads/master@{#322191}

BUG=469362

Review URL: https://codereview.chromium.org/1024543006

Cr-Commit-Position: refs/heads/master@{#322190}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7a01184..e523d4f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1033963003

Cr-Commit-Position: refs/heads/master@{#322189}

According to the stack trace in bug 467372, ~RenderThreadImpl() destructs
RenderThreadImpl::gpu_va_context_provider_, which touches the main message loop
that has been already shut down and crashes. To avoid the crash, this CL
clears RenderThreadImpl::gpu_va_context_provider_ before RenderThreadImpl
shuts down the main message loop.

BUG=467372

Review URL: https://codereview.chromium.org/1036773002

Cr-Commit-Position: refs/heads/master@{#322188}

Specifications of UriBeacon:
https://github.com/google/uribeacon/tree/master/specification

Here's the description of the encoding of UriBeacon:
https://github.com/google/uribeacon/blob/master/specification/AdvertisingMode.md

Review URL: https://codereview.chromium.org/950083003

Cr-Commit-Position: refs/heads/master@{#322187}

Before/Now comparison: http://imgur.com/a/4Nivx

BUG=467790

Review URL: https://codereview.chromium.org/1037483005

Cr-Commit-Position: refs/heads/master@{#322186}

Add test imitating several well-known situations where loading is blocked
by Blink. Verify that clients can know about blocks via
WebChromeClient.onConsoleMessage.

Remove traces of previous attempt to add ERR_BLOCKED code.

BUG=456782

Review URL: https://codereview.chromium.org/1029313003

Cr-Commit-Position: refs/heads/master@{#322185}

Revert of Test Accelerators In Interactive UI Tests (patchset #5 id:80001 of https://codereview.chromium.org/1026513005/)

Reason for revert:
AcceleratorInteractiveUITest.ChromeOsAccelerators and AcceleratorInteractiveUITest.TestNonRepeatableNeedingWindowActions are failing on the cros_trunk official builders.

http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/31840

Original issue's description:
> Test Accelerators In Interactive UI Tests
>
> In order to avoid future regressions.
>
> BUG=469235
> TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.*
>
> Committed: https://crrev.com/b0c1e2d572b2bda87f11007c89ecdaac6301770a
> Cr-Commit-Position: refs/heads/master@{#322076}

TBR=oshima@chromium.org,afakhry@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469235

Review URL: https://codereview.chromium.org/1035763003

Cr-Commit-Position: refs/heads/master@{#322184}

Reason for revert:
This depends on https://codereview.chromium.org/1023043002, which was reverted.

Original issue's description:
> Re-enable ChannelMojo
>
> It was disabled due to crbug.com/466814 that is now fixed.
> It's time to turn it on again.
>
> R=viettrungluu@chromium.org
> BUG=466814,377980
>
> Committed: https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643
> Cr-Commit-Position: refs/heads/master@{#322092}

TBR=viettrungluu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466814,377980

Review URL: https://codereview.chromium.org/1034753002

Cr-Commit-Position: refs/heads/master@{#322183}

Review URL: https://codereview.chromium.org/1028903002

Cr-Commit-Position: refs/heads/master@{#322182}

BUG=none
R=glider@chromium.org

Review URL: https://codereview.chromium.org/1037763002

Cr-Commit-Position: refs/heads/master@{#322181}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/8c015c13ad...cc268ee730

Picked up changes:
cc268ee Revert "Treat images as another type of embed"
a7949c7 implement extraction of page parameters from potential pagination URLs
47c825f Add target "ant runtest" to run tests without recompiling
7a29e21 Fixes a crash when window.performance is not available.
b7b4d4a Fixing python header.
1c2dd98 Revert "Disable flaky page link tests"
2a64c8d Use a much simpler baseUrl heuristics
3e49cf2 Fix flakiness due to a bug in createAnchorWithBase()
d69f15d Allow multiple instances of "ant test" running
d9fb022 Put steps in continuous integration into a bash script
94320fe Unify the style in Ant target descriptions
4adbcfa Don't let base tag change original_url
a3a07ce Disable flaky page link tests
0b8c2e7 Treat images as another type of embed
d49edaf Add pagenum difference in the next page heuristics
abee435 Do not sum up scores of next page links with the same URL
0955aa3 Use numbers as a fast filter in next page detection
ff4bc3d Fix relative link resolution with base tag
875b0ff Use URL prefix as a fast filter in next page detection
7b12bc7 Resolve links in a new HTML document with a base tag
ab96c56 Add timing info for pagination
2812744 Add support for wrapping the standalone JavaScript.
7bd24c4 Groundwork for retaining popular embeds in results
4b3cdb9 Add instructions for using `git cl format`.
94c8270 Add project introduction in README.md
86983de Add support for running jstests on Mac OS X and add documentation.
f33d992 Add JS tests to package and suppress log output.
1a42d14 Make the "test" target not depend on "package"
eabc11d Add data tables to the WebDocument
669d605 Revert "Disable some tests in PagingLinksFinderTest"
2874c7b Fix the page URL in PagingLinksFinderTest
ddc30e2 Fix next-page tests for new mocking mechanism

BUG=431067,450813,455503,464143

Review URL: https://codereview.chromium.org/1029263006

Cr-Commit-Position: refs/heads/master@{#322180}

The old logic was difficult to follow with pointers and values switching from
SSL_read return values to net return values. This new formulation should
hopefully be clearer.

BUG=none

Review URL: https://codereview.chromium.org/1000813002

Cr-Commit-Position: refs/heads/master@{#322179}

Both socket implementations have client auth logic to remove a session from the
session cache in case of client auth. In both cases, this doesn't do anything.
The OpenSSL one was copied from the NSS one. It was always dead code and became
a no-op when we stopped using the internal session cache (see
https://crbug.com/466352).

The NSS one dates to http://codereview.chromium.org/276037. At that time, we
returned SECFailure rather than SECWouldBlock, so the handshake would continue
and potentially poison the session cache. As of
http://codereview.chromium.org/669198, this was no longer an issue.

BUG=none

Review URL: https://codereview.chromium.org/1013193004

Cr-Commit-Position: refs/heads/master@{#322178}

range-based loops is one of the C++11 allowed features. See
https://chromium-cpp.appspot.com/ and
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/hpzz4EqbVmc.

This patch was generated with the following command lines:

$ ninja -C out/Debug -t compdb cxx > out/Debug/compile_commands.json
$ cd out/Debug
$ find ../../tools/gn -name '*.cc'  | xargs -n 16 -P 32 \
~/src/repos/llvm/build/bin/clang-modernize -loop-convert -p . -include \
tools/gn -format -style=Chromium
$ ninja gn gn_unittests
$ ./gn_unittests

BUG=None
TEST=gn && gn_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/986113002

Cr-Commit-Position: refs/heads/master@{#322177}

Move pending navigation parameters to RenderFrame, and use the HistoryController to distribute them to affected frames.

BUG=369661
TEST=existing tests

Review URL: https://codereview.chromium.org/1027863002

Cr-Commit-Position: refs/heads/master@{#322176}

Revert of content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test. (patchset #1 id:1 of https://codereview.chromium.org/1033553003/)

Reason for revert:
Still flaky

Original issue's description:
> content: Re-enable ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory test.
>
> BUG=
> TEST=content_browsertests --gtest_filter=ChildDiscardableSharedMemoryManagerBrowserTest.LockMemory
>
> Committed: https://crrev.com/98e563846f88a2df7107e170381a6a5e8bd4454b
> Cr-Commit-Position: refs/heads/master@{#322122}

TBR=avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1038703002

Cr-Commit-Position: refs/heads/master@{#322175}

This is related to https://codereview.chromium.org/1027693004/ and should be submitted before (although doesn't matter much).

This obsoletes the unowned:
Net.HttpSocketType
Net.HttpConnectionLatency

and removes writing to:
Net.SocketIdleTimeBeforeNextUse_UnusedSocket
Net.SocketIdleTimeBeforeNextUse_ReusedSocket

which were made obsolete in
https://codereview.chromium.org/1027693004/

Are any of these histograms being looked at?

BUG=469288

Review URL: https://codereview.chromium.org/1025073002

Cr-Commit-Position: refs/heads/master@{#322174}

These will be used in the Media Router WebUI custom Polymer elements, which will be submitted in future patches.

BUG=464222

Review URL: https://codereview.chromium.org/1029213002

Cr-Commit-Position: refs/heads/master@{#322173}