- 09 Apr, 2020 40 commits
-
-
edchin authored
This CL installs the ManagedBookmarksPolicyHandler in policy handler list factory. This is guarded by a command-line switch: '--install-managed-bookmarks-handler' Bug: 1065187 Change-Id: Ie103fd92185b1397a3e5da30afd1da9b8384dd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142774 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757934}
-
David Bokan authored
Small cleanup to avoid sentinel value and make the semantics and lifetime clearer. Bug: NONE Change-Id: Icf22008e94aae436024d524a5d9eaeb5b9be63ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142514Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#757933}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I5510715fa0889a96b6208209b92a857ebe773584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139440 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757932}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c72a211d0090..3999e2615f58 git log c72a211d0090..3999e2615f58 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sadrul@chromium.org rendering benchmark: Some no-op cleanups. Created with: gclient setdep -r src/third_party/catapult@3999e2615f58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058155 Tbr: oysteine@google.com Change-Id: Ic9e1330460b9810594fac9e4b98018852adf8994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757931}
-
Connie Wan authored
The main fix for the flicker is the check for is_open(), but this caused another issue with the first context menu not showing up. See inline comment for the subsequent fix for the context menu. Bug: 1068934 Change-Id: Ib1269571b95de5624e0891501e8fb42e77d61611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144262Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#757930}
-
Yulun Wu authored
Bug: 1055694 Change-Id: I12f06d300aab873b8cf1a5b992a6c3bd0c412416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136101Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757929}
-
Dominic Farolino authored
This CL adds a kNonBlockingImage ImageRequestOptimization enum value to FetchParameters. ImageLoader::DoUpdateFromElement sets FetchParameters::image_request_optimization_ to this new value when requesting a once-deferred image. Finally, ResourceFetcher reacts to this by placing the ResourceLoader associated with the image Resource, in the |non_blocking_loaders_| set, as opposed to |loaders_| set. This ensures that when a `loading=lazy` image is fetched before the Document load event fires, the Document load event will not be blocked on this request. This matches the load event semantics that the HTML Standard mandates [1]. This follows the initial design proposed in https://docs.google.com/document/d/1QEp9zL8WPAthFlXcsyhhwDoDQd2STSh_Rex801LVQkA/edit#heading=h.4do48ac3us8v. [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:lazy-loading-attribute-2 R=kinuko@chromium.org, sclittle@chromium.org Bug: 992526,1033501 Change-Id: I8da2c3a6cfee8039d4dc353f9e9b679a04f2e302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133108 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#757928}
-
Sam Bowen authored
Bug: 1068748 Change-Id: I1354f7963254ab17570180ffca41b3764fc7890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140561 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#757927}
-
Kai Ninomiya authored
Deprecates GPUBindGroup(Layout)Descriptor.bindings. Bug: 1069302 Change-Id: I6c4cada0681d0417938d443a4dcd149072720c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143375Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#757926}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into a WPT-specific directory for crashtests, adding links to the relevant specs and a test assertion describing its purpose. This CL also creates a external/wpt/css/filter-effects/crashtests directory to place the new crashtest, in order to be able to add a multiple-references-id-crash-002.html in a follow-up CL, since otherwise (i.e. no crashtest dir) we would have to move the '-crash' substring after the '-001/-002' one part, right before the extension, or otherwise the test would not run (see the relevant RFC[1]). Besides, having a crashtest directory will be convenient to migrate more crash tests into css/filter-effects in the future. [1] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/load_test.md Bug: 1063749 Change-Id: I997fba360058d604698fab74ae84ee3b9893cb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144035 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#757925}
-
Reilly Grant authored
This change configures UsbServiceWin to receive all new device notifications. Upon receiving a notification about a device that is not a USB device it is checked to see if it is the child of a USB device. In this case we have discovered a new USB function. This is necessary because when Windows enumerates a new USB device it will generate an event for the root device before it generates events for any of the functions and so the initial enumeration of children added in a previous patch will not discover them. With this code in place composite devices discovered while Chrome is running are now usable. Bug: 637404 Change-Id: I8ab0b4a92069d19ac8489febc8d62862903eda9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142767Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757924}
-
Kyle Horimoto authored
Update OsSettingsLocalizedStringsProvider to use the synchronous API provided by LocalSearchService. Bug: 1063505 Change-Id: I569215fd0149bd9912a82a66ba2c8d0eb509c4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140960Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#757923}
-
Hailey Wang authored
Add calculation method for scoring of a tab depending on it's last visibility change time. This will be used for calculating tab score in future cl. Bug: 1059341 Change-Id: Ib6c9534bc6f47d73063a436a2a31f436c77ae872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136031 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#757922}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/89fa61264af5..a8ab783931f9 Created with: gclient setdep -r src-internal@a8ab783931f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1063948 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I8d7256d10ab0c5683d065a8772c4c94165ebd94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144385Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757921}
-
Sergey Ulanov authored
The test is trying to verify that WebEngine closes devtools port as expected. It was using URLFetcher to make an HTTP request to devtools. Due to a netstack bug (fxb/49779) sometimes that request was hanging indefinitely, so the test was timing out. Updated the tests to connect raw socket, which allows to verify that the port is closed without hitting that netstack bug. Bug: 1067727 Change-Id: Id07eefe490ca4e25cf6d9143636802f8115cd0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143380Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#757920}
-
chrome://appsDaniel Murphy authored
This hooks up the 'Show App Info' option in the context menu to work for BMO-enabled apps. R=loyso@chromium.org Bug: 1009302 Change-Id: I18ce0848c7cddfa46137cd67bee9bff0e1d99771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121437Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#757919}
-
Peter Kasting authored
Because these host content including toolbar buttons, which read data off the ThemeProvider, they need to have one configured. Right now this will run, but likely not look correct (e.g. I imagine the reload button is red) because the ThemeProvider is the stub class Widget provides by default. In the future, I'll remove this stub, and this wouldn't run at all. Bug: none Change-Id: I0a5e404534098f6f0a82782bbe55346aee9f8066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143655 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#757918}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7db1491a85f6..9f6ff832d99a git log 7db1491a85f6..9f6ff832d99a --date=short --first-parent --format='%ad %ae %s' 2020-04-09 mmorrison@nvidia.com Do not trigger -Wimplicit-int-float-conversion Created with: gclient setdep -r src/third_party/webrtc@9f6ff832d99a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I97076d413b6cea715fcee00c7ae1b85408cc7b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757917}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da31061a..d23973d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I101df9069d8182790e38967e12a1e89764352ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144232Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757916}
-
Kai Ninomiya authored
Allows deprecation warnings during the transition period for breaking WebGPU API changes. Bug: 1069302 Change-Id: Ic9a34b5edbd08dad0be5401d796a4ef3e96ecc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143374Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#757915}
-
Matt Menke authored
The fields are populated with a valid NIK, but never actually used otherwise. Bug: 1060631 Change-Id: I58619e7642cbce90c2e54138108e4cea21223f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142500Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#757914}
-
Ben Joyce authored
Bug: 1067070, 1067050 Change-Id: Id6814d5875ea1df4472422fbfd3121e67cf0d7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137676 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#757913}
-
Eric Roman authored
Change-Id: I6e26f11ea17234a45930312a103fc133db815205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116391Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#757912}
-
Eugene But authored
Running this script is required for Asan builds if Xcode has different locations on builder and tester machines. Bug: 1064181 Change-Id: Idd8517c9c43936901517d2713bff43285a295b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141119 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#757911}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10b9675c807b..08dd1a3ca3a5 git log 10b9675c807b..08dd1a3ca3a5 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 petermarshall@chromium.org [ui] Fix dropdown menu sizing with large fonts Created with: gclient setdep -r src/third_party/devtools-frontend/src@08dd1a3ca3a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066415 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie708c6fa46c5844b5c04c52cdaa0bd42bde28d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144386Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757910}
-
Robert Sesek authored
The generic service_manager InterfaceProvider is deprecated. It was being conceptually being used for two things: - Create RenderFrameHost-bound interfaces - Allow //content embedders to bind additional interfaces than those provided by //content. This change replaces the MediaInterfaceProvider with a new FrameInterfaceFactory interface, which has methods to directly acquire //content-provided RenderFrameHost-bound interfaces. But it also provides a GenericPendingReceiver binder method, to allow embedders to augment the set of interfaces. Bug: 660573, 755801 Change-Id: Ic5eacc544e4f1ab2a001d0b5757dcd6aa16199a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134694 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#757909}
-
Shawn Gallea authored
Allows user to test go back functionality. Bug: 1011977 Test: Run client, use back command. Change-Id: Ib07e48dd9e07211a9b2b8cf2199d9bc65e4df98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142571 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#757908}
-
Maksim Moskvitin authored
Histograms related to keystore migration investigation aren't recorded anymore, because Directory implementation of Nigori is disabled. There is no reason to re-introduce these histograms: we should have enough data already and it's better to avoid intoducing additional complexity in USS codepaths. Full clean-up (in particular removing NigoriMigrationTrigger and NigoriMigrationReason) isn't performed, because sync_encryption_handler_impl.* is a subject for removal in close future (crbug.com/970213). Bug: 1053267, 944831 Change-Id: I03d3e64e3ae3aed3594603210d6f7c11ed1c35a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141095 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#757907}
-
edchin authored
This CL creates two flags: 1) ShouldInstallManagedBookmarksPolicyHandler() checks the presence of a command line flag to decide whether to install the ManagedBookmarks policy handler. See below for explanation of the need to use a command line flag. 2) IsManagedBookmarksEnabled() checks a Finch feature flag to decide whether to show the managed bookmarks in the bookmarks UI. A Finch feature flag is used to act as a server-side kill switch. The policy system is initialized before about:flags or field trials, so it is not possible for either of those mechanisms to decide whether or not policy should be enabled at runtime. Instead, we will switch to looking for the presence (or absence) of a command line flag. This will allow us to easily turn policy on locally during development, and when we are ready to ship policy support, we can remove the command line flag. Bug: 1065187 Change-Id: I1aea8c106642ec86b422e4bb333294d05d3dba95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142752 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757906}
-
Jérôme Lebel authored
The selected identity in UnifiedConsentCoordinator should not be set to nil. This can happen when starting FRE with identity already known by the device, or when opening the sign-in view "Choose Another Account". Bug revealed by: crrev.com/c/2139666 Bug: 971989 Change-Id: I0ec051b195246d74c408de5d7d9f375c33b556ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144134 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#757905}
-
Katie D authored
This ensures that no matter how long the label is, only the bottom two lines will be shown. Also adds a browsertest and does some quick UX tweaks to color and placement to look more like Android. Bug: 1055150 Change-Id: I52fb46a77ecea0f32b2f7d8d1bda7899ae4d28fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139448 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#757904}
-
Peter Kasting authored
Bug: none Change-Id: Ib38b8ff2654cb13b6962afbb2b8a1bf6cb0b8f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143535 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#757903}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie916b28aed4b0c3b68ef55510f92ce4b5b5b1c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757902}
-
Bo Liu authored
Factor out code that manipulate profile directories into its own file, to prepare for upcoming changes to now deleting profile data work. There are some behavior changes: The cache directory is created on the UI thread on ProfileImpl construction, rather than lazily when first requested. Cache directory is likely to be requested soon after profile creation, so should not affect performance much. The cache directory is now empty for incognito. The return value is never actually used for incognito profile, so this should not change anything. Bug: 1065585 Change-Id: I06f86235be34f1bc30247004b57cf9c3762248f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140038 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#757901}
-
Daniele Castagna authored
Bug: None Change-Id: I6bde5f644956718be3a37701d178e6b99a8a1292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144256Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#757900}
-
Klaus Weidner authored
The feature is intended to be enabled by default, but a couple of code locations erroneously still checked for the "WebXR Incubations" flag which used to control it. Remove those conditionals. Bug: 1069279 Change-Id: Ic22339c736d32a47ba0ec848d15b9f9ad69c854a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142102Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#757899}
-
Allen Bauer authored
Bug: 1056944 Change-Id: I4a689b104eeb4dd666a8f05d276d5d5fd014566e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132960 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757898}
-
Jarryd authored
The installed apps warning out of the storage pressure UI project, so this CL puts the change behind a separate flag so that it can be launched independent of all the other storage pressure UI changes. Change-Id: Ibafa02d76e51e54f99e162bc24c69590f1aab916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138636Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757897}
-
Allen Bauer authored
Bug: 1056944 Change-Id: Iae93e42668f71cb4e750f43ac4778fb5e9a2998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112147 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#757896}
-
behdad authored
Skipping these tests: blink_perf.events/is-input-pending-all-events.html blink_perf.events/is-input-pending-default-events.html To stop failures on performance_test_suite. Bug: chromium:1069468 Change-Id: I8bc86a0271357a9497643c24ed902f5a23e5833e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144355Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#757895}
-