- 20 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603195140-e7f1aee2c0a50a929699520496ae0e25b15e94bf.profdata to chrome-mac-master-1603216608-7529e831dfcfdc3eeb93d3e8d9f23aaded5766b2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8661e5f7c72581521134d81c0f628afed44f136a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487809Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819076}
-
Karthika Pai authored
This is part of a migration that replaces the old <histogram-suffixes> syntax that was used to denote groups of histogram to the new patterned histogram syntax. Bug: 758782 Change-Id: Ieb7136dc5d8e59438d9d7fd28f5fa05c81beaa23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481464 Commit-Queue: Karthika Pai <karthikapai@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#819075}
-
Scott Violet authored
It wasn't clear whether the supplied parameter is a delta or absolute value. Hopefully this clears that up. BUG=none TEST=none Change-Id: Ic0921d209c1c11f125cdc6b8821d9bf265c8cd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487683Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819074}
-
Andrew Grieve authored
Change-Id: I0ea9cfaf68ec3dc68cc0fff456add47f1e6ab4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488382 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819073}
-
John Lee authored
Bug: 1105862 Change-Id: I84b07861bf1cc6485a07546347154e6cb9262c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443214Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819072}
-
Jeffrey Kardatzke authored
This will block usage of the CDM factory daemon on Chrome OS when in incognito or guest mode. This is required since a unique identifier is used in that implementation. BUG=b:153111783 TEST=Verified daemon is not used in incognito/guest mode Change-Id: Iba59659fe0e331f2f5f5e3bdfce4ff65895e4386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485144 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819071}
-
Jamie Madill authored
This config is very unlikely to ship and causes extra load on the team to maintain. Remove it for now. Bug: angleproject:5196 Change-Id: I48c6475eacfdb19af2dd664d228261225a13b784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485308Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#819070}
-
Tom Anderson authored
The SGIVideoSyncThread instance may be recreated on context loss. In this case, we need to detach the connection from the thread's sequence so that subsequent threads can reuse it. R=sunnyps Bug: 1139015 Change-Id: I9a151597582dcbb22cba87781e94c76a46346f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486286 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#819069}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2b85ad75ff5bfe9e972b09ca34a37583adef46b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488224Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819068}
-
Joon Ahn authored
Fixed: 1139523 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: I346a8e58d96cc10691ba1aea3eef6789844d5a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485696Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#819067}
-
Xing Liu authored
This CL plumbs creation time and reading list read status to Java. Also add an API in reading_list_manager.h to query the read status. Bug: 1139133 Change-Id: Ia6bad05c16136b453fc8db198448c5a38be24132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485342 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#819066}
-
Takumi Fujimoto authored
Move the sink ID to its own argument in the logger call so that it gets truncated properly. Bug: 1117673, b/170651374 Change-Id: I72d040078104d5f4ce15f15c26f34f542b3f5ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469438Reviewed-by:
John Williams <jrw@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#819065}
-
Wenyu Fu authored
Calls to FirstRunFragment#setInitialA11yFocus can be triggered when view is not initialized yet for the fragment and cause NPE with current implementations. This CL simply ignores the calls if it is made too early. More context on why #setInitialA11yFocus is introduced and why this fix might be sufficient can be found in the crbug.com/1140174#c2. Bug: 1140174 Change-Id: Ie7771e73a46bd30d1c0e0fa3e2e56c0e886c4d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487580 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#819064}
-
Kevin McNee authored
This test is flaky under tsan. Tbr: bcwhite@chromium.org Bug: 1061320 Change-Id: I2a0e47659ca84aadb8a4e139406f7e77ec4a0349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487844Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819063}
-
Nicolas Ouellet-Payeur authored
The DestroyProfileOnBrowserClose experiment (see go/destroy-profile-on-browser-close) changes profile teardown, and introduced a new crash. ExtensionRequestObservers should be destroyed before the Profile is destroyed, not during BrowserProcess teardown. Listen to OnProfileWillBeDestroyed() events for _all_ profiles, because they can get destroyed at any time. Previously, we only did this for some profiles. Bug: 88586, 1140492 Change-Id: I8657119ae36c763b6e2e515185f1d2f15586376c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485176 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819062}
-
Peter Boström authored
Does not address subfolders which will be done in separate chunks. Bug: 1128500 Change-Id: Id3caa97d0d59b4700b888c5bca5f89f69d4c64d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485148 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819061}
-
Sigurdur Asgeirsson authored
Includes 3 Stability.Internals.* and Suggestions.LocalBlacklistSize. Bug: 975530, 975251 Change-Id: I1fe13c53993d855c48b0869e2f47ad5037311dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487841 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#819060}
-
Salvador Guerrero authored
This CL modifies the trace events added in http://crrev.com/c/2229611 to used typed arguments. It also fixes a typo in an event name (OnDwmCompositionChanged -> OnDpiChanged). Change-Id: I04e5c125f1d68be1be2a19414cd363992b7a7b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472501 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/615063999dd2..4deb1ed9573d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com,mcnee@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117663,chromium:1140474 Tbr: reillyg@google.com,mcnee@google.com Change-Id: Ife957fccb764fb7c184730f6ef686c1e58c6c50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819058}
-
Kevin McNee authored
The filter file had these tests parameterized, when the tests themselves are not. Bug: 1137434 Change-Id: Ia344915cb70535f8ad6b429c51622d0f264dc85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488122 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#819057}
-
Matt Menke authored
Add NIK to the on-disk reporting and NEL information. Bug: 993805 Change-Id: I27b1242458e48423b7615effcee3de5afda916e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485253Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819056}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idb3f123f56aa73ead7470fcb33cff388baaf62ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819055}
-
Xing Liu authored
This CL adds download later task type to reduced mode support. Bug: NONE Change-Id: I18ecd78971fb57d1e12c6802798f05ad5a2c9af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461143Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819054}
-
Rouslan Solomakhin authored
Before this patch, creating two payment credentials in Touch ID with identical instrument display name and relying party would erase the first credential, so it could no longer be exercised. This patch uses a random 32 byte array instead of instrument display name as the user identifier. After this patch, a relying party can create a large number of payment credentials with identical instrument display name, so all of them can still be exercised. Bug: 1139040 Change-Id: I68895c4b7d6bb64afa1f44e2b30a613ab6293023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487220Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819053}
-
Dave Tapuska authored
The PPAPI broker code was removed in http://crrev.com/1d71c85 but it left the IPC message definitions around. Remove them. BUG=1064652 Change-Id: I5336c64a53736ef28749a7570f267eaf490f620d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485543Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#819052}
-
Ben Kelly authored
Bug: 1140514 Change-Id: I5205c1e7305e823203d3015efd9eefd54f10bbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486410Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#819051}
-
yilkal authored
Provide user's email during reauthetication for the edu-coexistence flow. Bug: 1131174 Change-Id: I48407f942c05b0893ebba298a7eb713c77135757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468797 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819050}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b1ac88b6534f..c55cd6b43d55 2020-10-20 syoussefi@chromium.org Vulkan: Remove dead path in clear 2020-10-20 lehoangq@gmail.com Metal: Auto detect parent layer's contentsScale change 2020-10-20 lexa.knyazev@gmail.com Metal: Skip redundant clamp of stencil ref value 2020-10-20 lehoangq@gmail.com Metal: Remove no longer needed precompiled shaders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I8da42ea59671db04d80d639dc3c088ac9b8948fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819049}
-
Aaron Colwell authored
Removing proxy creation code that wasn't getting called, because we always create proxies for speculative RFHs since r501081. Also removed related logic that appears to have only been there for proxies that were created in this function. Bug: 1015882 Change-Id: I22c9a735254c3e2cf0068c9914ab66815a40dd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481905 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819048}
-
Dylan Cutler authored
By guarding the instrumentation on the condition causing the DCHECK, we should be able to avoid the flakes that are happening due to http://crrev.com/c/2472528. Bug: 1139738 Change-Id: If9076e9dc446ecb83816978abe40ba14ffc63a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485517 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819047}
-
Peter Kasting authored
Bug: 772945 Change-Id: I0ade53423cfb13df5ac78914ab2a42b022567587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466819 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819046}
-
Andrew Grieve authored
Depending on a java target from a native target doesn't do anything. Change-Id: I01e2b75f93c95219a02f23f3da4d3d7878726f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488381 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819045}
-
Karthika Pai authored
This is part of a migration that replaces the old <histogram-suffixes> syntax that was used to denote groups of histogram to the new patterned histogram syntax. Bug: 758782 Change-Id: Ide054101bd01cb64d697106fb5ec85b88137c1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476609Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karthika Pai <karthikapai@google.com> Cr-Commit-Position: refs/heads/master@{#819044}
-
Finnur Thorarinsson authored
Bug: 1135551 Change-Id: Ie82e10e722e5c9cd5d417ed247c1e09de80cc52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485169 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819043}
-
Liquan (Max) Gu authored
Context: DimmingDialog#show() could throw BadTokenException which is an Android internal programming error. To work around this issue, DimmingDialog#show() catch this exception and uses its return to indicate the failure to PaymentUiService. When the failure happens, close the PaymentRequest and report the error to the user. Bug: 1139441 Change-Id: Ia2a23b61b249c25d068e201be0a41b1d57ebf249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484043Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819042}
-
Andrey Kosyakov authored
This triggers Fetch.requestPaused if we get a network error through URLLoader::OnComplete() instead of network response. Bug: b/170901677 Change-Id: Ieb1a7beafa627dd17b130494c6daba47948d57c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478143Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819041}
-
Anders Hartvoll Ruud authored
Change-Id: Ic049d5d75cc399b98223ff469ad2c2c55ce231dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484797Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#819040}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iaf3ba962a4cec440d9740798f0663aef3a8b8709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488001Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819039}
-
Geoff Lang authored
Use GL_ANGLE_get_tex_level_parameter to detect when the texture about to be allocated for YUV copies in YUVToRGBConverter will be a no-op, avoiding potential re-allocation costs. Bug: chromium:1132514 Change-Id: I1fabe4e44f92009250a82318cffa962be65b3560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476413Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819038}
-
Alex Turner authored
base::Bind is deprecated and should be replaced with more explicit calls. ThemeService only has a single use, which can be converted to the preferred BindOnce. Bug: 1007635 Change-Id: I83d7af39bbf6be73262c024972df6b3652574e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487840Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819037}
-