- 09 Jul, 2020 40 commits
-
-
Brandon Walderman authored
This change updates JavaScriptTests.testAllJS to use a smaller window size of 640x480. get_element_location_test.html has been updated to take the smaller viewport into account. This change also updates ChromeDriverTest.testActionsMouseDrag to run safely on a smaller screen by making the drag actions a little smaller. I've verfied that the tests now run successfully on the impacted test environment. See bug for details including failed test logs. Bug: 1103391 Change-Id: I5d0284c187a7dd41b91857af102f7f6458d266fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288279 Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786874}
-
Yves Arrouye authored
This CL treats a value of 0 for the check_enrollment RW VPD key as a signal to do an initial state determination (a.k.a. initial enrollment in the code right now). If the value is 1, it still does an FRE check. This change allows for multiple initial state determinations that can bring up the proper OOBE for license packaging (LP) as well as for zero-touch enrollment (ZTE). Writing check_enrollment=0 to the RW VPD is effectively made a no-op now. We do not clean all the places in the code that write this value in this CL in order to make it smaller. This can be done easily in a followup CL. See go/cros-oobe-state-determinations for design. --gtest_filter="*Wizard*WithInitialEnrollmentTest*" Bug: chromium:1103006 Test: xvfb-run -s "-screen 0 800x600x24" out/Default/browser_tests \ Change-Id: Ia3f60cee26dbe0fc8c81818c04c483e50ac7aaaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285517 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786873}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/08a294d37693..6cd27bab06f4 2020-07-09 capn@google.com Remove unsupported formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic5d345403ac8b8c50bae89733562193356239379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786872}
-
Panos Astithas authored
Bug: 1101179 Change-Id: I4c4bad5bede356bd34601c3972beefa935c77719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286474Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Panos Astithas <pastithas@google.com> Cr-Commit-Position: refs/heads/master@{#786871}
-
Tim Volodine authored
SyntheticInputTest.SlowSmoothScrollWheel test is flaky on Android bots. Failed recently on Lollipop Phone Tester, see crbug.com/1103731. BUG=1103731 TBR=bokan@chromium.org,sadrul@chromium.org Change-Id: I7bc8a98daf7f192eed6f0f7ef7d3ad4ca9b14900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288706Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#786870}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594295624-67e0cea334ff513a5ec88ee6203327adbc5924fc.profdata to chrome-mac-master-1594317395-ab4c4d7824bf93337da7afe44e0cee387faf7ba7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8ecb5e914432d4403036183b2d7812127f247869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289656Reviewed-by:
-
Ali Juma authored
This CL moves real-time lookup logic from safe_browsing_url_checker_impl_content.cc to safe_browsing_url_checker_impl.cc, so it can be used on iOS. Only WebUI-related logic remains in the content-specific file. This CL also makes SafeBrowsingUrlCheckerTests run on iOS. Bug: 1103218 Change-Id: I9ee4eda4b90d10d75890e213c13e244607e1523c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288205Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#786868}
-
danakj authored
Either the renderer sends it, or the browser generates it. R=avi@chromium.org Bug: 866140 Change-Id: I3691825760ce2e8d260de856a8d3756206df1c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289387 Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786867}
-
Pete Williamson authored
This implements the new sendFeedback API to allow clients to send feedback. Bug: 1099504 Change-Id: I3790094588726b602890c04e6473826d54c3a303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276685 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786866}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594295624-be812e379d7ce03c92153266b9fb8c9180f5e5ee.profdata to chrome-win32-master-1594306414-ea59bc3a1c9fdf908bc858e60c651b9b15bf1190.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie33ee7ac5727cc06e3a132398cb479323de069ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289906Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f1d7aa48. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/layout-instability NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I32387f6c3857a887acd0794bd332b82137cd585c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289615Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786864}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/196515cbd749..9e8f484499bd 2020-07-09 johnstiles@google.com Rename 'analytic FPs' to 'analytic elements' throughout the clip system. 2020-07-09 michaelludwig@google.com Remove unused GrTRecorder 2020-07-09 jvanverth@google.com Fix GrMeshTest for Direct3D. 2020-07-09 johnstiles@google.com Clear analytic FPs and clip paths in GrReducedClip::makeEmpty. 2020-07-09 johnstiles@google.com Count analytic FPs directly. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097538,chromium:1102804 Tbr: mtklein@google.com Change-Id: I23850d61a782b474e0bcf82549114e191fbcc62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289905Reviewed-by:
-
Mohamed Heikal authored
To prevent issues where multiple android_resources targets have the same R.java package, java_library_impl can be configured via "resources_package" to generate its own R.java (for all transitive dependencies) rather than using the srcjars provided by its direct android_resources targets. Prebuilts no longer create R.java srcjars. Instead, you either need to depend on the prebuilt from an android_resources target (soon to be deprecated) or add a resources_package to your android_library target so it generates a comprehensive R.java for all your target's dependencies. Bug: 1073476 Change-Id: If06dab74c1d9763a93ffec552caded284d4725a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281034Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#786862}
-
Peter Wen authored
This makes it easier to land chromium-wide build changes, as build/OWNERS will be able to review all build-only changes. This change will reduce the number of TBRs for wide-sweeping build changes. Note: per-file globs applies recursively to subdirectories. Bug: None Change-Id: I916a737f89518bcaf44bf6ee3001461779576c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289910 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Joey Arhar authored
TBR=danakj@chromium.org Bug: 1103759 No-Try: true Change-Id: Ie83d9840697f4c08cbb1eaf817af61d8d5ef3da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290252 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#786860}
-
Peter Boström authored
Adds a few missing WARN_UNUSED_RESULTs to methods returning the PropertyChangedSubscription type. This prevents accidental no-op callback registrations where the unique_ptr returned is immediately free'd and the callback never called. Bug: chromium:1103707 Change-Id: I626954d0be0637f8fa3b28668954678c7bffaaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289916Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#786859}
-
Christopher Cameron authored
When pixel data is provided, rather than upload it using OpenGL, copy the data directly into the IOSurface. This is very similar to the SharedImageBackingFactoryAHB method, and merging should be considered at some point. Bug: 894929 Change-Id: I383e188c2c463d0e12e024bbfd61eea1c3045331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275357 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786858}
-
Roger Tawa authored
Bug: 1096060 Change-Id: I055fc9ea1470b0e8e1049e6527841e375f79ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284397 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786857}
-
danakj authored
This reverts commit 4c4908c9. Reason for revert: Fail cause was reverted. Original change's description: > Sheriff: Mark document-policy-oversized-images.php as failing > > Using other build sheriff as tbr > > TBR=nektar@chromium.org > Bug: 1103712 > > Change-Id: I93841cfdbea95d261a146d8aaff5cdaed8ab0cfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290072 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786826} TBR=jarhar@chromium.org Change-Id: I38df620c01d34d8c118fdce6fba700293ea27932 Bug: 1103712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289217 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786856}
-
Chris Harrelson authored
Replace existing callsites with SetSubtreeShouldDoFullPaintInvalidation or SetShouldDoFullPaintInvalidation. Change-Id: I639107242f9401d8d6445302339a4197ee978035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289073 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786855}
-
Daniel Murphy authored
This change attempts to deflake the test by not starting sync until after the WebApps are both installed. R=loyso@chromium.org Bug: 1097534 Change-Id: Ia64935151874059d007da5643023937bf047abbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285178 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#786854}
-
Victor Fei authored
https://crrev.com/c/2242046 introduced IItemContainerProvider::FindItemByProperty for unique id only for when start_after_element=nullptr only. Since start_after_element caller can pass a non-null ptr for FindItemByProperty, we need to properly handle this case. This CL implements FindItemByProperty using unique id when start_after_element is not null. https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nf-uiautomationcore-iitemcontainerprovider-finditembyproperty Moved MockIRawElementProviderSimple from ax_platform_node_textprovider_win_unittest.cc to its base test class ax_platform_node_win_unittest.{cc/h} to be shared across win unittests. AX-Relnotes: ATs will be able to lookup an UIA element from an IA2 element with the start_after_element parameter. Bug: 1098160 Change-Id: I7b67a85827bb6e6233b71a7fb262c6000ec737a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277057 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786853}
-
Wojciech Dzierżanowski authored
As determined in issue 958324, current time can be infinite and thus OnTimeUpdate() must be prepared to handle this case gracefully. Bug: 1103278 Change-Id: Ib6fb836b06227bd9735c6b7122249f0f9b96f26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288562 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786852}
-
Alexander Hendrich authored
These behavior features can then be used in the permission features (or other behavior features) as dependencies to avoid having to duplicate the same whitelist every time. Bug: 1100979 Change-Id: Ia5c6e4264e5091972da8f78db1ba47ce9d41db4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275878 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786851}
-
Sean Gilhuly authored
Dawn is auto-rolled into Skia, and Skia has CQ build coverage for Dawn. Enable building SkiaRenderer with the Dawn D3D12 backend on Windows. Usage of the feature is still behind the runtime feature flag --enable-features=SkiaDawn. The Windows CQ bots aren't able to initialize Skia Dawn, so the gtests that use this path shouldn't be included in the build by default. Add 'enable_skia_dawn_gtests' to keep these tests enabled on the Skia Dawn FYI bots. Bug: 1071455 Change-Id: If1fb98993160078250e9b73dbec90d7f42121850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246855Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#786850}
-
Xianzhu Wang authored
We should test visual rects in unit tests (we already have). Only one test used the API. Convert the test into a normal repaint test. Change-Id: I3eabd3bb39f5db4108d447017949db9d9839cd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289915Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786849}
-
Jordan Bayles authored
These logs are sent to infrastructure that is turned down and no longer used, so the SessionMonitor and its related code are deleted. However, the SessionMonitor also included some features to query the receiver for its setup information, including build version and the receiver's friendly name. This information is used by the session in order to apply hacks for different Chromecast versions. This patch adds a new ReceiverSetupQuerier class that contains the setup information code, as well as an updated and expanded unit test class for the querier. See https://chromium-review.googlesource.com/c/chromium/src/+/2240910. Bug: 1015471 Change-Id: I700ae27e3241e4d0e9a997d5fbeee43d011dd4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261394 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786848}
-
Ian Kilpatrick authored
This patch introduces one "large" object at the end of NGPhysicalBoxFragment which contains all the "very rare" fields which we typically don't see. (currently MathML painting information, and OOF fragmentainer descendants) There should be no behaviour change. Change-Id: I252d2461b0346cd4ab03978188d392eca0ed1417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284150Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#786847}
-
David Bokan authored
In https://crrev.com/7bf3fbf5532b7 we implemented page-based granularity scrolling in the compositor scrolling path. However, this path isn't used in production yet. There was a small bug in that CL where we convert the scroll delta to a percent but then call ResolveScrollPercentageToPixels with the originally passed in |scroll_delta| rather than the modified |pixel_delta|. This is caught by web tests like fast/events/platform-wheelevent-paging-x-in-scrolling-page.html but this test suite currently routes all input to the main thread, hence why it wasn't caught. This CL also adds a unit test to make this easier to catch. This CL also fixes an inconsistency between main and compositor threads in that the viewport rect used to calculate the amount of scroll includes scrollbars on the main thread but excludes them in the compositor. This CL makes it so that we always exclude scrollbars and fixes the wheelevent-paging test to verify this behavior. Bug: 1082589 Change-Id: Ic8723c4d80750570f823899518190b0ff680cff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281320 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786846}
-
Kyle Milka authored
If the user hasn't granted storage permission prompt them for it before downloading. If the user has asked to "don't ask again", replace the Download button with a link to open settings. Bug: 1099426 Change-Id: Ib0e998b9c85ff6b15e764d90d923e062b4068406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276641Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#786845}
-
Anqing Zhao authored
The browser test KioskVirtualKeyboardTest.RestrictFeatures was flaky before it was disabled. After investigation, it is found that the keyboard config vary in each run because the KeyboardController is a singleton and could be changed by other test case. To solve this problem, the additional reset logic is to be added at the beginning of test to make sure the initial config values are as expected. Bug: 10948093 Change-Id: I6929ee97a7a31327f98e45cbb5a7d0fd9742b2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289421Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/517f81e0a410..60ed45996279 2020-07-09 handellm@webrtc.org Migrate a leftover in test/ to webrtc::Mutex. 2020-07-09 eshr@google.com [Adaptation] Move AdaptationConstraints to VideoStreamAdapter 2020-07-09 handellm@webrtc.org Reland "Migrate test/time_controller to webrtc::Mutex." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I93b3ba7950ad0b0684ac67843bbba54fd67a325e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289907Reviewed-by:
-
Fredrik Söderqvist authored
Rather than casting to double and then clamping to int, perform a clamped add. Change-Id: Iad26ba3429b723a70b40c5edd632e82bf3202db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289839 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#786842}
-
Morten Stenshorne authored
The spec isn't crystal clear, but unconditionally considering spanners that are siblings of another spanner's ancestors as adjacent is definitely wrong. We need to resume column content layout inside the parent block of the spanner, since it may have a fixed block-size, block-end padding / border, or anything else that we'd just lose otherwise. This breaks one existing (non-WPT) test, but I'm not convinced that the test is valid. Filed crbug.com/1100849 for it. It also fixes 3 WPT tests. They were all quite complex, so I added a couple of simple ones, that demonstrate this fix more to the point. Bug: 829028 Change-Id: I9d55153f859dd84a5019e7d4dd09453f7f9ee1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290150Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#786841}
-
Reilly Grant authored
This changes converts the remaining instances of base::Callback in the BluetoothDevice interface to base::OnceCallback. There should be no functional change. Bug: 834319 Change-Id: I194e1bf3e0b88338dae51423c72e75ff860a34fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288841 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#786840}
-
danakj authored
TestRunner can track all main frames already, and now can track any RenderViews in the process as well. This is toward removing the overlapping responsibilities of TestRunner and TestInterfaces. However TestInterfaces still sets the "main view" and the "main view's" BlinkTestRunner on TestRunner in awkward ways that are not very compatible with swapping the main frame during or between tests. This CL isolates that code further in order to approach deconstructing it. R=avi@chromium.org Bug: 866140, 1069111 Change-Id: I6e2aa1bb2b9a53fdc3a407eef51d2384e386b8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290075Reviewed-by:
-
Fredrik Söderqvist authored
Rather than calling EnsureInvalidationSet() and performing another lookup in |map|, just use the |slot| that we already have and call EnsureMutableInvalidationSet(). Also change to move the invalidation set into |slot| if it is empty. Change-Id: Ibefdf3ac7ef13fd3b7e05e4086405a0b980603f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289838 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786838}
-
Maksim Ivanov authored
Add ability to wait until the extension gets loaded into the ExtensionForceInstallMixin. Migrate the tests in signin_profile_extensions_policy_browsertest.cc to this new functionality. Bug: 1090941 Change-Id: Icdc2517fd40ad7a1714c16629d6904d928451f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283144 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#786837}
-
David Bertoni authored
These IncognitoApiTest tests were disabled a long time ago for flakiness, but they passed 3000 iterations on the bots with no issues. Bug: 89054, 120484 Change-Id: I59b22ef5f7daa6d040279d388a2f4d90770c9f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270687Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786836}
-
Ken Rockot authored
This reverts commit 865d1b47. Reason for revert: There are clear signs of performance regression particularly around GPU IPC, and addressing them with a dedicated Mojo thread is probably not going to be worthwhile in the near term. See associated bug for details. Original change's description: > Reland "Add MojoDedicatedThread field trial testing config" > > This is a reland of 6eda333b > > The test-only bug which elicited the revert has been fixed, > so this is relanding the original CL unmodified. > > Original change's description: > > Add MojoDedicatedThread field trial testing config > > > > Bug: 1082761 > > Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407 > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Commit-Queue: Ken Rockot <rockot@google.com> > > Cr-Commit-Position: refs/heads/master@{#777367} > > Bug: 1082761 > Tbr: asvitkine@chromium.org > Change-Id: Icefe444d49199e402a772775f687374b7c14b1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264732 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#781943} TBR=rockot@google.com,asvitkine@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1082761 Change-Id: Ib65a4a5170638399e8debdad728e8a38cc7a746f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289406Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#786835}
-
