GitLab

Bug: 909799
Change-Id: I9fdeec4f569d7ee272f8a384012fec3a201908eb
Reviewed-on: https://chromium-review.googlesource.com/c/1354220Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611793}

This patch mimics the style code in that it tries not to propagate the
invalidation up the container chain if the element is locked for display

When the lock commits and the element needs layout, then it marks
the ancestor chain so that the code can reach it in layout.

R=chrishtr@chromium.org, mstensho@chromium.org

Bug: 882663
Change-Id: I499e91e6a14f61e5dfbeae74d3c93ac8b321e944
Reviewed-on: https://chromium-review.googlesource.com/c/1344825Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611792}

APIs that have Ash dependencies can only run on ChromeOS so bind them
only when building for ChromeOS. This allows EXO to build on Chromecast.

Bug: 896710
Test: None
Change-Id: I60acf956b5a0f682f89c97b5818bb54cefcc7113
Reviewed-on: https://chromium-review.googlesource.com/c/1328702Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611791}

Bug: 903983
Change-Id: If4a6bdd236a82267e4b8302992dc9c0d3b3a8cc0
Reviewed-on: https://chromium-review.googlesource.com/c/1344908
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611790}

This CL lets FindInPage support searching over multiple HTML Nodes, and
adds a unittest case for that.

Bug: 228585
Change-Id: Iec2715034bebb36afcf9160e2bad6c4276ca8008
Reviewed-on: https://chromium-review.googlesource.com/c/1352153
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611789}

Removing unused histogram value:

  WebCore.IndexedDB.LevelDB.Transaction.CommitTime

Bug: 902193
Change-Id: I0274825b6ca8a289e86166b070bfba68382b87fd
Reviewed-on: https://chromium-review.googlesource.com/c/1351484
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611788}

Bug: 898868
Change-Id: I067bf23c3838c6a7576dc91b090f79c12ce798ea
Reviewed-on: https://chromium-review.googlesource.com/c/1351427Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611787}

After this change there are no more callers. The next cl will remove the implementations of that
method.

Bug: 908955
Change-Id: Ie424e9d6be5d6bb8702962198c61e718968ac2a7
Reviewed-on: https://chromium-review.googlesource.com/c/1352510Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611786}

This patch implements touch-action rects in composite-after-paint by
generalizing the ScrollingCoordinator UpdateLayerTouchActionRects
function to work with both SPV1 and SPV2.

Several tests are failing due to cc::Layer::position being zero,
though the touch-action rects are correct. Expectation entries have
been added for these.

This patch also reorders some lines in internals.h. This was found in
the review of http://crrev.com/611376 but was mistakenly left out when
the patch landed.

Bug: 909749

Change-Id: I9d66ebdfef25d46388ce5740121a7b4844de1ca5
Reviewed-on: https://chromium-review.googlesource.com/c/1351802
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611785}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/703305b1a5a2..3ee605d7ccb9


git log 703305b1a5a2..3ee605d7ccb9 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 zoddicus@users.noreply.github.com Ensure that only whitelisted extensions are used in WebGPU (#2127)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@3ee605d7ccb9

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I4388244673ad41cef1c8e72be31a15252d393815
Reviewed-on: https://chromium-review.googlesource.com/c/1352802Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611784}

This CL removes ConsentBumpFragment and ConsentBumpMoreOptionsFragment
and the code that was only used by these fragments.

Bug: 909649
Change-Id: Id9be789a5542ecc9d0f73581801bf7eaaf0426a3
Reviewed-on: https://chromium-review.googlesource.com/c/1352781Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611783}

https://chromium.googlesource.com/catapult.git/+log/17079a5cc1f2..6457c042bc7b


git log 17079a5cc1f2..6457c042bc7b --date=short --no-merges --format='%ad %ae %s'
2018-11-27 bpastene@chromium.org devil: When setting flags on the device, log the file location.
2018-11-27 perezju@chromium.org [soundwave] Finish merging soundwave.dashboard_api into dashboard_service
2018-11-27 perezju@chromium.org [soundwave] Move timeseries (v1) API to dashboard_services
2018-11-26 eyaich@google.com Create method to add shared diagnostics to histograms not created through tbmv2


Created with:
  gclient setdep -r src/third_party/catapult@6457c042bc7b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:907899,chromium:890691,chromium:890691,chromium:714231
TBR=sullivan@chromium.org

Change-Id: Ib6bd9c1d01e778e980d316e2889cc6a3f92d315d
Reviewed-on: https://chromium-review.googlesource.com/c/1352712Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611782}

When a SecureChannel disconnects due to authentication failures,
BleConnectionManagerImpl invokes the relevant failure callback, which
then causes ConnectionAttemptBase to cancel the connection attempt.

When the attempt is cancelled, the SecureChannel object is deleted via
BleConnectionManagerImpl::ProcessPotentialLingeringChannel(), but
BleConnectionManagerImpl::HandleSecureChannelDisconnection() assumed
that the object was still valid and tried to to remove itself as an
observer, causing a segfault.

The fix is to check whether the object has been deleted before
attempting to call RemoveObserver().

Bug: 905904
Change-Id: Ic593ef4047ff481e218c89028324eb0863131cdc
Reviewed-on: https://chromium-review.googlesource.com/c/1352855Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611781}

Currently ash_perftests fails to build due to undefined symbol
errors of keyboard::mojom::KeyboardConfig::KeyboardConfig() in
ash/public/cpp/test/test_keyboard_controller_observer.cc

Bug: none
Test: autoninja ash_perftests
Change-Id: Ib6c8ecd34295269ee27a1f63eb62f2c7a582f006
Reviewed-on: https://chromium-review.googlesource.com/c/1352044Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611780}

This CL fixes the Settings EG tests by calling [super tearDown].
It also fixes the Autofill profile tests by scrolling the view if
needed to find the element. This is because the new cells are slightly
bigger and not fully displayed now.

Bug: 909765
Change-Id: Ia8aae51529da054d902c11b3d640dcc344532943
Reviewed-on: https://chromium-review.googlesource.com/c/1353930Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611779}

This change prevents unhighlighting if the anchor button has not changed. Highlighting was added to a button when a widget is anchored to that button. On entering fullscreen, a widget's anchor is reset regardless of whether it was changed. This would unhighlight then rehighlight the button but only be noticable on Mac.

Bug: 905992
Change-Id: I4989a45101c704105f5b4a572e028c851b6165b7
Reviewed-on: https://chromium-review.googlesource.com/c/1351106
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611778}

Follow-up CL fixing a leak identified post check-in.

Bug: 902041
Change-Id: Ic900c107f13185fa8c823163b2278990ed543ff2
Reviewed-on: https://chromium-review.googlesource.com/c/1352030Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611777}

Delete three policies that causes issue or confusion on Admin Console.
ReportMachineIDData
ReportUserIDData
ReportVersionData

Remove policy migrator as it's not used by local reporting and
cloud reporting policies are going to be decoupled from the extension
policies.

Tbr: karandeepb@chromium.org
Change-Id: I5fcfa665aee3899dbd0d446427af2c4821de13fc
Reviewed-on: https://chromium-review.googlesource.com/c/1351288
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611776}

Updates Model and RandomTreeTrainer to use TargetDistribution
instead of Model::TargetDistribution.

Change-Id: I0e1a28dc78d5716aa54fd4d1061e86975e4815db
Reviewed-on: https://chromium-review.googlesource.com/c/1352056
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611775}

MediaPipelineBackendWrapper can now be revoked. After
being revoked, it still response to the application, but
release the real MediaPipelineBackend.

When new CmaBackend is to be created, if there is an existing
CmaBackend, the existing CmaBackend will be revoked so the
new CmaBackend can be created successfully.

Bug: internal b/69180616
Test: 1.Successive flings can now success even with
ENABLE_EXTENDED_SHUTDOWN feature flag enabled.
2.Cast a few different applications, including "cast and stop",
"cast a different app when the old app is playing", without issues.

Change-Id: I79d15542ae9b1c15565945e0098859e76ca76ab8
Reviewed-on: https://chromium-review.googlesource.com/c/1320204
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611774}

Added in https://chromium-review.googlesource.com/c/chromium/src/+/1351806

TBR=dmazzoni@chromium.org

Change-Id: I8f52d6f3ae9248e59780ff16c483583656e44f2f
Reviewed-on: https://chromium-review.googlesource.com/c/1351142Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611773}

This is to match the style in the latest UX mocks for desktop IPH.

Bug: 887991
Change-Id: I59326fe8012039ba765b2af5de9dd97dcd710bb3
Reviewed-on: https://chromium-review.googlesource.com/c/1345209Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611772}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: Ib22a139e17450b34471a19a9ba46504fe0c1be5e
Reviewed-on: https://chromium-review.googlesource.com/c/1352755Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611771}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I6065320160279528dd1a2e77269ab94e86c6a5c8
Reviewed-on: https://chromium-review.googlesource.com/c/1353887Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611770}

This reverts commit ec18ec70.

Reason for revert: the conversion was incorrect as the new API
is not yet implemented. This probably causes regressions (sad
that no tests caught this) and spam logs (see crbug.com/909712).

Original change's description:
> Convert startup_tab_provider.cc to IdentityManager
> 
> It was using the SigninManager API to check whether the primary
> account was authenticated and an authentication was in progress. We
> can use the IdentityManager and PrimaryAccountMutator APIs to perform
> the same operations.
> 
> Bug: 890801
> Change-Id: Ia2567a567481a4d67b68eee6b714aab72c537b5a
> Reviewed-on: https://chromium-review.googlesource.com/c/1346467
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Sergio Villar <svillar@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#610389}

TBR=ellyjones@chromium.org,blundell@chromium.org,svillar@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 890801
Change-Id: I8df5a79a40c503abd6dd74974a84eded8f69472a
Reviewed-on: https://chromium-review.googlesource.com/c/1353980Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611769}

https://chromium.googlesource.com/webm/libvpx.git/+log/ac3eccdc24bc..615922dfb531

$ git log ac3eccdc2..615922dfb --date=short --no-merges --format='%ad %ae %s'
2018-11-27 marpan vp9-svc: Add check/reset for long term reference.
2018-11-27 jianj vp9 svc: copy block if ref buffer in denoiser is NULL.
2018-11-27 jingning Replace deprecated scoped_ptr with unique_ptr
2018-11-26 johann.koenig rename quantize_x86.h
2018-11-26 marpan vp9-svc: Put check on usage of long term temporal ref.
2018-11-26 jianj VP9 SVC: fix crash on scaling partition.
2018-11-26 marpan vp9-svc: Fix to skip enhancement layer setting
2018-11-26 jingning Fix ARF rate allocation for cq mode
2018-11-21 marpan vp9 screen-content: Keep lower step_param for quality layers.
2018-11-21 angiebird Fix scan_build warnings in user_priv_test.cc
2018-11-21 marpan vp9 screen-content: Adjust seach step param
2018-11-20 angiebird Fix scan_build warnings in tiny_ssim.c
2018-11-20 angiebird Fix scan_build warnings in convolve_test.cc
2018-11-20 angiebird Fix scan_build warnings in vp9_loopfilter.c
2018-11-20 angiebird Fix scan_build warnings in variance_test.cc
2018-11-20 angiebird Fix scan_build warnings in vp9_resize.c
2018-11-20 angiebird Replace assert by ASSERT_TRUE
2018-11-19 angiebird Fix scan_build warnings in temporal_filter_test.cc
2018-11-19 angiebird Fix scan_build warnings in dct_test.cc
2018-11-20 jianj Disable partition scaling on 1080p and above.
(...)

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

BUG=b/119097707

Change-Id: I89c3b7dedfc7d6abc25fa2ded3c7754349f3e023
Reviewed-on: https://chromium-review.googlesource.com/c/1352974Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#611768}

Some blink public interfaces used size_t then truncated on the calls
internally to int. Use size_t throughout call graph.

BUG=879657

Change-Id: I3c124524c2e969b65e662a30d0c8898d9d4e01a5
Reviewed-on: https://chromium-review.googlesource.com/c/1354061Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611767}

This reduces some setup and layer plumbing because the WebSandboxSupport
is now implemented on top of Mojo.

Change-Id: Ib969ce301963151d6abb048aaa0319283b987b57
Reviewed-on: https://chromium-review.googlesource.com/c/1351727Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611766}

Bug: 908573
Change-Id: I3c971f449c1db305ae8aeb31d0678e949dc303e9
Reviewed-on: https://chromium-review.googlesource.com/c/1351741Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611765}

Use identity::IsUsernameAllowedByPattern() instead so that we can migrate
those consumers entirely to the IdentityManager in follow-up patches.

Also, in order to make it explicit that this API should not be used any
more, make SigninManager::IsAllowedUsername() a private method and friend
it with the relevant test cases from SigninManagerTest, so that it can
only be used from there. And while at it, also remove some stale lines
"friending" SigninManager with test cases that no longer exist.

Bug: 890794, 890815, 906085
Change-Id: I2a5be231ff70d3e390aa1718c795aef9d8b255ff
Reviewed-on: https://chromium-review.googlesource.com/c/1353894Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611764}

This patch adds the infrastructure to allow the omnibox suggestion
list to support custom view types. A view type is registered with the
adapter and the mediator is responsible for specifying the type of
view to be displayed.

Bug:909779

Change-Id: I2e3e6905fbf7e44d991c536134511e311078d1db
Reviewed-on: https://chromium-review.googlesource.com/c/1340947
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611763}

R=dpranke
CC=inferno, hans, thakis, metzman, mmoroz

Bug: 893614
Change-Id: I24c0da4da030bf2139d29a8088526e450262cc8c
Reviewed-on: https://chromium-review.googlesource.com/c/1351140Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611762}

https://skia.googlesource.com/skia.git/+log/d437c79ed036..6616efbdebd2


git log d437c79ed036..6616efbdebd2 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 egdaniel@google.com In Vulkan, use 1000 for maxLod instead of maxMipLevel when using mips.
2018-11-28 borenet@google.com Use LUCI trybots in update_meta_config
2018-11-28 reed@google.com rm SK_SUPPORT_LEGACY_TEXTBLOBBUILD_WITH_PAINT from fluter
2018-11-28 reed@google.com rm SK_SUPPORT_LEGACY_NESTED_HINTINGENUM from flutter


Created with:
  gclient setdep -r src/third_party/skia@6616efbdebd2

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: I0a97627da750bf829da129f425264f4a25ee5ac2
Reviewed-on: https://chromium-review.googlesource.com/c/1352803Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611761}

The new ID will be used to identify the corresponding client-side controller object (e.g. Android Window).

BUG=b:118842548
TEST=exo_unittests

Change-Id: Ifedfa236db19b57ea00947fce339f84d397bf57f
Reviewed-on: https://chromium-review.googlesource.com/c/1335079
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611760}

Bug: 894499
Change-Id: I698b51eac47cdb7af63e4bb2ace338f87c5e7493
Reviewed-on: https://chromium-review.googlesource.com/c/1351779Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611759}

Bug: None
Change-Id: I10debc9f1636250545b4bf9508d2df7ecf0e62e1
Reviewed-on: https://chromium-review.googlesource.com/c/956234Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611758}

We previously use other hit test data providers whenever there is one
created, regardless of whether we enable VizHitTestSurfaceLayer or not.

This makes the flag no longer effective in some conditions as we can
create a draw quad hit test data provider arbitrarily sometimes. It
accounts for the async hit testing of approximately 1% of all hit
testing requests when VizHitTestSurfaceLayer is enabled.

This patch makes us use layer tree hit test data when the flag is
enabled.

Bug: 901882
Change-Id: I833b693368721b09e1d2922274d21170a24125d7
Reviewed-on: https://chromium-review.googlesource.com/c/1348949
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611757}

Since BooleanValue cannot actually throw, the Maybe version of the
function is now deprecated.

Bug: v8:7279, v8:8238
Change-Id: I8ec2cf1a305fdcf79681a8b39db4728f205428c4
Reviewed-on: https://chromium-review.googlesource.com/c/1353938Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611756}

It should be shown only if:

- The feature is enabled
- The user is not syncing
- The user has server cards
- The user has not already opted-in
- The user is in sync transport mode for Wallet

The last point is checked implicitly by the fact the the user is not
syncing and has some cards.

Bug: 909026
Change-Id: Id0976ea98a2be295968f825f1269888b3d820f0d
Reviewed-on: https://chromium-review.googlesource.com/c/1351944
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611755}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I43de3ccb29bcb978c0a426094e996638b352d8ea
Reviewed-on: https://chromium-review.googlesource.com/c/1352762Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611754}