- 25 Jul, 2020 8 commits
-
-
Nate Chapin authored
Bug: 1107442 Change-Id: Ifc0d515e10bb73a3217dd6164aded10731e126ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316805 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791315}
-
Mario Sanchez Prada authored
Instead of having this element owning the embedding token matching the same embedding token for the iframe/inner web contents owned by such element, let's remove it from there and simply make it so that the {Set,Get}EmbeddingToken() methods are exposed at the Frame level, available both for local and remote frames. This fixes the currently asymmetric situation where the embedding token is set on the LocalFrame representing the child frame, and then on the element (i.e. HTMLFrameOwnerElement) owning that child frame. Instead, we now will have the following situation, depending on whether we have same-site or cross-site child frames: * For same-site child frames, the embedding token is only set on the LocalFrame rendering the child frame's contents. * For cross-site child frames, the embedding token propagated via the browser process will be directly set on the RemoteFrame that receives the SetEmbeddingToken() mojo message. In both cases retrieving the embedding token of a frame owned by the HTMLFrameOwnerElement is done by simply calling GetEmbeddingToken() over the HTMLFrameOwnerElement's "content frame". Bug: 1094150 Change-Id: I72671bb19bb8a42566da0f68a8f2379212a9fcd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299725 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#791314}
-
Eric Ye authored
Due to internal changes, it makes more sense to have display settings manager own whether the screen should power off, so reverting the screen off API to that state and adding a new call for setting whether it should power off. BUG=b/156411764 TEST=Build, flash to device, check behaviour Change-Id: Ib395a96ef7385640ee0bd36e0907f96c73dcd85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316666Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Eric Ye <ericye@google.com> Cr-Commit-Position: refs/heads/master@{#791313}
-
Shengfa Lin authored
Sed behave the same on Mac and Linux for release script Bug: chromedriver:3550 Change-Id: I5d24ef995297ec0a48d8ab289ce3eed815048cc7 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315434 Commit-Queue: Shengfa Lin <shengfa@google.com> Auto-Submit: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791312}
-
Aleksey Kuznetsov authored
During import process from C++ part we send supported import options (checkboxes). In js part we hide not supported checkboxes. But then we send from js to C++ user choised checkboxes includes hidden (that is true by default). Need to exclude hidden checkboxes as unchecked. Bug: 1107356 Change-Id: Idf372718c632217a5474e12b4117213f12c027e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310532Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#791311}
-
Miguel Casas authored
After consultation with PMs, we have decided to have a bit more brightness for SDR content (ToT: 50%, with this CL: 75%), hence sacrificing a bit the HDR wow effect. This only applies for the moment to kohaku (Samsung Galaxy Chromebook) and external HDR-capable, DP-connected displays. At the same time, using only 50%, or 75% of the brightness range when in SDR, kills a bit the contrast ratio, which is perceived as colors "not vivid", or greyish. This CL fixes that by adding a bit (1.25) of gamma correction in this case in DrmDisplay. With this CL, SDR colours look good (not washed out), and there's no perceived brightness change in the SDR content during SDR-HDR transitions. Bug: 958166 Change-Id: I627514e8e31129b8b8d96e528e1e51ad8bea3d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317508Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791310}
-
Erik Chen authored
Change-Id: Iedb3ca5f542c87634870c6c0d22c6604b4fdd734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316787Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791309}
-
Garrett Beaty authored
There is likely to be a large backlog of CLs to submit that built up during the network outage. Throttling the submits that land will prevent large blamelists for CI runs. Bug: 1108842 Change-Id: I117c89082640bb30daf12b2bf5daa2e1b25c323f No-Try: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317760 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791308}
-
- 24 Jul, 2020 10 commits
-
-
Garrett Beaty authored
This reverts commit 735eccaa. Reason for revert: Restoring full functionality Original change's description: > Remove builders from CQ that are affected by network maintenance. > > Bug: 1108842 > Change-Id: I44ae858ebe99f33a713d814c1257359b49870a1e > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315387 > Reviewed-by: Erik Staab <estaab@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791254} TBR=estaab@chromium.org,martiniss@chromium.org,bpastene@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108842 Change-Id: I81d7c8ca20f0faa19ee7fd7270c930a44b3000df No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317861 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791307}
-
Garrett Beaty authored
This reverts commit 291e4648. Reason for revert: Restoring full functionality Original change's description: > Remove gl_tests_passthrough and gl_tests_validating from the Linux builders > > The datacenter holding GPU's bots is offline, so these tests are > stuck. Remove them while we work on getting ATL back online. > > TBR=gbeaty > > No-Try: true > No-Tree-Checks: true > Bug: 1108842 > Change-Id: I1446673656eee48134dd271724de4a7f3279a3d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316689 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#791296} TBR=gbeaty@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108842 Change-Id: I728eb56e99f06f54eb61d0b5eb5c399452858115 No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318507 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791306}
-
Lindsay Pasricha authored
This reverts commit b5a657ac. Reason for revert: Network outage ending Original change's description: > [ios] Remove ios builders from the CQ that are affected by network maintenance. > > Bug:1108842 > Change-Id: Icad192ee46c4489972168888fc6c8bd696d5e642 > > No-Tree-Checks: true > Change-Id: Icad192ee46c4489972168888fc6c8bd696d5e642 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316325 > Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791301} TBR=estaab@chromium.org,lindsayw@chromium.org,gbeaty@chromium.org Change-Id: I0daeef0d31637808fe24458edbcc3c947eb553a3 No-Tree-Checks: true No-Try: true Bug: 1108842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317808Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#791305}
-
Stephen Martinis authored
This reverts commit 95e22d39. Reason for revert: Potentially breaking many builders, https://crbug.com/1108314 Original change's description: > Reland "Parallelize fetching telemetry benchmark deps" > > This is a reland of 8ab0b856 > > Original change's description: > > Parallelize fetching telemetry benchmark deps > > > > The fetching script currently fetches about 2 GB (on my linux workstation) > > from cloud storage serially. This can (and is) trivially parallelizable, and > > should speed up the fetching script significantly. > > > > This script has been taking 20 minutes on mac machines for a long time. This > > will hopefully significantly speed the mac builders up. > > > > Bug: 1102597 > > Change-Id: I93d2fa2b1f4b4ef6e27e9c894a9dd4c0d0e12d7b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285503 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > Reviewed-by: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786521} > > Bug: 1102597 > Change-Id: I37d0055fadb26bf4eae2b0b5fe0ecc4732edde3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288740 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789736} TBR=martiniss@chromium.org,johnchen@chromium.org,wenbinzhang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. # Tree is currently closed, trying to fix an outage No-Try: true No-Tree-Checks: true Bug: 1102597 Change-Id: If6b95395208a3136a798118e4eb229e4322c7878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317774 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#791304}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I6cf1b873ba9913042c986880e7e0660210c3ba8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295806Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#791303}
-
Garrett Beaty authored
This reverts commit 5ed2e0aa. Reason for revert: The restored capacity is experiencing connectivity issues that makes it unreliable. Original change's description: > Re-enable android-marshmallow-arm64-rel. > > The Android capacity for android-marshmallow-arm64-rel is mostly > recovered, so it is being re-enabled so that APAC and EMEA can get > Android M coverage. > > Bug: 1108842 > Change-Id: Ie865ced7efcdaa8357068db616e88801b8247840 > No-Tree-Checks: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316446 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791298} TBR=estaab@chromium.org,bpastene@chromium.org,gbeaty@chromium.org Change-Id: I5ef6bca7e03da51ee61494e327aa9b19f1231053 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317002Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#791302}
-
Lindsay Pasricha authored
Bug:1108842 Change-Id: Icad192ee46c4489972168888fc6c8bd696d5e642 No-Tree-Checks: true Change-Id: Icad192ee46c4489972168888fc6c8bd696d5e642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316325 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791301}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6f1ccb7f34c0fca9ad3b193409ccae0be350f091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315495Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#791300}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I7a91b5ee733c9b393b8ea3e53f177444c0ad9a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316528Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791299}
-
Garrett Beaty authored
The Android capacity for android-marshmallow-arm64-rel is mostly recovered, so it is being re-enabled so that APAC and EMEA can get Android M coverage. Bug: 1108842 Change-Id: Ie865ced7efcdaa8357068db616e88801b8247840 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316446 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#791298}
-
- 23 Jul, 2020 22 commits
-
-
Garrett Beaty authored
Change-Id: Ib91c6c6d7876b2200d09f6e79a35d8a257375d4d No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314164 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#791297}
-
Haiyang Pan authored
The datacenter holding GPU's bots is offline, so these tests are stuck. Remove them while we work on getting ATL back online. TBR=gbeaty No-Try: true No-Tree-Checks: true Bug: 1108842 Change-Id: I1446673656eee48134dd271724de4a7f3279a3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316689Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#791296}
-
Ali Juma authored
This adds an about:flags entry for real-time Safe Browsing lookups, to make it easier to enable and test. Bug: 1103213 Change-Id: I28bae0f333ece6d1f5f8f4dcf5b3c89ef6037772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315236 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#791295}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ba0609c22877..2bda4d1319b4 2020-07-23 vapier@chromium.org cros_sdk: merge user PATH with root's PATH 2020-07-23 pprabhu@chromium.org cbuildbot: Pin the CIPD instance of the `skylab` tool 2020-07-23 tcwang@google.com afdo: Attach chrome version info to Chrome debug binary name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ic42cebef59aa4f27ddab32a76c945d5cbd9b82e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791294}
-
Jonathan Ross authored
This reverts commit 26f4c62b. Reason for revert: crbug.com/1108303 regressions showing up on a large number of Graphics.Smoothness.PercentDroppedFrames graphs. We should analyze the impact and reland. Original change's description: > Re-add field trial testing config for DisableLatencyRecoveryDesktop > > Based on the data gathered from running the experiment on canary/dev and > beta, it seems that the disabling latency recovery for both main and > impl threads is an overall performance win. So, we are going to > re-enable the (now-expired) experiment on stable and move forward with > its gradual rollout. > > Bug: 993895 > Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790549} TBR=mohsen@chromium.org,rkaplow@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993895 Change-Id: I0409a5a5df03b34c8e4a203482175089dac83e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315014Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#791293}
-
Wen-Chien Wang authored
Change-Id: I4de9eaddd47175d7c295532ee292e8bf6351cfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304975 Commit-Queue: Wen-Chien Wang <wcwang@google.com> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791292}
-
Alexey Baskakov authored
Inline previously established constants. The formatting has become messy anyway. Fixed: 1103916 Change-Id: I9e8970614c05bde425c67418e42028150f281b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315896 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#791291}
-
Jose Dapena Paz authored
GCC cannot map passing directly curly braces notation to the x11->PutImage call. We need to initialize it first to an instance and pass it to PutImage. Bug: 819294 Change-Id: I9bbd1060eb3f8889ac789db21bb09a0d6a0ae504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302995Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#791290}
-
wutao authored
Needs to add $ to data-id attribute otherwise reads undefined. Bug: b/161081423 Test: manual Change-Id: I35fce415685645b5dbb5afa1df781374333f7311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315802Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791289}
-
Jose Dapena Paz authored
MockWebRtcVideoTrack and MockWebRtcVideoTrackSource are abstract because they do not implement the rtc::RefCounted interface. To fix hte problem, solution is inheriting from rtc::RefCountedObject. Bug: 819294 Change-Id: Ia0975711cff5755f0608e801a5cb60d175bd9b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310414Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#791288}
-
Matt Jones authored
Bug: 1108731 Change-Id: Ibbf6c03ad6c068c90ab356008c68878cb3d6604f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316319Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#791287}
-
Miguel Casas authored
While experimenting with SDR-HDR on Chromebooks with DCHECK()s on, I noticed I hit a few of them unnecessarily. This CL adds the RGB10 format where needed. Bug: 958166 Change-Id: Ifc3cbd4c6a6a4ee23b9430f3ee4ac75ac7c65a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315253Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791286}
-
Orin Jaworski authored
This CL eliminates the override readiness and execution logic to make the Pedal for updating Chrome rely on the base implementation with navigation to chrome://settings/help . Other URLs are also updated to stay in sync with targets agreed upon with PM & UX. Related unit tests are also eliminated. Bug: 893183 Change-Id: Iaaf2a02700449932d198331a0856cb7c926c145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314160Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#791285}
-
Dan H authored
This reverts commit cbd8c160. Reason for revert: Failure on win32-archive-dbg - https://bugs.chromium.org/p/chromium/issues/detail?id=1108859 Original change's description: > Allow use of Abseil in //net/third_party/quiche. > > This has been previously blocked on https://bugs.chromium.org/p/chromium/issues/detail?id=1046390. > > Change-Id: I1c0d68dc56d109be6189df0cfb8fc04230949a1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302721 > Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791073} TBR=zhongyi@chromium.org,vasilvv@chromium.org,mbonadei@chromium.org Change-Id: Ibf29f66c708ae25e5a140f04eec39e1a751e0369 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316323Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#791284}
-
Elly Fong-Jones authored
See the bug for details about why. Bug: 1102153 Change-Id: I71423c13405cfd57a1eee024205c48145af18009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313156 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791283}
-
Aaron Colwell authored
Adding an extra sanity check in the BrowserContext destructor to immediately terminate if we detect that a RenderProcessHost still references the object being destroyed. Bug: 1099998 Change-Id: I84af3b5d5f09274fa551b63903101ab5710d073d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305674 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#791282}
-
Wei Li authored
Use direct event calls so the tests will work across platforms including Mac. Bug: none Change-Id: I41df114ed67709f7fcb95400ddec99aaf83a2ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304135Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#791281}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595437495-2d3f811bb66fa71af5c868be4b1e4126108bec15.profdata to chrome-win64-master-1595483644-344e9c0c00099fa9f04b516964f94e743df86469.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I523c07323d754ca5dced2bdb36e9361b51e5f2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791280}
-
Bruce Dawson authored
Due to Windows event log spam (tracked in bug 1070362) there is no guarantee that there will be enough system session events to do analysis and, in fact, there is no guarantee that there will be *any* system session events. This means that FetchEvents is unavoidably flaky and must be disabled, and ValidateEvents has to tolerate another failure mode. Bug: 1053451, 1070362 Change-Id: Ib95701d42f1152c6e7726bd7c6de913d6764ac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314667Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#791279}
-
Elly Fong-Jones authored
This test needs to be updated for Big Sur's new visual style. Bug: 1101415 Change-Id: Iea580bdef7828e79e73a453443958152a1aa33ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314999 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#791278}
-
Brian Sheedy authored
Adds support for specifying a non-default corpus when initializing a SkiaGoldPixelDiff or BrowserSkiaGoldPixelDiff instance. This allows users to separate their images, either to reduce clutter when looking through results or to prevent internal results from being mirrored to the public Gold instance. This particular implementation is meant to be a temporary solution so that users can be unblocked. A more robust implementation that will catch public corpora being used in non-public settings, etc. will be implemented later. Bug: 1108465 Change-Id: I8f868bfb32cdf72cf9feccf64c7291f758c3ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314976Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#791277}
-
Maksim Ivanov authored
Provide test coverage for the scenario when the signature operation, triggered during the challenge-response login (a.k.a. smart card based login), fails. This corresponds to the real-world case when a smart card user tries to log into the system but the smart card is broken or is ejected during the login. Bug: 1090941 Change-Id: Ida39fa52385905643bbeb3728dbbc2f49c527195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315676 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#791276}
-