1. 23 Apr, 2009 34 commits
    • mrowe@apple.com's avatar
      Versioning. · 4837f57c
      mrowe@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@42793 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4837f57c
    • dglazkov@chromium.org's avatar
      WebCore: · bb67166c
      dglazkov@chromium.org authored
      2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=25313
              Missing scroll bars in GMail.
      
              Test: fast/overflow/overflow-y-scroll.html
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn
              scroll mode.
      
      LayoutTests:
      
      2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
              https://bugs.webkit.org/show_bug.cgi?id=25313
              Missing scroll bars in GMail.
      
              * fast/overflow/overflow-y-scroll-expected.txt: Added.
              * fast/overflow/overflow-y-scroll.html: Added.
      
      WebKit/mac:
      
      2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=25313
              Missing scroll bars in GMail.
      
              * WebView/WebDynamicScrollBarsView.m:
              (-[WebDynamicScrollBarsView updateScrollers]): Added check for the ScrollbarAlwaysOn
                  scroll mode.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42791 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bb67166c
    • kdecker@apple.com's avatar
      Fix the Tiger build · c13c2c79
      kdecker@apple.com authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c13c2c79
    • andersca@apple.com's avatar
      2009-04-23 Anders Carlsson <andersca@apple.com> · cf30df75
      andersca@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Fix <rdar://problem/6821992>
      
              Add a new m_inDestroy member variable. Set it to true when in destroy, and have all NPRuntime functions return false
              when m_inDestroy is true.
              
              * Plugins/Hosted/NetscapePluginInstanceProxy.h:
              * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
              (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
              (WebKit::NetscapePluginInstanceProxy::destroy):
              (WebKit::NetscapePluginInstanceProxy::invoke):
              (WebKit::NetscapePluginInstanceProxy::invokeDefault):
              (WebKit::NetscapePluginInstanceProxy::construct):
              (WebKit::NetscapePluginInstanceProxy::getProperty):
              (WebKit::NetscapePluginInstanceProxy::setProperty):
              (WebKit::NetscapePluginInstanceProxy::removeProperty):
              (WebKit::NetscapePluginInstanceProxy::hasProperty):
              (WebKit::NetscapePluginInstanceProxy::hasMethod):
              (WebKit::NetscapePluginInstanceProxy::enumerate):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42789 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cf30df75
    • mitz@apple.com's avatar
      WebCore: · bc883879
      mitz@apple.com authored
              Reviewed by Justin Garcia.
      
              - fix <rdar://problem/6081309> Mail crash when pressing down arrow in
                some messages in WebCore::canHaveChildrenForEditing
      
              Test: editing/selection/extend-by-line-anonymous-content-crash.html
      
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition): Null-check node. If p is not an
              editable position, then closestLeafChildForXPos() may have returned a
              non-editable box, and in particular one belonging to anonymous content.
              If node is 0, fall back on RenderObject::positionForPoint, which
              finds the closest position in non-anonymous content.
              (WebCore::nextLinePosition): Ditto.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createVisiblePosition): Fixed a typo.
      
      LayoutTests:
      
              Reviewed by Justin Garcia.
      
              - test for <rdar://problem/6081309> Mail crash when pressing down arrow
                in some messages in WebCore::canHaveChildrenForEditing
      
              * editing/selection/extend-by-line-anonymous-content-crash-expected.txt: Added.
              * editing/selection/extend-by-line-anonymous-content-crash.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42788 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bc883879
    • hyatt@apple.com's avatar
      2009-04-23 David Hyatt <hyatt@apple.com> · 384959c7
      hyatt@apple.com authored
              Reviewed by Maciej.
      
              Fix for <rdar://problem/6789879> REGRESSION (42464): Hitting assertion when loading message in Mail + TOT WebKit
              
              Make the Mac platform the same as all the other platforms.  Instead of (incorrectly) marking a FrameView for layout
              when its underlying document view changes, just mark the outermost frame view for layout when the WebView's size changes.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _frameOrBoundsChanged]):
              (-[WebHTMLView addSuperviewObservers]):
              * WebView/WebView.mm:
              (-[WebView _boundsChanged]):
              (-[WebView removeSizeObservers]):
              (-[WebView addSizeObservers]):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42787 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      384959c7
    • kdecker@apple.com's avatar
      Reviewed by Tim Hatcher. · d2ec9e6c
      kdecker@apple.com authored
              Second part of the fix for <rdar://problem/6352982>
      
              * Plugins/WebBaseNetscapePluginView.h: Make this class conform to WebPluginContainerCheckController
              * Plugins/WebBaseNetscapePluginView.mm: Likewise.
              (-[WebBaseNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added skeleton method.
              * Plugins/WebPluginContainerCheck.h: Added protocol for <WebPluginContainerCheckController>
              * Plugins/WebPluginContainerCheck.mm:
              (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]):
              * Plugins/WebPluginController.h: Make this class conform to WebPluginContainerCheckController
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42786 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d2ec9e6c
    • ap@webkit.org's avatar
      Reviewed by Adele Peterson. · 9fb1c9df
      ap@webkit.org authored
              <rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
      
              Test: http/tests/history/back-to-post.php
      
              * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
              Apply a new cache policy if it changed after the platform request was first created.
              While at it, also made sure to update timeout.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42785 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9fb1c9df
    • kov@webkit.org's avatar
      2009-04-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 5ecf0bfd
      kov@webkit.org authored
              Rubber-stamped by Xan Lopez.
      
              * pt_BR.po: translation update.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42784 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5ecf0bfd
    • kov@webkit.org's avatar
      2009-04-23 Zan Dobersek <zandobersek@gmail.com> · e2a38480
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              When creating a new drawable object, collect system's
              information about the best depth it can provide and use it
              in a new colormap that the new drawable requires.
      
              * platform/graphics/gtk/ImageGtk.cpp:
              (WebCore::BitmapImage::getGdkPixbuf):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42783 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e2a38480
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · a0b89361
      kdecker@apple.com authored
              
              First part of <rdar://problem/6352982>
      
              * Plugins/WebBaseNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h; Added two new method:
              checkIfAllowedToLoadURL:url:frame:callbackFunc: and cancelCheckIfAllowedToLoadURL:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added skeleton method, does nothing interesting
              yet.
              (-[WebBaseNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Likewise.
              * Plugins/WebNetscapeContainerCheckPrivate.h: Added.
              * Plugins/WebNetscapeContainerCheckPrivate.mm: Added.
              (browserContainerCheckFuncs): Added. 
              * Plugins/WebNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h;
              * Plugins/WebNetscapePluginView.mm: Imported #WebNetscapeContainerCheckPrivate.h; added WKN_CheckIfAllowedToLoadURL
              and WKN_CancelCheckIfAllowedToLoadURL functions.
              (-[WebNetscapePluginView getVariable:value:]): Return vtable for container check functions.
              * Plugins/npapi.mm:
              (WKN_CheckIfAllowedToLoadURL): Added new private function.
              (WKN_CancelCheckIfAllowedToLoadURL): Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42782 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a0b89361
    • aroben@apple.com's avatar
      Skip a newly-added test that fails on Windows · 26739144
      aroben@apple.com authored
              See Bug 25344: http/tests/misc/redirect-to-external-url.html fails on
              Windows
              <https://bugs.webkit.org/show_bug.cgi?id=25344>
      
              Reviewed by Brady Eidson.
      
              * platform/win/Skipped: Added
              http/tests/misc/redirect-to-external-url.html.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42781 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      26739144
    • kov@webkit.org's avatar
      2009-04-23 Zan Dobersek <zandobersek@gmail.com> · 8a7d9756
      kov@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=15654
              GdkPixbuf support for ImageCairo
      
              Add support for converting a Cairo surface to a GdkPixbuf.
      
              * platform/graphics/BitmapImage.h:
              * platform/graphics/Image.h:
              (WebCore::Image::getGdkPixbuf):
              * platform/graphics/gtk/ImageGtk.cpp:
              (WebCore::BitmapImage::getGdkPixbuf):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42780 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8a7d9756
    • vestbo@webkit.org's avatar
      Fix Qt build warning · ac916426
      vestbo@webkit.org authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@42779 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ac916426
    • ariya@webkit.org's avatar
      2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> · ed2651d2
      ariya@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.
      
              Basically, what we want is to send wheel events to the plugin *only*
              when it has focus, or else send it to the parent frame.
      
              This is a work around, and basically what we do, is to steal the
              wheel events from the plugin, modify the window ID, and put the
              event back into the Qt event loop.
      
              * plugins/qt/PluginContainerQt.cpp:
              (PluginClientWrapper::PluginClientWrapper):
              (PluginClientWrapper::~PluginClientWrapper):
              (PluginClientWrapper::x11Event):
              (PluginContainerQt::PluginContainerQt):
              (PluginContainerQt::~PluginContainerQt):
              (PluginContainerQt::on_clientClosed):
              (PluginContainerQt::on_clientIsEmbedded):
              (PluginContainerQt::redirectWheelEventsToParent):
              (PluginContainerQt::x11Event):
              (PluginContainerQt::focusInEvent):
              * plugins/qt/PluginContainerQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42778 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ed2651d2
    • ariya@webkit.org's avatar
      2009-04-23 Antonio Gomes <antonio.gomes@openbossa.org> · 3ccb9561
      ariya@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] Added QWebElement::computedStyleProperty method.
      
              * Api/qwebelement.cpp:
              (QWebElement::computedStyleProperty):
              * Api/qwebelement.h:
              * tests/qwebelement/tst_qwebelement.cpp:
              (tst_QWebElement::computedStyle):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42777 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ccb9561
    • vestbo@webkit.org's avatar
      2009-04-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com> · dcad4f60
      vestbo@webkit.org authored
              Rubber-stamped by Ariya Hidayat.
      
              [Qt] Rename QWebElement arguments from html to markup
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42776 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dcad4f60
    • mrowe@apple.com's avatar
      Fix the Windows DRT build. · 5a5544ba
      mrowe@apple.com authored
      * DumpRenderTree/win/PolicyDelegate.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42775 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5a5544ba
    • beidson@apple.com's avatar
      2009-04-23 Brady Eidson <beidson@apple.com> · 77e2f8c7
      beidson@apple.com authored
              Fix Windows DRT build.
      
              * DumpRenderTree/win/PolicyDelegate.cpp:
              (PolicyDelegate::unableToImplementPolicyWithError):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42774 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      77e2f8c7
    • beidson@apple.com's avatar
      2009-04-23 Brady Eidson <beidson@apple.com> · 5a12b98c
      beidson@apple.com authored
              Update my just-landed layout test to agree with Tiger's CFNetwork
      
              * http/tests/misc/resources/redirect-to-external-url.php:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42773 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5a12b98c
    • beidson@apple.com's avatar
      WebCore: · f979796a
      beidson@apple.com authored
      2009-04-22  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Maciej Stachowiak
      
              <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
      
              For most loads, we were consulting the navigation policy delegate twice.  Once from FrameLoader before
              the load started and once from MainResourceLoader in its willSendRequest callback.
      
              In the past we tried removing MainResourceLoader's call altogether.  This caused a regression where urls 
              that redirect to a url handled by an external application would no longer work in Safari.  It probably 
              also broke other WebKit apps in subtle ways.
      
              Changing MainResourceLoader to make the check only on redirects fixes both bugs.  We now only call the 
              policy delegate once for most standard loads, but we do correctly call it a second time for redirects.
      
              Tests: http/tests/misc/policy-delegate-called-twice.html
                     http/tests/misc/redirect-to-external-url.html
      
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.
      
      WebKitTools:
      
      2009-04-22  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Maciej Stachowiak
      
              Add additional support for test:
              <rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.
      
              * DumpRenderTree/mac/PolicyDelegate.mm:
              (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]): Dump formatted information when
                a policy cannot be implemented.
      
              * DumpRenderTree/win/PolicyDelegate.cpp:
              (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
              * DumpRenderTree/win/PolicyDelegate.h:
      
      LayoutTests:
      
      2009-04-22  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Maciej Stachowiak
      
              With the fix for:
              <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
              And also to make sure we never rebreak:
              <rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.
      
              * http/tests/misc/redirect-to-external-url-expected.txt: Added.
              * http/tests/misc/redirect-to-external-url.html: Added.
              * http/tests/misc/resources/redirect-to-external-url-iframe.html: Added.
              * http/tests/misc/resources/redirect-to-external-url.php: Added.
      
              * http/tests/misc/policy-delegate-called-twice-expected.txt: Added.
              * http/tests/misc/policy-delegate-called-twice.html: Added.
              * http/tests/misc/resources/iframe-policy-1.html: Added.
              * http/tests/misc/resources/iframe-policy-2.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42772 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f979796a
    • mrowe@apple.com's avatar
      Add the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a few comments. · 7ae5ec8f
      mrowe@apple.com authored
      Rubber-stamped by Gavin Barraclough.
      
      * jit/ExecutableAllocatorFixedVMPool.cpp:
      (JSC::FixedVMPoolAllocator::addToFreeList):
      (JSC::FixedVMPoolAllocator::coalesceFreeSpace):
      (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
      (JSC::FixedVMPoolAllocator::alloc):
      (JSC::FixedVMPoolAllocator::free):
      (JSC::FixedVMPoolAllocator::isWithinVMPool):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7ae5ec8f
    • mrowe@apple.com's avatar
      Add some assertions to FixedVMPoolAllocator to guard against cases where we · 70d44aa1
      mrowe@apple.com authored
      attempt to free memory that didn't originate from the pool, or we attempt to
      hand out a bogus address from alloc.
      
      Rubber-stamped by Gavin Barraclough.
      
      * jit/ExecutableAllocatorFixedVMPool.cpp:
      (JSC::FixedVMPoolAllocator::release):
      (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
      (JSC::FixedVMPoolAllocator::alloc):
      (JSC::FixedVMPoolAllocator::free):
      (JSC::FixedVMPoolAllocator::isWithinVMPool):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42770 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      70d44aa1
    • weinig@apple.com's avatar
      2009-04-22 Sam Weinig <sam@webkit.org> · e2f1ba73
      weinig@apple.com authored
              Reviewed by Mark Rowe.
      
              Fix for <rdar://problem/6800695>
      
              Add a hack to only allow navigating (via a link from a http page)
              to feed: urls (same for feeds: and feedsearch:) that map to http:
              or https: via their nested protocol. This includes both feed://example.com
              and feed:http://example.com.
      
              * loader/FrameLoader.cpp:
              (WebCore::isFeedWithNestedProtocolInHTTPFamily):
              (WebCore::FrameLoader::loadFrameRequest):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42769 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e2f1ba73
    • weinig@apple.com's avatar
      2009-04-22 Sam Weinig <sam@webkit.org> · a0c6d6e9
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Autogenerate the XMLHttpRequest constructor getter/setter for the
              WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
              file.
      
              * DerivedSources.make: Remove JSWorkerContextBase.lut.h
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * bindings/js/JSWorkerContextBase.cpp:
              * bindings/js/JSWorkerContextBase.h: Remove code to support hand written
              code for XMLHttpRequest constructor lookup and shadowing.
      
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes.
              (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of
              cached constructor lookup.
              * workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not
              V8 specific.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42768 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a0c6d6e9
    • adachan@apple.com's avatar
      WebKitLibraries: · 71dee2bd
      adachan@apple.com authored
              Update WebKitSystemInterface with new method that maps CFNetwork error code to localized description.
              
              Reviewed by Darin Adler.
      
              * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
              * win/lib/WebKitSystemInterface.lib:
              * win/lib/WebKitSystemInterface_debug.lib:
      
      WebKit/win:
              <rdar://problem/5115298> Don't get error msg when download is interrupted and cannot resume due to server unavailability
              If we fail to get an error description back from CFNetwork, try to get the localized description
              based on the error code.
      
              Reviewed by Darin Adler.
      
              * WebError.cpp:
              (WebError::localizedDescription):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42767 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      71dee2bd
    • darin@apple.com's avatar
      2009-04-22 Darin Adler <darin@apple.com> · 1f962f15
      darin@apple.com authored
              * page/Navigator.idl: Touch this file to fix build since Geolocation
              configuration was recently turned off.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42766 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1f962f15
    • oliver@apple.com's avatar
      Include updated results · 0af4e6c9
      oliver@apple.com authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42765 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0af4e6c9
    • oliver@apple.com's avatar
      Modify test to only record the important mouse events · fad55e0b
      oliver@apple.com authored
      Reviewed by Geoff Garen.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42764 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fad55e0b
    • justin.garcia@apple.com's avatar
      WebCore: · 3ec4a1f3
      justin.garcia@apple.com authored
      2009-04-22  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=25322
              Can't delete empty paragraph after a block image
              
              Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
              because of some code that avoided problems that would arise from Positions that would go
              bad during deletion.  
              
              We have several checks that prevent us from using bad Positions, this one in particular
              was added to avoid bad Positions that result from text removal.  So, I removed the check
              and started correctly updating m_downstreamEnd during text removal so that it doesn't go
              bad.  m_upstreamStart doesn't need to be updated during text removal, since only text
              after it will ever be removed.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::deleteTextFromNode):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
      
      LayoutTests:
      
      2009-04-22  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              https://bugs.webkit.org/show_bug.cgi?id=25322
              Can't delete empty paragraph after a block image
      
              * editing/deleting/25322-1-expected.txt: Added.
              * editing/deleting/25322-1.html: Added.
              * editing/deleting/25322-2-expected.txt: Added.
              * editing/deleting/25322-2.html: Added.
              * editing/deleting/25322-3-expected.txt: Added.
              * editing/deleting/25322-3.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42763 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ec4a1f3
    • darin@apple.com's avatar
      2009-04-22 Darin Adler <darin@apple.com> · 3ef00980
      darin@apple.com authored
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Fixed one
              case Eric seems to have missed earlier today of RenderImage -> RenderSVGImage.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42762 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ef00980
    • oliver@apple.com's avatar
      <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop... · c81d8c16
      oliver@apple.com authored
      <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
      
      Reviewed by Darin Adler.
      
      Make mouseUp target the correct frame when the original
      mousedown made the drag non-capturing.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42761 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c81d8c16
    • oliver@apple.com's avatar
      <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop... · a3249bdc
      oliver@apple.com authored
      <rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves
      
      Reviewed by Darin Adler.
      
      This is the first step of allowing drag events to match the behaviour
      of mouse move events when the default action of the initial mouse down
      is prevented.  Remaining issue is that the final mouse up event still
      targets the original root frame.
      
      Test: fast/events/mouse-drag-from-frame-to-other-frame.html
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42760 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a3249bdc
    • simon.fraser@apple.com's avatar
      2009-04-22 Simon Fraser <simon.fraser@apple.com> · 908bdec1
      simon.fraser@apple.com authored
              Reviewed by Adele Peterson
      
              <rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
              <rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting
      
              When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
              layer backing under some circumstances. However, drawing the view via
              displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
              So when in the media document, we draw via displayRectIgnoringOpacity:.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::paint):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42759 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      908bdec1
  2. 22 Apr, 2009 6 commits
    • mrowe@apple.com's avatar
      Update test results after Blackbeard's change in r42752 to disable geolocation. · 484a1ef7
      mrowe@apple.com authored
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/navigator-detached-no-crash-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42758 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      484a1ef7
    • simon.fraser@apple.com's avatar
      2009-04-22 Pierre d'Herbemont <pdherbemont@apple.com> · 3396260e
      simon.fraser@apple.com authored
              Reviewed by Simon Fraser.
      
              https://bugs.webkit.org/show_bug.cgi?id=24849
      
              Add tests for media 'played' attribute (missed in r42619).
      
              * media/video-played-expected.txt: Added.
              * media/video-played.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42757 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3396260e
    • andersca@apple.com's avatar
      2009-04-22 Anders Carlsson <andersca@apple.com> · 602aae92
      andersca@apple.com authored
              Reviewed by Oliver Hunt.
      
              Fix <rdar://problem/6792694>
              
              When we're trying to instantiate a plug-in and the plug-in host has died, we need to invalidate the
              instance so that it doesn't stick around and do bad things.
              
              * Plugins/Hosted/NetscapePluginHostManager.mm:
              (WebKit::NetscapePluginHostManager::instantiatePlugin):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42756 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      602aae92
    • barraclough@apple.com's avatar
      2009-04-22 Gavin Barraclough <barraclough@apple.com> · a20aa64a
      barraclough@apple.com authored
              Rubber stamped by Sam "Blackbeard" Weinig.
      
              Although pirates do spell the word 'generate' as 'genertate',
              webkit developers do not.  Fixerate.
      
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::generateAssertionBOL):
              (JSC::Yarr::RegexGenerator::generateAssertionEOL):
              (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary):
              (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle):
              (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
              (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed):
              (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
              (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
              (JSC::Yarr::RegexGenerator::generateCharacterClassSingle):
              (JSC::Yarr::RegexGenerator::generateCharacterClassFixed):
              (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
              (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy):
              (JSC::Yarr::RegexGenerator::generateTerm):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42755 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a20aa64a
    • barraclough@apple.com's avatar
      2009-04-22 Gavin Barraclough <barraclough@apple.com> · 3576db13
      barraclough@apple.com authored
              Reviewed by Sam "Blackbeard" Weinig.
      
              Improvements to YARR JIT.  This patch expands support in three key areas:
                  * Add (temporary) support for falling back to PCRE for expressions not supported.
                  * Add support for x86_64 and Windows.
                  * Add support for singly quantified parentheses (? and ??), alternatives within
                    parentheses, and parenthetical assertions.
      
              * runtime/RegExp.cpp:
              (JSC::RegExp::match):
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::storeToFrame):
              (JSC::Yarr::RegexGenerator::storeToFrameWithPatch):
              (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
              (JSC::Yarr::RegexGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord):
              (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative):
              (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm):
              (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack):
              (JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists):
              (JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump):
              (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks):
              (JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom):
              (JSC::Yarr::RegexGenerator::genertateAssertionBOL):
              (JSC::Yarr::RegexGenerator::genertateAssertionEOL):
              (JSC::Yarr::RegexGenerator::matchAssertionWordchar):
              (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary):
              (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle):
              (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair):
              (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed):
              (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy):
              (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy):
              (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle):
              (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed):
              (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy):
              (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy):
              (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
              (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
              (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
              (JSC::Yarr::RegexGenerator::generateTerm):
              (JSC::Yarr::RegexGenerator::generateDisjunction):
              (JSC::Yarr::RegexGenerator::generateEnter):
              (JSC::Yarr::RegexGenerator::generateReturn):
              (JSC::Yarr::RegexGenerator::RegexGenerator):
              (JSC::Yarr::RegexGenerator::generate):
              (JSC::Yarr::RegexGenerator::compile):
              (JSC::Yarr::RegexGenerator::generationFailed):
              (JSC::Yarr::jitCompileRegex):
              (JSC::Yarr::executeRegex):
              * yarr/RegexJIT.h:
              (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
              (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42754 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3576db13
    • timothy@apple.com's avatar
      Fix a crash in Mail when forwarding a specific HTML email. · 3429aa03
      timothy@apple.com authored
              Caused by the fix for <rdar://problem/6512520> (r42096).
              Unable to create a test case that works outside of Mail.
      
              <rdar://problem/6796069>
      
              Reviewed by Ada Chan.
      
              * editing/markup.cpp:
              (WebCore::createMarkup): Null check pastEnd before trying to
              call Range::compareBoundaryPoints.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42753 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3429aa03