- 28 Feb, 2020 40 commits
-
-
Kenichi Ishibashi authored
ServiceWorkerDatabase::Status is an alias of storage::mojom::ServiceWorkerDatabaseStatus. ServiceWorkerRegistry can't use the alias once ServiceWorkerDatabase is moved to the storage service. ServiceWorkerRegistry should use the original one. Bug: 1055677 Change-Id: Idc8505a53bca5fef17792fe13ac0268489509387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074838 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#745293}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/840d5db64e4d..4017f982cd1d git log 840d5db64e4d..4017f982cd1d --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rwkeane@google.com DNS-SD: Querier Cleanup Created with: gclient setdep -r src/third_party/openscreen/src@4017f982cd1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ibf17f517965f35e586bf78a793612bd50db8c7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079345Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745292}
-
Vasiliy Telezhnikov authored
Few non-trivial problems were discovered with shared images on WebView. For this reason we should disable feature by default and proceed with launching it using finch when the problems will be addressed. Keeping feature enabled by default is not safe for now. VizForWebView depends on SharedImages, so this CL adds EnableSharedImagesForWebView to fieldtrials_testing_config and server-side finch config, but launching EnableSharedImageForWebview will be blocker for VizForWebView. Bug: 1052114, 900973 Change-Id: I562500319dc5ae8b86781654a15aa4e8a8dd59cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079432 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745291}
-
Luciano Pacheco authored
The query and the remvoval are performed in-line, so checking for "contains()" isn't necessary. Bug: 1056443 Change-Id: I86a5dc0601948502b0ce0a94845422b4db07fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078515 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745290}
-
Sylvain Defresne authored
This reverts commit 4ed2234c. Reason for revert: causes `gn gen --ide=xcode` to fails with error code 250 when targeting iOS (this is caused by an assertion failure in gn in debug mode resulting in a crash in release), Original change's description: > generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests > > The existing iOS recipe utilizes an isolate template, and an > isolated.gen.json file to fill the template in per test with > config-variables and path-variables. This isolate template contains > the command arguments to invoke the iOS test runner. > > To support the iOS recipe migration to the Chromium recipe, I use GN to > generate a script per test target instead of the isolate template. The > script is pre-baked with arguments to the test runner (run.py). The > given Swarming task is expected to execute the test by invoking the > generated script. > > Invoking the generated script requires changes to gn_isolate_map.pyl > for each iOS test target, and thus, these changes are only additive. > > * "ios_test_runner_wrapper" template wraps the generate_wrapper target. > It bakes iOS specific arguments into the script, such that it can > launch run.py with the given args. > * ios_eg2_test, ios_eg_test, and test templates have > been updated to utilize the ios_test_runner_wrapper for iOS targets. > * mb.py to skip generated_directory check when writing isolates. > View crbug/ in comments. > > Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64 > Bug: 1055328,912681 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745105} TBR=rohitrao@chromium.org,sdefresne@chromium.org,eugenebut@chromium.org,jbudorick@chromium.org,jeffyoon@chromium.org Change-Id: I649d1051b276738c87ea54633e447ebdadad539f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055328, 912681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078260Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#745289}
-
Brian Sheedy authored
Re-enables conformance/context/context-release-upon-reload.html on Nexus 5Xs. This test was previously flakily crashing, but could not be diagnosed due to an issue that was preventing the minidumps from symbolizing properly. That issue has been fixed, so re-enable to see if the test is still flaky, and if so, get a symbolized minidump. TBR=ynovikov@chromium.org Bug: 1052344 Change-Id: I52fd7769570df3664d2927c325e6e7e5e95c06e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079378Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745288}
-
Changwan Ryu authored
Bug: N/A Change-Id: I8d0e186a866973f977db1f157c58fd53450e3b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073223 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745287}
-
Ilya Sherman authored
Studies that use the Feature API -- which should be the vast majority of current studies -- do not need to specify a group name that matches the server config. Only the enabled features and params matter. R=rkaplow@chromium.org Bug: none Change-Id: Ic701f3b95af596fc7def453814717dbd4502317c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072117 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#745286}
-
Hoch Hochkeppel authored
Updates the check used for gating the availability of various commands (CanCreateWebApp) to include a check for the current page being in an error state, correctly reflecting the functionality of the code associated with this check (CreateWebAppFromCurrentWebContents). Currently the only user scenario this changes is the enabled state of the "Creates shortcut" command, but this ensures that any other commands leveraging the same functionality will be appropriately gated as well. Other commands already using this check (such as the command for installing a PWA) are already disabled in the error page state due to additional restrictions. Test: Navigate to an invalid page (e.g. "foo.bar") and invoke More tools > Create shortcut. Without this change, nothing will appear to happen until navigating to a valid page, at which point the "Create shortcut?" dialog will finally appear. With this change the "Create shortcut" menu option will be disabled until you navigate to a valid page. Bug: 1056709 Change-Id: I9cd15876ca9bc1443b776fe8ea326608cd8ea0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063031 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745285}
-
Ahmed Fakhry authored
Auto rotation depends on the tablet physical state of the device, not the UI state. Therefore AccelerometerFileReader should keep reading accelerometer data as long as the device is physically a tablet (detached or flipped). BUG=1056862 TEST=Manually on hatch. Change-Id: I96f6c8f1430fa2d50b20aaa97bd25e072bce098f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079618Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745284}
-
Henrique Nakashima authored
References were migrated downstream, so these are not needed anymore. Conveniently, this gets rid of the last dependency out of CachedFeatureFlags so it can be moved to a separate module. Bug: 1012975 Change-Id: I4716689255c2c3a8ad641c2716bf7c319353c68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071109 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745283}
-
Christopher Lam authored
This CL adds a python script that generates a file with CSS Variables that are specified in a JSON5 file. This will allow unified semantic color (and other properties) specification in Chrome OS. Bug: 1018654 Change-Id: I3a427cbb04f59659143739f717689810da661fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041110Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#745282}
-
Peter Kotwicz authored
This CL merges androidx.browser.trusted.sharing.ShareData and WebApkInfo.ShareData Bug=997771 Change-Id: I96ab7e2a25a20594821977cfde194442cb9f6a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069843 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745281}
-
rajendrant authored
Adds checks for whether navigation is committed and only for http/https navigations. Bug: 1055573 Change-Id: Ib65801efbe1cd66362c885e5b2f0442de65aa918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078784Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#745280}
-
Brandon Wylie authored
This version includes a fix for the crash reported in the attached bug. This change also rolled out to finch, but this will still crash if you build locally with an agsa version earlier than 10.98. Bug: 1053930 Change-Id: I57f83aa1861aba7e6bef58be5a969d13d15ac078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071356 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Steven Bennetts authored
This CL: * Reduces log spam for "Strength" updates for non active networks. * Reduces redundant log spam for "GetShillProperties". * Increases the lines provided for network feedback logs from 400 to 4000. (Currently feedback logs are ~50000 lines or so, so the relative cost is <10% for critical networking information). Bug: 1054951 Change-Id: Ibac865efe8672b9d972a23371e72f79e39127a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068720Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#745278}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a4f9aa037585..fdf027a728e9 git log a4f9aa037585..fdf027a728e9 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 vapier@chromium.org my_activity: add short url for android CLs 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-27 sokcevic@google.com Print content of description backup on exit 2020-02-27 ehmaldonado@google.com git-cl: Add tests for git-cl presubmit Created with: gclient setdep -r src/third_party/depot_tools@fdf027a728e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324,chromium:1056193,chromium:1056309 Tbr: agable@chromium.org Change-Id: I1b66cb222fbb77c5ea7fee609e3793a535971077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079343Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b194b7a67c8..9c9e8d96fb56 Created with: gclient setdep -r src-internal@9c9e8d96fb56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1056809 Tbr: jbudorick@google.com Change-Id: I1cc1a7d7dce812143ecd01ef5402ea1cd76fd399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079286Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbb0a25d1fab..a7dc87893807 git log dbb0a25d1fab..a7dc87893807 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mtklein@google.com add some more instructions 2020-02-27 jvanverth@google.com Add GrD3DUtil. 2020-02-27 jvanverth@google.com Add DXGI_FORMAT to BackendFormat. 2020-02-27 mtklein@google.com bit_and and gather 2020-02-27 robertphillips@google.com Add a GrSimpleMeshDrawOpHelper CreatePipeline method that doesn't require a GrFlushState 2020-02-27 bsalomon@google.com Reset GrGLGpu::fBoundDrawFramebuffer on resetContext 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-27 nifong@google.com Add SK_NO_FONTS check around font uses in skottie Created with: gclient setdep -r src/third_party/skia@a7dc87893807 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I9600e205af7cfade0f3e11f3e5169eef6d9c803e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079350Reviewed-by:
-
Lei Zhang authored
As is, touching web_ui.h results in ~4000 targets getting rebuilt. Forward declare content::WebUI in some headers, or just remove unneeded web_ui.h includes, reduces the number of rebuilt targets to ~850. Change-Id: Ia55aeb559cc16b16f5b872a7262c51cc3522205c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065433Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#745274}
-
Josh Nohle authored
Screenshot at https://storage.cloud.google.com/chromium-translation-screenshots/7fc580944eb5da2b860990438606d22fd6f90311 Fixed: 1008185 Change-Id: Ia00e85fdd1ebd7108dbb152142c8037a484ed4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008410Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#745273}
-
rbpotter authored
fake_input_method_private.js is also used by browser settings tests, so it should not be in the chromeos/ specific folder. Bug: 1026426 Change-Id: I3c88ce63115463dc2966538c6a2536d41d8d71e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076090 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Bettina authored
The experiment is no longer used anymore. Bug: 1054179 Fixes: 1054179 Change-Id: Ie00127cd5327e3313e7684db25797cd14d58ca70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067563Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745271}
-
Vasiliy Telezhnikov authored
There is few dependencies between features: VizForWebView requires UseSkiaRenderer and UseSkiaForGLReadback. UseSkiaRenderer requires EnableSharedImageForWebview. Previously we enforced dependencies in AwMainDelegate which involves changing of command line arguments and has two problems: 1. Finch experiments are not initialized yet at that moment, so they have to enable four features instead of one. 2. Command line overrides finch trials flags. This CL changes how we check for features to enforce all dependencies. Bug: 805739 Change-Id: I34f823640f355637ea0b27d1dec1b5afc3e9bec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067349Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745270}
-
Allen Bauer authored
Bug: 648382 Change-Id: I40d0ab4977c7f39893606a0104239cb2408956ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079511 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745269}
-
Lukasz Anforowicz authored
GetOriginForURLLoaderFactory in render_frame_host_impl.cc calculates the expected origin (or, more precisely, the expected request_initiator_site_lock) for about:blank URLs based on the navigation's initiator (since about:blank frames should inherit their origin from the navigation's initiator). OTOH, before this CL RenderFrameHostManager::DetermineSiteInstanceForURL would ignore |source_instance| if navigating to about:blank was a result of a (webRequest-based) redirect. This meant that |request_initiator_site_lock| disagreed with the origin lock associated with the SiteInstance picked by RenderFrameHostManager, leading to a failed CHECK in the browser process. This CL fixes SiteInstance selection in RenderFrameHostManager by: - Ignoring/removing |was_server_redirect| for about:blank, while preserving the old behavior for data: URLs. - Making sure that error isolation is taken into account (otherwise ChromeNavigationBrowserTest.RedirectErrorPageReloadToAboutBlank would have started failing) - Deduplicating the code that takes error isolation into account (so that |dest_instance| and |source_instance| calculations can reuse the same helper function) This CL adds a regression test that would trigger the CHECK without the RenderFrameHostManager changes in the rest of the CL. The test uses an |opener| page to exercise opener/parent inheritance in Blink (https://crbug.com/585649) even though the regression test would repro https://crbug.com/1026738 even when using just a single page with page_with_two_frames_remote_and_local.html. Bug: 1054579 Change-Id: Icade531b7894627a8d83f8c261b2d34c8cd0b1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064449 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#745268}
-
Frank Liberato authored
This patch adds support for 8-bit and fp16 RGB textures via KHR streams, since ANGLE almost supports it. 8-bit textures work as-is, but fp16 requires a small patch to ANGLE. However, since fp16 support is off by default in D3D11VideoDecoder anyway, it's okay to land this without ordering with respect to the ANGLE changes. Change-Id: I484760e462341bc6cad699d35f2c9733a7404c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079451Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#745267}
-
Rahul Arakeri authored
This CL turns the "Compositor Threaded Scrollbar Scrolling" on by default in master. The details about this feature can be found in the following links: Design doc: https://docs.google.com/document/d/1JqykSXnCkqwA1E3bUhhIi-IgEvM9HZdKtIu_S4Ncm6o Demo page: https://rahul8805.github.io/DemoPages/BouncyMoon.html Lightning talk: https://www.youtube.com/watch?v=FOCHCuGA_MA&t=1150s input-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/input-dev/6ACOSDoAik4 Bug: 148501 Change-Id: Iec2e4de5c79e94815629be37c5bbe4ed435e106b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048418Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745266}
-
Rohit Rao authored
BUG=1024115 Change-Id: I01f1a5f11710a6956cd17ada97b462c250c64d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079391 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745265}
-
Varun Khaneja authored
1. Notifier::OnStartSlowCheck(), PauseReadingBodyFromNet(), and ResumeReadingBodyFromNet() were added with the assumption that Safe Browsing checks mostly return synchronously (except a tiny percentage) so calling PauseReadingBodyFromNet() in only those few cases was a good precautionary measure. 2. The "precaution" was against overzealous AVs that may warn the user if we cache an unsafe resource; note that the resource is not used until Safe Browsing confirms it is SAFE. 3. On mobile, since connection is usually slower, we did not enable this "precaution". That's a very good indication of how good this "precaution" is :) 4. Now, with SafeBrowsingRealTimeUrlLookup enabled, a larger percentage of navigations are going to hit PauseReadingBodyFromNet(). 5. This would have been fine by itself but due to the special handling of PDFs and some other special types, as described in 1056696#c9, this completely breaks the loading of those types. 6. The "precaution" does not seem worth the breakage. See https://crbug.com/1056696#c9 and https://crbug.com/1056696#c12 for full details. R=xinghuilu Bug: 1054978,1056696 Change-Id: I0f6f48831733996e0ab91a0c0c1ab240a1923c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079338 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/cd2eb2e2d632..21be4b46c82c git log cd2eb2e2d632..21be4b46c82c --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Set use_system_xcode GN arg to false on mac Created with: gclient setdep -r src/native_client@21be4b46c82c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056008 Tbr: mseaborn@chromium.org Change-Id: Icf83007415e00161295761b3730d7b78b90c4c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079285Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d2040a6f973..78da538aed52 git log 4d2040a6f973..78da538aed52 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rnk@chromium.org Revert "Vulkan: Disable global merge for volk" 2020-02-27 jmadill@chromium.org Capture/Replay: Capture DrawBuffersEXT. 2020-02-27 jmadill@chromium.org Fix out-of-bounds read in test. 2020-02-27 jonahr@google.com eglGetConfigAttrib validation missing extension check Created with: gclient setdep -r src/third_party/angle@78da538aed52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1015454 Tbr: geofflang@google.com Change-Id: Ia8d67711c2e59d0511bee0a76c06f00a663fd1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079347Reviewed-by:
-
liberato@chromium.org authored
We'd like to know "is user watching video" vs "is user scrolling around the page" when recording power. So, we allow any fullscreen-like experience to count, rather than just strictly full-screening the media element. While this is still not exact, it's much closer to what we want. Bug: 1017787 Change-Id: Idb022eb10a9f5e51f0fdef58c3a11ab5e9f40849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070836Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#745261}
-
dpapad authored
This UI is never shown to the user anymore. It was originally deleted at r704421, but that CL was later reverted at r704423. Bug: 991764 Change-Id: I37ba605350522a6d86188f21db2d058beaa0627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079050 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745260}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9db20bb3437e..a4b47b52e653 git log 9db20bb3437e..a4b47b52e653 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Increase sampling from 0.2 to 0.5 Created with: gclient setdep -r src/third_party/catapult@a4b47b52e653 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: oysteine@google.com Change-Id: Iedd03c66de6b4d0cd01f9d78c755d41448adf687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079349Reviewed-by:
-
Allen Bauer authored
Bug: 1056761 Change-Id: I0f477c21d315ae707825b43daf8a1cbfb11eb72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078996 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745258}
-
Toni Barzic authored
The test was flaky because it was clicking the home button while the hotseat was animating from hidden to extended state. If the mouse events came in the right time, they would be eaten up by the hotseat widget. This means that home button would not change the home launcher state, and the hotseat would remain extended. This should not be an issue any longer: * Today, the default hotseat state with spoken feedback enabled is kExtended, so the hotseat is not animating when test tries to click the home button. * Hotseat widget has since been fixed not to consume events while it's animating. BUG=1020806 Change-Id: I791810ed34eb890b834a93b1a0f26e63d54f3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079536Reviewed-by:Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#745257}
-
Miguel Casas authored
Intel Display Controller does not support AR30/AB30 framebuffers, but only their opaque XR30/XB30 versions. This CL adds a provision for these formats to |prefer_opaque| when importing a buffer. This CL was split off crrev.com/c/2072621, and is used for supporting high bit-depth framebuffers for HDR composition. Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 776093 Change-Id: Iacd0414ea0f0a9dd359796c982ed60d0ee74a737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078655 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#745256}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/729310aa1810..e3e07bf979ea git log 729310aa1810..e3e07bf979ea --date=short --first-parent --format='%ad %ae %s' 2020-02-27 marinaciocea@webrtc.org Introduce frame transformer interfaces for Insertable Streams Web API. 2020-02-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4f8e062e..4ed2234c (744969:745105) Created with: gclient setdep -r src/third_party/webrtc@e3e07bf979ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8beef0caf9307b33b2776aeea6b43c528ac354ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079531Reviewed-by:
-
Josh Simmons authored
is used The CONTEXT_MENU enumeration value was incorrectly being emitted when Quick View was opened via the Selection Menu. The correct SELECTION_MENU enumeration is now emitted. Bug: 1046997 Change-Id: I24f8ec60308c323fbd22dff734e0d07e26c17ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071163 Commit-Queue: Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#745254}
-
