- 19 Mar, 2020 40 commits
-
-
Mike West authored
This reverts commit 0fac3886. Reason for revert: `virtual/controls-refresh/color/color-picker-from-color-suggestion-picker.html` test failures beginning in https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/9370. Original change's description: > Fixed color-picker style when opened from datalist via Other button. > > The issue was caused by the fact that the color-picker style wasn't added > when constructing the color-suggestion-picker popup. > > Added a test to validate the change and prevent future regressions. > > Bug: 1062501 > Change-Id: Iaf561f33e18bf2f26a8f87ffd1fb549118e02764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108091 > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751610} TBR=tkent@chromium.org,masonfreed@chromium.org,iopopesc@microsoft.com Change-Id: I8f55d4ca75cf35bea0da47ba9f79a422ee87bd9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107845Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#751625}
-
Ye Kuang authored
* luci-go's `isolate archive` requires `-isolate` flag. * we also enable `-dump-json`, which dumps a JSON file that contains the SHA1 hash of the isolated file. Tested on the following command: ``` tools/mb/mb.py run -s --no-default-dimensions -d pool chromium.tests -d device_os KTU84P -d device_type hammerhead out/Release/ base_unittests -- --test-filter FakeClass#fakeTest ``` It runs successfully. Bug: 1062881 Change-Id: I46af6679e43d3af6bfed797485cb485b39235733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105272Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#751624}
-
Maggie Chen authored
This reverts commit 3b813a2b. Reason for revert: <This is the suspected CL that breaks 12 GPU FYI bots on webgl2_conformance_validating_tests, webgl2_conformance_gl_passthrough_tests, webgl2_conformance_tests, webgl_conformance_d3d9_passthrough_tests and webgl_conformance_vulkan_passthrough_tests. Will come back to check the FYI results to decide if reland is needed.> Original change's description: > Fix WebGL PushFrame crash when GetDrawingBuffer returns NULL > > Bug: 1059491 > Change-Id: I6df4870cb8ece3986a2ad0fecd28b50593ae2e8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108874 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Shrek Shao <shrekshao@google.com> > Cr-Commit-Position: refs/heads/master@{#751547} TBR=kbr@chromium.org,kainino@chromium.org,shrekshao@google.com Change-Id: I1b88f2e4f36b69c6a4daf07d0fc4ee21830ebe1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109460Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751623}
-
Gyuyoung Kim authored
Null crashes and flakiness test failures have taken place after converting WebTestHostMsg_InitiateCaptureDump and BlinkTestHostMsg_PrintMessage. The flakiness happened when a message came from different frames almost simultaneously. But, existing implementation was implemented by using Remote instead of AssociatedRemote. So, a race condition happened. Clusterfuzz has reported crashes that happened in BlinkTestController. The crashes happened in case of when BlinkTestClientImpl called functions of BlinkTestController even after BlinkTestController was destroyed. So, this CL makes BlinkTestController inherit BlinkTestClient interface directly in order to completely eliminate the possibility of the crash. Bug: 1059322, 1059474, 1061180, 1061328, 1061441 Change-Id: Icd499c76e812565e24afd1d7ebf54b82202cf88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104567 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Maggie Cai authored
Currently the storage of preferred app takes up too much space. This CL introduce an optimized storage data structure. Start with the add and find functionality. This CL also ports in the relevant unittests from the original data structure to ensure the test still passed. More unit tests will be added in follow up CL. BUG=853604 Change-Id: I88e57033dde98275a638e64496e0fe86a15e880d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108302 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#751621}
-
arthursonzogni authored
[Note to sheriff] Feel free to immediately revert this CL if this test is failing in the next 3 days. This test was marked flaky 2 years ago, but nobody was assigned or CC. As a result, it hasn't been properly investigated. This patch enables it again. If it works, great. If it doesn't work we will get useful data about it. R=mkwst@chromium.org Bug: 745887 Change-Id: I0c50d61992dd56a13aee891e4eedfd14c43bc9df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108144 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9f2f702a988..96f5a877f9c0 Created with: gclient setdep -r src-internal@96f5a877f9c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If18251ce726129f14630f08001a1400927e880c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751619}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3b92b910ce0..d65a790d71e8 git log d3b92b910ce0..d65a790d71e8 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 440fc9959f06..bc98fbeec99b (3 commits) Created with: gclient setdep -r src/third_party/skia@d65a790d71e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I1a4b12d463849bbda875e6d003d0940547327025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751618}
-
Hiroshige Hayashizaki authored
This CL modifies generated files affected by https://chromium-review.googlesource.com/c/chromium/src/+/2109570 Bug: 906850 Change-Id: I4891492ed2fe88a8dbf24cbdb3b1a9d27c317309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109511 Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751617}
-
Eriko Kurimoto authored
This CL changes the WorkerGlobalScope's SecurityOrigin for workers constructed in chrome-extension. Previously, workers didn't inherit the origin from their parents but create security origin from their url. SecurityOrigin::Create(creation_params->script_url); Usually, the result of this is the same with inheriting the parent origin since workers are same-origin only. However, in chrome-extension, it is allowed to construct a cross-origin worker if the script url has the permission. In this case, we should inherit the origin with 'chrome-extention://example/' so that the |request_initiator| matches to what the browser can see. This CL also adds the test for subresource fetch from dedicated workers and shared workers constructed in chrome-extension. This test covers the case that worker's script url is cross-origin to chrome-extension but included in permitted urls by chrome-extension. The worker should allow same-origin and cross-origin fetch unless the script url is not permitted by chrome-extension. Bug: 1059218 Change-Id: I498399275d3b4c2c3085e26a8e37145aa74f1d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091327Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#751616}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/33997f3d931a..64e0899efa07 git log 33997f3d931a..64e0899efa07 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 mjackson@microsoft.com Avoid automatically reloading DevTools on Theme change 2020-03-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@64e0899efa07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1001549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia73dc166bc529a025c7dc85cb87e3ed887c1b3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109612Reviewed-by:
-
Alan Screen authored
The print compositor is now able to concurrently generate the print document while compositing the individual pages for preview. When this is happening we can improve the renderer by not collecting and capturing a full document object. Testing: On Windows platform watching the "Peak Private Bytes" in Process Explorer, observed an increase of renderer process memory of only 59MB, roughly about the size of one page's worth of metadata. This is much less than the hundreds of megabytes that it used to grow by when the renderer would still create the full document metafile. This was observed for the testcase [1] (taken from prior issue 872935). [1] https://www.gmbinder.com/share/-LFhhtssjN-teWCOregn Bug: 1026968 Change-Id: I697ebd4129722c63e4847d54a65d75a4b3e9f1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068936 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#751614}
-
Joel Hockey authored
System Web Apps use a domain such as chrome-untrusted://terminal which should not be shown to users. The concept of a domain for System Web Apps is not so useful, and should not be required for users to identify or differentiate between tabs in a System Web App browser. Bug: 1060863 Change-Id: Ib0fe04b6d6d982162c89d6599522da8669d2553e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108218 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751613}
-
nancy authored
Add "Learn more" link for the PWAs unisntall dialog per UX deck: https://docs.google.com/presentation/d/1jfyLf21naKDQwe07jkhgqtI8Fd2Z88W93l1F1q3FyhY/edit#slide=id.g6e0ab3bcaa_0_0 https://docs.google.com/presentation/d/1jfyLf21naKDQwe07jkhgqtI8Fd2Z88W93l1F1q3FyhY/edit#slide=id.g7d0934dbfa_0_0 Mock dialog: https://photos.app.goo.gl/AtQfZr9RYKH5HsMi9 Move OnDialogCancelled and OnDialogAccepted to keep the consistent order as the definition in *.h file. BUG=1010303 Change-Id: I5c955940643c3753e68fca6aa9a3d07aed226615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106986 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f955fb455585..dadeffa315e7 git log f955fb455585..dadeffa315e7 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 jmadill@chromium.org Capture/Replay: Fix stride in compressed texture caching. Created with: gclient setdep -r src/third_party/angle@dadeffa315e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I715e200fe27e3d8d5d20e5e819444a84862f6740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109265Reviewed-by:
-
Ionel Popescu authored
The issue was caused by the fact that the color-picker style wasn't added when constructing the color-suggestion-picker popup. Added a test to validate the change and prevent future regressions. Bug: 1062501 Change-Id: Iaf561f33e18bf2f26a8f87ffd1fb549118e02764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108091 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#751610}
-
Alan Cutter authored
Bug: 1007786 Change-Id: Idd730b35e0cead74b10ff758c1339f18c5a6e754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105187 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751609}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43f82417b9f711be4d69560cb6c15c8766d51b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109211Reviewed-by:
-
Karandeep Bhatia authored
Currently the single static indexed ruleset for an extension is stored at $extension_path/_metadata/generated_indexed_ruleset. Since we plan to support multiple static rulesets, we need to store multiple indexed rulesets. This CL changes the static indexed ruleset location to $extension_path/_metadata/generated_indexed_rulesets/_ruleset$ruleset_id. This helps us move the code away from the assumption of a single static ruleset. As a result of this existing extensions with a DNR ruleset will initially fail to load the DNR ruleset. However the re-indexing logic should step in and ensure the extension works seamlessly. A side-effect for these extensions is that the old indexed ruleset will remain on disk. However this is ok since the API is still on beta and doesn't have significant usage yet. Furthermore, we do periodically clean up extension folders after extension updates. BUG=754526 Change-Id: Id3bd6c1e25fde4ceb1a34f9f84c67bfa340790ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094626 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This CL adds a constructor of MainScriptResponse which takes URLResponseHead. Tests and ServiceWorkerNewScriptLoader use the new constructor to reduce HttpResponseInfo use in service worker codebase. Bug: 1060076 Change-Id: I884efa7c1e15789ef46fdab0998136c0f9695d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105183 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751606}
-
Yury Semikhatsky authored
When browser shutdown started pipe file descriptors are closed on the UI thread while there may be outstanding reads and writes on parallel threads. If such read/write operations fail error messages will only be written to the console if pipe shutdown has not begun yet. Bug: none Change-Id: I57e9b6c7f2921335cc2bb1f5289bd9347bba1f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108825Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#751605}
-
https://crbug.com/1006814Fergal Daly authored
Record whether we are currently in the middle of dispatching handlers for process-death as this is a stronger contender for how this is occurring. Bug: 1006814 Change-Id: I0d269c250a870c25088e92c4b207e7fa647f0bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106987Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751604}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1574c49c4f09..33997f3d931a git log 1574c49c4f09..33997f3d931a --date=short --first-parent --format='%ad %ae %s' 2020-03-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@33997f3d931a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4a625cd533f41470a171f9027adbb58d9af9c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108499Reviewed-by:
-
Hiroshige Hayashizaki authored
When `spec.src.json` is modified, the order of subtests were changed and thus unncessesary diffs were generated, even if the subtest contents are not modified. This CL sorts subtests to avoid such diffs. Generated files will be modified in https://chromium-review.googlesource.com/c/chromium/src/+/2109511 Bug: 906850 Change-Id: Ic17d8122b0b5139e89ec2b4423511b933941ad65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109570Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8413a03c394c..df670f0bed9e git log 8413a03c394c..df670f0bed9e --date=short --first-parent --format='%ad %ae %s' 2020-03-19 fancl@chromium.org Remove the Sheriff model and related infra Created with: gclient setdep -r src/third_party/catapult@df670f0bed9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050891 Tbr: oysteine@google.com Change-Id: Idbf9ee38cffc3bd3b4ba4af57c9fbc11ff59cd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108926Reviewed-by:
-
Theresa Wellington authored
The KitKat CQ bot is no longer running chrome_public_test_apk, so goldens weren't updated with in crrev.com/c/2096101. KitKat was removed as an expected version for RenderTestRule in crrev.com/c/2108912, but existing render tests with KitKat goldens still either need to be updated or have their KitKat goldens removed. BUG=1060030 TBR=wychen@chromium.org Change-Id: I3d00e00f98e4957e9ca52994ed463a3cbba26044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108574Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751600}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd01ffa2b6de..f9f2f702a988 Created with: gclient setdep -r src-internal@f9f2f702a988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I168b71781b69506a4559cfa308c95f839181498e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107513Reviewed-by:
-
Satoshi Niwa authored
chromeos_channel value for ARC container is also extracted in the same way. (GetChromeOsChannelFromFile() in arc_setup_util.cc) This fixes the issue that "unknown" value is set for testimage (b/151289109) BUG=b:151289109 TEST="android-sh -c getprop" and check ro.boot.chromeos_channel is "testimage" Change-Id: I7d84dab2adb665f56689cb26c2cd20082d64272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108306 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751598}
-
K. Moon authored
TestDocumentLoader currently loads the entire test PDF file as soon as PDFiumEngine calls DocumentLoader::RequestData(0, 1). This change adds a new TestDocumentLoader::SimulateLoadData(uint32_t) method that allows a test to control how quickly the document loads. A future test will take advantage of this to put the PDFiumEngine into a partially-loaded state. A test can request the TestDocumentLoader by calling PDFiumTestBase's InitializeEngineWithoutLoading() method instead of InitializeEngine(). This change also removes the DocumentLoader::SetDocumentSize() method, which only was used internally by DocumentLoaderImpl anyway. Bug: 1051548 Change-Id: Ib5256aa70c468284e0f01964b409f2a85a9a066a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067692 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#751597}
-
Henry Jian authored
This reverts commit 3c12c3b0. Reason for revert: it breaks chrome AR, see https://crbug.com/1062910 Original change's description: > [Android] Move linker from Trichrome library to chrome > > Also, move linker loadable module inclusion from rules.gni to > chrome_public_apk_tmpl.gni > > Bug:1032062 > > Change-Id: Idfd0116321ee23b6cf8e6628553f10c569bb6b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091645 > Commit-Queue: Henry Jian <hzjian@google.com> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749845} TBR=wnwen@chromium.org,agrieve@chromium.org,hzjian@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032062,1062910 Change-Id: I26aa95ed864410b9a721ecdc6243441fc5721e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109252Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#751596}
-
Anand K. Mistry authored
Bug: None Change-Id: I28c0fe028f906807628e62c84a380e293b18fc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105688Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751595}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I6fa56c1cdd6bfbc92b6954a05da232bcf61ecec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108617Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Nicholas Hollingum authored
This is a reland of 9b8ade13 Original change's description: > Crostini Upgrader: Do not proceed if user cancels backup > > Previously if the user cancelled the backup, we would proceed with the > upgrade as though the user had elected not to backup at all. > > With this change, the flow will instead return to the initial screen > when the user cancels, rather than proceed. > > Bug: 1061203 > Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nic Hollingum <hollingum@google.com> > Cr-Commit-Position: refs/heads/master@{#750833} Bug: 1061203 Change-Id: I983fc82b74db8cba6f2d2acf6997c8d0a2a25bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109431Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#751593}
-
Kelvin Jiang authored
Bug: 947591 Change-Id: I06b2ff6505ed0f1efd326df2a73cac8ee3ec35bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081363 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751592}
-
Nancy Wang authored
This reverts commit e3e24fb5. Reason for revert: <INSERT REASONING HERE> Tree is close because of this CL: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/24482?blamelist=1#blamelist-tab Original change's description: > [CrOS setting] Move OS routes into os_settings_routes.js > > Before this CL, routes for both browser and OS where in routes.js file. > This CL removes routes for chromeOS to a new file os_settings_routes.js > also updates references to SettingsRoutes to OSSettingsRoutes in all > chromeOS files. > > Fixed:967861 > > Change-Id: Ib3aea093fad90188699e7325632dc93610336f99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090794 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Cr-Commit-Position: refs/heads/master@{#751587} TBR=khorimoto@chromium.org,rbpotter@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com Change-Id: I58359fa710ace42d2dc3c184d080263df8de1f51 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108452Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751591}
-
Christopher Lam authored
This CL adds specificity to generated CSS variables. This is needed to override the variables defined in paper-styles/color.html and shared_vars_css.html. This will allow us remove deprecated colors and ensure that clashing color names will resolve to cros_palette colors. Bug: 1062154 Change-Id: I87fbd3013daae8f6553f3129ed44d27be51b18b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106041Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#751590}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d9ebe015405d..93bcaae44524 git log d9ebe015405d..93bcaae44524 --date=short --first-parent --format='%ad %ae %s' 2020-03-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1386d9f5..d69529f5 (751294:751530) Created with: gclient setdep -r src/third_party/webrtc@93bcaae44524 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icfc054cf27b77adb1fe05b4c5da2abf797261f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108924Reviewed-by:
-
Mei Liang authored
This CL enables TabSelectionEditor to show a List for low-end devices. Change-Id: Ie60c1e7ddcda09c2f32e23c4de52be7e642e09e0 Bug: 1042889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103313 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751588}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, routes for both browser and OS where in routes.js file. This CL removes routes for chromeOS to a new file os_settings_routes.js also updates references to SettingsRoutes to OSSettingsRoutes in all chromeOS files. Fixed:967861 Change-Id: Ib3aea093fad90188699e7325632dc93610336f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090794Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#751587}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ibfa72892603bf293ad5777213cc02fe1e4bfb2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107917Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751586}
-
