- 13 Aug, 2019 40 commits
-
-
Peng Huang authored
Bug: 974359 Change-Id: Idcc3c80eda39d4c94470c7f5542fea68dc65cc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751823 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686434}
-
Thomas Tangl authored
The menu width no longer depends on the Dice state. The Dice menu width is always used from now on. Reasons: - The pre-Dice menu works perfectly with the Dice menu width. - pre-Dice users are a very small percentage of users. - pre-Dice users will soon be migrated. Bug: 966388 Change-Id: I0721a0f7d2f56891ad9d01c99bce77505b3b9779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751842 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#686433}
-
Eugene But authored
This change is made because all subdirectories of ios/web/public represent features, while web_state subdirectory is class name. The move proposal was discussed here: https://docs.google.com/document/d/1C2YIU0rDbH5wz2VI6nk0COrktwY3DbF-e7QbMIAKEJc/edit TBR=blundel@chromium.org Bug: 942244 Change-Id: I0cd8cfc540ccf22335bde366bc9d1de3f5aeef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748085Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#686432}
-
Joe Mason authored
Also adds a presubmit check in //chrome/chrome_cleaner to make sure no BUILD.gn files are added to subdirs without an explicit visibility declaration. This is a safety measure to ensure that changes to the //chrome/chrome_cleaner directory won't affect anything else in chromium. R=vakh Bug: 985787 Change-Id: I8185a74542bea3bb96df31144c1d5a641de4a527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749529 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#686431}
-
Christos Froussios authored
When PasswordStoreDefault initialises the LoginDatabase, if the step fails, it will set the database to null. In that case, PasswordStoreX should not attempt to perform a migration. Bug: 991213 Change-Id: Id31a65b228532c1206283f6af175f339efbb292b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746167Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#686430}
-
Takuto Ikuta authored
This is followup for https://chromium-review.googlesource.com/c/chromium/src/+/1750477 Change-Id: Ib1151a14b482d015985e5d0bc4f5cb00898dfafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752262 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686429}
-
Mike Frysinger authored
Python 3 moved StringIO.StringIO to io.StringIO. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I2e6c19c5009a1bf77ca427b94272ba475d96861e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700506Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686428}
-
Nick Burris authored
This fixes a bug with ChromeOS touchpad scrolling where a fling scroll is initiated even if the scroll events are consumed. Fling scroll events are not cancellable so this results in a fling scroll happening at the end of a consumed touchpad scroll, as demonstrated on https://jsfiddle.net/kuqhjem4/. Bug: 894223 Change-Id: I38f9f3ba3b6651540c26304832fc662b6d72a5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733575 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686427}
-
Kevin Babbitt authored
Narrator frequently calls ExpandToEnclosingUnit() for page or document units when moving by words. This call was accounting for a sizable fraction of each movement step, and about 56% of it was spent creating the start and end positions. Switching to tree positions to find them eliminates almost all of that cost. Bug: 928948 Change-Id: I447aae5f089a27d041c2b173b16bf40629cb64ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745547 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#686426}
-
Yann Dago authored
Bug: 990538 Change-Id: I8707e2b3dbf4083460f4e5bbe52b35d95bd26b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746646Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#686425}
-
Navid Zolghadr authored
This CL sends scrollend event if GSE is being handled on the main thread after the snap (if the snap has started after GSE). It also takes care of sending scrollend event for snap after fling. This CL is exactly the same as previous CL that got reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1743253 with some modification to the test and input injection instrumentation to solve the leak bots. TBR=bokan@chromium.org Bug: 907601 Change-Id: I02f501573cb2021473df0b36f4c512b82e617fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749790 Auto-Submit: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686424}
-
Chris Mumford authored
This CL moves the "Android WebView and the UI thread" document at: https://docs.google.com/document/d/1sDMN-K4TPh8osNBt-4ANfhf9FrRWl3xxrGRp7O-hkB8 into Markdown. Bug: None Change-Id: Ia33d68f92b881485c43b7a7dcfab37f8cfabf258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746488 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686423}
-
Rouslan Solomakhin authored
Originally landed in: https://crrev.com/c/1687795 Reverted in: https://crrev.com/c/1746959 Reason for revert: Use-after-free of browser context. Fix in reland: Store service instance group token in the callback and map that to the browser context when necessary. If the browser context has been freed, the mapping will return a nullptr. Bug: 980249, 992285 Change-Id: I8a92dd448cc81c940cb18bc9596f6af3329aee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749982Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686422}
-
Dominik Röttsches authored
Additional underline tests from Mozilla testing offset and thickness. Bug: 785230 Change-Id: Iabfbf884beb1d827f27cee82acef2743d5bc5bf2 Tbr: schenney Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751727Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#686421}
-
Mohamed Heikal authored
aapt2 optimize --enable-resource-path-shortening is non-deterministic in the latest aapt2 release. This is has been fixed in aapt2 ToT. Also add myself as an OWNER to the package. Bug: 753402 Change-Id: I356b123251130601c1746dbe5c2fad791cdfbf9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749847Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#686420}
-
Makoto Shimazu authored
Previously it doesn't care about the throttles, but it means the update requests will be missed from the embedder. This CL is to use ThrottlingURLLoader in ServiceWorkerSingleScriptUpdateChecker, and also this makes ServiceWorkerNewScriptLoader be able to inherit the throttling loader if it's resuming a cache writer. Now throttles work only on the UI thread, so this CL introduces a thin wrapper to invoke method calls on the UI thread. After this CL lands, I'm going to add code to send the paused state to the renderer as a resource override so that the renderer doesn't create ThrottlingURLLoader for the request which is already using ThrottlingURLLoader in the browser process. Bug: 988957 Change-Id: I32e19d3cd7071dddc056ffdab2bfad36679d5b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728889 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686419}
-
Tibor Goldschwendt authored
This will make the modules target SDK version 29 if we build with the Q SDK. TBR=yfriedman@chromium.org Bug: b/139271004 Change-Id: I5777893c61644f4c27292d57295553352ff0cd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751903Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686418}
-
Julie Jeongeun Kim authored
This CL converts SetupDevToolsFrontend from devtools_frontend.mojom to new Mojo types. Along with updating mojom interfaces, it also updates methods and members which take DevToolsFrontendAssociatedPtr, DevToolsFrontendAssociatedPtr, DevToolsFrontendHostAssociatedPtrInfo, DevToolsFrontendAssociatedRequest with new Mojo types. Bug: 955171, 978694 Change-Id: I7896a82b81b36066b5d36ca91fc86f858fd9c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748966Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#686417}
-
Roger Tawa authored
This reverts commit dd7de273. Reason for revert: See crbug.com/993369 for details. ContextMenu2/FilesAppBrowserTest.Test/checkInstallWithLinuxStateForDebianFile_DriveFs fails consistently. Original change's description: > Add integration test for Install with Linux context menu option > > Add test to ensure the "Install with Linux" context menu option is > hidden/shown when Crostini root access is allowed or disallowed by > kUserCrostiniRootAccessAllowedByPolicy policy preference control. > > Feature flag kCrostiniAdvancedAccessControls is enabled for file > manager browser tests to test this functionality which is hidden > behind the flag. > > Follow up CL to crosreview.com/1730907 > > Bug: 983997 > Change-Id: I12f70ea516528275b327525119587d0f0742a50d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738686 > Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686349} TBR=noel@chromium.org,lucmult@chromium.org,chrisgunadi@google.com Change-Id: I588c0d21861b603f972977cb34aff66a1e88dd24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752124Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686416}
-
Manu Cornet authored
Change-Id: I1e561547fe954e8516ed0daf80ccd8dcf33517c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750347 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686415}
-
Donn Denman authored
Fixes a null-dereference regression from a recent CL that added support for scrolling to a position:fixed element when there a scrollable visual viewport. Also implements GetSmoothScrollSequencer by getting it from the main frame if possible. BUG=992683 Change-Id: I75cbb7e25e1a8289e1405f01d2d9ddfafb785361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749549 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#686414}
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/259645392 to client. Change-Id: Iae12415e75902d0199d84dc0e0b99714609164c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751248Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#686413}
-
Jun Cai authored
This CL changes sms dialog background color to use sheet_bg_color so that when Chrome changes to different theme, the dialog background is also changed. This is to fix the text on the dialog not visible when Chrome changes to dark theme. I uploaded some dialog screenshots when using default theme and dark theme on the issue page. Bug: 991392 Change-Id: Ib685689e7f150a09243edf9d02b61b166ea54276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749764Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#686412}
-
Andy Paicu authored
This represents steps 7 and 8 of: https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj Bug: 950905 I have combined these two steps as they make a lot of sense together. 1) A new bool `obey_origin_policy` has been added to ResourceRequest 2) Based on its presence: a) The `Sec-Origin-Policy` HTTP header is set b) The OriginPolicyManager is used to retrieve the policy c) The policy is saved on the ResourceRequest 3) The OriginPolicyThrottle has all the necessary information to trigger the interstitial or allow the navigation. Change-Id: I75b4da55f01c0eff461e005a92f24b28925eef62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706428Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#686411}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ideec0f3a60319eee3354642074ff3be7d078b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751827 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686410}
-
Yuki Shiino authored
Fixes pydeps settings and makes web_idl module work without user-side settings of PYTHONPATH. This hack workarounds an issue that action_with_pydeps and print_python_deps.py don't provide a chance to set up PYTHONPATH. Bug: 839389 Change-Id: I342e3dbd5b6d23a555e3ee253c362e6a82ff6f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751423Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#686409}
-
Roger Tawa authored
This reverts commit 4051b667. Reason for revert: see crbug.com/993332 for details. Essentially DumpAccessibilityEventsTest tests consistently fails. Original change's description: > Change mapping of text leaf nodes and line breaks to ATK_ROLE_STATIC > > Text leaf nodes and line breaks were being exposed as ATK_ROLE_TEXT. > However, the definition of ATK_ROLE_TEXT is: > > An interactive widget that supports multiple lines of text > and optionally accepts user input, but whose purpose is not > to solicit user input. > > In contrast, ATK_ROLE_STATIC is defined as: > > A generic non-container object whose purpose is to display > a brief amount of information to the user and whose role is > known by the implementor but lacks semantic value for the user. > > Thus text leaf nodes and line breaks should be exposed with the latter > role; not the former. > > Bug: 984590 > Change-Id: I4dfbf8d8d90a3f894803a62914a6d9882828957e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749145 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Cr-Commit-Position: refs/heads/master@{#686343} TBR=mrobinson@igalia.com,jdiggs@igalia.com Change-Id: I7dc55820a07ebdd6be722aa3e1e305fbc9d48781 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751830Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686408}
-
Peter K. Lee authored
This feature flag is now default enabled. No need to check it at runtime. Bug: 905891 Change-Id: Id2b9d720146cd5aaae4c5a4bb40f17a48506be5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746734Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#686407}
-
Olya Kalitova authored
Adds keyed service to handle Crostini Ansible management so that this feature is separated from Crostini manager and Crostini manager does not get overloaded. This CL also adds basic functionality for Ansible installation. Bug: 986276 Change-Id: Ia5d0cab00f5f40ab152131f2edd2dce52a0bb524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712677 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#686406}
-
Dominik Röttsches authored
The fallback cache was originally introduced in issue 603314 to avoid extra IPC overhead when finding fallback fonts for an identical base family. It needs to be investigated in how much this cache actually helps, but for now, avoid CJK fallback cache priming inconsistencies by adding the locale to the cache key. When an ideograph character was requested with a Chinese locale before requesting it with a Japanese locale, the Japanese request would retrieve a Chinese font and vice versa. Add the locale to the key to avoid ignoring the locale, which is very relevant for CJK fallback. I was not able to add a test with reasonable effort: as the current code tries the user preferences fonts first for CJK characters and does not necessarily reach fallback. On the other hand, testing this is in a more localized unittest is not possible at it requires a Mojo IPC connection to the browser process and DWriteFontProxy to be running on the other side. In the existing FontFallback unittests, a DWriteFakeSender is initialized which simulates a font collection with only one font and does not allow access to system fonts. Bug: 992936 Change-Id: I4635bf2d3f7d598e89357dbd3269510667e2f961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751246 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#686405}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7dfd381e1295..7741db7456bc Created with: gclient setdep -r src-internal@7741db7456bc The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I7d473cfd6420ae42ddec8573bc105b210d518098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751442Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686404}
-
Sam Maier authored
There are class verification errors that must be retried at runtime. This prevents inlining of some errors to reduce the number and size or these verification errors. Bug: 991851 Change-Id: Ib49621f20ad48d2017e984c47e84f6c6ee7cda58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746840Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#686403}
-
Mohamed Abdelhalim authored
This includes adding a new member to RenderFrameHostImpl to store the latest http status code. Bug: 990812 Change-Id: I83e61b328df4e37194cc3e1b17952986dd48cf1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742152 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#686402}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2d4016c4. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I54bcd885e214164ea8b0b61ecad4fd3858b980f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751462Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686401}
-
Kenichi Ishibashi authored
This is a follow-up CL of https://crrev.com/c/1743227. We plan to start service worker threads on the IO thread so use main thread orthogonal suffix. We use "the initiator thread" instead of "the main thread." Bug: 692909 Change-Id: I624df28773807677c830cd385c82b8b78440e26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745685 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686400}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9b45b5aafa37..b6d7c5370888 git log 9b45b5aafa37..b6d7c5370888 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 shaobo.yan@intel.com Reland "Fix dynamic buffer offset issues on D3D12 backend" 2019-08-13 enga@chromium.org Factor RenderPass command validation Created with: gclient setdep -r src/third_party/dawn@b6d7c5370888 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I2f0fe8c3ec78b88166b603b5529546d21fdcd796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686399}
-
Tina Wang authored
Change-Id: Ie8c61e4e7d8528bbdbad2187f222a9ca261c805d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716009 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#686398}
-
Joel Hockey authored
If System Web Apps support tabs, then the new tab '+' button will load the app launch URL rather than the default chrome://newtab/. Bug: 990158 Change-Id: I66bc86335135fefe22fbc954d17a52ea88528f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748974Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#686397}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1c632e376ba4..772d5c6161c5 git log 1c632e376ba4..772d5c6161c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 perezju@chromium.org [Telemetry] Remove telemetry.benchmark_runner Created with: gclient setdep -r src/third_party/catapult@772d5c6161c5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:928275 Change-Id: I7b212040de1b979e871808c70fca3a0c2c40ba6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686396}
-
henrika authored
It seems like there are some audio devices with more than 8 channels (on Mac) trying to render remote media streams. Given that there is no standards on how to upmix to more than 8 channels we instead provide silence in these extreme cases instead of crashing which was the case before. Bug: 986415 Change-Id: I82d9422e4888cb07ccc1c531e3276f2685bff6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751191Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#686395}
-