- 27 Sep, 2018 40 commits
-
-
Kent Tamura authored
Replace content::FileChooserFileInfo usage with blink::mojom::FileChooserFileInfo. * Replace std::vector<content::FileChooserFileInfo> with std::vector<blink::mojom::FileChooserFileInfo*Ptr*> because it's the representation of array<fileChooserFileInfo> in mojom. * Because FileChooserFileInfoPtr is not copyable, we use std::move() to pass it over functions. * We temporarily transfer std::vector<blink::mojom::FileChooserFileInfoPtr> over legacy IPC. Add ParamTraits<blink::mojom::FileChooserFileInfoPtr> because FileChooserFileInfoPtr is not a simple struct for which we can use IPC_STRUCT_TRAITS_* macros. FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454 Bug: 869257 Change-Id: I73d54b70d3e24c917a783d3eafa1f29c292dc2bc Reviewed-on: https://chromium-review.googlesource.com/1237798Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#594763}
-
dpapad authored
per Polymer 2 migration guide: - wrap <style is="custom-style"> with <custom-style> - move <custom-style> inside <body> Bug: 739532 Change-Id: I089208681d14e19e71251a41e80bd024c02d1b3a Reviewed-on: https://chromium-review.googlesource.com/1247530Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594762}
-
Ioana Pandele authored
If there is no keyboard accessory, signaling that password generation is unavailable doesn't constitute a state update. The keyboard accessory should only be created and initialized if there is an action or data to display. Bug: 888932 Change-Id: I9dbf8bd1ce4ae620f9b50e4e4aadb7c3c2335733 Reviewed-on: https://chromium-review.googlesource.com/1249084Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#594761}
-
Vladimir Levin authored
This patch changes force_subtree_update bool into "reasons" that fall into one of two categories: - Isolation piercing, meaning that the update crosses and recurses into an isolation boundary. - Isolation blocking, meaning that the recursion may be blocked by isolation. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5389a02b8cc529ca93bf0e50b225b0f343e2439 Reviewed-on: https://chromium-review.googlesource.com/1247201Reviewed-by:Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594760}
-
Daniel Bratell authored
Some jumbo build configurations would not compile because of the unused field. The are not allowed by the build system but sometimes only jumbo builds notice such things since they have access to more source code. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I079412fc98e5812f709b6566d02de9d91a5a8706 Reviewed-on: https://chromium-review.googlesource.com/1249485Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#594759}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d9930ffe556..f7f0def7921b git log 0d9930ffe556..f7f0def7921b --date=short --no-merges --format='%ad %ae %s' 2018-09-27 fmayer@google.com Move unix socket to base. 2018-09-27 fmayer@google.com profiling: Add missing pieces to heapprofd. Created with: gclient setdep -r src/third_party/perfetto@f7f0def7921b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ide7d3b2ee71ae12939560cd7473f051537c5f610 Reviewed-on: https://chromium-review.googlesource.com/1249626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594758}
-
Tommy Martino authored
Currently, the password dropdown only uses a two-line style when disambiguation text (i.e., the subdomain on which the password was saved) is available. For the experiment, when a user is in the Two-Line group, we want to always use a two-line display, even when no such text is present. This CL puts the obscured password (e.g., *****) on the second line in such cases. Bug: 870342 Change-Id: I77deba680277bdbe9ed8e435205e8fc7f18f0ef4 Reviewed-on: https://chromium-review.googlesource.com/1247029Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#594757}
-
Antoine Labour authored
This is not used anywhere any more. Remove extension, entrypoints, bindings and tests. Bug: 889651 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3e2c95f7531752f2690b1f3e4345620bf4efb2d Reviewed-on: https://chromium-review.googlesource.com/1247191Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594756}
-
Antoine Labour authored
This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster. This also adds memory accounting in SharedImageFactory/SharedImageStub. TBR=boliu@chromium.org,sadrul@chromium.org Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7cb3837f2082c5a4d03a9bc71e91dc265cbd0e82 Reviewed-on: https://chromium-review.googlesource.com/1242080 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d8c6f4f9d8f..a16c39ef89c4 Created with: gclient setdep -r src-internal@a16c39ef89c4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I557eee8fcb096f692c4fbf797f02cf3a95c7c7c6 Reviewed-on: https://chromium-review.googlesource.com/1249624Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594754}
-
Jérôme Lebel authored
Adding cell to a sync error if it exists. This cell disappears when the error is fixed. The asset is missing. https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3e63bc1501_10_15 Screenshot (shared with chromium accounts): https://drive.google.com/open?id=1S8kzlFmUwErOTn3BFC-2rR7KBeOX-V9i Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I69eeac598b5d1742528acb16d8c0cc672580b402 Reviewed-on: https://chromium-review.googlesource.com/1231333 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#594753}
-
Christian Biesinger authored
To avoid the previous regression (see analysis in bug), we force layout in the case where we otherwise would get an outdated result. Bug: 596743 Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756 Reviewed-on: https://chromium-review.googlesource.com/1246730 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#594752}
-
Yves Arrouye authored
In some situations, Start() would be called from both the constructor and the observer notification method quickly, yielding to multiple concurrent flows. Prevent those. In addition, redo the tests so that they test both work from the observer notification method and from an existing policy. Also add a test that triggers the concurrency situation and verifies that there is only one flow running in that situation. BUG=chromium:887683 TEST=unit_tests --gtest_filter=*EnrollmentPolicyObserverTest* CQ-DEPEND=CL:1234373 Change-Id: Ice6b46e19bf77a837b4c4908f332e9af6c5189f5 Reviewed-on: https://chromium-review.googlesource.com/1237242 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594751}
-
Jialiu Lin authored
We'd like to learn the distribution of users' browser window (content area) size to guide the vision-based phishing detection model training. This CL collects the contents area size for SBER users when PG pings ( both on focus ping and reuse ping) are sent. Server side proto change has already landed cl/214521992 Bug: 882942 Change-Id: Id7feb60372b59c36ec8fcfa435bd1b461e8ce735 Reviewed-on: https://chromium-review.googlesource.com/1246662Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#594750}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/shell_integration_win.cc. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=gab@chromium.org Bug: 874080 Change-Id: Ifa0f35aa3000ab99401647c45a131b3c457eeb8c Reviewed-on: https://chromium-review.googlesource.com/1191095 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Patrick Monette <pmonette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#594749}
-
Evan Stade authored
TBR=sky@chromium.org,dcheng@chromium.org Bug: none Change-Id: I0e6ee1377df56412d3b000808de5a7d5382c33b2 Reviewed-on: https://chromium-review.googlesource.com/1249532Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594748}
-
Evan Stade authored
1. Implement Mojo api for snapping (FrameCaptionDelegate) 2. Move CustomFrameHeader to //chrome, rename to BrowserFrameHeaderAsh 3. Share more code between Mash and classic Ash in BrowserNonClientFrameViewAsh 4. Move FrameHeader to //ash/public, along with some utilities and vector icons 5. Delete some immersive-related code. The mash reveal widget and DetachedTitleAreaRenderer are no longer needed. 6. Remove some ash window properties that are no longer necessary TODO: 1. remove old browser theme related code, including BrowserImageRegistrar 2. add handling for double tap/double click on browser window caption (to maximize). Also enable the context menu. 3. add handling for browser window dragging Bug: 887051 Change-Id: Ibc05728f6f91c4b94673431a8b97b7c79116d0eb Reviewed-on: https://chromium-review.googlesource.com/1241833Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Victor Miura authored
These tests run MotionMark with fixed complexity sufficient to saturate most mobile phones today. Excludes Canvas tests which are already included in other story sets. BUG=619680 Change-Id: Id199dc6d7c5d497941c33405a069de6a9fc26980 Reviewed-on: https://chromium-review.googlesource.com/1244544 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#594746}
-
Emilio Cobos Álvarez authored
Otherwise `:host div` is equally specific to `div`, which seems undesirable and doesn't match any spec. Bug: 857415 Change-Id: I0a012ada134acb022dab85c3912b33ac5d0bd1dd Reviewed-on: https://chromium-review.googlesource.com/1238445 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#594745}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9fdc1f5b5de..cf257cec18f0 git log d9fdc1f5b5de..cf257cec18f0 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@cf257cec18f0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7faa4ddb691109944380859d594e3316860af6e3 Reviewed-on: https://chromium-review.googlesource.com/1249625Reviewed-by:
-
Eric Stevenson authored
This CL changes Monochrome APKs to allow proguard to strip out Java native methods that aren't used. For APKs that use explicit JNI registration, this isn't possible since RegisterNatives ends up trying to load classes that are unused and removed by proguard. Bug: 688465 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I6816bd68ce47e59bfc9f75dace1b34ab3c200222 Reviewed-on: https://chromium-review.googlesource.com/1244605Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#594743}
-
Geoff Lang authored
GL_CHROMIUM_sync_query is currently implemented in ANGLE which requires that we implement it in each backend. The implemention in the command decoder is simple with a Fence and faster because fewer layers and validation are needed. BUG=angleproject:2721 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I80fde7fc466dfdd5adb579d56293f1bf3ea660f4 Reviewed-on: https://chromium-review.googlesource.com/1244366 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#594742}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/529d0d9795b8..efb94d57eb88 git log 529d0d9795b8..efb94d57eb88 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 oprypin@webrtc.org Revert "Revert "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config."" 2018-09-27 nisse@webrtc.org Revert "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." 2018-09-27 mbonadei@webrtc.org Fix global_constructors, exit_time_destructors in audio device pulse. 2018-09-27 srte@webrtc.org Adds scenario test framework. 2018-09-27 saza@webrtc.org Remove echo_cancellation() and echo_control_mobile() interface access outside APM 2018-09-27 nisse@webrtc.org Avoid overflow when parsing H.264 SPS. Created with: gclient setdep -r src/third_party/webrtc@efb94d57eb88 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:877843 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0f958230b4d5565bebed96f68e31e4a67a8d20b Reviewed-on: https://chromium-review.googlesource.com/1249621Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a78fa0978d64..d3738be3476f git log a78fa0978d64..d3738be3476f --date=short --no-merges --format='%ad %ae %s' 2018-09-27 stevenperron@google.com Update CHANGES 2018-09-27 jaebaek@google.com Validator: Validate OpImageTexelPointer (#487) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d3738be3476f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6f99885e9e8b53c720b6e7885b0be84003bced4b Reviewed-on: https://chromium-review.googlesource.com/1249622Reviewed-by:
-
Paul Jensen authored
Listening for LinkProperties changes is required so we can detect if private DNS is enabled. Register a default-network callback so NetworkChangeNotifierAutoDetect on Android can listen for these LinkProperties changes. Use this default-network callback in place of CONNECTIVITY_ACTION which is deprecated. Bug: 885291, 774497 Change-Id: I0e6457f9cb970f1e010171af6c030638b1a667e6 Reviewed-on: https://chromium-review.googlesource.com/1243343 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#594739}
-
Elly Fong-Jones authored
This change: 1) Adds support to MenuClosureAnimationMac for animating menu closure without animating selecting an item; 2) Has MenuController use MenuClosureAnimationMac to animate cancels caused by outside clicks Bug: 833856 Change-Id: I9743b396798e4b125c038b35decc9aceb083926d Reviewed-on: https://chromium-review.googlesource.com/1231837 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Benjamin authored
Cryptography is timing-sensitive. MACs should never be compared with usual string comparison functions, only constant-time checks. Use HMAC::Verify. Bug: none Change-Id: Ic1b164441396e4a4a853f1a50d91bc8f5c7fa18e Reviewed-on: https://chromium-review.googlesource.com/1246323Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#594737}
-
Yoichi Osato authored
HasMarkers and its caller InlineTextBoxPainter::PaintsMarkerHighlights is not called anywhere. Remove them. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2ad088d8637d461178e7e3af3017c923b6c1f4c3 Reviewed-on: https://chromium-review.googlesource.com/1248282Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Allen Webb authored
This reverts commit 098b2caf. Reason for revert: This is no longer needed because of go/crosr/1199443 Original change's description: > anonymizer_tool: Added pattern to remove usbguard serial numbers. > > The usbguard-daemon prints serial numbers of USB devices to > /var/log/messages. This change adds a pattern to anonymize those > serial numbers to prevent leaking PII. > > BUG=None > TEST=Generate a report with logs and verify usbguard-daemon log > lines are properly anonymized. > > Signed-off-by: Allen Webb <allenwebb@google.com> > Change-Id: Ifd41c8208b4d14bb3fafbf38198b04da6a8babd6 > Reviewed-on: https://chromium-review.googlesource.com/1160935 > Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580946} TBR=rkc@chromium.org,mnissler@chromium.org,allenwebb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I4af62c2af7d9dc569175e5e68393c9e2a7ebb5e6 Reviewed-on: https://chromium-review.googlesource.com/1220095Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#594735}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4034a5cf..99b1fae1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I243f13f6e4a8ba97cd575e72f61bf46926f96cea Reviewed-on: https://chromium-review.googlesource.com/1249312Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594734}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 779dead9. With Chromium commits locally applied on WPT: 16f78349 "Move target-in-different-window.html into wpt/" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25391 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I8152cea831525ada1548548a2c8827a2b1891dd6 Reviewed-on: https://chromium-review.googlesource.com/1249521 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594733}
-
Trent Apted authored
It's effectively the default. Only a few places using gfx::Typesetter::NATIVE explicitly should be using RenderTextMac now. Bug: 798944, 889152 Change-Id: I3318676b14b938607de9413130627dc1581b2289 Reviewed-on: https://chromium-review.googlesource.com/1248263 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#594732}
-
Xu Xing authored
The idea is from: TODO(weiliangc): GL Renderer has optimization that when Render Pass has a single quad inside we would draw that directly. We could add similar optimization here by using the quad's SkImage. BUG=888930 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I42717c8a3fcfd93671db4ccff04acb76c005fa6a Reviewed-on: https://chromium-review.googlesource.com/1242303Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#594731}
-
Hugo Holgersson authored
Scenario: activeElement (focus) resides in an *offscreen* iframe's viewport. Problem: Spatnav only checked if activeElement was visible in its localmost frame. Even if that frame wasn't visible to the user, activeElement was used as the starting point in the search for focus candidates. Solution: Do not only ensure that activeElement is visible in its own frame: Also ensure that activeElement is being visible through the root frame. We do this by testing visibility through VisualViewport. Note: Element::VisibleBoundsInVisualViewport() returns an empty rect if an element is clipped by an iframe but VBIVV does not return an empty rect if the element is clipped by an overflow div. That's why we first still check the node's LayoutObject's VisualRectInDocument(). Let's fix this problem in Issue 889840. Bug: 881721 Change-Id: I091d07a4f1f909e947fce11a335e3e6fe756ce18 Reviewed-on: https://chromium-review.googlesource.com/1243246 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594730}
-
Eugene But authored
This adds a new value to Download.IOSDownloadMimeType histogram. text/calendar could be a common email attachment and this histogram will allow to understand if Chrome should support "Add To Calendar" UI for these downloads. Bug: 666211 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iafd9d30b1b3c565b38fd5c324bb8767ac1bc61b2 Reviewed-on: https://chromium-review.googlesource.com/1247064Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#594729}
-
Eugene But authored
Sylvain did codereviews for most of the CLs CL in this directory, which is more than 5-10 reviews. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I120e618bed1f8ed1f6526c4ab204ad2341229191 Reviewed-on: https://chromium-review.googlesource.com/1246294 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Micah Morton authored
This flag allows users to work around a shill-related breakage due to sandboxing, by forcing the feature disabled. It also allows testers to toggle the feature during testing without needing to modify /etc/chrome-dev.conf. Having this flag in the chrome://flags will allow a user to manually enable/disable shill sandboxing without needing a VariationsService update, which might be infeasible if network connectivity is lost. BUG=chromium:649417 Change-Id: I6de9e11a605a53f206996a7b3acdd10849daa3a9 Reviewed-on: https://chromium-review.googlesource.com/1246830Reviewed-by:
-
Justin DeWitt authored
- The ExploreSitesService is configured to start on startup if the feature is enabled, and will schedule the daily task directly in the service factory. - The task will cancel itself if it runs and the feature is disabled. Bug: 867488 Change-Id: I38b55c97d9b2d26a3c94cdff5bcce03bf341d404 Reviewed-on: https://chromium-review.googlesource.com/1244738 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#594726}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /components/download. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=shaktisahu@chromium.org TBR=shaktisahu@chromium.org Bug: 874080 Change-Id: Icf3e527d0d344e099a9debe054a8046273baebef Reviewed-on: https://chromium-review.googlesource.com/1191096 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594725}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/80564a56ec85..a78fa0978d64 git log 80564a56ec85..a78fa0978d64 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 33432579+alan-baker@users.noreply.github.com Set the C++ version to C++11 (#1933) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a78fa0978d64 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I692bca1481e95041d91bb80ece423983f836e625 Reviewed-on: https://chromium-review.googlesource.com/1249502Reviewed-by:
-
