- 22 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7afb8a45a389..796ade2e6451 git log 7afb8a45a389..796ade2e6451 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 fmayer@google.com Teach trace_to_profile to handle InternedData. Created with: gclient setdep -r src/third_party/perfetto@796ade2e6451 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9228ae5b1de12ac12b866d04cab3ac65246a8681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671517}
-
Shakti Sahu authored
Bug: 975506, 975683, 972774 Change-Id: I791a5503f3a37b329144709e96095f8a7b0569e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666775Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13820f2a7ac9..2d4afcc3cff3 Created with: gclient setdep -r src-internal@2d4afcc3cff3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:132908766 TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: I097ac2d0418e21b312d359f0e1afc063284efe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672709Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671515}
-
Tom Anderson authored
* Use 128x128 logo for the "background mode" status icon on Linux. * The 22x22 logo is now unused, so remove it. [1] removes internal icons. * Always use the highest resolution image representation that we're given, since all status icon implementations want to draw in pixel coordinates and we don't know in general how large the containing window will be. * Change StatusIconLinuxX11 drawing logic to handle icon resizing. [1] https://chrome-internal-review.googlesource.com/c/chrome/theme/google_chrome/+/1410578/ BUG=419673 R=thestig Change-Id: I2cad9414ba24022b9305d808c8b30228ae5d5c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671427Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#671514}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/647f200016ab..dfd760055152 git log 647f200016ab..dfd760055152 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 jmadill@chromium.org Vulkan: Don't update pipeline when only textures change. 2019-06-21 timvp@google.com Increase demangled array size 2019-06-21 dongja@google.com GL/Vulkan: handle depth texture discrepancy Created with: gclient setdep -r src/third_party/angle@dfd760055152 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I959067ec494d2a6603a35f12ec46ec4a8e59cd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672685Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4580351c794..6bbeb4ab7222 git log b4580351c794..6bbeb4ab7222 --date=short --no-merges --format='%ad %ae %s' 2019-06-22 mtklein@google.com remove xbyak 2019-06-21 mtklein@google.com vmovq 2019-06-21 mtklein@google.com vpmovzxbd 2019-06-21 mtklein@google.com vmovups, both ways 2019-06-21 mtklein@google.com jne Created with: gclient setdep -r src/third_party/skia@6bbeb4ab7222 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I3353d52729de684043bc89a1d2aebe47c8657d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672691Reviewed-by:
-
Dana Fried authored
Includes both calls and documentation that can be simplified. Change-Id: Ibdfe9dfaeb640ca72213cf60897e36c017c92ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669882Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#671511}
-
David Bertoni authored
For extensions with service worker-based scripts, only allow a service worker to be registered at the root scope if it specifies the extension's script. Bug: 973582 Change-Id: I5c41bd83cfdcd996033a0ce762a348f10d370e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602440 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#671510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c2b616bc420..385e9d4f27d3 git log 1c2b616bc420..385e9d4f27d3 --date=short --no-merges --format='%ad %ae %s' 2019-06-22 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@385e9d4f27d3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie0c31cdb01d14bb759ce9bbf86cc2b3e756ec1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672704Reviewed-by:
-
Rakib M. Hasan authored
Instead of setting class member functions to MagicMock classes and making sure that they are set back to their original values at the end of a test within a finally block, we can use a with block by using mock.patch.object to patch member functions of a class. Also updates the sanitization of the tags returned from GetPlatformTags. Since tags are case insensitive we can remove the lower function call. We can also replace the chain of replace calls with one re.sub call to change spaces and underscores to dashes. Bug: chromium:976505 Change-Id: Ic8b5da86ef711d5698916fef40da0ed439b8ce49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670024 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#671508}
-
Charlene Yan authored
Index can be out of bounds when attaching to a new tabstrip. Bug: 915956 Change-Id: Id921c4232f7e081b7d821f6722ff2ba7994ade76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670125 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#671507}
-
Findit authored
This reverts commit ad356ab2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 671493 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FkMzU2YWIyZGExODA4YWFmMWQwOTA5MDMxYjg4YmY0Y2E5ODE2MjcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/1549 Sample Failed Step: compile Original change's description: > Mass refactoring: Change JNI #includes to use full paths (chrome/, ui/). > > Using relative paths was causing build failures. To create this change: > * find out/Debug -name *_jni.h -delete > * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; > * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant > * refactor_jni_includes.py --out-dir out/Debug > * fix DEPs files manually > * split out chrome/ and ui/ changes into this cl > > See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI > for discussion on naming scheme. > > Bug: 964169 > Change-Id: I1e3b455c0405d93d7f516796fa77b5d0679d9888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669073 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671493} Change-Id: I44a0fdfc7b2e2a68a31abc64efbfda35c632a52f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 964169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672487 Cr-Commit-Position: refs/heads/master@{#671506}
-
sczs authored
If the user interacts with the Banner mid presentation we should finish the presentation animation (meaning that completeTransition will be called) so the user can safely interact with the Banner. If completeTransition is not called and the user tries to dismiss the banner or present an InfobarModal, the banner will freeze until completeTransition gets called from the PropertyAnimator completion block. This CL's creates plumbing between the InfobarBanner and the TransitionDriver so the animation stops and finishes after an interaction with the Banner. Bug: 977017 Change-Id: I63b9593262cb15aca182af029a5a3fd19f8d2ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670393 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#671505}
-
dpapad authored
Previously these checks were customly implemented in PRESUBMIT.py Bug: 720034,425829 Change-Id: I04a11f680ace0a6b7d250f4116562ce3710eb27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670274 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#671504}
-
Antoine Labour authored
Move from GraphicsResetStatus logic from decoders to GLContext and make it sticky. This is to ensure that once the GL context is lost once, we never try to use the context again, as some drivers wrongly claim they recovered from it. Bug: 946978 Change-Id: I1527fe6ac997ddb766c7c3fec30270c3ae84a5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669997 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#671503}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/payments directory. Additionally, this CL updates the URLs of the specificiations. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I6fdaba4bac93e7538756ccb8b931261035c2ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670667Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#671502}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bed9125..46e13cfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I08715659e63ae79b3f660a2956bb4e16d735bc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672567Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671501}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/125f7cc4d52d..dd2737e2b572 git log 125f7cc4d52d..dd2737e2b572 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 debrian@google.com Augment presubmit_support to output a json summary. Created with: gclient setdep -r src/third_party/depot_tools@dd2737e2b572 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:971895 TBR=agable@chromium.org Change-Id: I7eaf369f689f5adc8f6b6dee520f18a7e1ad3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672179Reviewed-by:
-
Tom Anderson authored
This fixes binary size increase in the Linux archived builds after r663143. BUG=977716 R=dpranke Change-Id: Iad3cae54968effe5ec32213ef9f321705a25fd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672564Reviewed-by:
-
Nick Harper authored
Change-Id: I17462b7db854e3587b4bf645e677a4c9d7609742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671052 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671498}
-
Kenneth Russell authored
conformance2/textures/misc/ tex-base-level-bug.html tex-mipmap-levels.html are failing on 10.14 as well. Bug: 870856, 965842 Change-Id: I2dd15e3a3672579bd6557ef459564a5f508e4613 Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672565Reviewed-by:Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#671497}
-
Mohamed Heikal authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant * refactor_jni_includes.py --out-dir out/Debug * fix DEPs files manually * split out services/, testing/, url/ changes into this cl See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: If6cd9a19ccf2bf189aada4d165d89322ef429518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671669Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671496}
-
Dominik Laskowski authored
This CL changes the type of OutputProtectionDelegate callbacks to OnceCallback, and fixes an uninitialized member variable. Bug: 929449 Test: Build Change-Id: If3bd6cc96fa2056ce59d044e68bc727166a5d720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597225 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#671495}
-
Becca Hughes authored
Make the PictureInPictureOptions optional because we can infer everything from the element. BUG=953957 Change-Id: I85865a02a403d7694795d22d2fe49d030a5c2bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659151 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#671494}
-
Mohamed Heikal authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant * refactor_jni_includes.py --out-dir out/Debug * fix DEPs files manually * split out chrome/ and ui/ changes into this cl See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: I1e3b455c0405d93d7f516796fa77b5d0679d9888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669073 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671493}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/712f0a7bd31d..b4580351c794 git log 712f0a7bd31d..b4580351c794 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 michaelludwig@google.com Fix subset behavior in makeWithFilter. 2019-06-21 herb@google.com Add API for glyph image data 2019-06-21 mtklein@google.com vpshufb 2019-06-21 michaelludwig@google.com Handle non-finite quads in attemptQuadOptimization 2019-06-21 mtklein@google.com vbroadcastss 2019-06-21 mtklein@google.com clarify can-we-call-JIT logic 2019-06-21 mtklein@google.com rearrange who mprotects Created with: gclient setdep -r src/third_party/skia@b4580351c794 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:977315 TBR=bsalomon@google.com Change-Id: I1d5a3c1aa258038879549f918dcd05c475242fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672167Reviewed-by:
-
Jacob DeWitt authored
This test verifies that XRInputSource objects are re-created when required by the SameObject attributes: when a gamepad is connected or disconnected from the input source, when handedness changes, and when target ray mode changes. The test also makes sure the input change events are sent correctly. This can't be an external WPT test because it uses MockXRInputSource and a cross-browser XR input test API is not available yet. Bug: 976978 Change-Id: I5fd5e90daf78c40fc8c57f70f0a389274222eb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672108 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#671491}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec9252e6d134..1c2b616bc420 git log ec9252e6d134..1c2b616bc420 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 achuith@chromium.org device: Reduce dropped SSH connections. Created with: gclient setdep -r src/third_party/chromite@1c2b616bc420 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9393f54503afbf02ec9b585b07c7e8411c2c3a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672505Reviewed-by:
-
Dana Fried authored
This allows proper UI update (color change) on tabs that have been added to a group. Had to remove the unit test ensuring contiguity across all update notifications, since it's no longer a valid assumption. Bug: 976502 Change-Id: I260eb4fb5128079068f7750b882dcb1d749eceed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670281 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Jimmy Gong authored
- Fixes a bug where the default text for printer queue would appear grey, which made it seem inactive. Bug: 958740 Test: end to end manual, browsertests Change-Id: I18bdcc5a6984f737cabfaa7ab06a7714b5176194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663075Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#671488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78e90396294f..13820f2a7ac9 Created with: gclient setdep -r src-internal@13820f2a7ac9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: I5010e30f34435018a287cc64871b12d9479545f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672506Reviewed-by:
-
Matt Mueller authored
Bug: 975173 Change-Id: I13507ea3eb6cf76a1cb2bc1134a6a255b55a650b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666717 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#671486}
-
Christian Biesinger authored
...when computing the main-axis size of a flex item. As per this change: https://drafts.csswg.org/css-flexbox/#change-2018-used-cross-size R=dgrogan@chromium.org, eae@chromium.org Bug: 972576 Change-Id: I11a1ac14e2e0e44e39fcd45d4568874da2dcfce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672014 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#671485}
-
Eric Aleshire authored
Bug: 963613 Change-Id: I05a043cd5d1788b53e38a5b9a51bc5da08ba7290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668312Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#671484}
-
Xiaocheng Hu authored
This patch removes some redundant includes of the header file, and also clear one indirect include via css_primitive_value_mappings.h This is a preparation for augmenting calc() to support min() and max(). Bug: 825895 Change-Id: I4d607e501448015096fa98535e33a4505859509b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672465 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#671483}
-
Ben Pastene authored
Bug: 932269, 977736, 977737, 977738, 977739, 977740, 977741, 977743, 977744, 977745, 977749, 977750 Change-Id: I79a8991e3a6db7602fc45aa1ff78ee2eecd2e584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672568Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#671482}
-
Kenneth Russell authored
This reverts commit 8d4643f0. Reason for revert: caused some pixel and WebGL test failures per http://crbug.com/965842 . Original change's description: > Use high performance GPU by default in GPU tests. > > Upcoming CLs will change the heuristics for selecting the low-power > vs. high-performance GPUs on dual-GPU systems, macOS in particular. > The GPU tests in Chromium's hardware fleet expect to run on the > high-power GPU, so maintain this behavior by default. > > Bug: 965842 > Change-Id: I17707475a4505905ea95a8a57d06a1754fc101fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665910 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670302} TBR=ccameron@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965842 Change-Id: I6402b31efe05ebacb5a488c5d6cecba4f790c1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671863Reviewed-by:
-
Xianzhu Wang authored
Composited layer under multicol is still not fully correctly supported. Currently we don't allow fragmentation of composited layers, and skip fragment clip for them. However, if there are other clips below the fragment clip, we should not skip fragment clip to ensure the other clips are correctly applied. This is still not fully correct (see the comment in the code for details), but the result is less broken in many cases. Hopefully we'll fully fix the issue in CompositeAfterPaint+LayoutNG-box-fragments. Bug: 976187 Change-Id: Ica9acc71f0d1204d6380f1bcac3e2159631d63e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670413 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#671480}
-
Abhishek Bhardwaj authored
This change adds a separate class to do the dirty work of running and retrying a task if it fails. This will be used for all tasks that would need to be run on an update check. BUG=924762 TEST=Unit tests. Change-Id: I89cc65fc93631989857c3bd8dce6f53dca31fe2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661972Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#671479}
-
Matt Menke authored
And plan to remove it in Chrome 78. It was added about 2.5 years ago as a temporary measure to give Enterprises time to fix servers that were (likely accidentally) returning HTTP/0.9 responses. Usage appears to be low, allowing for relatively safe removal of the policy and the code backing it. Bug: 976751 Change-Id: I3d5c133cca77c1747bf52c905a5509e520f8626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666912Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
-
