- 24 Jan, 2019 40 commits
-
-
Yi Su authored
This CL renames 2 functions LargeIconService. This is a prerequisite work for adding LargeIconService::GetLargeIconRawBitmapOrFallbackStyleForIconUrl in this CL(http://crrev/c/1384366). Bug: 903617,910525 Change-Id: Id46811309646955fd2b8888d829f94918e5b910a Reviewed-on: https://chromium-review.googlesource.com/c/1429959 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625771}
-
Findit authored
This reverts commit 48246c46. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625435 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDgyNDZjNDZjYzUxNjQzOWJkNjJjOGEyYmQwZGFmM2NkZmQyMGRhYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/6542 Sample Failed Step: browser_tests on Ubuntu-16.04 Sample Flaky Test: LocalCardMigrationBrowserTest.ClickingSaveClosesDialog Original change's description: > [Autofill] Added browser tests for local card migration flow (part 1) > > The previous browser tests CL got reverted twice due to flaky tests, > so I will try to break the browser tests into several CLs. Listed the > following tests to be added in the TODO in the browser tests file. > > > Bug: 897998 > Change-Id: Ib3c99de27028530e2f8bce7b616d7d5a9dae4cd3 > Reviewed-on: https://chromium-review.googlesource.com/c/1364695 > Commit-Queue: Siyu An <siyua@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#625435} Change-Id: I45450945906bbcdef982bca45310722c7a9fd968 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897998 Reviewed-on: https://chromium-review.googlesource.com/c/1435216 Cr-Commit-Position: refs/heads/master@{#625770}
-
Christopher Cameron authored
Change OpenApplicationWithPath to return the NSRunningApplication instead of just its pid. Use this in LaunchShim to detect when the process terminates, and issue a callback, which lands in AppShimHost::OnShimProcessTerminated. In AppShimHost, treat OnShimProcessTerminated just like a failure in OnShimProcessLaunched -- attempt to recreate the app bundles and launch again, and if that fails, close the app's windows. Ensure that only the first call to AppShimHost::LaunchShim do anything. Handle IsAcceptablyCodeSigned failing by closing the shim process and re-launching. This makes us re-generate app shims when they are not signed by the following sequence - The launch will attempt to launch from the Applications folder - If this is signed, success - If this is not signed (more likely), then it will fall through the same path -- the second AppShimHost::LaunchShim call will do nothing, and the shim process will terminate. - This termination will cause us to launch again, this time re-creating the shim, whereupon it should now be signed. Add tests for this sequence. Bug: 924482 Change-Id: I915c8fb3b9ee9b8fe109e7330d16673a4192e30a Reviewed-on: https://chromium-review.googlesource.com/c/1433442 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625769}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6588e2f70fe8..bb3f9060c4ea Created with: gclient setdep -r src-internal@bb3f9060c4ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If5863f0eb6608c0f6ab6fbc9eec29f73e8640b92 Reviewed-on: https://chromium-review.googlesource.com/c/1434774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625768}
-
Alexei Filippov authored
It doesn't make sense to look for module in one process (renderer) using a function address from another process (browser). Identify the main renderer module using name instead. BUG=921712 Change-Id: I45c6a961f9cc2d80817a48ac4177196a9ac07382 Reviewed-on: https://chromium-review.googlesource.com/c/1415256 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Auto-Submit: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#625767}
-
Xiaocheng Hu authored
WebTextCheckClient used to hold strong reference to Blink objects, which requires explicit cleanup to avoid leaking those objects. Now that the references have become weak, the explicit cleanup is no longer needed. Hence, this patch removes the relevant logic. Bug: 924616 Cq-Include-Trybots: luci.chromium.try:leak_detection_linux; luci.chromium.try:linux_chromium_asan_rel_ng; luci.chromium.try:layout_test_leak_detection Change-Id: Ied66b4dfd1a6c58d0253c21ddbc007889c91be6a Reviewed-on: https://chromium-review.googlesource.com/c/1431393Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625766}
-
Caleb Rouleau authored
See https://cs.chromium.org/chromium/src/testing/scripts/run_performance_tests.py?l=201 I used the wrong arg in https://chromium-review.googlesource.com/c/chromium/src/+/1428090 but it didn't break because the logic doesn't yet require this argument. BUG=924351 Change-Id: I69f7fc5bfbd01537f8d99ace53b64d73386bf96f Reviewed-on: https://chromium-review.googlesource.com/c/1433292 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#625765}
-
Tom Anderson authored
This file hasn't been maintained for several years and is out-of-sync with build/install-build-deps.sh. BUG=508895 R=thestig Change-Id: Idd69ada513ddcb8cf2ae9f1525cdd87419d460d2 Reviewed-on: https://chromium-review.googlesource.com/c/1434894 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625764}
-
Tom Tan authored
Bug: 893460 Change-Id: If7b83470daf03a4de0a9a45dbc73c1d2fe44abb4 Reviewed-on: https://chromium-review.googlesource.com/c/1434916Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#625763}
-
Xida Chen authored
The include of the image_provider.h is not necessary, instead a forward declaration is enough. This CL does that. It should not introduce any behavior change. Bug: None Change-Id: Iccc485099e6d2e7789329d746048f9dfc88b2787 Reviewed-on: https://chromium-review.googlesource.com/c/1430584Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625762}
-
Michael Giuffrida authored
When removing preinstalled Demo Mode Resources, only track UMA stats for resource removal reasons and results for devices that actually have the offline resources. Bug: 905794 Change-Id: I76aefd5ea71d6d2bc2be8eeb92cf154e05eecac3 Reviewed-on: https://chromium-review.googlesource.com/c/1430539Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625761}
-
wutao authored
This patch removes the chrome flag ash-enable-trilinear-filtering, but keeps the feature ash::features::kTrilinearFiltering for future development. Bug: none Test: manual Change-Id: Icff1a60c3cabe06776f0d519b348e64cb9099860 Reviewed-on: https://chromium-review.googlesource.com/c/1432292Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625760}
-
Jan Krcal authored
This CL makes sure the sync-requested pref is set to false while the individual data types are being stopped. This is needed by the Directory version of the Wallet DTC (as revealed by a sync integration test for wallet data Directory implementation that was temporarily disabled while PSS code has changed). Bug: 853688 Change-Id: If738c13ad1d8c8fe82439f47f6127508e7155a85 Reviewed-on: https://chromium-review.googlesource.com/c/1433624 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#625759}
-
Nick Harper authored
Bug: 875053, 903642 Change-Id: Iee68cbac625abddff00ef4ec9099c4894af52143 Reviewed-on: https://chromium-review.googlesource.com/c/1405887 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
-
Travis Skare authored
Bug: 889697 Change-Id: I6771c03f5448f83b385dc17a8526ab958378f5bf Reviewed-on: https://chromium-review.googlesource.com/c/1247524 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625757}
-
Matthew Mourgos authored
- When ChromeVox is enabled, launcher state transitions to peeking or fullscreen are now announced. - This fix also removes the ability to focus on the expand arrow while in fullscreen. Bug: 779687 Change-Id: I942737bed53c258272aaea1a379cb7dd4053f605 Reviewed-on: https://chromium-review.googlesource.com/c/1423741Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625756}
-
Mike Wittman authored
Records work ids along with samples to distinguish which samples came from which work items (i.e. tasks, user interface event handlers, etc.) This information will be used to infer coarse work item durations and from that information, jankiness. Task id recording takes place while the thread is suspended so must be implemented in a lockless fashion. The corresponding Mac implementation will be much more involved so is deferred to a future CL. This is a reland of 721cd487. Change-Id: Ife21309d469ab7ffae3cd41ea069cfafb3747dd7 Reviewed-on: https://chromium-review.googlesource.com/c/1417835 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
-
Daniel Rubery authored
This CL adds the needed protos for the visual features sent as part of PhishGuard pings. Bug: 922226 Change-Id: I075b48039b6f9a6aea79f7bf8129c059b4760dfa Reviewed-on: https://chromium-review.googlesource.com/c/1430587Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#625754}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/86d0d9be254a..8915a7c8f120 git log 86d0d9be254a..8915a7c8f120 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 46733637+JasperNV@users.noreply.github.com spirv-val: Emit an error when an OpSwitch target is not an OpLabel (#2298) 2019-01-24 zoddicus@users.noreply.github.com Add WebGPU specific validation for Position BuiltIn decoration (#2309) 2019-01-24 fjhenigman@users.noreply.github.com Add SpirvTools::IsValid(). (#2326) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@8915a7c8f120 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If3da95ebc09eb66f6f905785a6db04fcb2eca369 Reviewed-on: https://chromium-review.googlesource.com/c/1434096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625753}
-
Reilly Grant authored
As a follow-up to r620271 which assigned each serial port a token this change makes it so that the Device Service serves all requests for the SerialPortManager interface from the same SerialPortManagerImpl. This means that the tokens assigned to each port are consistent between multiple clients of this interface. Otherwise each gets its own mapping from port path to token, which defeats the point. Sensor tests have been updated to not inherit from DeviceServiceTestBase as they do not depend on it and don't initialize it properly. Bug: 908833 Change-Id: Id7ea9ab6368891fe384286fd18c82ca40c842ced Reviewed-on: https://chromium-review.googlesource.com/c/1416535Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625752}
-
Hans Wennborg authored
Bug: 924192 Change-Id: Idb80cad0e7017296388ab10a9bf964006218f552 Reviewed-on: https://chromium-review.googlesource.com/c/1434319 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/f3abb280c2aa..8bea0a266ac9 git log f3abb280c2aa..8bea0a266ac9 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 cepheus@frii.com Update headers from previous SPV_INTEL_media_block_io grammar addition. 2019-01-24 johnkslang@users.noreply.github.com Merge pull request #93 from PawelJurek/SPV_INTEL_media_block_io Created with: gclient setdep -r src/third_party/spirv-headers/src@8bea0a266ac9 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I86949f20a39b2e702b0be992c9591e1a2c71364a Reviewed-on: https://chromium-review.googlesource.com/c/1434102Reviewed-by:
-
Nate Fischer authored
This changes our testing instructions as follows: * Use a shorter syntax for links to other markdown. * Devs find it confusing that we have inconsistent use of "Class#method" and "Class.method". This clarifies with an aside. * Upstream docs for layout and page cycler tests. * Remove docs for run_cts.py options: these are truly optional thanks to aluo@'s work, and the script will exit early anyway if it needs the user to specify. R=changwan@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I48fc0a0740f1d9bd52c4890c795aa72ad00a8265 Reviewed-on: https://chromium-review.googlesource.com/c/1433140 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625749}
-
Staphany Park authored
After some cleanup for onion souping AppCache, appcache_info.h was left with only typedefs and a constant. This CL moves the constant to appcache_info.mojom and inlines the typedefs. Bug: 611938 Change-Id: I0857b9bdd8c7a30779000075fe786fe456a84f3c Reviewed-on: https://chromium-review.googlesource.com/c/1423335Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#625748}
-
Findit authored
This reverts commit 94b5b84b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625711 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRiNWI4NGIwNTg2MDljY2YxZDU4ZjUxNzVjMDkzMWI2M2I5ZjBmMgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/29257 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/animation-worklet/worklet-animation-pause.https.html Original change's description: > [animation-worklet] Basic pause implementation > > Pausing worklet animation now holds the time. This works as expected for > main thread animations. Implementing this for composited worklet > animations will be done in a follow up patch. > > Major changes: > - Add and expose pause() method pausing the animation. > - Introduce hold_time that is used when animation is paused. > - Rework how current time is computed, it is now closer to > regular animations i.e., we either compute it based on > "start time and timeline.currentTime" or use "hold time". > - Instead of setting start time we now set the current time > which then works backward to compute either the start time > or the hold time based on the animation state. > - When transitioning animation play state, we now always set > the current time. Previously this was adhoc and inconsistent. > - Introduce has_started_ to differentiate when playing an > animation for the first time vs playing it from pause. > > > TEST: > * wpt/animation-worklet/worklet-animation-pause.https.html: js test for basic current time calculations > * wpt/animation-worklet/worklet-animation-pause-immediately.https.html: reftest for basic pause > * wpt/animation-worklet/worklet-animation-pause-result.https.html: reftest for pause/resume. > * WorkletAnimationTest.PausePlay: unit test for basic state transition and time calc > > Bug: 821910 > > Change-Id: Ie4b00129398159b3b5b83212bb63c43f2ce8bf4e > Reviewed-on: https://chromium-review.googlesource.com/c/1383298 > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625711} Change-Id: Ibb3c50f772493f1761cee657aaa618f357348188 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821910 Reviewed-on: https://chromium-review.googlesource.com/c/1434815 Cr-Commit-Position: refs/heads/master@{#625747}
-
Elly Fong-Jones authored
This flag is unused. The command-line switch will stay for board bringup purposes, though. Bug: None Change-Id: Ic128da0dd8d69a136ec90ebd0a36a30ba51f33b2 Reviewed-on: https://chromium-review.googlesource.com/c/1434514 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625746}
-
Ken Rockot authored
This is a reland of b9991b86 Original change's description: > Add a base::Feature for Mojo dispatch change > > Adds a new base::Feature to control whether or not Mojo uses the more > granular task-per-message dispatch policy as opposed to the old batch > dispatch behavior. > > This is disabled by default until M73 branch. > > TBR=jam@chromium.org > > Bug: 866708 > Change-Id: I138a66c0d65106f44f153e02c1cf92d71c27d14d > Reviewed-on: https://chromium-review.googlesource.com/c/1433139 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#625514} Bug: 866708 Change-Id: I467757bfdede77cae371388898310173bcea1d37 TBR: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1434455 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Mason Freed authored
Keep track of changes to property trees and cc Layers, and only run the PAC Update() function if something has changed. Bug: 920323 Change-Id: Ia44e188ed73e1deed6c542d84325d6869c682df1 Reviewed-on: https://chromium-review.googlesource.com/c/1407606Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625744}
-
David Tseng authored
kRadioGroupIds gets set on a radioButton and refers to other radio buttons in the group. The intent of the relatedNodesChanged generated event is to notify a client on the source node when a target changes. In the case of a radio button, this results in multiple sources being notified when a radio button changes. It is unclear if this is useful and it is having some negative impact on reasoning about the related nodes changed event. This change therefore excludes this intlist attribute from triggering an event. Bug: 900643 Change-Id: Ic02a8ec34acf7855b85a6a99106379472fe1a5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1427567 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Dan Beam authored
Screenshots: https://imgur.com/a/VIMVO2d Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c485b44#slide=id.g4a64df24f4_20_0 R=dpapad@chromium.org BUG=923224 Change-Id: I7292cdcb35b23320f67de75cc6cbbe1b4f2f9003 Reviewed-on: https://chromium-review.googlesource.com/c/1432795 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625742}
-
Tommy C. Li authored
After deduplicating 100 filenames, i.e. foo.jpg, foo (1).jpg, ... foo (100).jpg, Chrome uses an ISO 8601 timestamp. This works on all platforms but Windows, as the default ISO 8601 format contains colons, which is a forbidden character on Windows. This CL changes this to use a delimiter-light version of ISO 8601 that is still compliant with the spec. It also changes to use local time instead of UTC time. foo - 2018-10-11T215547.392.jpg Bug: 135428 Change-Id: I2759240ee41341cb558b32e8f925742611c4debc Reviewed-on: https://chromium-review.googlesource.com/c/1432882Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#625741}
-
Henrique Grandinetti authored
Bug: 902364 Change-Id: Iea3f38d0f72665f279b5605453af3b3fde1a16c3 Reviewed-on: https://chromium-review.googlesource.com/c/1427449 Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625740}
-
Robert Liao authored
In the common case, using GetAddressOf() is fine immediately after a ComPtr<T> declaration as it is empty. However, we've started to see cases where developers are reusing ComPtr<T> and using GetAddressOf(), which is unsafe and leaks the original pointer. As a result, the recommendation now is to always use operator&, which is shorter and in general safer. BUG=914541,914910 Change-Id: I6338e1a9082abeba5beefa25dfb6af058bfe37b5 Reviewed-on: https://chromium-review.googlesource.com/c/1431914 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Konstantin Ganenko authored
PlatformNotificationServiceImpl has internal counter that increments when ClosePersistentNotification fires. Counter is intended to be checked + decremented on PersistentNotificationHandler::OnClose. It worked only when bridge is instance of NotificationPlatformBridgeMessageCenter. All other implementations of bridge do not call Close of a handler. Thus tagged notification that was closed via ClosePersistentNotification (from js) on next user closed action will be skipped. Solution is to decrement counter on new persistent notification show. R=peter@chromium.org Bug: 818083 Change-Id: Ie842244f72d4fafedea10dadf86c962bbc958644 Reviewed-on: https://chromium-review.googlesource.com/c/1424802Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625738}
-
Nicolas Pena authored
Change-Id: Ic079967fa2a878d59484c34097ecf3f6c007c155 Reviewed-on: https://chromium-review.googlesource.com/c/1434558 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#625737}
-
Bryan McQuade authored
Change-Id: I0ccee8c3e4caccefa4df75fef87ad3335d17fa63 Bug: 924765 Reviewed-on: https://chromium-review.googlesource.com/c/1432394 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#625736}
-
jdoerrie authored
Bug: 914765 Change-Id: Iafca4b37f8ad59af50b4e527743a845be23ab582 Reviewed-on: https://chromium-review.googlesource.com/c/1434656 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
kdillon authored
Bug: 795636 Change-Id: Ifbeaf7eab76b992ac41a4dc7f23ec46f72ad8ca2 Reviewed-on: https://chromium-review.googlesource.com/c/1412827 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#625734}
-
Luciano Pacheco authored
Before this CL when MyFilesVolume flag is enabled users couldn't select other folders inside MyFiles, only inside MyFiles/Downloads, this CL fixes it. The flag MyFilesVolume will be enabled by default in follow up CL. this CL when MyFilesVolume flag is enabled Test: browser_tests --gtest_filter=DownloadPrefsTest only passes with Bug: 873539 Change-Id: I8dc172412a1fd7b7cc69bc82f75c39f29e2f984e Reviewed-on: https://chromium-review.googlesource.com/c/1433635 Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Andrew Xu authored
In current code, the mask layer of AppsGridView uses the wrong recording size because the paint recorder is not given correct scale factor when created. As result, during painting, AppsGridView has different size from its mask layer. It is the reason why there is an one-pixel line shown. This CL fixes the issue by giving the correct scale factor. Bug: 921274 Change-Id: I91cfd8ced16e266400e91c1b8e4b0566f10736e7 Reviewed-on: https://chromium-review.googlesource.com/c/1432894 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#625732}
-
