GitLab

This reverts commit 774d23c5.

Reason for revert: Moved webState timeout to correct test.

Original change's description:
> Revert "[ios] Disable failing tests for Xcode 11 beta 6."
> 
> This reverts commit 0ba4c00b.
> 
> Reason for revert: webState timeout is in the wrong place, fixing via
> revert.
> 
> Original change's description:
> > [ios] Disable failing tests for Xcode 11 beta 6.
> > 
> > Increases a webState timeout, disables a request desktop and two
> > share button tests.
> > 
> > Bug: 995797, 996541, 990186, 996544
> > Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331
> > Commit-Queue: Justin Cohen <justincohen@chromium.org>
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Auto-Submit: Justin Cohen <justincohen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#689326}
> 
> TBR=rohitrao@chromium.org,justincohen@chromium.org
> 
> Change-Id: I0fb517a23c012fae88df440adac061901d1c8cdc
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 995797, 996541, 990186, 996544
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765494
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689476}

TBR=rohitrao@chromium.org,justincohen@chromium.org

Change-Id: I1e0b311ed2533e8311fe86ba2c290b6794c02930
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 995797, 996541, 990186, 996544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763237Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689480}

This reverts commit 16579581.

Reason for revert: Offline discussions happened around the repercussions of this change. Silently changing a browser's behavior might not be as desirable as expected. Reverting this until a consensus is reached or a another solution found.

Original change's description:
> Policy: Allow setting enterprise defaults for all platforms
>
> Transfer the responsibility to set default policies into PolicyService.
> The decision is made using a EnterpriseUsersDefaultDelegate injected
> into the PolicyService.
>
> The ProfilePolicyConnector acts as EnterpriseUsersDefaultDelegate.
>
> For Chrome OS, the resulting behavior is not changed - enterprise
> user defaults are set if the profile is managed.
>
> For android and Desktop platforms enterprise user defaults are set if
> the profile managed.
>
> Bug: 980132
> Change-Id: I134125ed0dbe22149eb36459b45268244afc5954
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706575
> Commit-Queue: Yann Dago <ydago@chromium.org>
> Reviewed-by: Pavol Marko <pmarko@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#687241}

TBR=mmenke@chromium.org,pmarko@chromium.org,ydago@chromium.org


Bug: 980132
Change-Id: I6334e4d6a7eeda7fef87a4ea6d6ecb820a16eb92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764468Reviewed-by: Yann Dago <ydago@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689479}

The thread ServiceWorkerContextCore lives on (the "core thread") will
move from the IO thread to the UI thread.

This CL makes DevToolsBackgroundServicesContext aware of the core thread
instead of assuming the IO thread.

Bug: 824858
Change-Id: I1c58de5e2dc6d262fe6d6f5c375956aa54da77c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765096Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689478}

Add myself to OWNERS for //third_party/google_android_play_core.

Built locally @264816199 and uploaded to CIPD. Updated ModuleInstaller
to use the new SplitCompat API. Add new play core activity to expected
manifest file.

Bug: 996212
Change-Id: I0aba37897048cc554330eb933b2687d37e9343e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764804
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689477}

This reverts commit 0ba4c00b.

Reason for revert: webState timeout is in the wrong place, fixing via
revert.

Original change's description:
> [ios] Disable failing tests for Xcode 11 beta 6.
> 
> Increases a webState timeout, disables a request desktop and two
> share button tests.
> 
> Bug: 995797, 996541, 990186, 996544
> Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Auto-Submit: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689326}

TBR=rohitrao@chromium.org,justincohen@chromium.org

Change-Id: I0fb517a23c012fae88df440adac061901d1c8cdc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 995797, 996541, 990186, 996544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765494Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689476}

This is a speculative revert in order to either confirm or eliminate it
as a source for a hard to track down persistent performance regression.

This reverts r679183 (commit 6b846d36).

Bug: 993476
Tbr: pdr@chromium.org
Change-Id: I37566d32fb0853590e72299fdc0f281c712bf027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764195
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689475}

ContextProvider notifies observers on context loss that the context is
no longer usable. These observers typically hold a
scoped_refptr<ContextProvider> and could drop their reference
immediately. This could result in the ContextProvider being destroyed
before OnContextLoss() has finished executing and result in a
use-after-free error.

Ensure this use-after-free isn't possible by acquiring a scoped_refptr
before notifying observers.

Bug: 994430
Change-Id: I5e0d6c99b0a42bbfc3dfca28af311df2b0f33831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764803Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689474}

Bug: webrtc:10899
Change-Id: I022ac114957b596e76172ca5de5b925d6a937c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757941Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Artem Titarenko <artit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689473}

TBR=khushalsagar@chromium.org

Bug: 995142, 900706
Change-Id: Id3505014c517a7715c199419b9b9d93766441c76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764143Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689472}

The change is related to CL:1731250. Add histogram information in
histograms.xml to make the histogram visible on chromedashboard.

BUG=chromium:988295

Change-Id: Ibe05f462a0282dc3f03d53fe5b0350e5705fdcac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757951
Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689471}

Some cleanup in preparation for converting the internet detail pages
to mojo. Includes changes to internet_detail_dialog.js to conform to
JS style in Settings.

Bug: 853953
Change-Id: Id4bf7586f6d6ed02c2abcb9d33e0e14717a60a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756906
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689470}

The possible variations are:
- "Enabled" (default option) which dictates to use quiet notifications
- "Enabled using heads-up notifications" which dictates to use heads-up
notifications
- "Enabled using mini-infobars" which dictates to use mini-infobars

The feature itself is disabled by default.

Updated the "ShouldShow...." logic to use the new feature.

Bug: 986737
Change-Id: I87873e0eb45c53a92bfbf7e2f613a69c9157af83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764152
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689469}

MSVC fails when these hash values are const as seen with the following
on Windows: `error: call to implicitly-deleted default constructor of
'std::hash<const input_prediction::PredictorType>'`. This can be seen
I don't see a clear reason for them to be const, and have thus removed
them in this CL in order to fix the build on MSVC.

here: https://ci.appveyor.com/project/electron-bot/electron-ia32-testing/builds/26830974.
Change-Id: I978cd122554a30715a54bc3e0609f5724539bae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762335Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689468}

The value is now defined as a mojo enum so we should avoid transporting
it in IPC as an int.

R=csharrison@chromium.org
Bug: 993039

Change-Id: I99ef056a8d9320badb8251cefa1714c68ade84df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755329
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689467}

https://skia.googlesource.com/skia.git/+log/c071fc92cd3d..197c58647161

git log c071fc92cd3d..197c58647161 --date=short --no-merges --format='%ad %ae %s'
2019-08-22 bsalomon@google.com limit SK_API exposure on GrTexture

Created with:
  gclient setdep -r src/third_party/skia@197c58647161

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: I00ac3279f434ba1853ac89a44a6f3f93c20ab06a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765203Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689466}

New-style WebAPKs use splash screen screenshot from the WebAPK content
provider and don't use WebApkInfo#splashIcon().
This CL introduces WebappLazyIcon which postpones reading the bitmap
from resources till WebappLazyIcon#bitmap() is called.

This CL improves startup on an Android One device by ~20ms.

BUG=995168

Change-Id: I013afadb1a781837830fe1d2ff5ade56fbf83dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759296
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689465}

The fix was to add a null pointer check.

Bug: 990624
Change-Id: Iec3283a8a908343661945cf40343cdfbe8aefe37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762223
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689464}

This is a reland of [1], originally revert in [2], being
suspicious of have caused [3].

The bug was fixed differently [4], and it should be safe to reland
this CL.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1760407
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1758468
[3] https://crbug.com/995709
[4] https://chromium-review.googlesource.com/c/chromium/src/+/1758471

Original commit message:

  This CL addressed guidou's remark on [1], that
  was accidentally left off when splitting the CL into
  smaller pieces.

  [1] https://crrev.com/c/1757490/4/third_party/blink/renderer/modules/modules_initializer.cc#185

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I76477b2adfbf4f6b942b066640b4e2d19a7e8e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765489Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689463}

crrev.com/c/1700112 renamed a number of tests. Follow that up by
deleting old baseline images, renaming the tests in the SkiaRenderer
blink web tests filter, and reordering them in the SlowTests file.

Change-Id: Ida4907e3f71466db203250e7de85580bdbc434d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764248Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689462}

This prevents manual edits from making it into a commit.

Bug: None
Change-Id: I3386db3668287984d09f45ead497bac11a6390a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765097
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689461}

Change-Id: I87c586858edda0b52e6344e5b04821d698b577ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764154
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689460}

Bug: 989726
Change-Id: I070bd8bc9503d443e9ab3f6d331c4e92c01023b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762482
Auto-Submit: Yue Ru Sun <yrsun@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689459}

I've had too many problems with base::unique_any due to the type id being fragile
wrt symbol exports.  E.g. there are tests which load a .so but symbols are not
exported from base, which causes DCHECK failures.

So I've decided to remove base::unique_any in favor of a similar container
customized for promises which encodes it's state in the low bits of the type_ops_
pointer. This enables several binary size optimizations:

1. We can move calls to OnResolved/OnRejected out of templatized code
2. We no longer need the TypeId TypeTag<Type>::dummy_var

Other optimizations:
* Tweaked AbstractPromise::ValueHandle so it can be inlined (saves a few kb).
* Tweaked PromiseExecutor::GetPrerequisitePolicy to read a variable rather
than call a function.
* Realized the MoveHelper<> out of line templates didn't need to call copy/move
constructors it could just move the pointers. This saves a few kb.

Misc fixes:
* ThenOn/CatchOn can't DCHECK(abstract_promise_) because during shutdown the
prerequisite may fail.  This isn't reason to DCHECK.

* There was a type confusion between Resolved<void> and Resolved<Void> in
AllTupleExecutor.

Bug: 906125
Change-Id: I939fd863a554a248850d62b83d79b866e4dda0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733498
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689458}

Bug: 853953
Change-Id: I431cb9e892dc86fc9df7e9d265e00ebdf6ede539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763165
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689457}

TabSwitchTimeRecorder needs to be notified when a tab is hidden, to
record histograms and keep local state up to date if no frame was
presented since the tab was shown.

This CL ensures that TabSwitchTimeRecorder is notified when the tab
is hidden because of native window occlusion This was broken by
https://chromium-review.googlesource.com/c/chromium/src/+/1680969.

Bug: 995339
Change-Id: I77b6fe6ad438c1c038e3fcce09a0a639d153fa6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760872Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689456}

HashTraits<blink::PropertyHandle>'s IsDeketedValue method was declared
as accepting blink::PropertyHandle. The argument should have been
const blink::PropertyHandle& (as it is in the parent class).
As a result, when trying to use this method, PropertyHandle was copied
resulting in a crash when traced by concurrent markers.

Bug: 986235
Change-Id: I0f29d37453f5c948bfd6e041e2979c9dbe144366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764157Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689455}

This reverts commit 27ca1df7.

Reason for revert: This CL causes an official build failure
https://crbug.com/996658

Original change's description:
> Enable dist fusing for all feature modules.
> 
> Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Ben Mason <benmason@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689075}

TBR=tiborg@chromium.org,benmason@chromium.org

Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689454}

Add a web platform test that performs navigations to a test page with
various targetText parameters and checks if the target page
successfully scrolled as expected. Using a BroadcastChannel is the only
way to communicate whether the target page scrolled, since scroll to
text is specifically restricted from iframes or pages with an opener,
so there's no other way for the test page to track the status of the
child target page.

Bug: 994299
Change-Id: I69243e739c3a7469ac48647508e379f204ccfbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756707
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689453}

Bug: 991553
Change-Id: If5d74661f713101080f75e4baa6a77e981ac0f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742209
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689452}

Bug: 648382
Change-Id: I127a672ac3b53220816737843cb2525859a25b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765030Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689451}

The prompt field in the GetPaymentInformationAction was dropped due to a

std::move. This patch fixes that by setting the status message before
moving.

R=arbesser@google.com

Bug: b/139842776
Change-Id: I7c62a72d0f4856f20baa882081d8ee1d61104c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763683Reviewed-by: Clemens Arbesser <arbesser@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#689450}

Change-Id: I2cd3b65e477a99a3e7c2368767958d0f08156a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764156Reviewed-by: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689449}

This CL removes the special treatment applied to counters labels in
order to make the label pluralizable. Given the special format of
ChoiceLabel, some characters (like '<', '#' or '|') make the
application crash.

Those special characters can be escaped with ' but they will then be
displayed in the string, which is undesired.

We can safely remove this pluralizable logic as it is not used by any
scripts (the text shown is extracted from the website).

Bug: b/139643534
Change-Id: I88109b2f374c5c343545603a28aac38a8a190b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763682Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689448}

The same dialog component will be used for multiple purposes, for
the onboarding flow as well as for leak detection. Since these need
different button strings, this CL makes the strings customizable
from the bridge.

Bug: 986317
Change-Id: Icfb80952b0312cd15e6f16bf722abf292b82a523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762230
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689447}

Ran:
$ rm -rf third_party/android_deps/libs/[!O]*
$ tools/android/roll/android_deps/fetch_all.py --update-all

Tbr: Trivial update to documentation
Bug: None
Change-Id: I5a59c721c9b6cbbf4334464f71f8363baa0ac753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765551Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689446}

Stability.iOS.UTE.OSRestartedAfterPreviousSession is stability metric
and should be logged via the macro.

Change-Id: Ia72ba513b2e5d47c040528ad732af1a1a10dde70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763164
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689445}

Add compiler option to turn shadowed variables into errors for cc.
Fix various shadowing errors generated by compiler error.

BUG=794619

Change-Id: I84a6aaceb6552291c4d2122228a894097b4c7da5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763297
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689444}

Bug: 986298
Change-Id: I743c86bec5f5424781a050a5d732c269b4e296d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760798
Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689443}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d20e6d40df1f..e9bc22c848cc


Created with:
  gclient setdep -r src-internal@e9bc22c848cc

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I12040d0422fb1927d62e0cde673fcc3cd901aa56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764880Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#689442}

This reverts commit 99e62c7f.

Reason for reland: Not actually the culprit for PrintBrowserTests flakiness

Original change's description:
> Revert "Remove print document race condition using synchonous message"
> 
> This reverts commit 2ff72648.
> 
> Reason for revert: Suspected of making various PrintBrowserTests flaky, see crbug.com/996185
> 
> Original change's description:
> > Remove print document race condition using synchonous message
> > 
> > JavaScript window.print() requests have been returning back to the
> > renderer process before the print has actually completed.  When the
> > print preview is disabled it is easier to expose a race condition
> > between serving the print logic and whatever comes next in the
> > JavaScript.
> > 
> > If the script has a popup window to be printed, which has
> > window.close() immediately after the window.print(), then the document
> > to be printed has its destruction racing against being printed - and
> > will typically lose that race, resulting in a lost or empty print job.
> > 
> > Resolve by ensuring that the renderer process does not proceed past
> > window.print() until the DidPrintDocument message is sufficiently
> > completed.  Making this message synchonous achieves this effect.
> > 
> > This means that the renderer process will be blocked for all sites
> > which it serves for slightly longer than it already does. [1]
> > 
> > [1] https://www.chromium.org/developers/design-documents/printing
> > 
> > Bug: 974480
> > Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275
> > Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
> > Reviewed-by: Tao Bai <michaelbai@chromium.org>
> > Reviewed-by: Tom Sepez <tsepez@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Commit-Queue: Alan Screen <awscreen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#688096}
> 
> TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,ctzsm@chromium.org,awscreen@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 974480, 996185
> Change-Id: I3ae34235d1bbdb98619a157a451e94e6b0e1cf48
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760795
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#689415}

TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,treib@chromium.org,ctzsm@chromium.org,awscreen@chromium.org

Change-Id: Ifc9ba8829440672fa83fdd1aa2ed45d4ede71e4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 974480, 996185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764196Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689441}