- 17 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db6ca7f2d7fd..44509036060c git log db6ca7f2d7fd..44509036060c --date=short --first-parent --format='%ad %ae %s' 2020-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 862d9d7b..1ae08c8c (732747:732864) 2020-01-17 ilnik@webrtc.org RtpReferenceFrameFinder: protect against crashes due to large temporal idx value on the wire 2020-01-17 jsphchn@google.com Update RTCAudioSession isInterrupted state when audio session is activated while interrupted. 2020-01-17 danilchap@webrtc.org Move Offset constants from VideoSendTiming value to VideoTimingExtension class 2020-01-17 srte@webrtc.org Adds current thread to yielders in SimulatedThread::SendTask. Created with: gclient setdep -r src/third_party/webrtc@44509036060c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042933 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If944c76dacbc185ae7a2f94e44c31fda856101d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732981}
-
kylechar authored
It's not used anywhere. Bug: 936425 Change-Id: Ifff668d1485060a6fa41e0b6f6a2452f45722e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005868Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732980}
-
Brandon Wylie authored
When the browser is recreated after a theme swap, the current model isn't necessarily the same before/after recreate() is called. Bug: 1042565 Change-Id: Icc63273b1690ec0fc5101c0abd252e0eef816469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006269Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732979}
-
Robbie McElrath authored
This moves AwSwitches to org.chromium.android_webview.common so flags can be used outside the browser process. This was broken off from crrev.com/c/2002897 to keep the change history correct. Test: ninja -C out/aw system_webview_apk Bug: 1035235 Change-Id: I283273ad70d6b9b71efefc9c198be3f796e8c8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003031 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732978}
-
Piotr Bialecki authored
- ran ESLint on webxr-test.js and xr-internal-device-mocking.js - xr-internal-device-mocking.js now stores the `MockRuntime._injectAdditionalFrameData()` before overwriting it with its own implementation, and calls the original implementation as the first step - throw instead of console.warn when math helper encounters unexpected combinations of .w component Changes: Change-Id: I94c015b5c89cfbc0e1a4b90db6ec44a198f4ce05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008073 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#732977}
-
proberge authored
This change adds a small (0 to 5 minutes) delay to scheduled policy fetches in order to alleviate server-side traffic spikes. The delay is randomly set at policy initialization time in the CloudPolicyRefreshScheduler constructor. To avoid causing issues with ChromeOS' synchronous policy fetches, we skip adding the delay in some cases. Bug: 963910 TEST: updated logic of component_unittest and one unit_tests Change-Id: Ic02ac2ef18e7e7b03ac95bdfab19e946c2f46324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998789Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#732976}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f53792645f06..c6a2ef12dffc git log f53792645f06..c6a2ef12dffc --date=short --first-parent --format='%ad %ae %s' 2020-01-17 rharrison@google.com Change call in shaderc_spvc_needs_buffer_size_buffer to be correct (#964) Created with: gclient setdep -r src/third_party/shaderc/src@c6a2ef12dffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I56a314aaa8b3c7f67ea92b74a484673158f71ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008171Reviewed-by:
-
Zhuoyu Qian authored
This CL change the class SandboxFileSystemTestHelper to use dedicated Origin type instead of GURL. Bug: 598424 Change-Id: I72eeda87aa6a32ffeeb5e61957e9df87d4642a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007088 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732974}
-
Toni Barzic authored
When active user changes, the old app icon loaders are reset, and the currently loaded app icons are discarded. This means that they have to be refetched while rebuilding pinned icons for the new user. Adds back ChromeLauncherController::OnAppUpdated (called from UpdateAppLaunchersFromSync() during user switch), and re-purposes it to ensure an icon is loaded for pinned apps. BUG=1040486 Change-Id: I553af66cd5fc2e1df9e285fff45290605eee58a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005228Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#732973}
-
Sebastien Marchand authored
This code has been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1960077 Bug: 1025842 Change-Id: I39cb113b784c29f7306c164df9cda693692b65b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002933Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#732972}
-
Swapnil authored
extensions This is to get a better idea about why the force installed extension failed to unpack through UMA statistics by reporting Sandbox Unpack failure reason in the InstallationTracker. Following histogram is added: Extensions.ForceInstalledFailureSandboxUnpackFailureReason Bug: 981891 Change-Id: Ia11f2603744e6b6f828bca6c3cba5f67e3a9c257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992062 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732971}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I0150fb957dcd929ca9889a4e817ae7b7e1d1ff4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002635Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#732970}
-
Mugdha Lakhani authored
Change-Id: Id4288fe389c42ecd3c53d1cdc636cde4129e59ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000921 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#732969}
-
Brian Geffon authored
BUG=chromium:1014871 Change-Id: I76375fadefee910ed7274f984c91d46dc499fe0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002834 Auto-Submit: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Mohammad Refaat authored
This addition makes sure that calling the restoreSession method from the agent has the same effect as calling it from the TabModel. Also forward the call from TabModel to call IsRestoringSession of SessionRestorationAgent. Bug: 1010164, 783777 Change-Id: Ib4fdfb1c1fe4fc04515b8e4462f3f68df0c9453f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003911 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732967}
-
Dan Beam authored
Fixed: 1042572 Change-Id: I4928cdae0ac882921e8083193a36570f41b32c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005827 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732966}
-
Yi Gu authored
This is a follow-up patch of crrev.com/c/1962567 to support transform inducing resnapping. Bug: 1028316 Change-Id: Ie1ae2f088919665c6ddfbf3d8a9dce119d066f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008061Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732965}
-
rbpotter authored
Remove some noise for screen readers in dialogs by moving non-title elements out of the [slot='title']. Anything in this slot is read out when the dialog loads. Move these elements to the body instead. This change requires updating some CSS styling, in order to keep the lists the only piece of the dialog that scrolls and to keep the appearance of the dialogs the same. Bug: 987324 Change-Id: I0ae6f7b338b7df988c12289f7eca2e876bd99a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006216 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
jonross authored
We have removed the usage of --fuzzy-diff on Linux: https://chromium-review.googlesource.com/c/chromium/src/+/1989866 A series of tests were identified in that patch as failing without the fuzzy-diff. Here we attempt to re-enable, running a rebaseline. Many tests had linux specific baselines deleted. Others have been updated. This reflects some tests with small pixel differences. As well as some where the style of the controls has been changed. Two tests feature new linux specific baselines. There is no diff as in the review as they did not exist before. Both represent slight shifts in the font: third_party/blink/web_tests/platform/linux/virtual/controls-refresh-hc/virtual/controls-refresh/color-scheme/text-selection-outside-control-expected.png third_party/blink/web_tests/platform/linux/virtual/controls-refresh/color-scheme/text-selection-outside-control-expected.png TEST= blink_web_tests Bug: 1039401 Change-Id: I102cf9cee9c85daa3f5c00cbe185fead1fea3abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993424 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#732963}
-
Kevin Marshall authored
A bug in the Blink renderer required that we use a 2x2 rect for the simulated browser window instead of a 1x1 rect. cl/2002839 fixes that issue, so we can now use the smallest possible dimensions. Bug: 1039762 Change-Id: I89a24547f6a0ef62d9f0476e1ffff83dd5df32c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003395Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#732962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/243095cddff8..7b0e33db0c16 Created with: gclient setdep -r src-internal@7b0e33db0c16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034144,chromium:1042660,chromium:1042712,chromium:1042717 Tbr: jbudorick@google.com Change-Id: Id73f0c22b9aea7606116afe909a7a84ba02779dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732961}
-
Kenneth Russell authored
I haven't made contributions to this area of the code for a long time. Bug: none Change-Id: I7aa03680fe8f087677c11a57fa519e790ba2f2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007654 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732960}
-
Vikas Soni authored
1. Enable shared images by default on webview via finch feature flag. 2. Update Shared image factory usage to use correct backings for webview. 3. Implement and use a dummy version of MailboxManagerSync to be used only when shared images are enabled on webview. Bug: 900973 Change-Id: I2cc046b8bb5fa9121d6c90a2670d378ff3fe0258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977842 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732959}
-
sukwanlee authored
Bug: 1042407 Change-Id: Ifd15c599bee387e54ff2edabb92565a667055005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003365 Commit-Queue: Sukwan Lee <sukwanlee@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#732958}
-
jongdeok.kim authored
This CL adds a border color to views::Border, and remove a color memeber in subclasses. Bug: None Change-Id: I5598325d4baac305c145b933889fea96de6d3bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985635Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#732957}
-
Avi Drissman authored
Collect basic information as to whether the Mac is joined to a domain, or if it is controlled by MDM. Tbr: pastarmovj@chromium.org, asvitkine@chromium.org, mark@chromium.org Bug: 1040630 Change-Id: Idcc3fbeca66b9b5278965d5219851e51a20f3da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007511Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732956}
-
Kyle Horimoto authored
Fixed: 1042316 Change-Id: Id013c917732d00c65b4f2533a697ffbd1c4ccb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006422Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732955}
-
Joe DeBlasio authored
This CL changes the mixed content download blocking code to return an enum indicating what type of blocking should be used (silent, or two types of blocking UI). Previously, this function returned a boolean that indicated silent blocking. The CL then propagates that result through the DownloadTargetDeterminer into the DownloadItem. That state is needed later to trigger the existing download shelf warning UI. This CL also renames callbacks in/around the DownloadTargetDeterminer from "ShouldBlock"-type names to "GetMixedContentStatus"-type names. This CL causes no functional change to Chrome. Follow-up CLs will add support for, then trigger, user-visible warnings. This is part of go/downloads-as-mixed-content . Bug: 960819 Change-Id: Ic0c3f41caf7e623050d4b75be364f410a46e296d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982680Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#732954}
-
Darwin Huang authored
Bug: 1042145, 1042578, 1042700 Change-Id: If611c01b0b4e507376d187292809d50b9c786932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006427Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732953}
-
Ahmed Mehfooz authored
Bug: 1035361 Change-Id: Ib39b48c2798262c98ded9a2beb796d8f359da925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006370 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Fixes Telemetry's tombstone and logcat stack symbolizing not working on the bots due to missing data dependencies. Instead of including the files in the Telemetry group, they have now been moved to //build/android:stack_tools. Bug: 1041902 Change-Id: I14d614199a7e54bc4dd03a6a2b7379cf229fb8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006390 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#732951}
-
Michael Thiessen authored
This is a necessary pre-cursor to cleaning up scheme initialization. No GURLs should be created before schemes are modified/added and GURL is ready to use. Enforcement of this will come in a followup CL. See the bug for additional context. Replacing static initalizers with functions ensures the GURLs are only initialized when used, which happens after test setup. Bug: 783819 Change-Id: Ifafe4a45b69eac0df10ac2125a328d24de130bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918828 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#732950}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93e3c76a6543..e1b7afc8f3a1 git log 93e3c76a6543..e1b7afc8f3a1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 reed@google.com add guard to move to explicit matrix conversions 2020-01-17 fmalita@chromium.org [skottie] Cleanup: convert more effects to new animator pattern 2020-01-17 bsalomon@google.com Reland "Make SkGpuBlurUtils take SkTileMode"" 2020-01-17 brianosman@google.com Switch coord transforms in gradient layouts to 3x3 (SkMatrix) Created with: gclient setdep -r src/third_party/skia@e1b7afc8f3a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: If4318a0d238d6e82f3be59dae1064b5d6b29e31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007925Reviewed-by:
-
Harald Alvestrand authored
Delete juberti@ as non-committer Add people currently working on webrtc Bug: none Change-Id: I5828538aedec8d507947fbfcbbe6801ff6f81be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005990Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#732948}
-
Maksim Ivanov authored
Fix the error font and position according to the latest UX feedback: * increase the font size to 12; * remove the bold weight from the font; * move the error label up, so that the distance from the input field to it is only 4px. Bug: 1024251 Test: use DevTools to check the font, take a screenshot to check the margins Change-Id: I631f2fab46270251d0e980480c21b4d37fb479e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002874Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#732947}
-
Michael Lippautz authored
This reverts commit f0776695. Reason for revert: Failures should be fixed. Original change's description: > Test suppression for deqp/functional/gles3/sync.html failure > > deqp/functional/gles3/sync.html is failing intermittently on Win. > Suppress. > > TBR=kbr@chromium.org > > Bug: 1033662 > Change-Id: Ib4721835bb5cbf2d500dbeb1a411548244a89a05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966087 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724414} TBR=rjkroege@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1033662 Change-Id: I211cba88f49165522a5083240476dad4ae5a0d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007109Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732946}
-
Kristi Park authored
Implement a basic dialog and insert the Ink canvas. Downstream component for https://crrev.com/i/2415665. Bug: 1024586 Change-Id: Iff5d0d9be76e0c4fb9a7a6c03691f068013e3de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999265Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#732945}
-
danakj authored
The UpdateBrowserControlsState IPC requires a main frame to be present and only makes sense for a (local) main frame since that is the single place that has browser controls. This DCHECKs instead of ignoring the IPC to catch and point out logic errors if they exist in the browser. All callers clearly check or are calling the IPC for the main frame already except BFCache which is difficult to tell. The BFCache bot will inform us if there are any tested misuses already, and this DCHECK will prevent future mistakes. R=avi@chromium.org Bug: 419087 Change-Id: Ic91453ab8cbf5d0d575983a82a2cf3a3855e3d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005814 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
They are replaced with the new setters. Bug: 1011446 Change-Id: I1c4bcb1853e4ae43d043135bc7f3fbf534aca66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007649Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#732943}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d092437b81ea..2e5c7edf368f git log d092437b81ea..2e5c7edf368f --date=short --first-parent --format='%ad %ae %s' 2020-01-17 lalitm@google.com Merge "trace_processor: allow selecting rowmaps with smaller rowmaps" 2020-01-17 buss@google.com Merge "Fix compilation on Windows/VSC." 2020-01-17 hjd@google.com Merge "ui: Remove small gap in pinned track container" Created with: gclient setdep -r src/third_party/perfetto@2e5c7edf368f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib8ceb5de792d61f42929d30e6f411fb3435d8238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008168Reviewed-by:
-
