GitLab

This method should not be in ChromeFeatureList and can be used by
components.

Bug: 1060097
Change-Id: I954f71fd4dc0207a7f3b90ec855e2814f733475e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111274
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757145}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fdbd42e2f874..298b8cc3134f

git log fdbd42e2f874..298b8cc3134f --date=short --first-parent --format='%ad %ae %s'
2020-04-07 tvanderlippe@chromium.org Enforce no default exports exist
2020-04-07 tvanderlippe@chromium.org Update Mocha to 7.1.1
2020-04-07 alexrudenko@chromium.org Hide text overflow in Settings -> Locations
2020-04-07 tvanderlippe@chromium.org Update karma-typescript to 5.0.2

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@298b8cc3134f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1068145
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ic7239315b3cc3f542f82f85eb1632bba72075a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140252Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757144}

This CL:
- Deletes unused WebappScopePolicy class
- Deletes unused methods:
  WebappActivity#isSplashShowing()
  WebappActivity#isInitialized()

BUG=None

Change-Id: Ic2fb17a2b66676ebe8b932a310dd7974d4716394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138565Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757143}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5deecef6..203b5f85

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I65a400656c30048c691ac194c7e9d965c8ae10ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139903Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757142}

This reverts commit c0f5639c.

http://crrev.com/c/2139722 reverts setting the default color to
CanvasText until ForcedColors can be enabled by default.

As a result, the default color in forced colors mode needs to be
reverted back to CanvasText until we can safely set the default
to CanvasText in all cases.

Bug: 1067481
Change-Id: I70292761d239215cd963f26066d716ffebe0cd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140291Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#757141}

This reverts commit fbe0892e.

Without the ForcedColors Blink runtime feature enabled, using Canvastext
resulted in a white text on white background default rendering on
Windows when high contrast mode was enabled in the OS.

Should be re-landed when the ForcedColors feature is enabled by default.

Bug: 1067481
Change-Id: I41a18fc1e406151085930e0953046caf5f4d9b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139722Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757140}

https://skia.googlesource.com/skia.git/+log/e19babf99696..0999bce974ac

git log e19babf99696..0999bce974ac --date=short --first-parent --format='%ad %ae %s'
2020-04-07 csmartdalton@google.com Reland "Remove GrGLGpu mirror methods of GL draw calls"
2020-04-07 reed@google.com stage changing didCocnat44 virtual
2020-04-07 egdaniel@google.com Ignore incorrect vulkan valdiation error.
2020-04-07 fmalita@chromium.org [SkTrimPathEffect] Preserve wrap-around continuity
2020-04-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1c95795f1fb3..eb298a024032 (11 commits)
2020-04-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b8d47928094f..b4a27407e2be (5 commits)

Created with:
  gclient setdep -r src/third_party/skia@0999bce974ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: csmartdalton@google.com
Change-Id: I0480dec1408aca95189933229568cb13bd1ef66a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140253Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757139}

Add non-owner child user remove warning enum. Update explanation.

Bug: 952500
Change-Id: I014206b6fd00ecafb526c466a1e8098ef408e9bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129281
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757138}

Bug: 1026426
Change-Id: I8bfa01f305890554249cf444ceda3e7e8b30de77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136281Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757137}

Previously, the raster color space was set to prefer raster in sRGB
for Android. However, this is not desirable for WebView, which should
prefer raster in whatever color space the app is using. That was
already being done and was overwritten by the preference of sRGB.

This CL prevents preferring raster in sRGB when using WebView.

Bug: 955158
Change-Id: I316e646bc7ebac309fa609c2c30a5efa8e6c3650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116560Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757136}

This reverts commit 21154bb7.

Reason for revert: Flaky compile errors

Original change's description:
> [OutOfBlinkSandbox] Move SandboxFlags into service/network.
> 
> Rename {blink->network}::mojom::WebSandboxFlags.
> 
> This patch is a step in the following direction:
> ~~~
> Stop parsing the HTTP CSP sandbox header in blink. Parse it in the
> network service CSP parser. This allows the browser process to compute
> the Origin of the new document before loading it.
> ~~~
> https://docs.google.com/document/d/1PechV73KKMF8leh7uTlyGkR32kD5qILvu3ZeG8TYGfk/edit?usp=sharing
> 
> This CL touch many files (Sorry). To easy review, here is the list of
> changes to look at:
> 
> 1) Interesting files:
>    - *.DEP
>    - services/network/public/cpp/sandbox_flags.h
>    - services/network/public/mojom/sandbox_flags.mojom
>    - third_party/blink/renderer/core/frame/sandbox_flags.h
>    - third_party/blink/public/mojom/feature_policy/feature_policy.mojom
> 
> 2) The enum blink::kPresentationReceiverSandboxFlags was defined in:
>    third_party/blink/...
>    .../public/common/presentation/presentation_receiver_flags.h but it
>    was not used in blink. It has been moved to the content/browser.  See
>    content/public/browser/presentation_receiver_flags.h
> 
> 3) The operator<<(ostream, Sandbox) is removed. It was defined both in
>    sandbox_flags.h and in the generated mojo files. The bot
>    "win_chromium_compoile_dbg_ng" was not able to inline the calls and
>    ends up with a linker errors. See the trybot for:
>    https://chromium-review.googlesource.com/c/chromium/src/+/2062336/4.
> 
> TBR=thakis@chromium.org
> 
> Bug: 1041376
> Change-Id: I9f6cbb3b04ac07ecee22b3fca43cf19a260269cd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062336
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Ian Clelland <iclelland@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757059}

TBR=kinuko@chromium.org,thakis@chromium.org,mfoltz@chromium.org,iclelland@chromium.org,mkwst@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org

Change-Id: I1d5d0dff6b229cfa618bb07670610f5932f012f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139823Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757135}

Before this change, when the active tab was changed but
it's webcontents not updated (we switched to a quiescent tab),
the UrlBar wasn't getting updated.

After this change, it is always updated when active tab changes.
Tested manually, and added a browsertest to verify behavior.

Bug: 1025607

Change-Id: I085b4748f25d3f2f483a5d9964bb767ed178f1de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139707
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757134}

Using wpt-import in Chromium bad271a7.
With Chromium commits locally applied on WPT:
d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers"
2688e49a "De-flake two lazyload WPT tests."
7e979350 "Handle k-rate AudioParam inputs for PannerNode"
64239f32 "Revert "[css-filters] Migrate effect-reference-convolve-error.html test to WPT""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ifd0fc96f01ebeb002d86bfed9063971303afdf91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139899Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757133}

Bug: 1065848
Change-Id: I3e6291704643ac833ba6f7d97bc77a8e4f455e44

Change-Id: I3e6291704643ac833ba6f7d97bc77a8e4f455e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138773Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757132}

The instantiation for this was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1435824/6..7/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc
, which I think must have been in error.

Bug: none
Change-Id: I984a0f7d73b2099333a67cb14369df676e9e3db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139113
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757131}

These use actions will show up in Breadcrumbs logs, which are the steps
to reproduce attached to the crash logs.

Bug: 1046223
Change-Id: I49d6a19fb22eebce2d939a7378179148913cc85f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138166Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757130}

Bug: 1067208
Change-Id: I7c731470111440b9f5ca1100819dff780e847172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139720Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Dominic Battré <battre@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757129}

After:
When a merchant page runs in a Trusted Web Activity that's installed
from an app store (e.g., Google Play) and the PaymentRequest is not
requesting shipping or payer contact, if it satisfies the following
conditions, the TWA itself would be included:
- the PaymentRequest supports the (TWA installer) app store's
billing method in the payment request.
- the TWA can handle pay intents.
- the TWA can handle the app store billing method.

Before:
AndroidPaymentAppFinder could not include a TWA for an app store
billing method.

Change:
* In AndroidPaymentAppFinder#findAndroidPaymentApps, check if the
merchant page is a TWA installed from app store and if the
PaymentRequest is requesting shipping or payer contact. If it is,
add the TWA itself as a payment app if it's eligible.
* remove mIgnoredMethods.

Note:
* Counterintuitively, the merchant page would send the pay intent to
the TWA instead of the Play Store, because it would be the TWA who
is responsible to interact with the app stores.

Bug: 1064740

Change-Id: I0a2f6baebae422aaeab574e3c39a10cd61fafb4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135152
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757128}

Bug: 1067622
Change-Id: I1fddfec245cf267100f56756bc9fd38ddacb87ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137868
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757127}

This CL adds a cache config in ImageFetcherParams public API. There is
no internal change in this CL.

Also use reduced mode image fetcher for query tiles project.

Bug: 1067049,1058534
Change-Id: I3accc828e3436d71fbf801f6bdd33d934c51f091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133210Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757126}

BUG=v8:9684

Change-Id: I5ff38157fffe36f99aed05f4199544c46c66e897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139767
Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757125}

Bug: none
Change-Id: Ica79e3731938a6a342d86d072177516ae0c5ca3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136474
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757124}

This CL moves the Skia to Java bitmap conversion off UI thread.
It also adds background color support to the Paint Preview player.

Bug: 1068644
Change-Id: Ice495fe1ec2e52e7ef29ae45263679e29cd3bc7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139906
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757123}

This reverts commit deccd219.

Reason for reland: Relanding after consideration of landing
in M83 branch.

- This CL now has just the content/ changes implementing
RenderDocumentHostUserData.

- Followup CL (https:://crrev.com/c//2139814) will introduce the
first use of the new content/public API for
RenderDocumentHostUserData.

Original change's description:
> Revert "[content] Introduce RenderDocumentHostUserData"
>
> This reverts commit d2cce3a4.
>
> Reason for revert: To avoid large code changes/fixes according to the
guidelines and postponing landing this CL after M83 branches out.
>
> Original change's description:
> > [content] Introduce RenderDocumentHostUserData
> >
> > This CL introduces RenderDocumentHostUserData(RDHUD) API through which
> > we can associate data with the underlying document.
> >
> > This patch converts UsbTabHelper to use RenderDocumentHostUserData and
> > replaces existing manual tracking of frame lifetime in a map.
> > Currently a map from render_frame_host to the FrameUsbServices is
> > maintained to get the associated FrameUsbServices
> > object instead we use RDHUD to do the same set of operations.
> >
> > This document https://docs.google.com/document/d/138_67WkBaU35W_wlLUS7ux-ICM_5tosdyLOBiqvlWs8/edit?usp=sharing
> > explains in more detail on how RenderDocumentHostUserData can be
> > used and extended to different classes.
> >
> > BUG=1057611
> >
> > Change-Id: I37894f2897f4f7b2c5bbd10d422a39daba9bd0c2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055105
> > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Alexander Timin <altimin@chromium.org>
> > Reviewed-by: Jun Cai <juncai@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#754070}
>
> TBR=nasko@chromium.org,rockot@google.com,fdoray@chromium.org,reillyg@chromium.org,clamy@chromium.org,alexmos@chromium.org,juncai@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,sreejakshetty@chromium.org
>
> Change-Id: If3a7449dd9155c542bf374cd2bcbf8aec267ffdd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1057611
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124671
> Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754115}

TBR=nasko@chromium.org,rockot@google.com,fdoray@chromium.org,reillyg@chromium.org,clamy@chromium.org,haraken@chromium.org,alexmos@chromium.org,juncai@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,sreejakshetty@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1057611
Change-Id: I8817e26f4a21edc03471e6946ac449e97b6b8611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137103
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757122}

This tries to prevent users from accidentally triggering a context menu
option on platforms with show-context-menus-on-mouse-press.  It forces
people to wait 200 ms before the mouse release will activate the context
menu.

This is fine, but there's a better check just above in this code which
early-returns in this case, except that that check also includes a mouse
movement check -- we allow releases if the mouse moved more than 4 DIP.
This seems like desirable behavior.

Worse, the two checks have reverse conditionals, but this check uses >
instead of >=, so the "==" case is not handled equivalently by the two;
and in tests, where the "hold time" is often reset to zero (in an
attempt to disable this check) and the task environment often uses
MOCK_TIME (so press and release often have an identical timestamp), that
means this check can trigger when it shouldn't.

Bug: none
Change-Id: I25d94c9c0d793321dd872ebcac886c5eac7deb27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138234
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757121}

In ambient mode, when user interacting with the background image by
mouse or gesture, lock screen contents (login pod and media control
view) need be shown on top for users to either do re-authentication,
or media control.

This CL implements a prototype of this view transaction by:
1. Show the lock screen contents, and
2. Fade-out the current shown image.

Bug: b/149246238
Test: manually.
Change-Id: Ie31c666cdfaddefc863ff8173dc185d73ef19178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110689
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757120}

Assistant UI and search results page in the app list view may contain
hosted native views (e.g. for answer cards, or assistant card UI
elements). These would not animate with the app list page layers,
causing glitches when app list view was animating after drag to
fullscreen or half position.

This CL updates the app list view contents animations for app list view
state change to animate windows hosted within the app list (i.e. app
list window children that have a host view property).

Along the way, this makes sure that page shadoes are animated together
with the page layers.

BUG=b:147825124

Change-Id: Ic1974b8a6767bbc25fdf96d5d6a67c41eb906fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136845
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757119}

TBR=govind@chromium.org

Change-Id: Ib974507d0994b5d945c1e143930c2a869aec8db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140067Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757118}

Add a new parameter for the TrayBubbleView that allows whether they
are anchored to the status tray area to be set without extending the
class, and updates the autoclick menu to take advantage of that.

Relnotes: N/A
Bug: 973719
Change-Id: I5a65afa02a4aaf8150049551ab97ced3eb425a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134956Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#757117}

File chrome\browser\policy\browser_dm_token_storage_win.cc includes
comutil.h for _variant_t but doesn't add comsuppw.lib which is required
according to MSDN:
https://docs.microsoft.com/en-us/cpp/cpp/variant-t-class?view=vs-2019

Without this change, we'll get a linking error as follows:

[2773/2779] LINK(DLL) chrome.dll chrome.dll.lib chrome.dll.pdb

FAILED: chrome.dll chrome.dll.lib chrome.dll.pdb
...
lld-link: error: undefined symbol:
wchar_t * __cdecl _com_util::ConvertStringToBSTR(char const *)
>>> referenced by .\..\..\third_party\depot_tools\win_toolchain\
    vs_files\<...>\include\comutil.h:1294
>>> obj/chrome/browser\browser/browser_dm_token_storage_win.obj:
    (public: __cdecl _variant_t::_variant_t(char const *))

Bug: 1068627
Change-Id: Iec1c323fca3664b8310e31c622e4d145bc7bc37f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140192
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757116}

This came in handy while debugging when I wanted an accurate classname.

Bug: none
Change-Id: I09c427b8ae74e5866f5262f2c76b809790e1dacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137829
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757115}

* Minor tweaks to comments/blank lines/etc.
* Use temps as needed
* Remove unnecessary headers
* Remove spurious RunUntilIdle()
* Remove unnecessary resets of raw pointers to null during teardown/destruction
* Init members in declaration
* Use =default where possible
* Prefer make_unique to bare new
* Prefer unique_ptr::reset() to =nullptr

Bug: none
Change-Id: Id7d0374d60519be8b65c1611b3d33a63872efee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139071
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757114}

This removes all dependencies on chrome:// from PageInfoControllerAndroid
except for the dependency on the JNI header for its java counterpart. We
can remove this once the java counterpart is ready to be moved to
components.

Bug: 1052375
Change-Id: I26e21019655d7099f89e16d481789f1afb1736d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137323
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757113}

Bug: 369206
Change-Id: I73bcffbaf87b8db84e75293d5d590bea70568ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137817Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757112}

Updates the expires_after attribute for 50 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2020-10-04.

TBR=bcwhite@chromium.org

Change-Id: Ibd3878f819cc6cadab4ed61fcdf0dd30e08048ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140211Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#757111}

Work on IsolationInfo is hopefully getting us towards getting the
browser-side one entirely right.

Bug: 1066044
Change-Id: Ib62b1f2bea2843649b2dd48a45b4d68ed3c769d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140171Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757110}

No change to logic.

This is a partial revert of commit
5d6c4ec7, to remove the histogram it
added (this metric is no longer necessary). This only keeps the
comments the original CL added to AwHistogramRecorder.

Fixed: 1066113
Test: N/A
Change-Id: I6cb270225e048c67473a288de387ec7a822ff140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137826Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757109}

This migrates remaining DeprecatedEqual comparisons against ASCII
constants [1]. Although it is potentially web-facing, no tests are
written as suggested on blink-dev [2].

[1] https://docs.google.com/document/d/1uZ0wMBF63eLJNbW3yz1oGK7qkO3VqRUwdmNAbiLanN8
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ

Bug: 627682
Change-Id: I5479c236c44c61a4f722a1746fdc859983c3135b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128315Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#757108}

Spellcheck languages that have Windows platform support but not
Hunspell support (Arabic, Finnish, ...) cannot be disabled or forced
enabled by enterprise policy. This is because of the use of
spellcheck::GetCorrespondingSpellCheckLanguage in
SpellcheckLanguageBlacklistPolicyHandler::SortBlacklistedLanguages and
SpellcheckLanguagePolicyHandler::SortForcedLanguages, a method that
only recognizes Hunspell languages.

The fix is to instead check if a language with policy being enforced is
on the list of supported accept languages, as these are what are used
to populate the language list on the language settings page. Note that
in the upcoming implementation of support for non-Hunspell languages,
we will only allow Windows platform spellchecking for these accept
languages (if they have a Windows spellcheck dictionary).

Instead of just searching for the accept language within the tag, the
algorithm first tries for an exact match (so "en-CA" would be found),
then searches for an exact match for the language without locale
info, that is, what's to the left of the hyphen in a language tag
(so "ar" would be found for "ar-SA").

Also adds unit test coverage for the spellcheck policy handlers, which
previously had none.

Note that there is an interplay between forced and blocked languages,
as well as the spellcheck-enabled policy:

  1) If a language is both forced and blocked, forced wins.
  2) If spellcheck is disabled by policy, the forced/blocked languages
     policy has no effect.

Test cases cover this interplay.

Bug: 1056850
Change-Id: Iec54a851d38f00a7aa7597449f7acc30f3dd2de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080450Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Bruce Long <brlong@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#757107}

This builder was broken by recipe-side change crrev.com/c/2125157,
but the fix (crrev.com/c/2128842) was not cherry-picked to the M81
branch. Since this feature is not enabled in M81, we can simply
remove this builder from the CQ rather than cherry-picking the test
fix.

Bug: 1068383
TBR: gbeaty@chromium.org
No-Try: True
No-Tree-Checks: True
Change-Id: I2cc44a80dca5ca55cc5f94c96c3bbbec2397907e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140295
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757106}