- 23 Nov, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts RemotingDataStreamSender to new Mojo types using PendingRemote, PendingReceiever, Receiver, and Remote. Bug: 955171 Change-Id: I6e19b01ee378d1996e1bed31dea0fed7bc8baefc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923972 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#718420}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5787e3e65d9b4596ba483fc96e96724dd3c52ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931916Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718419}
-
Pavel Feldman authored
Change-Id: I1fe3dfdf032c5780eb7a14f27816f235b4e27c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931345 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Auto-Submit: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718418}
-
Tom Anderson authored
* Removed SelectAPI() which relied on the XDG_CURRENT_DESKTOP environment variable. The correct approach is to check the presence of each DBus API directly. * Remove unnecessary |freedesktop_suspend_delegate_|. PowerSaveBlocker::Delegate can now hold multiple inhibit cookies, so having multiple delegates is no longer needed. BUG=1013812 TEST=Tested on GNOME and KDE environments R=blundell Change-Id: Ia338a12a70e3deed72166e5a980eec64767a7f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926852 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718417}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f72b13cb..aef9e1f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iadc505d2d650f6e5c0f6adb81ddc8482bbd8aaa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931623Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718416}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/556c0a2e0f48..800129711d28 git log 556c0a2e0f48..800129711d28 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 vbendeb@chromium.org my_activity: allow to exclude some servers Created with: gclient setdep -r src/third_party/depot_tools@800129711d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:none Tbr: agable@chromium.org Change-Id: I3dafc8ee9a4c4df2c024fad5ac5676093608fcbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931659Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic7dee6be5e1ede4d6d979e8b926ab0fd81b7609c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930410Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718414}
-
Tom Anderson authored
* Remove complex locking and thread state tracking and instead switched to using blocking dbus calls. The calls all happen on |blocking_task_runner_| anyway, so blocking is OK. BUG=1013812 TEST=Tested on GNOME and KDE environments R=blundell Change-Id: I1f9e60e535425c55ced50a204e3cbbc6b30dab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926825 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6140be50ddb..df3cd06cdbe8 Created with: gclient setdep -r src-internal@df3cd06cdbe8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None,chromium:984162,chromium:1004848 Tbr: jbudorick@google.com Change-Id: Ieb21d01ed5233088cf50276a0aa9516c9f474ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718412}
-
Ethan Jimenez authored
1. Refactoring most of `AXRange::AsForwardRange` logic into a new static helper `CompareEndpoints` that determines between two `AXPosition` which one should be the start when using `AXRange::Iterator`. This helper is also used in `ITextRangeProvider::MoveEndpointByUnit`, in order to avoid more expensive comparisons of text positions. 2. As part of the `AsForwardRange` refactor, `CompareEndpoints` was optimized by avoiding even more text position comparisons. 3. Removing a pair of unnecessary calls to `CreateParentPosition` in `AXRange::GetScreenRects` when we iterate over inline text boxes. `CreateParentPosition` for a text position computes the max text offset of every subtree before the child node containing the given position, doing this sequentially for inline text boxes within the same parent node would result in n^2 calls to `MaxTextOffset`. 4. Before introducing these optimizations, the percentage of how much the subroutines above constituted a call to `GetScreenRects` were: AXRange::GetScreenRects Weight % |- AXPosition::CreateParentPosition ~20.81% |- AXRange::Iterator::begin ~18.28% |- AXRange::Iterator::end ~18.41% ITextRangeProvider::MoveEndpointByUnit Weight % |- AXPosition::operator< ~10.01% After introducing this change's optimizations, the weight of every method listed was reduced to ~0% in their respective call stacks. Bug: 928948 Change-Id: I0584e74af8327fdc3855a4d80060030998b7de95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928320 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#718411}
-
Esmael El-Moslimany authored
old: --cr-icon-button-color new: --cr-icon-button-fill-color old: --cr-icon-button-focus-color new: --cr-icon-button-fill-color-focus Bug: 1022752 Change-Id: I0ebe6f0bbad25a391b108d1c7d38db431a8ef009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917976Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#718410}
-
Jiawei Shao authored
This patch exposes the read-only attribute GPUAdapter.extensions in Blink as is required in WebGPU SPEC. GPUAdapter.extensions is a dictionary whose keys are extension names and values are boolean values that indicate if the extensions are supported on this adapter or not. BUG=chromium:996713 Change-Id: I6bfd2283babf981208ade10adb458f088f0333f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929717Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#718409}
-
Jon Mann authored
Previously, when a modal was open, the left and right arrow keys were activating the accelerator used to toggle between users on the the main login screen underneath. Fixed: 1019912 Change-Id: Ibd9cde9e7239566ae75c36a388722b4a08b0a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930105Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#718408}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3d35f8f9c6f..e9b68f332a30 git log f3d35f8f9c6f..e9b68f332a30 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 emircan@chromium.org Clean unused NewCreateImagePipeCmd 2019-11-22 cnorthrop@google.com Enable frame capture on Android 2019-11-22 jmadill@chromium.org Posix: Fix async LaunchProcess. 2019-11-22 shrekshao@google.com EXT_texture_norm16 readpixels fix Created with: gclient setdep -r src/third_party/angle@e9b68f332a30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024387,chromium:1000354 Tbr: courtneygo@google.com Change-Id: I61e468a8a7a87d2c172c16aeaf19f49e3dabfb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931739Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::ScopedAccessPermission with using PendingRemote and MakeSelfOwnedReceiver. Bug: 955171 Change-Id: I6d5de865728ebc3f5ef18de9b6d3d75d1fe6b89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930534Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Toni Barzic authored
Makes search result page view a list box, whose value indicates the number of available results, and the query for which the results are shown. The search result view roles are changed to list box options (which should give the user feedback of the relative position of the currently selected result). When the result list is updated, the accessibility framework is notified of the results page view's value change (so the new value gets announced by spoken feedback). The notification is sent with a delay, once the set of results, and the query itself stabilize to avoid spamming accessibility framework with interim values. The result selection changes are still announced by sending kSelection events on the selected result, but the timing of the notification is now controlled by the search results page view. The notification is not sent from the views when the selection state changes - instead, SearchResultsPageView will request the selected result view to send notification when required. With this, selection change notifications are throttled while the result list is still changing. Bug: 939111, 1021270 Change-Id: I0db6f1263e0bea0dddd0f278436bfc025bc6f450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925769 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718405}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a47f7784. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic8499401a4f488e15d9d41f71cdebf57aedac3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931619Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718404}
-
Ulan Degenbaev authored
These events are now emitted by V8 ensuring proper event nesting which is necessary for upcoming perfetto change. The corresponding V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/1928857 Bug: 1026658 Change-Id: Icbe75d8c6da18ea0894446e23162c7794dc1fd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929227Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#718403}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f6eb890f4c9c..733842c59dd2 git log f6eb890f4c9c..733842c59dd2 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 yunchao.he@intel.com Add memory synchronization tests - render to compute and vice versa 2019-11-22 hob@chromium.org Remove WrapVulkanImageOpaqueFD Created with: gclient setdep -r src/third_party/dawn@733842c59dd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:996470 Tbr: cwallez@google.com Change-Id: Ia9500db76cb7cfc1e3dd4a2a2f32363a2ca0c7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931736Reviewed-by:
-
Sunny Sachanandani authored
Fix access of shared image with the legacy mailbox consume API in GPU raster and HUD layer. Remove DISPLAY usage for one copy staging buffers since they aren't exported to viz. These issues were found during DrDC prototyping. Bug: None Change-Id: I71a7c0b1c0f404bd556f6db739f7ad70b6822ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929776Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#718401}
-
Daniel Cheng authored
base::Hash() is deprecated and is being replaced by base::FastHash(). The output of base::FastHash() is only fixed within the lifetime of a single process, so if the code depends on the mapping of inputs to hash outputs not changing over time, base::PersistentHash() must be used instead. Notes: - Add a base::PersistentHash() overload that takes a base::span to match base::FastHash(). - Fixes tracing ID generation to use base::PersistentHash(), since the tracing IDs are not always generated in the same process. Bug: 1025358, 1026837 Change-Id: Ibdfe5185c0a8fdb9ab2fd2ee7408ea73e842801b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923499 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718400}
-
David Trainor authored
The test still used System.currentTimeMillis() which could very rarely return a different value even between just a few instructions. Change-Id: I8cc649771cec6506b28decba91bd74a1ed1a7e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929084Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#718399}
-
Maria Villarreal authored
This reverts commit 7be5b8ce Reason for revert: https://crbug.com/1021934 Original change's description: >Hit testing should make use of GetEventHandlerForPoint in Views > >This change intends to fix touch with a screen reader in nested >elements across the browser frame, as the tabs and the location bar. >The issue here is that the focus ring is the first child found and >returned by HitTestSync and does not allow to continue looking for >the nested view child. >For example, if touching the bookmark button inside the location bar, >focus ring (which covers all the area of the location bar) will be >found before the bookmark button. > >This fix adjusts HitTestSync by now calling >View::GetEventHandlerForPoint which returns the hit child on the >view. Then we still iterate the children of this view since >we need to return the deepest-most child it can find. The benefit >on calling now GetEventHandlerForPoint is that this method >already knows how to handle overlapping views. > > >Bug: 990560 >Change-Id: I9076c3dfaa1424b69eb49b83c07b10ebeb26776d >Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817289 >Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> >Reviewed-by: Nektarios Paisios <nektar@chromium.org> >Commit-Queue: Maria Villarreal <mavill@microsoft.com> >Cr-Commit-Position: refs/heads/master@{#705217} Bug: 1021934 Change-Id: Idb8621c728aeff49f5762804c716f8386d228664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928012Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718398}
-
Avery Musbach authored
The present CL fixes how the divider position in clamshell split view is adjusted when the display orientation changes. BEFORE: It is updated in SplitViewController::OnDisplayMetricsChanged, with logic meant for tablet mode, such as subtracting half the thickness of the divider. AFTER: It is updated based on the snapped window bounds after those bounds are updated by good old WindowState::AdjustSnappedBounds. Fixed: 1005501 Change-Id: I9471cf54a5cc0da3e73090716493d5fea34da9d6 Bug: 1005501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925237Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#718397}
-
Johannes Henkel authored
New revision: 7a44a37f66b58358dd8ab85ccde1998fafa95e53 Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1899564 Previously, we used a wrapper routines, e.g. those in content/browser/devtools/devtools_protocol_encoding.cc to use this library, by using dependency injection to provide the string<->number conversion routines. With this change, the third_party library depends on the routines in //base via a custom, Chrome-specific .cc file, json_platform_chromium.cc. This does away with the indirection for the library usage. Change-Id: I963b0f962473ce911bfbdfb848863d253bc7dbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922594 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#718396}
-
Tsuyoshi Horo authored
Bug: 1025835 Change-Id: Ie5effc90de1dc7514df9f2d96e2f6ff1cb281278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923215Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718395}
-
siyua authored
Reason for this CL: We did implementation review with Chrome UX and one feedback was the verify pending dialog was too short for a modal dialog. Therefore UX decision is for this dialog, we also reuse the template of the webauthn dialog (adding an illustration on top). So it makes sense to merge the separate MVCs of webauthn_offer_dialog and verify_pending_dialog into one, and show different content for different states (in other words, adding kVerifyPending as a new state in WebauthnDialogModel). This is a renaming CL which is the precursor of the major merging CL. Includes two changes: 1. Rename all WebauthnOffer- to Webauthn- to avoid confusion; 2. In AutofillClient, move all webauthn related functions under build flags to ensure these functions are all on desktop. No other change on flow logic. TBR=michaelbai@chromium.org,mahmadi@chromium.org,martinkr@google.com Change-Id: I80ae00d219cdaf868056a04938c6968ed186ad3d Bug: 949269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925761 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#718394}
-
W. James MacLean authored
CL to continue debugging the cause of flakes in SitePerProcessInteractivePDFTest.LoadingPdfDoesNotStealFocus. Bug: 1024672 Change-Id: Ic2a577a960f5333419aa70f89a5ca1149130e1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929628 Auto-Submit: James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd8cccb7..f72b13cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I258e828a67cb89bb89bf2b0f6562ebbda549afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929529Reviewed-by:
-
Adrienne Walker authored
This is a followup to remove unnecessary thread hops by binding the mojo interface on the correct sequence in the first place. Bug: 1022104 Change-Id: Id69811673d6a14e11a1da4caa452c40868454df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907095 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#718391}
-
Brandon Wylie authored
Chrome would crash when longpressing the url because the padding is adjusted at the same time Editor#selectCurrentWordAndStartDrag is called. This causes a nullptr exception since Editor#getSelectionController() will be null at that time. The fix is to post the padding update which will resolve both the longpress and the padding update without crashing. Bug: 1024994 Change-Id: I7816ffbbe2fff43cf2b1047eee278f8d1ba863a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930066 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#718390}
-
Toby Huang authored
When the "Permissions for sites and apps" toggle in Chrome family dashboard is disabled, we should prevent child users from installing new extensions and approving additional permissions for existing extensions. This CL focuses on preventing child users from installing new extensions. The second functionality will be implemented in a future CL. When the toggle is disabled, pref kSupervisedUserExtensionsMayRequestPermissions becomes false, and this is used to implement the desired effects in this CL. Bug: 1018956,1007011 Change-Id: Ida3c53d87da55fd266edc9d021211f5cdc641d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904502 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#718389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/498ba7042fc1..4a0fd75b105f git log 498ba7042fc1..4a0fd75b105f --date=short --no-merges --format='%ad %ae %s' 2019-11-22 primiano@google.com Fix Chromium roll on windows 2019-11-22 primiano@google.com Merge "Minor fixes to IPC proto and build files" 2019-11-22 rtenneti@google.com Merge "Revert "Add proto for recording VkDebugMarkerSetObjectNameEXT"" 2019-11-22 chiur@google.com Merge "Add proto for recording VkDebugMarkerSetObjectNameEXT" 2019-11-22 lalitm@google.com Merge "trace_processor: expose set_name function" 2019-11-22 ilkos@google.com Merge "Add build fingerprint to system info" Created with: gclient setdep -r src/third_party/perfetto@4a0fd75b105f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I79b8a7e92dc1655b878de9ee0c2e0286296a5410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931642Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e32eb6fc6fc..d6140be50ddb Created with: gclient setdep -r src-internal@d6140be50ddb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I6c0f8074a50a1c3cfe1e0bbd0a0c5c1d5ea8bc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931341Reviewed-by:
-
Kevin Qin authored
Some existing tests do not fully verify the API usage. This CL is dedicated to provide a better coverage for OpenXR implementation. And remove some no longer used mock functions. Fixed: 1025404 Change-Id: I7493d5ddc6f00544d8f8474fdaa3ab2fe8d283c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919494 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#718386}
-
Nikita Podguzov authored
Bug: 996785 Change-Id: Ib8d28e3651a9b39107f242883983a13fa13eedb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930811 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718385}
-
Kurt Horimoto authored
This CL updates the JS dialog egtests to work with both modal and non- modal dialog implementations in preparation for updating the non-modal dialog feature to be enabled by default. This required introducing a11y identifier functionality to the AlertConsumer protocol to allow the tests to properly wait for the dialogs to be displayed. Bug: none Change-Id: I26010b73501442db729f8c561d925d70b8c5eca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925775 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#718384}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9dabaedfa33c..556c0a2e0f48 git log 9dabaedfa33c..556c0a2e0f48 --date=short --no-merges --format='%ad %ae %s' 2019-11-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@556c0a2e0f48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic4e31ae399af15a7974bbb12e3065d9c2ec86ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931740Reviewed-by:
-
Piotr Pawliczek authored
This patch extends the unittest by adding an entry with incorrect uri. I was not able to reproduce the bug described in the issue. BUG=chromium:1015916 TEST=on my workstation by running unit_tests Change-Id: I989fc9d82956f16b277648ec942de454763fadd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912695 Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Errorprone is currently causing javac to crash when warnings are hit. TBR=agrieve # Fixing build Bug: 1027541 Change-Id: I7b95fa3dadd8947d66234c1f6c2490148d7e5d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931742Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#718381}
-
