- 06 Aug, 2019 40 commits
-
-
Adam Rice authored
In the JavaScript API for underlying sinks, they usually capture the controller if they need it in the start() method. However, the C++ UnderlyingSinkBase needs to store the controller internally for its own use. It's wasteful for subclasses to take their own copy. Instead expose it to subclasses directly via a protected getter. This getter will be used by the implementation of WebSocketStream. See the design doc at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit. Also fix a bug in the generic version of WritableStreamDefaultControllerInterface::Error(). BUG=983030 Change-Id: I5339f9117f52b78947592b417cb595b2fa496c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734738Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#684284}
-
Robbie Gibson authored
Bug: 976664 Change-Id: I8b1cdcd88d5a76a91433f86c68f2a728770777d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731844Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#684283}
-
Tanmoy Mollik authored
Bug: 959157 Change-Id: Ic8d53f154c0065a14a9841fbe2eea44b87f1250f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735381Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#684282}
-
Gyuyoung Kim authored
This CL introduces ChooserResourceLoader class to replace Platform::Current()->GetDataResource(name) with UncompressResourceAsString. ChooserResourceLoader class supports static functions which return a string of the given style sheet or javascript. But, Android doesn't support IDR_FOO used by the choosers in blink_resource.grd. So, this CL just returns String() because Android port doesn't use the resources. Bug: 983396 Change-Id: I2a836cc3868e2bccfd4da1449aee217396073438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714624Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#684281}
-
Richard Knoll authored
This adds metrics when we receive a web push message to see how often the device is in doze mode and if messages are sent with the high priority flag. Bug: None Change-Id: I2b37c20320e3e40dfd6e8d7ec3f050fe0ce1d801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730453 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#684280}
-
Javier Ernesto Flores Robles authored
Bug: 976645 Change-Id: Ib1de554f07a3bb4a7fb63b6a57e19fe26dc7e331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735384Reviewed-by:
-
Javier Ernesto Flores Robles authored
This color is also going to be used in popup menu. Bug: 976645 Change-Id: I7259415ba23aa7bbad24a5eb79794da0a3100389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735377 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#684278}
-
Andrei Chulkov authored
Change-Id: I0e4a85bc3c6558ff8a5dd0b3e0b2369ac5491c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736363 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#684277}
-
Robbie Gibson authored
The code in OmniboxPopupRow wasn't actually doing anything. The default UIKit method of row highlighting is to insert a view in the table cell's subviews at index 0, so the cell's background color is always covered. Setting selectedBackgroundView is the modern way of controlling this color. Bug: 976662 Change-Id: If0d18fc3edc82f6cb2eda0324dabe23e9ba9a085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735164 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684276}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/558f1a9df6d3..5c3c17c8711c Created with: gclient setdep -r src-internal@5c3c17c8711c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iad14291c568e725e26d85c22e7a83378bfb495f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738567Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684275}
-
Vadym Doroshenko authored
Now, form manager is created only for password forms. In order to fill username field during username first flow, form manager needs to be created for username-only forms. This CL implements it. Bug: 959776 Change-Id: I2252c8e07aa04c606dfb5edadaea6675fecc96d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735575 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#684274}
-
Yutaka Hirano authored
data URLs are now handled in blink, so we don't need to use WebURLLoaderImpl for data URL handling in tests. Remove |default_loader| param from WebURLLoaderMockFactory::CreateURLLoader. That allows us to expect non-null |resource_dispatcher_| and |loader_factory_| in WebURLLoaderImpl. Remove the redundant code. Bug: 751425 Change-Id: Iddcc5178b641c37aa563dce65b0626472d710d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704717Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#684273}
-
Javier Ernesto Flores Robles authored
Changes .com to .org Change-Id: I12e6035b4f71109a668048a49bf5882ed87456a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738846 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#684272}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bf176a0d6db9..74ec0afe01ec git log bf176a0d6db9..74ec0afe01ec --date=short --no-merges --format='%ad %ae %s' 2019-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 4f14b4c8cc25..698b56a8f024 (1 commits) Created with: gclient setdep -r src/third_party/angle@74ec0afe01ec The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: chromium:None Change-Id: I41a0df7e925bc3515b94e848afee7eb8216845dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684271}
-
arthursonzogni authored
Understand for every failing content_browsertests, why they are failing with the BackForwardCache. Bug: 990354 Change-Id: Iafcf568be7cde737a86f8753442ed4c390c6aea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731948 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#684270}
-
Eugene But authored
This CL adds file to EG2 target and updated includes. Other changes has been already landed in separate CLs. Bug: 987646 Change-Id: I7b44b28d0d20a9bef24e7ec1aba5c78f27cba22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726412 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Matthias Körber authored
Increased the expiration version of the PasswordManager.PrefilledUsernameFillOutcome histogram to M82. Bug: 984245 Change-Id: I1fa829aa1f29273306d14101721d1f84fa38a398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722539Reviewed-by:
-
Vaclav Brozek authored
As described in the design doc [1], a new class, CSVPasswordIterator, is introduced as an abstraction for consuming CSV data line by line, representing each line as a CSVPassword. [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: I3477a600abad1c41f27a2ebca6c9c150da560818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700049 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#684267}
-
Andreea Costinas authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/206270625a4a..c59652b94a7e $ git log 206270625..c59652b94 --date=short --no-merges --format='%ad %ae %s' 2019-07-15 acostinas system_api: Add key_name_for_spkac 2019-07-25 akhouderchah shill: technology: Make all type names part of the D-Bus API 2019-06-26 sjzhong cryptohome: Allow user to selectively remove keysets. 2019-07-24 isandrk system_api: Add kSessionManagerStartRemoteDeviceWipe 2019-07-26 benchan system_api: shill: remove 'kPRLVersionProperty' constant 2019-07-16 xiaochu system_api: add sub OWNER file for update_engine 2019-06-28 khegde power: Add new battery metrics to PowerSupplyProperties 2019-07-23 ljusten system_api: Build Kerberos Go protos 2019-07-15 kimjae dlcservice: Modify install API to take protobuf list of DLC ids 2019-07-23 zuan cryptohome: Add UpdateCurrentUserActivityTimestamp() to UserDataAuth 2019-07-25 kimjae system_api: Install indication signal from update engine 2019-07-23 benchan system_api: add OWNERS for more sub-directories Created with: roll-dep src/third_party/cros_system_api Bug: 988367 Change-Id: Ia58014f74bd41f31dbb6c8a484444e0478f4e718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736671 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#684266}
-
Raphael Kubo da Costa authored
Rather than having several mappings for sensor-specific settings and providing methods to change them in MockSensorProvider, move all of them to a separate SensorTypeSettings class. This makes it easier to note which methods are really MockSensorProvider's and which are changing sensor-specific settings for when MockSensorProvider gets to create a MockSensor. Bug: 987639 Change-Id: I57daa09506e15af16d747a48e6250f53f3644e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718378 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#684265}
-
Raphael Kubo da Costa authored
Also group them together. This makes it easier to know which values must be returned and which functions are not Mojo function implementations. Bug: 987639 Change-Id: Ia21b98acaed90902dcf42e798a6c37077e4cc8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718333 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Creates a local colorset for the separator. Bug: 976645 Change-Id: I8e5168c18fe01095537c4d34cdba151db11f2d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735162Reviewed-by:
-
redatawfik authored
1)Creates new class AutofillAddCreditCardCoordinator as a coordinator for add new credit card. 2)Initiates AutofillAddCreditCardCoordinator with BrowserState. 3)Creates new Interface CreditCardValidationDelegate. 4)Implements CreditCardValidationDelegate in AutofillAddCreditCardCoordinator. 5)Creates new class AutofillAddCreditCardMediator. 6)Creates new Interface AddCreditCardViewControllerDelegate. 7)Initiates AutofillAddCreditCardMediator with PersonalDataManager and AutofillAddCreditCardCoordinator as a delegate. 8)Initiates AutofillAddCreditCardViewController with AutofillAddCreditCardMediator as a delegate. 9)AutofillAddCreditCardMediator creates and saves new credit card object. Bug: 984545 Change-Id: I36e390f1e84c3cf54c4491780f73cdfdb142a21a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724073 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
-
Anton Bikineev authored
Calling destructors explicitly in FinalizerTrait revealed some warnings clang emits when the non-virtual destructor gets called on a polymorphic type. Many of the changed classes inherit from abstract NameClient, but making the destructor of NameClient virtual would be suboptimal as it would increase the number of finalizers. Bug: 990913 Change-Id: I06bffd838ac4917920caa7ecb6db6b8610b32685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736890 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces |ForceSetText()| and |SetTextIfNeeded()| in |LayoutText| to get rid of optional bool parameter |force| from |LayoutText::SetText()| for improving code health. Change-Id: I292776fcadedf16e790bfec45cc5537ffde8d5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736426 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684260}
-
arthursonzogni authored
The main motivation behind this CL is to land: https://chromium-review.googlesource.com/c/chromium/src/+/1688957 It makes every navigations from a crashed RenderFrameHost to use a new RenderFrameHost. Previously, only the cross-origin navigations where using a new RenderFrameHost. DevToolsProtocolTest was only used with same-process navigation, this CL adds a regression test: DevToolsProtocolTest.InspectorTargetCrashedNavigateCrossProcess This test fails without this patch and works with it. Context: RenderFrameDevToolsAgentHost follows the current document in a given frame. This translates by following a RenderFrameHost in a given FrameTreeNode. To do this, most observers of a WebContents uses: WebContentsObserver::RenderFrameHostChanged(old_rfh, new_rfh). They updates the current RenderFrameHost after the navigation has been done and the old and new RenderFrameHost have been swapped. The RenderFrameDevToolsAgenHost way of doing things is slightly different, it wants to follow the new RenderFrameHost as soon as possible. It happens when the navigation is ReadyToCommit(). To handle canceled navigation and crashed RenderFrameHost, the RenderFrameDevToolsAgentHost observes the following "events": * ReadyToCommitNavigation * DidFinishNavigation * RenderFrameHostChanged. Please take a look at their implementations. Depending on the case, they are called in a different order and produces different results. Let's explore several examples with a cross-process navigation from A to B: ──────────────────────────────────────────────────────────────────────────────── Case 1: Successful navigation from a living RenderFrameHost. ┌─┬────────────────────────┬───────────────────┬───────────────────┐ │#│ Event │ before patch │ after patch │ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │1│ ReadyToCommitNavigation│ UpdateFrameHost(B)│ UpdateFrameHost(B)│ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │2│ RenderFrameHostChanged │ │ UpdateFrameHost(B)│ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │3│ DidFinishNavigation │ UpdateFrameHost(B)│ UpdateFrameHost(B)│ └─┴────────────────────────┴───────────────────┴───────────────────┘ Observation: This produces the same effects, UpdateFrameHost called several time in a row with the same RenderFrameHost is essentially a no-op. ──────────────────────────────────────────────────────────────────────────────── Case 2: Successful navigation from a dead RenderFrameHost. ┌─┬────────────────────────┬─────────────────────────┬───────────────────┐ │#│ Event │ before patch │ after patch │ ├─┼────────────────────────┼─────────────────────────┼───────────────────┤ │1│ RenderFrameHostChanged │ UpdateFrameHost(nullptr)│ UpdateFrameHost(B)│ ├─┼────────────────────────┼─────────────────────────┼───────────────────┤ │2│ ReadyToCommitNavigation│ UpdateFrameHost(B) │ UpdateFrameHost(B)│ ├─┼────────────────────────┼─────────────────────────┼───────────────────┤ │3│ DidFinishNavigation │ UpdateFrameHost(B) │ UpdateFrameHost(B)│ └─┴────────────────────────┴─────────────────────────┴───────────────────┘ Observation: Without this patch, when the new RenderFrameHost starts loading, it temporarily switch to nullptr for a short time. It is no more the case. ──────────────────────────────────────────────────────────────────────────────── Case 3: Navigation canceled after ReadyToCommitNavigation. ┌─┬────────────────────────┬───────────────────┬───────────────────┐ │#│ Event │ before patch │ after patch │ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │1│ ReadyToCommitNavigation│ UpdateFrameHost(B)│ UpdateFrameHost(B)│ ├─┼────────────────────────┼───────────────────┼───────────────────┤ │2│ DidFinishNavigation │ UpdateFrameHost(A)│ UpdateFrameHost(A)│ └─┴────────────────────────┴───────────────────┴───────────────────┘ Observation: Nothing changed. ──────────────────────────────────────────────────────────────────────────────── The previous way of "following" RenderFrameHost by the RenderFrameDevToolsAgentHost can "temporary" follow nullptr in case 2. This is no more the case. Bug: 990315 Change-Id: I0703e1602ef47f8964a5041cc509ed0344bf4e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731489Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684259}
-
Jérôme Lebel authored
When sign-in with a new gmail account, the Chrome identity was initialized with no hosted domain since the SSO profile was not fetched yet. The property was never updated later. Even when the AuthenticationFlow was fetching hosted domain using the AuthenticationFlowPerformer. During the sign-in process To fix the issue, -ChromeIdentity.hostedDomain is remove. ChromeIdentity stays just a proxy for SSOIdentity. ChromeIdentityService::GetCachedHostedDomainForIdentity() is added to get the hosted domain. Bug introduced with: + crrev.com/c/1687254 + crrev.com/i/1434627 + crrev.com/c/1687254 Related to: + crrev.com/c/1732084 (adding new API) + crrev.com/i/1560989 (adding new implementation) + crrev.com/c/1732085 (switching implementation) + crrev.com/i/1560990 (old implementation cleanup) => crrev.com/c/1732101 (cleanup API) <= Bug: 987380 Change-Id: I77b4a1428ce43aca81ae93a0875b3052be97bea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732101 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Maggie Cai authored
Add mxcai@ as an OWNER of chrome/browser/chromeos/apps/intent_helper. Bug: None Change-Id: Ie837b7e3628fe268431ea7fc0174b8ef5f8ba5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738087 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#684257}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c409951bea4f..88681ddd1d38 git log c409951bea4f..88681ddd1d38 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dc2c5c5a419e..bf176a0d6db9 (10 commits) Created with: gclient setdep -r src/third_party/skia@88681ddd1d38 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:None Change-Id: I34e327a7d16a5625d6a3dc0955edb18ca5990c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737754Reviewed-by:
-
Takashi Toyoshima authored
Bug: 990041 Change-Id: I8b5924e0d3bed705a2389a875200b0db0b1fe2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736866 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#684255}
-
Alexey Baskakov authored
Extract SystemWebAppManager into CreateCommonSubsystems(). Fix comments. Bug: 877898 Change-Id: I909f2c92317a2db2e0a73a1af08be28d84a51c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737492Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#684254}
-
Maksim Sisov authored
For now, just run with headless backend. Once Ozone/X11 is more mature and Weston is built from third_party (ongoing), use --ozone-platform=wayland/x11 as well. Bug: 700309 Change-Id: Ib869ab8cb0d8c3e98ccf322d7c9b226baeeaa974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735580 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#684253}
-
Kenichi Ishibashi authored
The motivation of this change is to avoid creating ParentExecutionContextTaskRunners while starting service worker. It's a garbage collected object and we can't create it on the IO thread. Before this CL, WorkerThread took ParentExecutionContextTaskRunners as a parameter of Start(). For service/shared workers, we create a dummy version of task runners which always fall back to the default task runner that is bound to the current thread. The task runners are used to schedule a task to terminate script execution outside the worker thread (e.g. force terminating infinite loop). Since the termination task doesn't rely on parent context, we can just use the default task runner of the current thread (mostly the main thread, could be the IO thread in the future). Another option is to pass a SingleThreadTaskRunner as a parameter of Start(). I didn't take this approach because: * I wanted to aggregate the call of Thread::Current()->GetTaskRunner() as it's discouraged to use widely. * For dedicated workers we could pass ParentExecutionContextTaskRunners::Get(kInternalDefault) but this could be stale when the parent context is destroyed. Keeping it without ContextLifecycleObserver isn't safe. Bug: 988335 Change-Id: I3fe27bfc184619f5c4b1be516ad794190588eed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735591 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Yusuke Sato authored
Per request from the owner at CL:1728319. This also makes upstart_client.cc lint-clean. BUG=None TEST=try Change-Id: I59230caa3f430df72af88ba76154a509621254fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737731Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#684251}
-
Dominick Ng authored
BUG=991075 Change-Id: I11a08609b85dbfa534e4479657478788819d9000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737793 Auto-Submit: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#684250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfd49e0cb072..558f1a9df6d3 Created with: gclient setdep -r src-internal@558f1a9df6d3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9163677382b3a91db38b79d3102e7dde350a41f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738005Reviewed-by:
-
Alex Danilo authored
Adds more detail to the aria-label for better screen reader experience on the summary panel. Sets the label to 'Close' when the summary panel has expanded the panel items on display and sets it back to 'Expand' when it's collapsed. The keywords 'Close' and 'Expand' are internationalized, the string itself contains 'Files feedback panel' which will be internationalized in a follow-up CL. Bug: 989322 Change-Id: I1ae67400eed5963e7254ea644f757eed47291b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735448Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#684248}
-
Kent Tamura authored
* insert_paragraph_separator_command_test.cc <colgroup>'s actual appearance will be 'none', and it has no height. * external/wpt/css/css-lists/list-and-margin-collapse-003.html and -004.html <div> can't have 'checkbox' appearance any longer, and we couldn't find other ways to reproduce the original issue. So we remove the tests. * fast/css/invalid-appearance.html Removed. It was made to check deprecation messages. * fast/css/square-button-appearance.html Removed. -webkit-appearance:square-button doesn't work for arbitrary elements any longer, and its appearance is tested in input[type=color] tests. * fast/forms/file/file-style-inheritance.html -webkit-appearance:square-button doesn't work for ::-webkit-file-upload-button any longer. -webkit-appearnace:none works well in the test. * fast/forms/range/thumbslider-no-parent-slider.html -webkit-appearance:slider-thumb-* don't work in this case any longer. Its pixel result has nothing. This CL converts the test to a reference test. * scrollbars/custom-scrollbar-appearance-property.html -webkit-appearance:searchfield-cancel-button doesn't work for ::-webkit-scrollbar* any longer, and pixel result of this test would be changed. This CL converts the test to a testharness.js test. * fast/css/invalid-appearance-progress-bar-meter-expected.txt * fast/forms/datalist/slider-appearance-with-ticks-crash-expected.txt * fast/forms/range/slider-appearance-crash-expected.txt * fast/forms/range/thumbslider-crash-expected.txt * fast/text/whitespace/pre-block-normal-inline-crash-2-expected.txt * paint/invalidation/selection/multiple-body-remove-selection-crash-expected.txt * paint/theme/anonymous-element-menulist-painting-expected.txt Remove deprecation messages. Bug: 981720 Change-Id: I91068c8265cdfc682a06b1b4588b04ea30a318d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727654Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#684247}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/074f0d2d282d..bdc909653e31 git log 074f0d2d282d..bdc909653e31 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2c4c2e2e..8776a388 (684065:684182) Created with: gclient setdep -r src/third_party/webrtc@bdc909653e31 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia873c1b3fc30b56ad89363141ba02426b4f067de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737950Reviewed-by:
-
Raymes Khoury authored
This adds browser-side checks for the registerProtocolHandler API. In particular: 1) Checks that the origin of the URL handler matches the origin of the RFH where the call originates. 2) Checks that the protocol being handled is one of the safelisted schemes. 3) Checks that the scheme of the URL handler is either http or https. Check (1) is implemented in the content/ layer so that non-Chrome embedders can benefit from this check. Checks (2) and (3) are implemented further down in Chrome because we need to ensure that if existing handlers are registered that we don't load them from prefs. Tests are added. We may want to consider restricting this API to secure contexts in a follow-up but this will need to be vetted by blink-dev@. Note: This CL was originally reverted because it didn't allow Extensions to register protocol handlers. This has been fixed by allowing the chrome-extension scheme. This check must be done in the chrome/ layer. Bug: 971917,952974 Change-Id: I19da557135af9a86c3305ef47e4b06152abd6ddd Tbr: benwells@chromium.org,tapted@chromium.org,dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730689 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
